Re: [PR] RATIS-2094. Avoid corruptions from TransactionContext's stateMachineLogEntry and stateMachineContext. [ratis]

2024-06-03 Thread via GitHub
szetszwo merged PR #1106: URL: https://github.com/apache/ratis/pull/1106 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ratis.apache

Re: [PR] RATIS-2094. Avoid corruptions from TransactionContext's stateMachineLogEntry and stateMachineContext. [ratis]

2024-06-02 Thread via GitHub
szetszwo commented on PR #1106: URL: https://github.com/apache/ratis/pull/1106#issuecomment-2144062303 @duongkame , "This pull request is still a work in progress". I guess it is not the case? -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] RATIS-2094. Avoid corruptions from TransactionContext's stateMachineLogEntry and stateMachineContext. [ratis]

2024-05-31 Thread via GitHub
szetszwo commented on code in PR #1106: URL: https://github.com/apache/ratis/pull/1106#discussion_r1622823140 ## ratis-common/src/main/java/org/apache/ratis/util/ReferenceCountedObject.java: ## @@ -152,6 +153,10 @@ public boolean release() { }; } + default ReferenceC

[PR] RATIS-2094. Avoid corruptions from TransactionContext's stateMachineLogEntry and stateMachineContext. [ratis]

2024-05-31 Thread via GitHub
duongkame opened a new pull request, #1106: URL: https://github.com/apache/ratis/pull/1106 ## What changes were proposed in this pull request? As discuss in RATIS-2094, the usage of TransactionContext's `getStateMachineLogEntry` and `getStateMachineContext` may cause corruptions

Re: [PR] RATIS-2094. Avoid corruptions from TransactionContext's stateMachineLogEntry and stateMachineContext. [ratis]

2024-05-31 Thread via GitHub
duongkame commented on PR #1106: URL: https://github.com/apache/ratis/pull/1106#issuecomment-2142716387 @szetszwo can you have a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific