szetszwo commented on code in PR #1098:
URL: https://github.com/apache/ratis/pull/1098#discussion_r1631917108
##
ratis-shell/src/main/java/org/apache/ratis/shell/cli/RaftUtils.java:
##
@@ -86,4 +103,111 @@ public static RaftClient createClient(RaftGroup raftGroup)
{
.s
DaveTeng0 commented on code in PR #1098:
URL: https://github.com/apache/ratis/pull/1098#discussion_r1619570302
##
ratis-shell/pom.xml:
##
@@ -48,6 +48,14 @@
org.slf4j
slf4j-simple
+
+ org.apache.ratis
+ ratis-grpc
+
+
+ org.apache.r
szetszwo commented on code in PR #1098:
URL: https://github.com/apache/ratis/pull/1098#discussion_r1613122613
##
ratis-shell/pom.xml:
##
@@ -48,6 +48,14 @@
org.slf4j
slf4j-simple
+
+ org.apache.ratis
+ ratis-grpc
+
+
+ org.apache.ra
DaveTeng0 commented on PR #1098:
URL: https://github.com/apache/ratis/pull/1098#issuecomment-2128020652
Also, I'll revert changes in those subcommands of AbstractRatisCommand and
keep original _processReply_ method in AbstractRatisCommand.
--
This is an automated message from the Apache G
DaveTeng0 commented on PR #1098:
URL: https://github.com/apache/ratis/pull/1098#issuecomment-2128016581
Thanks @szetszwo suggestion, I'll separate the security related features
(changes of
ratis-shell/src/main/java/org/apache/ratis/shell/cli/SecurityUtils.java) to
another jira/PR later. I
DaveTeng0 commented on PR #1098:
URL: https://github.com/apache/ratis/pull/1098#issuecomment-2128005034
For reference, the reason I can't use ratis's AbstractRatisCommand and it's
suite of subcommands in Ozone's shell directly is because Ozone shell uses
[picocli](https://github.com/apache/
DaveTeng0 commented on PR #1098:
URL: https://github.com/apache/ratis/pull/1098#issuecomment-2125786346
cc. @szetszwo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
DaveTeng0 opened a new pull request, #1098:
URL: https://github.com/apache/ratis/pull/1098
## What changes were proposed in this pull request?
We have an Ozone Jira that we'd like to run ratis command from Ozone shell
(https://issues.apache.org/jira/browse/HDDS-10509).
In order to shar
