[jira] [Commented] (RATIS-649) Add metrics related to ClientRequests

2019-11-06 Thread Hanisha Koneru (Jira)
[ https://issues.apache.org/jira/browse/RATIS-649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16968910#comment-16968910 ] Hanisha Koneru commented on RATIS-649: -- After this patch, RaftServer restart is failing. In

[jira] [Commented] (RATIS-736) Add a new RetryPolicy similar to MultipleLinearRandomRetry in HDFS

2019-11-06 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/RATIS-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16968790#comment-16968790 ] Hadoop QA commented on RATIS-736: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Updated] (RATIS-736) Add a new RetryPolicy similar to MultipleLinearRandomRetry in HDFS

2019-11-06 Thread Tsz-wo Sze (Jira)
[ https://issues.apache.org/jira/browse/RATIS-736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz-wo Sze updated RATIS-736: - Attachment: r736_20191106.patch > Add a new RetryPolicy similar to MultipleLinearRandomRetry in HDFS >

[jira] [Commented] (RATIS-744) Minimize the dependency on hadoop-common

2019-11-06 Thread Henrik Hegardt (Jira)
[ https://issues.apache.org/jira/browse/RATIS-744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16968774#comment-16968774 ] Henrik Hegardt commented on RATIS-744: -- What I'm trying to point out is that hadoop-common pulls in a

[jira] [Commented] (RATIS-599) Support Underscores in Numeric Literals in RaftProperties

2019-11-06 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/RATIS-599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16968591#comment-16968591 ] Hadoop QA commented on RATIS-599: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (RATIS-729) ClientProtoUtils#toRaftClientReplyProto should consider all RaftException types

2019-11-06 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/RATIS-729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16968586#comment-16968586 ] Hadoop QA commented on RATIS-729: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (RATIS-740) Fix checkstyle violations in ratis-common

2019-11-06 Thread Tsz-wo Sze (Jira)
[ https://issues.apache.org/jira/browse/RATIS-740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16968565#comment-16968565 ] Tsz-wo Sze commented on RATIS-740: -- - IntegerRanges is not used anywhere.  Let's remove it. Could you

[jira] [Commented] (RATIS-458) GrpcLogAppender#shouldWait should wait on pending log entries to follower

2019-11-06 Thread Tsz-wo Sze (Jira)
[ https://issues.apache.org/jira/browse/RATIS-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16968562#comment-16968562 ] Tsz-wo Sze commented on RATIS-458: -- {code} final long size = (matchIndex > 0 && nextIndex > 0) ?

[jira] [Commented] (RATIS-729) ClientProtoUtils#toRaftClientReplyProto should consider all RaftException types

2019-11-06 Thread Tsz-wo Sze (Jira)
[ https://issues.apache.org/jira/browse/RATIS-729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16968558#comment-16968558 ] Tsz-wo Sze commented on RATIS-729: -- What exceptions could OtherRaftException be? Could you give some

[jira] [Commented] (RATIS-743) Remove log4j default test scope from dependencyManagement

2019-11-06 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/RATIS-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16968444#comment-16968444 ] Hadoop QA commented on RATIS-743: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (RATIS-744) Minimize the dependency on hadoop-common

2019-11-06 Thread Tsz-wo Sze (Jira)
[ https://issues.apache.org/jira/browse/RATIS-744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16968433#comment-16968433 ] Tsz-wo Sze commented on RATIS-744: -- Do you mean that ratis should not depend on hadoop-common when

[jira] [Created] (RATIS-744) Minimize the dependency on hadoop-common

2019-11-06 Thread Henrik Hegardt (Jira)
Henrik Hegardt created RATIS-744: Summary: Minimize the dependency on hadoop-common Key: RATIS-744 URL: https://issues.apache.org/jira/browse/RATIS-744 Project: Ratis Issue Type: Improvement

[jira] [Commented] (RATIS-743) Remove log4j default test scope from dependencyManagement

2019-11-06 Thread Henrik Hegardt (Jira)
[ https://issues.apache.org/jira/browse/RATIS-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16968283#comment-16968283 ] Henrik Hegardt commented on RATIS-743: -- I removed the scope for log4j and updated slf4j from 1.7.10

[jira] [Updated] (RATIS-743) Remove log4j default test scope from dependencyManagement

2019-11-06 Thread Henrik Hegardt (Jira)
[ https://issues.apache.org/jira/browse/RATIS-743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henrik Hegardt updated RATIS-743: - Attachment: RATIS-743.0001.Remove-log4j-default-test-scope-from-depen.patch > Remove log4j

[jira] [Commented] (RATIS-652) Add metrics related to snapshot and log purge

2019-11-06 Thread Lokesh Jain (Jira)
[ https://issues.apache.org/jira/browse/RATIS-652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16968255#comment-16968255 ] Lokesh Jain commented on RATIS-652: --- [~avijayan] Thanks for working on this! The changes look good to

[jira] [Commented] (RATIS-580) Refactor retryPolicy for RaftClient to customize wait time based on exception

2019-11-06 Thread Lokesh Jain (Jira)
[ https://issues.apache.org/jira/browse/RATIS-580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16968229#comment-16968229 ] Lokesh Jain commented on RATIS-580: --- [~szetszwo] Thanks for the contribution! [~swagle] Thanks for

[jira] [Commented] (RATIS-580) Refactor retryPolicy for RaftClient to customize wait time based on exception

2019-11-06 Thread Lokesh Jain (Jira)
[ https://issues.apache.org/jira/browse/RATIS-580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16968223#comment-16968223 ] Lokesh Jain commented on RATIS-580: --- [~szetszwo] Thanks for updating the patch! The changes look good to