[jira] [Commented] (RATIS-730) Fix checkstyle violations in ratis-examples

[ https://issues.apache.org/jira/browse/RATIS-730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16977040#comment-16977040 ] Hadoop QA commented on RATIS-730: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (RATIS-730) Fix checkstyle violations in ratis-examples

[ https://issues.apache.org/jira/browse/RATIS-730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16977017#comment-16977017 ] Dinesh Chitlangia commented on RATIS-730: - Updated patch 004 to address checkstyle

[jira] [Updated] (RATIS-730) Fix checkstyle violations in ratis-examples

[ https://issues.apache.org/jira/browse/RATIS-730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dinesh Chitlangia updated RATIS-730: Attachment: RATIS-730.004.patch > Fix checkstyle violations in ratis-examples >

[jira] [Comment Edited] (RATIS-740) Fix checkstyle violations in ratis-common

[ https://issues.apache.org/jira/browse/RATIS-740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16976955#comment-16976955 ] Dinesh Chitlangia edited comment on RATIS-740 at 11/19/19 12:13 AM:

[jira] [Comment Edited] (RATIS-740) Fix checkstyle violations in ratis-common

[ https://issues.apache.org/jira/browse/RATIS-740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16976955#comment-16976955 ] Dinesh Chitlangia edited comment on RATIS-740 at 11/19/19 12:12 AM:

[jira] [Commented] (RATIS-740) Fix checkstyle violations in ratis-common

[ https://issues.apache.org/jira/browse/RATIS-740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16976969#comment-16976969 ] Hadoop QA commented on RATIS-740: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Comment Edited] (RATIS-740) Fix checkstyle violations in ratis-common

[ https://issues.apache.org/jira/browse/RATIS-740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16976955#comment-16976955 ] Dinesh Chitlangia edited comment on RATIS-740 at 11/18/19 10:46 PM:

[jira] [Commented] (RATIS-740) Fix checkstyle violations in ratis-common

[ https://issues.apache.org/jira/browse/RATIS-740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16976955#comment-16976955 ] Dinesh Chitlangia commented on RATIS-740: - [~szetszwo] Addressed review comments i

[jira] [Updated] (RATIS-740) Fix checkstyle violations in ratis-common

[ https://issues.apache.org/jira/browse/RATIS-740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dinesh Chitlangia updated RATIS-740: Attachment: RATIS-740.004.patch > Fix checkstyle violations in ratis-common > --

[jira] [Commented] (RATIS-730) Fix checkstyle violations in ratis-examples

[ https://issues.apache.org/jira/browse/RATIS-730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16976924#comment-16976924 ] Hadoop QA commented on RATIS-730: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Updated] (RATIS-741) Create a Github PR template

[ https://issues.apache.org/jira/browse/RATIS-741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz-wo Sze updated RATIS-741: - Component/s: build > Create a Github PR template > --- > > Key: RA

[jira] [Reopened] (RATIS-741) Create a Github PR template

[ https://issues.apache.org/jira/browse/RATIS-741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz-wo Sze reopened RATIS-741: -- Reopen due to {code} Lines that start with ? in the ASF License report indicate files that do not have

[jira] [Commented] (RATIS-741) Create a Github PR template

[ https://issues.apache.org/jira/browse/RATIS-741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16976904#comment-16976904 ] Tsz-wo Sze commented on RATIS-741: -- Oops, there is a Apache License warning. Will revert

[jira] [Commented] (RATIS-740) Fix checkstyle violations in ratis-common

[ https://issues.apache.org/jira/browse/RATIS-740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16976900#comment-16976900 ] Tsz-wo Sze commented on RATIS-740: -- Thanks for the update, [~dineshchitlangia]. Some mor

[jira] [Commented] (RATIS-740) Fix checkstyle violations in ratis-common

[ https://issues.apache.org/jira/browse/RATIS-740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16976891#comment-16976891 ] Hadoop QA commented on RATIS-740: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (RATIS-730) Fix checkstyle violations in ratis-examples

[ https://issues.apache.org/jira/browse/RATIS-730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16976885#comment-16976885 ] Dinesh Chitlangia commented on RATIS-730: - [~szetszwo] Review comments addressed i

[jira] [Updated] (RATIS-730) Fix checkstyle violations in ratis-examples

[ https://issues.apache.org/jira/browse/RATIS-730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dinesh Chitlangia updated RATIS-730: Attachment: RATIS-730.003.patch > Fix checkstyle violations in ratis-examples >

[jira] [Commented] (RATIS-740) Fix checkstyle violations in ratis-common

[ https://issues.apache.org/jira/browse/RATIS-740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16976873#comment-16976873 ] Dinesh Chitlangia commented on RATIS-740: - [~szetszwo] Thanks for reviewing. Uploa

[jira] [Updated] (RATIS-740) Fix checkstyle violations in ratis-common

[ https://issues.apache.org/jira/browse/RATIS-740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dinesh Chitlangia updated RATIS-740: Attachment: RATIS-740.003.patch > Fix checkstyle violations in ratis-common > --

[jira] [Commented] (RATIS-741) Create a Github PR template

[ https://issues.apache.org/jira/browse/RATIS-741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16976869#comment-16976869 ] Dinesh Chitlangia commented on RATIS-741: - [~szetszwo] Thanks for review & commit.

[jira] [Commented] (RATIS-740) Fix checkstyle violations in ratis-common

[ https://issues.apache.org/jira/browse/RATIS-740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16976794#comment-16976794 ] Tsz-wo Sze commented on RATIS-740: -- - In NativeIO, {{public static int}} probably is requ

[jira] [Commented] (RATIS-730) Fix checkstyle violations in ratis-examples

[ https://issues.apache.org/jira/browse/RATIS-730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16976708#comment-16976708 ] Tsz-wo Sze commented on RATIS-730: -- Thanks [~dineshchitlangia], - Let's move getPeer(Raf

[jira] [Commented] (RATIS-729) ClientProtoUtils#toRaftClientReplyProto should consider all RaftException types

[ https://issues.apache.org/jira/browse/RATIS-729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16976668#comment-16976668 ] Tsz-wo Sze commented on RATIS-729: -- For debug purpose, we may add a precondition in the c

[jira] [Commented] (RATIS-748) Follower might not update its commit index

[ https://issues.apache.org/jira/browse/RATIS-748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16976655#comment-16976655 ] Tsz-wo Sze commented on RATIS-748: -- [~ljain], thanks for clear explanation. How about ch

[jira] [Comment Edited] (RATIS-748) Follower might not update its commit index

[ https://issues.apache.org/jira/browse/RATIS-748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16976527#comment-16976527 ] Lokesh Jain edited comment on RATIS-748 at 11/18/19 1:19 PM: -

[jira] [Commented] (RATIS-748) Follower might not update its commit index

[ https://issues.apache.org/jira/browse/RATIS-748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16976527#comment-16976527 ] Lokesh Jain commented on RATIS-748: --- [~szetszwo] Here is the scenario from one of the cl

[jira] [Commented] (RATIS-729) ClientProtoUtils#toRaftClientReplyProto should consider all RaftException types

[ https://issues.apache.org/jira/browse/RATIS-729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16976457#comment-16976457 ] Lokesh Jain commented on RATIS-729: --- [~szetszwo] We saw it in ozone cluster while runnin

[jira] [Commented] (RATIS-652) Add metrics related to snapshot and log purge

[ https://issues.apache.org/jira/browse/RATIS-652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16976453#comment-16976453 ] Lokesh Jain commented on RATIS-652: --- [~avijayan] Thanks for the contribution! [~shashika

[jira] [Commented] (RATIS-652) Add metrics related to snapshot and log purge

[ https://issues.apache.org/jira/browse/RATIS-652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16976447#comment-16976447 ] Lokesh Jain commented on RATIS-652: --- [~avijayan] Thanks for updating the patch! The chan