[jira] [Commented] (RATIS-568) Server sliding window should fail out of order requests on close

2019-06-24 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871966#comment-16871966 ] Tsz Wo Nicholas Sze commented on RATIS-568: --- Hi [~ljain], TestWatchRequestWithGrpc started

[jira] [Reopened] (RATIS-601) Fix NotLeaderException handling

2019-06-24 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze reopened RATIS-601: --- > Fix NotLeaderException handling > --- > >

[jira] [Commented] (RATIS-601) Fix NotLeaderException handling

2019-06-24 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871956#comment-16871956 ] Tsz Wo Nicholas Sze commented on RATIS-601: --- Sorry that I did not check the test failure before

[jira] [Commented] (RATIS-592) One node ratis writes fail forever after first NotLeaderException or LeaderNotReadyException

2019-06-24 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871072#comment-16871072 ] Tsz Wo Nicholas Sze commented on RATIS-592: --- [~swagle], the 04 patch no longer applies. Please

[jira] [Resolved] (RATIS-590) Deadlock in ratis client

2019-06-24 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze resolved RATIS-590. --- Resolution: Fixed Fix Version/s: 0.4.0 I have committed this. Thanks

[jira] [Commented] (RATIS-590) Deadlock in ratis client

2019-06-24 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870836#comment-16870836 ] Tsz Wo Nicholas Sze commented on RATIS-590: --- Since there is deadlock, let's remove the

[jira] [Commented] (RATIS-595) appendEntry future should be completed only after the entry is flushed

2019-06-23 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870815#comment-16870815 ] Tsz Wo Nicholas Sze commented on RATIS-595: --- r595_20190624.patch: updated with master. >

[jira] [Updated] (RATIS-595) appendEntry future should be completed only after the entry is flushed

2019-06-23 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-595: -- Attachment: r595_20190624.patch > appendEntry future should be completed only after the

[jira] [Commented] (RATIS-573) Handle Raft Log Append Failure

2019-06-23 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870809#comment-16870809 ] Tsz Wo Nicholas Sze commented on RATIS-573: --- +1 the 07 patch looks good. There is an off

[jira] [Updated] (RATIS-601) Fix NotLeaderException handling

2019-06-22 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-601: -- Component/s: client > Fix NotLeaderException handling > ---

[jira] [Commented] (RATIS-601) Fix NotLeaderException handling

2019-06-22 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870387#comment-16870387 ] Tsz Wo Nicholas Sze commented on RATIS-601: --- [~msingh], thanks for the answers to my questions.

[jira] [Commented] (RATIS-573) Handle Raft Log Append Failure

2019-06-22 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870386#comment-16870386 ] Tsz Wo Nicholas Sze commented on RATIS-573: --- - Let's don't change done(). The code should not

[jira] [Commented] (RATIS-592) One node ratis writes fail forever after first NotLeaderException or LeaderNotReadyException

2019-06-22 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870385#comment-16870385 ] Tsz Wo Nicholas Sze commented on RATIS-592: --- > We would always reconnect in case of

[jira] [Commented] (RATIS-573) Handle Raft Log Append Failure

2019-06-20 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16868974#comment-16868974 ] Tsz Wo Nicholas Sze commented on RATIS-573: --- Let simply add a local variable raftLogIOException

[jira] [Updated] (RATIS-597) Add notifyLeader API in state machine

2019-06-20 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-597: -- Summary: Add notifyLeader API in state machine (was: Add notifyAsLeader API in state

[jira] [Commented] (RATIS-597) Add notifyAsLeader API in state machine

2019-06-20 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16868841#comment-16868841 ] Tsz Wo Nicholas Sze commented on RATIS-597: --- +1 patch looks good. The failed tests are not

[jira] [Commented] (RATIS-601) Fix NotLeaderException handling

2019-06-20 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16868832#comment-16868832 ] Tsz Wo Nicholas Sze commented on RATIS-601: --- [~msingh], in Ozone, do we have the leader

[jira] [Commented] (RATIS-601) Fix NotLeaderException handling

2019-06-20 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16868830#comment-16868830 ] Tsz Wo Nicholas Sze commented on RATIS-601: --- > a) OrderedAsync#sendRequest doesn't handle

[jira] [Commented] (RATIS-601) Fix NotLeaderException handling

2019-06-20 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16868824#comment-16868824 ] Tsz Wo Nicholas Sze commented on RATIS-601: --- > b) RaftServerImpl#generateNotLeaderException

[jira] [Created] (RATIS-600) Better logging for installSnapshot

2019-06-19 Thread Tsz Wo Nicholas Sze (JIRA)
Tsz Wo Nicholas Sze created RATIS-600: - Summary: Better logging for installSnapshot Key: RATIS-600 URL: https://issues.apache.org/jira/browse/RATIS-600 Project: Ratis Issue Type:

[jira] [Updated] (RATIS-596) Rename raft.server.leader.election.timeout

2019-06-19 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-596: -- Attachment: r596_20190619.patch > Rename raft.server.leader.election.timeout >

[jira] [Commented] (RATIS-599) Support Underscores in Numeric Literals in RaftProperties

2019-06-19 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16868051#comment-16868051 ] Tsz Wo Nicholas Sze commented on RATIS-599: --- r599_20190619.patch: 1st patch. > Support

[jira] [Updated] (RATIS-599) Support Underscores in Numeric Literals in RaftProperties

2019-06-19 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-599: -- Attachment: r599_20190619.patch > Support Underscores in Numeric Literals in

[jira] [Updated] (RATIS-599) Support Underscores in Numeric Literals in RaftProperties

2019-06-19 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-599: -- Component/s: conf > Support Underscores in Numeric Literals in RaftProperties >

[jira] [Created] (RATIS-599) Support Underscores in Numeric Literals in RaftProperties

2019-06-19 Thread Tsz Wo Nicholas Sze (JIRA)
Tsz Wo Nicholas Sze created RATIS-599: - Summary: Support Underscores in Numeric Literals in RaftProperties Key: RATIS-599 URL: https://issues.apache.org/jira/browse/RATIS-599 Project: Ratis

[jira] [Created] (RATIS-596) Rename raft.server.leader.election.timeout

2019-06-19 Thread Tsz Wo Nicholas Sze (JIRA)
Tsz Wo Nicholas Sze created RATIS-596: - Summary: Rename raft.server.leader.election.timeout Key: RATIS-596 URL: https://issues.apache.org/jira/browse/RATIS-596 Project: Ratis Issue

[jira] [Updated] (RATIS-595) appendEntry future should be completed only after the entry is flushed

2019-06-18 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-595: -- Attachment: r595_20190618.patch > appendEntry future should be completed only after the

[jira] [Created] (RATIS-595) appendEntry future should be completed only after the entry is flushed

2019-06-18 Thread Tsz Wo Nicholas Sze (JIRA)
Tsz Wo Nicholas Sze created RATIS-595: - Summary: appendEntry future should be completed only after the entry is flushed Key: RATIS-595 URL: https://issues.apache.org/jira/browse/RATIS-595

[jira] [Commented] (RATIS-589) Eliminate buffer copying in SegmentedRaftLogOutputStream

2019-06-18 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16867147#comment-16867147 ] Tsz Wo Nicholas Sze commented on RATIS-589: --- r589_20190618.patch: fixes some bugs. > Eliminate

[jira] [Updated] (RATIS-589) Eliminate buffer copying in SegmentedRaftLogOutputStream

2019-06-18 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-589: -- Attachment: r589_20190618.patch > Eliminate buffer copying in

[jira] [Comment Edited] (RATIS-573) Handle Raft Log Append Failure

2019-06-18 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866907#comment-16866907 ] Tsz Wo Nicholas Sze edited comment on RATIS-573 at 6/18/19 9:33 PM: -

[jira] [Commented] (RATIS-573) Handle Raft Log Append Failure

2019-06-18 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866907#comment-16866907 ] Tsz Wo Nicholas Sze commented on RATIS-573: --- > 2. passing LogEntryProto as a Optional to

[jira] [Updated] (RATIS-590) Deadlock in ratis client

2019-06-17 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-590: -- Component/s: client > Deadlock in ratis client > > >

[jira] [Commented] (RATIS-573) Handle Raft Log Append Failure

2019-06-17 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16865898#comment-16865898 ] Tsz Wo Nicholas Sze commented on RATIS-573: --- [~sdeka], thanks for working on this. - Let pass

[jira] [Commented] (RATIS-578) Illegal State transition in LeaderElection

2019-06-17 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16865888#comment-16865888 ] Tsz Wo Nicholas Sze commented on RATIS-578: --- It seems changing the code to below will fix the

[jira] [Commented] (RATIS-578) Illegal State transition in LeaderElection

2019-06-17 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16865886#comment-16865886 ] Tsz Wo Nicholas Sze commented on RATIS-578: --- Let's focus on the first ILLEGAL TRANSITION.

[jira] [Commented] (RATIS-589) Eliminate buffer copying in SegmentedRaftLogOutputStream

2019-06-17 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16865867#comment-16865867 ] Tsz Wo Nicholas Sze commented on RATIS-589: --- r589_20190617.patch: updated with master. >

[jira] [Commented] (RATIS-587) FinalizeLogSegment should flush the contents of log

2019-06-17 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16865857#comment-16865857 ] Tsz Wo Nicholas Sze commented on RATIS-587: --- [~sdeka], thanks for filing this bug and reviewing

[jira] [Updated] (RATIS-589) Eliminate buffer copying in SegmentedRaftLogOutputStream

2019-06-14 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-589: -- Attachment: r589_20190614.patch > Eliminate buffer copying in

[jira] [Commented] (RATIS-579) ExitUtils.terminate results in JVM terminated for peers not part of the group

2019-06-14 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864476#comment-16864476 ] Tsz Wo Nicholas Sze commented on RATIS-579: --- +1 the 05 patch looks good. > ExitUtils.terminate

[jira] [Commented] (RATIS-579) ExitUtils.terminate results in JVM terminated for peers not part of the group

2019-06-14 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864475#comment-16864475 ] Tsz Wo Nicholas Sze commented on RATIS-579: --- > ... From slf4j 1.6, parameterized logging and

[jira] [Commented] (RATIS-579) ExitUtils.terminate results in JVM terminated for peers not part of the group

2019-06-14 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864316#comment-16864316 ] Tsz Wo Nicholas Sze commented on RATIS-579: --- Patch looks good. The verify(..) in the test won't

[jira] [Commented] (RATIS-587) FinalizeLogSegment should flush the contents of log

2019-06-14 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864311#comment-16864311 ] Tsz Wo Nicholas Sze commented on RATIS-587: --- Oops, you are right that it may not call force().

[jira] [Updated] (RATIS-587) FinalizeLogSegment should flush the contents of log

2019-06-14 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-587: -- Attachment: r587_20190614.patch > FinalizeLogSegment should flush the contents of log >

[jira] [Created] (RATIS-589) Eliminate buffer copying in SegmentedRaftLogOutputStream

2019-06-13 Thread Tsz Wo Nicholas Sze (JIRA)
Tsz Wo Nicholas Sze created RATIS-589: - Summary: Eliminate buffer copying in SegmentedRaftLogOutputStream Key: RATIS-589 URL: https://issues.apache.org/jira/browse/RATIS-589 Project: Ratis

[jira] [Commented] (RATIS-587) FinalizeLogSegment should flush the contents of log

2019-06-13 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16863510#comment-16863510 ] Tsz Wo Nicholas Sze commented on RATIS-587: --- r587_20190613b.patch: - always forces, and -

[jira] [Updated] (RATIS-587) FinalizeLogSegment should flush the contents of log

2019-06-13 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-587: -- Attachment: r587_20190613b.patch > FinalizeLogSegment should flush the contents of log

[jira] [Updated] (RATIS-587) FinalizeLogSegment should flush the contents of log

2019-06-13 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-587: -- Attachment: r587_20190613.patch > FinalizeLogSegment should flush the contents of log >

[jira] [Updated] (RATIS-587) FinalizeLogSegment should flush the contents of log

2019-06-13 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-587: -- Component/s: (was: LogService) server > FinalizeLogSegment should

[jira] [Assigned] (RATIS-587) FinalizeLogSegment should flush the contents of log

2019-06-13 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze reassigned RATIS-587: - Assignee: Tsz Wo Nicholas Sze > FinalizeLogSegment should flush the contents of

[jira] [Commented] (RATIS-587) FinalizeLogSegment should flush the contents of log

2019-06-13 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16863470#comment-16863470 ] Tsz Wo Nicholas Sze commented on RATIS-587: --- > ..., there may be log entries which are not yet

[jira] [Commented] (RATIS-579) ExitUtils.terminate results in JVM terminated for peers not part of the group

2019-06-13 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16863462#comment-16863462 ] Tsz Wo Nicholas Sze commented on RATIS-579: --- [~swagle], thanks for the update. - The following

[jira] [Commented] (RATIS-579) ExitUtils.terminate results in JVM terminated for peers not part of the group

2019-06-12 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16862603#comment-16862603 ] Tsz Wo Nicholas Sze commented on RATIS-579: --- Thanks [~swagle]. Some comments: - Let's don't

[jira] [Commented] (RATIS-584) Provide an optional trigger for creating commit entries on Leader

2019-06-12 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16862587#comment-16862587 ] Tsz Wo Nicholas Sze commented on RATIS-584: --- The commit entry involves only a small amount of

[jira] [Updated] (RATIS-584) Provide an optional trigger for creating commit entries on Leader

2019-06-12 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-584: -- Issue Type: Improvement (was: Bug) > Provide an optional trigger for creating commit

[jira] [Commented] (RATIS-587) FinalizeLogSegment should flush the contents of log

2019-06-12 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16862583#comment-16862583 ] Tsz Wo Nicholas Sze commented on RATIS-587: --- It seems not a problem since WriteLog will flush

[jira] [Commented] (RATIS-577) NPE in LogAppender while creating a new request.

2019-06-12 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16862581#comment-16862581 ] Tsz Wo Nicholas Sze commented on RATIS-577: --- > Could we add logging for the purge so that we can

[jira] [Commented] (RATIS-585) LogMetadata does not wait for the metada operations to finish before acknowleding watch requests

2019-06-12 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16862567#comment-16862567 ] Tsz Wo Nicholas Sze commented on RATIS-585: --- > ...  we should wait for the metadata entry to be

[jira] [Commented] (RATIS-585) LogMetadata does not wait for the metada operations to finish before acknowleding watch requests

2019-06-06 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16857341#comment-16857341 ] Tsz Wo Nicholas Sze commented on RATIS-585: --- Do you mean that watch requests should be replied

[jira] [Updated] (RATIS-296) Cache entries in the raft log should only be evicted after the entries have successfully been persisted to the Segmented Raft Log

2019-06-04 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-296: -- Target Version/s: (was: 0.3.0) Fix Version/s: (was: 0.3.0) > Cache entries

[jira] [Updated] (RATIS-328) Follower should update StateMachine with leader's commit after applying log

2019-06-04 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-328: -- Target Version/s: (was: 0.3.0) Fix Version/s: (was: 0.3.0) > Follower

[jira] [Updated] (RATIS-465) Add docker support for running filestore example

2019-06-04 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-465: -- Fix Version/s: (was: 0.3.0) > Add docker support for running filestore example >

[jira] [Updated] (RATIS-471) `LogReader#readNext()` should return null or throw an error when reading off the end of the Log

2019-06-04 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-471: -- Fix Version/s: (was: 0.3.0) > `LogReader#readNext()` should return null or throw an

[jira] [Updated] (RATIS-477) Improve LogStateMachine.processReadRequest()

2019-06-04 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-477: -- Fix Version/s: (was: 0.3.0) > Improve LogStateMachine.processReadRequest() >

[jira] [Updated] (RATIS-544) Add ability in Statemachine to trigger snapshot creation.

2019-06-04 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-544: -- Fix Version/s: (was: 0.3.0) > Add ability in Statemachine to trigger snapshot

[jira] [Updated] (RATIS-574) Client should not use configured sleep interval in RetryPolicy when it gets NotLeaderException

2019-06-04 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-574: -- Component/s: client Issue Type: Improvement (was: Bug) Summary: Client

[jira] [Commented] (RATIS-574) Ratis should not use configured sleep interval in RetryPolicy when it gets NotLeaderException

2019-06-04 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856297#comment-16856297 ] Tsz Wo Nicholas Sze commented on RATIS-574: --- +1 the 08 patch looks good. > Ratis should not use

[jira] [Commented] (RATIS-564) Add raft group Id to install snapshot notification

2019-06-04 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856294#comment-16856294 ] Tsz Wo Nicholas Sze commented on RATIS-564: --- The test failures seem not related. Let me start

[jira] [Updated] (RATIS-583) Update asf-site-source branch for RATIS-539

2019-06-04 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-583: -- Attachment: r583_20190604.patch > Update asf-site-source branch for RATIS-539 >

[jira] [Commented] (RATIS-583) Update asf-site-source branch for RATIS-539

2019-06-04 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855565#comment-16855565 ] Tsz Wo Nicholas Sze commented on RATIS-583: --- r583_20190604.patch: 1st patch. > Update

[jira] [Created] (RATIS-583) Update asf-site-source branch for RATIS-539

2019-06-04 Thread Tsz Wo Nicholas Sze (JIRA)
Tsz Wo Nicholas Sze created RATIS-583: - Summary: Update asf-site-source branch for RATIS-539 Key: RATIS-583 URL: https://issues.apache.org/jira/browse/RATIS-583 Project: Ratis Issue

[jira] [Updated] (RATIS-577) NPE in LogAppender while creating a new request.

2019-06-04 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-577: -- Attachment: r577_20190604.patch > NPE in LogAppender while creating a new request. >

[jira] [Commented] (RATIS-577) NPE in LogAppender while creating a new request.

2019-06-04 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855438#comment-16855438 ] Tsz Wo Nicholas Sze commented on RATIS-577: --- The log entry somehow not found in the RaftLog.

[jira] [Commented] (RATIS-564) Add raft group Id to install snapshot notification

2019-06-04 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855430#comment-16855430 ] Tsz Wo Nicholas Sze commented on RATIS-564: --- - Please fix the checkstyple warning. - Similar to

[jira] [Commented] (RATIS-574) Ratis should not use configured sleep interval in RetryPolicy when it gets NotLeaderException

2019-06-04 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855428#comment-16855428 ] Tsz Wo Nicholas Sze commented on RATIS-574: --- - Please revert the RetryPolicies whitespace

[jira] [Commented] (RATIS-564) Add raft group Id to install snapshot notification

2019-06-04 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855374#comment-16855374 ] Tsz Wo Nicholas Sze commented on RATIS-564: --- +1 the 02 patch looks good. > Add raft group Id to

[jira] [Commented] (RATIS-564) Add raft group Id to install snapshot notification

2019-06-03 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855325#comment-16855325 ] Tsz Wo Nicholas Sze commented on RATIS-564: --- Thanks [~swagle]. The change in

[jira] [Commented] (RATIS-571) Client may send first request in sliding window with firstFlag as false

2019-06-03 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855317#comment-16855317 ] Tsz Wo Nicholas Sze commented on RATIS-571: --- Thanks [~ljain], just a minor comment: In

[jira] [Updated] (RATIS-149) TestGrpcOutputStream.testSimpleWrite may fail

2019-06-03 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-149: -- Description: Two different failure cases: - {code} java.lang.AssertionError:

[jira] [Commented] (RATIS-167) Implement a high performance OutputStream using async API

2019-06-03 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16854275#comment-16854275 ] Tsz Wo Nicholas Sze commented on RATIS-167: --- Thanks [~shashikant].  Yes, we have RATIS-149 for

[jira] [Updated] (RATIS-545) Leader Election timeout should consider JVM pause interval

2019-06-03 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-545: -- Component/s: server > Leader Election timeout should consider JVM pause interval >

[jira] [Commented] (RATIS-571) Client may send first request in sliding window with firstFlag as false

2019-06-03 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16854268#comment-16854268 ] Tsz Wo Nicholas Sze commented on RATIS-571: --- Thanks [~ljain] for the patch. This is a hard bug

[jira] [Commented] (RATIS-571) Client may send first request in sliding window with firstFlag as false

2019-06-02 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16854231#comment-16854231 ] Tsz Wo Nicholas Sze commented on RATIS-571: --- > ... Therefore the serverId for a request is

[jira] [Commented] (RATIS-545) Leader Election timeout should consider JVM pause interval

2019-06-02 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16854216#comment-16854216 ] Tsz Wo Nicholas Sze commented on RATIS-545: --- +1 the 005 patch looks good. > Leader Election

[jira] [Commented] (RATIS-564) Add raft group Id to install snapshot notification

2019-05-31 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852825#comment-16852825 ] Tsz Wo Nicholas Sze commented on RATIS-564: --- > ... Can I drop gid but keep the roleInfoProto in

[jira] [Commented] (RATIS-545) Leader Election timeout should consider JVM pause interval

2019-05-31 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852796#comment-16852796 ] Tsz Wo Nicholas Sze commented on RATIS-545: --- Thanks [~ljain] for the patch. The comparison of

[jira] [Commented] (RATIS-571) Client may send first request in sliding window with firstFlag as false

2019-05-31 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852778#comment-16852778 ] Tsz Wo Nicholas Sze commented on RATIS-571: --- Hi [~ljain], I have misunderstood the bug earlier

[jira] [Updated] (RATIS-571) Client may send first request in sliding window with firstFlag as false

2019-05-31 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-571: -- Component/s: client > Client may send first request in sliding window with firstFlag as

[jira] [Commented] (RATIS-574) Ratis should not use configured sleep interval in RetryPolicy when it gets NotLeaderException

2019-05-31 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852774#comment-16852774 ] Tsz Wo Nicholas Sze commented on RATIS-574: --- Thanks [~swagle]. After the patch, there is no

[jira] [Commented] (RATIS-571) Client may send first request in sliding window with firstFlag as false

2019-05-30 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851900#comment-16851900 ] Tsz Wo Nicholas Sze commented on RATIS-571: --- Thanks [~ljain] for working on this. Some

[jira] [Commented] (RATIS-167) Implement a high performance OutputStream using async API

2019-05-30 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851717#comment-16851717 ] Tsz Wo Nicholas Sze commented on RATIS-167: --- Thanks [~shashikant]. r167_20190530.patch: updated

[jira] [Updated] (RATIS-167) Implement a high performance OutputStream using async API

2019-05-30 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-167: -- Attachment: r167_20190530.patch > Implement a high performance OutputStream using async

[jira] [Commented] (RATIS-564) Add raft group Id to install snapshot notification

2019-05-29 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851539#comment-16851539 ] Tsz Wo Nicholas Sze commented on RATIS-564: --- Is there anything special about

[jira] [Commented] (RATIS-564) Add raft group Id to install snapshot notification

2019-05-29 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850534#comment-16850534 ] Tsz Wo Nicholas Sze commented on RATIS-564: --- Question: do we need only the groupId? Or also the

[jira] [Commented] (RATIS-566) OrderedStreamObservers#closeAllExisting should close the streams writing to certain group id only

2019-05-29 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850530#comment-16850530 ] Tsz Wo Nicholas Sze commented on RATIS-566: --- Thanks [~msingh]. Although it is impossible to

[jira] [Updated] (RATIS-566) OrderedStreamObservers#closeAllExisting should close the streams writing to certain group id only

2019-05-29 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-566: -- Attachment: r566_20190529.patch > OrderedStreamObservers#closeAllExisting should close

[jira] [Commented] (RATIS-565) Move the ordered async client code to a new class

2019-05-28 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850514#comment-16850514 ] Tsz Wo Nicholas Sze commented on RATIS-565: --- r565_20190529.patch: updated with master. > Move

[jira] [Updated] (RATIS-565) Move the ordered async client code to a new class

2019-05-28 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-565: -- Attachment: r565_20190529.patch > Move the ordered async client code to a new class >

[jira] [Commented] (RATIS-563) Purge logs after snapshot only after all the nodes have catught up with the index

2019-05-28 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16849624#comment-16849624 ] Tsz Wo Nicholas Sze commented on RATIS-563: --- In RaftLog, commitIndex is initialized by a

[jira] [Updated] (RATIS-455) Move exception classes to a new package

2019-05-28 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-455: -- Attachment: r455_20190528.patch > Move exception classes to a new package >

<    1   2   3   4   5   6   7   8   9   10   >