[
https://issues.apache.org/jira/browse/RATIS-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16662965#comment-16662965
]
Josh Elser commented on RATIS-334:
--
Had to tweak the protobuf-compiler pom stuff to account for the move
[
https://issues.apache.org/jira/browse/RATIS-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16662909#comment-16662909
]
Josh Elser commented on RATIS-334:
--
Thanks for the quick feedback, Sergey. Let's just plan to leave the
[
https://issues.apache.org/jira/browse/RATIS-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16662888#comment-16662888
]
Vladimir Rodionov commented on RATIS-334:
-
Someone (me or Sergey) should stop and wait until the
[
https://issues.apache.org/jira/browse/RATIS-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16662883#comment-16662883
]
Sergey Soldatov commented on RATIS-334:
---
bq. Just remove these from LogStateMachine instead of
[
https://issues.apache.org/jira/browse/RATIS-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16662854#comment-16662854
]
Sergey Soldatov commented on RATIS-334:
---
bq. equals(Object), toString(), and hashCode()?
This class
[
https://issues.apache.org/jira/browse/RATIS-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16662762#comment-16662762
]
Vladimir Rodionov commented on RATIS-334:
-
np, I will rebase RATIS-369 on top of this.
>
[
https://issues.apache.org/jira/browse/RATIS-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16660867#comment-16660867
]
Josh Elser commented on RATIS-334:
--
Either way to me. I can see arguments in either direction.
>
[
https://issues.apache.org/jira/browse/RATIS-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16660012#comment-16660012
]
Sergey Soldatov commented on RATIS-334:
---
bq. Let's spin this out into its own Jira issue if you
[
https://issues.apache.org/jira/browse/RATIS-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659968#comment-16659968
]
Josh Elser commented on RATIS-334:
--
{quote}this class is ambiguous
{quote}
Let's spin this out into its
[
https://issues.apache.org/jira/browse/RATIS-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659879#comment-16659879
]
Sergey Soldatov commented on RATIS-334:
---
[~vrodionov] well, my point is that this class is ambiguous
[
https://issues.apache.org/jira/browse/RATIS-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659600#comment-16659600
]
Josh Elser commented on RATIS-334:
--
{quote}I don't quite understand what LogService class is supposed to
[
https://issues.apache.org/jira/browse/RATIS-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659342#comment-16659342
]
Vladimir Rodionov commented on RATIS-334:
-
LogService looks like a client, agree. I would leave
[
https://issues.apache.org/jira/browse/RATIS-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659297#comment-16659297
]
Sergey Soldatov commented on RATIS-334:
---
[~rajeshbabu] I don't quite understand what LogService
[
https://issues.apache.org/jira/browse/RATIS-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659241#comment-16659241
]
Rajeshbabu Chintaguntla commented on RATIS-334:
---
[~sergey.soldatov] I have gone through the
[
https://issues.apache.org/jira/browse/RATIS-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16657325#comment-16657325
]
Sergey Soldatov commented on RATIS-334:
---
[~vrodionov], [~rajeshbabu] can you take a look.
[
https://issues.apache.org/jira/browse/RATIS-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653782#comment-16653782
]
Sergey Soldatov commented on RATIS-334:
---
Ah, forgot to mention that Worker's state machine is
[
https://issues.apache.org/jira/browse/RATIS-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653766#comment-16653766
]
Sergey Soldatov commented on RATIS-334:
---
This version includes:
1. proto files for both Log and Meta
[
https://issues.apache.org/jira/browse/RATIS-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16644307#comment-16644307
]
Sergey Soldatov commented on RATIS-334:
---
Just in case, to avoid any kind of confusion. The proto
[
https://issues.apache.org/jira/browse/RATIS-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16644227#comment-16644227
]
Sergey Soldatov commented on RATIS-334:
---
Attached wip patch for better understanding how
19 matches
Mail list logo
