[jira] [Commented] (RATIS-369) LogService read/write path (phase 2: more UTs, etc)

2018-10-26 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16665572#comment-16665572 ] Josh Elser commented on RATIS-369: -- v6 Applies cleanly for me. Are all of the tests in {

[jira] [Commented] (RATIS-369) LogService read/write path (phase 2: more UTs, etc)

2018-10-26 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1666#comment-1666 ] Josh Elser commented on RATIS-369: -- Looking at it, Vlad. Thanks! > LogService read/write

[jira] [Commented] (RATIS-369) LogService read/write path (phase 2: more UTs, etc)

2018-10-26 Thread Vladimir Rodionov (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16665530#comment-16665530 ] Vladimir Rodionov commented on RATIS-369: - TestMetaServer now passes (after v6) >

[jira] [Commented] (RATIS-369) LogService read/write path (phase 2: more UTs, etc)

2018-10-26 Thread Vladimir Rodionov (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16665529#comment-16665529 ] Vladimir Rodionov commented on RATIS-369: - The last patch applies cleanly to the m

[jira] [Commented] (RATIS-369) LogService read/write path (phase 2: more UTs, etc)

2018-10-26 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16665501#comment-16665501 ] Josh Elser commented on RATIS-369: -- That's really weird. I'm about half way through your

[jira] [Commented] (RATIS-369) LogService read/write path (phase 2: more UTs, etc)

2018-10-26 Thread Vladimir Rodionov (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16665497#comment-16665497 ] Vladimir Rodionov commented on RATIS-369: - [~elserj], I have never had this proble

[jira] [Commented] (RATIS-369) LogService read/write path (phase 2: more UTs, etc)

2018-10-26 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16665365#comment-16665365 ] Josh Elser commented on RATIS-369: -- I'm taking a look at v5. Let me see if I can fix it u

[jira] [Commented] (RATIS-369) LogService read/write path (phase 2: more UTs, etc)

2018-10-26 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16664826#comment-16664826 ] Hadoop QA commented on RATIS-369: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (RATIS-369) LogService read/write path (phase 2: more UTs, etc)

2018-10-25 Thread Vladimir Rodionov (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16664620#comment-16664620 ] Vladimir Rodionov commented on RATIS-369: - Some weird things are happening with my

[jira] [Commented] (RATIS-369) LogService read/write path (phase 2: more UTs, etc)

2018-10-25 Thread Vladimir Rodionov (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16664517#comment-16664517 ] Vladimir Rodionov commented on RATIS-369: - Hmm, will take a look. > LogService re

[jira] [Commented] (RATIS-369) LogService read/write path (phase 2: more UTs, etc)

2018-10-25 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16664510#comment-16664510 ] Hadoop QA commented on RATIS-369: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (RATIS-369) LogService read/write path (phase 2: more UTs, etc)

2018-10-25 Thread Vladimir Rodionov (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16664385#comment-16664385 ] Vladimir Rodionov commented on RATIS-369: - v2. Rebased to RATIS-334. Did some refa

[jira] [Commented] (RATIS-369) LogService read/write path (phase 2: more UTs, etc)

2018-10-24 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16663015#comment-16663015 ] Josh Elser commented on RATIS-369: -- Hahah. Thanks Vlad! :) > LogService read/write path

[jira] [Commented] (RATIS-369) LogService read/write path (phase 2: more UTs, etc)

2018-10-24 Thread Vladimir Rodionov (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16663004#comment-16663004 ] Vladimir Rodionov commented on RATIS-369: - {quote} What's the UNDEFINED for? {quot

[jira] [Commented] (RATIS-369) LogService read/write path (phase 2: more UTs, etc)

2018-10-24 Thread Vladimir Rodionov (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16663001#comment-16663001 ] Vladimir Rodionov commented on RATIS-369: - {quote} Do we want Test in the file nam

[jira] [Commented] (RATIS-369) LogService read/write path (phase 2: more UTs, etc)

2018-10-24 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662999#comment-16662999 ] Josh Elser commented on RATIS-369: -- bq. Hmm, this is what I usually try to avoid : workin

[jira] [Commented] (RATIS-369) LogService read/write path (phase 2: more UTs, etc)

2018-10-24 Thread Vladimir Rodionov (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662997#comment-16662997 ] Vladimir Rodionov commented on RATIS-369: - Hmm, this is what I usually try to avoi

[jira] [Commented] (RATIS-369) LogService read/write path (phase 2: more UTs, etc)

2018-10-24 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662988#comment-16662988 ] Josh Elser commented on RATIS-369: -- [~vrodionov], you should be good to rebase this on to

[jira] [Commented] (RATIS-369) LogService read/write path (phase 2: more UTs, etc)

2018-10-24 Thread Sergey Soldatov (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661890#comment-16661890 ] Sergey Soldatov commented on RATIS-369: --- Why do we need the snapshot support? In the

[jira] [Commented] (RATIS-369) LogService read/write path (phase 2: more UTs, etc)

2018-10-23 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661425#comment-16661425 ] Hadoop QA commented on RATIS-369: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (RATIS-369) LogService read/write path (phase 2: more UTs, etc)

2018-10-23 Thread Vladimir Rodionov (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661406#comment-16661406 ] Vladimir Rodionov commented on RATIS-369: - Patch v1. Code clean up, some missing A