[jira] [Commented] (RATIS-457) Timed out append entry reply should update follower match index, commit index

2019-10-24 Thread Tsz-wo Sze (Jira)
[ https://issues.apache.org/jira/browse/RATIS-457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16959115#comment-16959115 ] Tsz-wo Sze commented on RATIS-457: -- [~ljain], the 004 patch no longer applies. Could you

[jira] [Commented] (RATIS-457) Timed out append entry reply should update follower match index, commit index

2019-10-23 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/RATIS-457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16957650#comment-16957650 ] Hadoop QA commented on RATIS-457: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (RATIS-457) Timed out append entry reply should update follower match index, commit index

2019-10-23 Thread Lokesh Jain (Jira)
[ https://issues.apache.org/jira/browse/RATIS-457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16957638#comment-16957638 ] Lokesh Jain commented on RATIS-457: --- v4 patch fixes checkstyle issue. The unit tests pas

[jira] [Commented] (RATIS-457) Timed out append entry reply should update follower match index, commit index

2019-10-23 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/RATIS-457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16957632#comment-16957632 ] Hadoop QA commented on RATIS-457: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (RATIS-457) Timed out append entry reply should update follower match index, commit index

2019-10-22 Thread Lokesh Jain (Jira)
[ https://issues.apache.org/jira/browse/RATIS-457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16957602#comment-16957602 ] Lokesh Jain commented on RATIS-457: --- v3 patch fixes unit test failures. > Timed out app

[jira] [Commented] (RATIS-457) Timed out append entry reply should update follower match index, commit index

2019-10-21 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/RATIS-457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16956320#comment-16956320 ] Hadoop QA commented on RATIS-457: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (RATIS-457) Timed out append entry reply should update follower match index, commit index

2019-10-21 Thread Lokesh Jain (Jira)
[ https://issues.apache.org/jira/browse/RATIS-457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16956293#comment-16956293 ] Lokesh Jain commented on RATIS-457: --- [~szetszwo] v2 patch addresses your review comments

[jira] [Commented] (RATIS-457) Timed out append entry reply should update follower match index, commit index

2019-10-15 Thread Tsz-wo Sze (Jira)
[ https://issues.apache.org/jira/browse/RATIS-457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16951809#comment-16951809 ] Tsz-wo Sze commented on RATIS-457: -- {code} - private boolean checkAndUpdateMatchIndex(Ap

[jira] [Commented] (RATIS-457) Timed out append entry reply should update follower match index, commit index

2019-10-15 Thread Lokesh Jain (Jira)
[ https://issues.apache.org/jira/browse/RATIS-457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16951795#comment-16951795 ] Lokesh Jain commented on RATIS-457: --- [~szetszwo] updateMatchIndex updates to the maximum

[jira] [Commented] (RATIS-457) Timed out append entry reply should update follower match index, commit index

2019-10-15 Thread Tsz-wo Sze (Jira)
[ https://issues.apache.org/jira/browse/RATIS-457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16951770#comment-16951770 ] Tsz-wo Sze commented on RATIS-457: -- It is a good observation to update matchIndex for the

[jira] [Commented] (RATIS-457) Timed out append entry reply should update follower match index, commit index

2019-10-14 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/RATIS-457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16951034#comment-16951034 ] Hadoop QA commented on RATIS-457: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||