[jira] [Commented] (RATIS-499) Server should close the sliding window if it steps down

2019-03-19 Thread Lokesh Jain (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795769#comment-16795769 ] Lokesh Jain commented on RATIS-499: --- [~szetszwo] I agree we can commit r499_20190318b.patch. > Server

[jira] [Commented] (RATIS-499) Server should close the sliding window if it steps down

2019-03-19 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795761#comment-16795761 ] Tsz Wo Nicholas Sze commented on RATIS-499: --- [~ljain], It needs more work to changes server to

[jira] [Commented] (RATIS-499) Server should close the sliding window if it steps down

2019-03-19 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795744#comment-16795744 ] Hadoop QA commented on RATIS-499: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (RATIS-499) Server should close the sliding window if it steps down

2019-03-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795709#comment-16795709 ] Hadoop QA commented on RATIS-499: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (RATIS-499) Server should close the sliding window if it steps down

2019-03-18 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795628#comment-16795628 ] Tsz Wo Nicholas Sze commented on RATIS-499: --- r499_20190319b.patch: fixes some bugs. > Server

[jira] [Commented] (RATIS-499) Server should close the sliding window if it steps down

2019-03-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795600#comment-16795600 ] Hadoop QA commented on RATIS-499: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (RATIS-499) Server should close the sliding window if it steps down

2019-03-18 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795573#comment-16795573 ] Tsz Wo Nicholas Sze commented on RATIS-499: --- r499_20190319.patch: changes server to response

[jira] [Commented] (RATIS-499) Server should close the sliding window if it steps down

2019-03-18 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795564#comment-16795564 ] Tsz Wo Nicholas Sze commented on RATIS-499: --- For #2, the server may response error for

[jira] [Commented] (RATIS-499) Server should close the sliding window if it steps down

2019-03-18 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795558#comment-16795558 ] Tsz Wo Nicholas Sze commented on RATIS-499: --- Thanks [~ljain]. # We are already updating

[jira] [Commented] (RATIS-499) Server should close the sliding window if it steps down

2019-03-18 Thread Lokesh Jain (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795267#comment-16795267 ] Lokesh Jain commented on RATIS-499: --- [~szetszwo] Thanks for working on this! The patch looks good to me.

[jira] [Commented] (RATIS-499) Server should close the sliding window if it steps down

2019-03-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794922#comment-16794922 ] Hadoop QA commented on RATIS-499: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (RATIS-499) Server should close the sliding window if it steps down

2019-03-18 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794907#comment-16794907 ] Tsz Wo Nicholas Sze commented on RATIS-499: --- r499_20190318b.patch: uses unordered async calls

[jira] [Commented] (RATIS-499) Server should close the sliding window if it steps down

2019-03-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794854#comment-16794854 ] Hadoop QA commented on RATIS-499: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (RATIS-499) Server should close the sliding window if it steps down

2019-03-18 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794832#comment-16794832 ] Tsz Wo Nicholas Sze commented on RATIS-499: --- r499_20190318.patch: adds some tests. > Server

[jira] [Commented] (RATIS-499) Server should close the sliding window if it steps down

2019-03-14 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793135#comment-16793135 ] Hadoop QA commented on RATIS-499: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (RATIS-499) Server should close the sliding window if it steps down

2019-03-14 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793121#comment-16793121 ] Tsz Wo Nicholas Sze commented on RATIS-499: --- r499_20190314.patch: - closes all existing sliding