[jira] [Commented] (RATIS-651) Add metrics related to leaderElection and HeartBeat

[ https://issues.apache.org/jira/browse/RATIS-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16917889#comment-16917889 ] Aravindan Vijayan commented on RATIS-651: - Thank you for the reviews [~elserj] and [~shashikant]!

[jira] [Commented] (RATIS-651) Add metrics related to leaderElection and HeartBeat

[ https://issues.apache.org/jira/browse/RATIS-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16917869#comment-16917869 ] Josh Elser commented on RATIS-651: -- Nice! V3 looks good to me too (sorry for the delayed review). Great

[jira] [Commented] (RATIS-651) Add metrics related to leaderElection and HeartBeat

[ https://issues.apache.org/jira/browse/RATIS-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16917409#comment-16917409 ] Shashikant Banerjee commented on RATIS-651: --- Thanks [~avijayan] for updating the patch. The

[jira] [Commented] (RATIS-651) Add metrics related to leaderElection and HeartBeat

[ https://issues.apache.org/jira/browse/RATIS-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16917274#comment-16917274 ] Hadoop QA commented on RATIS-651: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (RATIS-651) Add metrics related to leaderElection and HeartBeat

[ https://issues.apache.org/jira/browse/RATIS-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16916900#comment-16916900 ] Hadoop QA commented on RATIS-651: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (RATIS-651) Add metrics related to leaderElection and HeartBeat

[ https://issues.apache.org/jira/browse/RATIS-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16916886#comment-16916886 ] Shashikant Banerjee commented on RATIS-651: --- Thanks [~avijayan] for working on this. The patch

[jira] [Commented] (RATIS-651) Add metrics related to leaderElection and HeartBeat

[ https://issues.apache.org/jira/browse/RATIS-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16916285#comment-16916285 ] Hadoop QA commented on RATIS-651: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (RATIS-651) Add metrics related to leaderElection and HeartBeat

[ https://issues.apache.org/jira/browse/RATIS-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16916110#comment-16916110 ] Josh Elser commented on RATIS-651: -- Was talking to Aravindan in chat – trying to summarize for the

[jira] [Commented] (RATIS-651) Add metrics related to leaderElection and HeartBeat

[ https://issues.apache.org/jira/browse/RATIS-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16915784#comment-16915784 ] Shashikant Banerjee commented on RATIS-651: --- Thanks [~avijayan] for working on this and

[jira] [Commented] (RATIS-651) Add metrics related to leaderElection and HeartBeat

[ https://issues.apache.org/jira/browse/RATIS-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914608#comment-16914608 ] Josh Elser commented on RATIS-651: -- The change to LogAppender makes sense to catch from any Peer, but

[jira] [Commented] (RATIS-651) Add metrics related to leaderElection and HeartBeat

[ https://issues.apache.org/jira/browse/RATIS-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914513#comment-16914513 ] Aravindan Vijayan commented on RATIS-651: - Added the first version of the patch for comments. I