[
https://issues.apache.org/jira/browse/RATIS-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16948914#comment-16948914
]
Siddharth Wagle commented on RATIS-698:
---
Thanks for reporting [~ljain], opened RATIS-707 to address
[
https://issues.apache.org/jira/browse/RATIS-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16948904#comment-16948904
]
Lokesh Jain commented on RATIS-698:
---
I think this is causing test failures in
[
https://issues.apache.org/jira/browse/RATIS-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16947470#comment-16947470
]
Tsz-wo Sze commented on RATIS-698:
--
+1 the 04 patch looks good.
> RaftServerImpl should not enforce
[
https://issues.apache.org/jira/browse/RATIS-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16947382#comment-16947382
]
Hadoop QA commented on RATIS-698:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/RATIS-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16946675#comment-16946675
]
Hadoop QA commented on RATIS-698:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/RATIS-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16946574#comment-16946574
]
Hadoop QA commented on RATIS-698:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/RATIS-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16946527#comment-16946527
]
Siddharth Wagle commented on RATIS-698:
---
Thanks [~szetszwo] for review comments. Updated 04 based on
[
https://issues.apache.org/jira/browse/RATIS-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16946486#comment-16946486
]
Tsz-wo Sze commented on RATIS-698:
--
Thanks [~swagle] for digging out the test failure.
[
https://issues.apache.org/jira/browse/RATIS-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16946287#comment-16946287
]
Hadoop QA commented on RATIS-698:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/RATIS-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16946199#comment-16946199
]
Siddharth Wagle commented on RATIS-698:
---
[~szetszwo] The unit test issue was introduced by RAT-693,
[
https://issues.apache.org/jira/browse/RATIS-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944223#comment-16944223
]
Tsz-wo Sze commented on RATIS-698:
--
This exception is not a failure. It just warns that there is still
[
https://issues.apache.org/jira/browse/RATIS-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944215#comment-16944215
]
Siddharth Wagle commented on RATIS-698:
---
Hi [~szetszwo], I am getting the test to fail as well as
[
https://issues.apache.org/jira/browse/RATIS-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944175#comment-16944175
]
Tsz-wo Sze commented on RATIS-698:
--
With the 02 patch, TestRaftWithGrpc.testOldLeaderCommit() failed
[
https://issues.apache.org/jira/browse/RATIS-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944170#comment-16944170
]
Tsz-wo Sze commented on RATIS-698:
--
Just tried TestRaftReconfigurationWithGrpc.testNoChangeRequest()
[
https://issues.apache.org/jira/browse/RATIS-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944169#comment-16944169
]
Tsz-wo Sze commented on RATIS-698:
--
Some test failures do seem related, e.g.
[
https://issues.apache.org/jira/browse/RATIS-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944037#comment-16944037
]
Siddharth Wagle commented on RATIS-698:
---
Hi [~szetszwo] It seems we are back down to usual failures
[
https://issues.apache.org/jira/browse/RATIS-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944033#comment-16944033
]
Hadoop QA commented on RATIS-698:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/RATIS-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943991#comment-16943991
]
Siddharth Wagle commented on RATIS-698:
---
Thanks [~szetszwo] most of these UT's work locally for me,
[
https://issues.apache.org/jira/browse/RATIS-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943470#comment-16943470
]
Tsz-wo Sze commented on RATIS-698:
--
+1 the 02 patch looks good.
[~swagle], there were many test failures
[
https://issues.apache.org/jira/browse/RATIS-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943399#comment-16943399
]
Hadoop QA commented on RATIS-698:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/RATIS-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943330#comment-16943330
]
Hadoop QA commented on RATIS-698:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/RATIS-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943288#comment-16943288
]
Hadoop QA commented on RATIS-698:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/RATIS-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943284#comment-16943284
]
Siddharth Wagle commented on RATIS-698:
---
Thanks for review [~szetszwo], I have rebased this on top
[
https://issues.apache.org/jira/browse/RATIS-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943277#comment-16943277
]
Tsz-wo Sze commented on RATIS-698:
--
Indeed, putting it in RaftServerImpl is better since FollowerState
[
https://issues.apache.org/jira/browse/RATIS-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943236#comment-16943236
]
Siddharth Wagle commented on RATIS-698:
---
[~szetszwo] Making it AtomicBoolean makes sense but moving
[
https://issues.apache.org/jira/browse/RATIS-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942448#comment-16942448
]
Tsz-wo Sze commented on RATIS-698:
--
[~swagle], thanks for working on this.
The 01 patch adds a
[
https://issues.apache.org/jira/browse/RATIS-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942321#comment-16942321
]
Hadoop QA commented on RATIS-698:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/RATIS-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942258#comment-16942258
]
Hadoop QA commented on RATIS-698:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
28 matches
Mail list logo