[jira] [Commented] (RATIS-698) RaftServerImpl should not enforce minTimeout before first leaderElection cycle

2019-10-10 Thread Siddharth Wagle (Jira)
[ https://issues.apache.org/jira/browse/RATIS-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16948914#comment-16948914 ] Siddharth Wagle commented on RATIS-698: --- Thanks for reporting [~ljain], opened RATIS-707 to address

[jira] [Commented] (RATIS-698) RaftServerImpl should not enforce minTimeout before first leaderElection cycle

2019-10-10 Thread Lokesh Jain (Jira)
[ https://issues.apache.org/jira/browse/RATIS-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16948904#comment-16948904 ] Lokesh Jain commented on RATIS-698: --- I think this is causing test failures in

[jira] [Commented] (RATIS-698) RaftServerImpl should not enforce minTimeout before first leaderElection cycle

2019-10-09 Thread Tsz-wo Sze (Jira)
[ https://issues.apache.org/jira/browse/RATIS-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16947470#comment-16947470 ] Tsz-wo Sze commented on RATIS-698: -- +1 the 04 patch looks good. > RaftServerImpl should not enforce

[jira] [Commented] (RATIS-698) RaftServerImpl should not enforce minTimeout before first leaderElection cycle

2019-10-09 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/RATIS-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16947382#comment-16947382 ] Hadoop QA commented on RATIS-698: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (RATIS-698) RaftServerImpl should not enforce minTimeout before first leaderElection cycle

2019-10-08 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/RATIS-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16946675#comment-16946675 ] Hadoop QA commented on RATIS-698: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (RATIS-698) RaftServerImpl should not enforce minTimeout before first leaderElection cycle

2019-10-08 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/RATIS-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16946574#comment-16946574 ] Hadoop QA commented on RATIS-698: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (RATIS-698) RaftServerImpl should not enforce minTimeout before first leaderElection cycle

2019-10-08 Thread Siddharth Wagle (Jira)
[ https://issues.apache.org/jira/browse/RATIS-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16946527#comment-16946527 ] Siddharth Wagle commented on RATIS-698: --- Thanks [~szetszwo] for review comments. Updated 04 based on

[jira] [Commented] (RATIS-698) RaftServerImpl should not enforce minTimeout before first leaderElection cycle

2019-10-07 Thread Tsz-wo Sze (Jira)
[ https://issues.apache.org/jira/browse/RATIS-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16946486#comment-16946486 ] Tsz-wo Sze commented on RATIS-698: -- Thanks [~swagle] for digging out the test failure.

[jira] [Commented] (RATIS-698) RaftServerImpl should not enforce minTimeout before first leaderElection cycle

2019-10-07 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/RATIS-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16946287#comment-16946287 ] Hadoop QA commented on RATIS-698: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (RATIS-698) RaftServerImpl should not enforce minTimeout before first leaderElection cycle

2019-10-07 Thread Siddharth Wagle (Jira)
[ https://issues.apache.org/jira/browse/RATIS-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16946199#comment-16946199 ] Siddharth Wagle commented on RATIS-698: --- [~szetszwo] The unit test issue was introduced by RAT-693,

[jira] [Commented] (RATIS-698) RaftServerImpl should not enforce minTimeout before first leaderElection cycle

2019-10-03 Thread Tsz-wo Sze (Jira)
[ https://issues.apache.org/jira/browse/RATIS-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944223#comment-16944223 ] Tsz-wo Sze commented on RATIS-698: -- This exception is not a failure. It just warns that there is still

[jira] [Commented] (RATIS-698) RaftServerImpl should not enforce minTimeout before first leaderElection cycle

2019-10-03 Thread Siddharth Wagle (Jira)
[ https://issues.apache.org/jira/browse/RATIS-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944215#comment-16944215 ] Siddharth Wagle commented on RATIS-698: --- Hi [~szetszwo], I am getting the test to fail as well as

[jira] [Commented] (RATIS-698) RaftServerImpl should not enforce minTimeout before first leaderElection cycle

2019-10-03 Thread Tsz-wo Sze (Jira)
[ https://issues.apache.org/jira/browse/RATIS-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944175#comment-16944175 ] Tsz-wo Sze commented on RATIS-698: -- With the 02 patch, TestRaftWithGrpc.testOldLeaderCommit() failed

[jira] [Commented] (RATIS-698) RaftServerImpl should not enforce minTimeout before first leaderElection cycle

2019-10-03 Thread Tsz-wo Sze (Jira)
[ https://issues.apache.org/jira/browse/RATIS-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944170#comment-16944170 ] Tsz-wo Sze commented on RATIS-698: -- Just tried TestRaftReconfigurationWithGrpc.testNoChangeRequest()

[jira] [Commented] (RATIS-698) RaftServerImpl should not enforce minTimeout before first leaderElection cycle

2019-10-03 Thread Tsz-wo Sze (Jira)
[ https://issues.apache.org/jira/browse/RATIS-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944169#comment-16944169 ] Tsz-wo Sze commented on RATIS-698: -- Some test failures do seem related, e.g.

[jira] [Commented] (RATIS-698) RaftServerImpl should not enforce minTimeout before first leaderElection cycle

2019-10-03 Thread Siddharth Wagle (Jira)
[ https://issues.apache.org/jira/browse/RATIS-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944037#comment-16944037 ] Siddharth Wagle commented on RATIS-698: --- Hi [~szetszwo] It seems we are back down to usual failures

[jira] [Commented] (RATIS-698) RaftServerImpl should not enforce minTimeout before first leaderElection cycle

2019-10-03 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/RATIS-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944033#comment-16944033 ] Hadoop QA commented on RATIS-698: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (RATIS-698) RaftServerImpl should not enforce minTimeout before first leaderElection cycle

2019-10-03 Thread Siddharth Wagle (Jira)
[ https://issues.apache.org/jira/browse/RATIS-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943991#comment-16943991 ] Siddharth Wagle commented on RATIS-698: --- Thanks [~szetszwo] most of these UT's work locally for me,

[jira] [Commented] (RATIS-698) RaftServerImpl should not enforce minTimeout before first leaderElection cycle

2019-10-03 Thread Tsz-wo Sze (Jira)
[ https://issues.apache.org/jira/browse/RATIS-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943470#comment-16943470 ] Tsz-wo Sze commented on RATIS-698: -- +1 the 02 patch looks good. [~swagle], there were many test failures

[jira] [Commented] (RATIS-698) RaftServerImpl should not enforce minTimeout before first leaderElection cycle

2019-10-03 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/RATIS-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943399#comment-16943399 ] Hadoop QA commented on RATIS-698: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (RATIS-698) RaftServerImpl should not enforce minTimeout before first leaderElection cycle

2019-10-02 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/RATIS-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943330#comment-16943330 ] Hadoop QA commented on RATIS-698: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (RATIS-698) RaftServerImpl should not enforce minTimeout before first leaderElection cycle

2019-10-02 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/RATIS-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943288#comment-16943288 ] Hadoop QA commented on RATIS-698: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (RATIS-698) RaftServerImpl should not enforce minTimeout before first leaderElection cycle

2019-10-02 Thread Siddharth Wagle (Jira)
[ https://issues.apache.org/jira/browse/RATIS-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943284#comment-16943284 ] Siddharth Wagle commented on RATIS-698: --- Thanks for review [~szetszwo], I have rebased this on top

[jira] [Commented] (RATIS-698) RaftServerImpl should not enforce minTimeout before first leaderElection cycle

2019-10-02 Thread Tsz-wo Sze (Jira)
[ https://issues.apache.org/jira/browse/RATIS-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943277#comment-16943277 ] Tsz-wo Sze commented on RATIS-698: -- Indeed, putting it in RaftServerImpl is better since FollowerState

[jira] [Commented] (RATIS-698) RaftServerImpl should not enforce minTimeout before first leaderElection cycle

2019-10-02 Thread Siddharth Wagle (Jira)
[ https://issues.apache.org/jira/browse/RATIS-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943236#comment-16943236 ] Siddharth Wagle commented on RATIS-698: --- [~szetszwo] Making it AtomicBoolean makes sense but moving

[jira] [Commented] (RATIS-698) RaftServerImpl should not enforce minTimeout before first leaderElection cycle

2019-10-01 Thread Tsz-wo Sze (Jira)
[ https://issues.apache.org/jira/browse/RATIS-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942448#comment-16942448 ] Tsz-wo Sze commented on RATIS-698: -- [~swagle], thanks for working on this. The 01 patch adds a

[jira] [Commented] (RATIS-698) RaftServerImpl should not enforce minTimeout before first leaderElection cycle

2019-10-01 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/RATIS-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942321#comment-16942321 ] Hadoop QA commented on RATIS-698: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (RATIS-698) RaftServerImpl should not enforce minTimeout before first leaderElection cycle

2019-10-01 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/RATIS-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942258#comment-16942258 ] Hadoop QA commented on RATIS-698: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||