[
https://issues.apache.org/jira/browse/RATIS-703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16952353#comment-16952353
]
Tsz-wo Sze commented on RATIS-703:
--
+1 the 02 patch looks good.
> ./ratis-common/src/ma
[
https://issues.apache.org/jira/browse/RATIS-703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16952286#comment-16952286
]
Hadoop QA commented on RATIS-703:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/RATIS-703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16952271#comment-16952271
]
Henrik Hegardt commented on RATIS-703:
--
I've added a patch RATIS-703.01.patch which c
[
https://issues.apache.org/jira/browse/RATIS-703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16951516#comment-16951516
]
Tsz-wo Sze commented on RATIS-703:
--
The attempt(..) methods are also useful in non-test c
[
https://issues.apache.org/jira/browse/RATIS-703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16950157#comment-16950157
]
Henrik Hegardt commented on RATIS-703:
--
Hmm, I think the bug got me. I was under the
[
https://issues.apache.org/jira/browse/RATIS-703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16950137#comment-16950137
]
Henrik Hegardt commented on RATIS-703:
--
JavaUtils.attempt(() ->
snapshotFiles.stream
[
https://issues.apache.org/jira/browse/RATIS-703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16948351#comment-16948351
]
Tsz-wo Sze commented on RATIS-703:
--
> And wouldn't your new method change the semantics f
[
https://issues.apache.org/jira/browse/RATIS-703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16947985#comment-16947985
]
Henrik Hegardt commented on RATIS-703:
--
I think just renaming it would suffice instea
[
https://issues.apache.org/jira/browse/RATIS-703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16947312#comment-16947312
]
Tsz-wo Sze commented on RATIS-703:
--
How about renaming the attempt(BooleanSupplier, ...)
[
https://issues.apache.org/jira/browse/RATIS-703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16947306#comment-16947306
]
Tsz-wo Sze commented on RATIS-703:
--
[~hheg], thanks for trying updating your JDK. Since
[
https://issues.apache.org/jira/browse/RATIS-703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16947182#comment-16947182
]
Hadoop QA commented on RATIS-703:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/RATIS-703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16947179#comment-16947179
]
Henrik Hegardt commented on RATIS-703:
--
You are right, the example I provided wasn't
[
https://issues.apache.org/jira/browse/RATIS-703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16946620#comment-16946620
]
Tsz-wo Sze commented on RATIS-703:
--
> ... the compiler cannot decide if it should use the
[
https://issues.apache.org/jira/browse/RATIS-703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16946500#comment-16946500
]
Henrik Hegardt commented on RATIS-703:
--
Yes, CheckedSupplier and CheckedRunnable are
[
https://issues.apache.org/jira/browse/RATIS-703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16946390#comment-16946390
]
Tsz-wo Sze commented on RATIS-703:
--
What JDK version are you using? It probably is a jav
[
https://issues.apache.org/jira/browse/RATIS-703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16946184#comment-16946184
]
Hadoop QA commented on RATIS-703:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
16 matches
Mail list logo