[jira] [Commented] (RATIS-756) Fix identified names in ratis-common

2019-11-26 Thread Tsz-wo Sze (Jira)
[ https://issues.apache.org/jira/browse/RATIS-756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16982740#comment-16982740 ] Tsz-wo Sze commented on RATIS-756: -- > ... If you still feel some more changes are needed,

[jira] [Commented] (RATIS-756) Fix identified names in ratis-common

2019-11-22 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/RATIS-756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16980627#comment-16980627 ] Hadoop QA commented on RATIS-756: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (RATIS-756) Fix identified names in ratis-common

2019-11-22 Thread Dinesh Chitlangia (Jira)
[ https://issues.apache.org/jira/browse/RATIS-756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16980618#comment-16980618 ] Dinesh Chitlangia commented on RATIS-756: - [~szetszwo] Patch 002 addresses review

[jira] [Commented] (RATIS-756) Fix identified names in ratis-common

2019-11-22 Thread Tsz-wo Sze (Jira)
[ https://issues.apache.org/jira/browse/RATIS-756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16980517#comment-16980517 ] Tsz-wo Sze commented on RATIS-756: -- - In RaftGroup, change EMPTY_GROUP to final but don't

[jira] [Commented] (RATIS-756) Fix identified names in ratis-common

2019-11-21 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/RATIS-756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16979882#comment-16979882 ] Hadoop QA commented on RATIS-756: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (RATIS-756) Fix identified names in ratis-common

2019-11-21 Thread Dinesh Chitlangia (Jira)
[ https://issues.apache.org/jira/browse/RATIS-756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16979858#comment-16979858 ] Dinesh Chitlangia commented on RATIS-756: - [~szetszwo] Patch 001 for your review.