[jira] [Commented] (RATIS-840) Memory leak of LogAppender

[ https://issues.apache.org/jira/browse/RATIS-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17095291#comment-17095291 ] Lokesh Jain commented on RATIS-840: --- [~yjxxtd] Thanks for the contribution! [~szetszwo] [~elek]

[jira] [Commented] (RATIS-840) Memory leak of LogAppender

[ https://issues.apache.org/jira/browse/RATIS-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17095244#comment-17095244 ] runzhiwang commented on RATIS-840: -- [~elek] Hi, I have verified my patch does not generate new failed UT,

[jira] [Commented] (RATIS-840) Memory leak of LogAppender

[ https://issues.apache.org/jira/browse/RATIS-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17095242#comment-17095242 ] Marton Elek commented on RATIS-840: --- bq. Marton Elek Please wait for me, I have to make sure the patch

[jira] [Commented] (RATIS-840) Memory leak of LogAppender

[ https://issues.apache.org/jira/browse/RATIS-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17095000#comment-17095000 ] Hadoop QA commented on RATIS-840: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (RATIS-840) Memory leak of LogAppender

[ https://issues.apache.org/jira/browse/RATIS-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17094551#comment-17094551 ] runzhiwang commented on RATIS-840: -- [~elek] Please wait for me, I have to verify the ratis failed ut has

[jira] [Commented] (RATIS-840) Memory leak of LogAppender

[ https://issues.apache.org/jira/browse/RATIS-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17094548#comment-17094548 ] Marton Elek commented on RATIS-840: --- [~szetszwo] can you please help to review it? Ozone test results

[jira] [Commented] (RATIS-840) Memory leak of LogAppender

[ https://issues.apache.org/jira/browse/RATIS-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093226#comment-17093226 ] runzhiwang commented on RATIS-840: -- PR available: https://github.com/apache/incubator-ratis/pull/69 >

[jira] [Commented] (RATIS-840) Memory leak of LogAppender

[ https://issues.apache.org/jira/browse/RATIS-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17091195#comment-17091195 ] runzhiwang commented on RATIS-840: -- [~szetszwo] Sure, I will take a look. > Memory leak of LogAppender >

[jira] [Commented] (RATIS-840) Memory leak of LogAppender

[ https://issues.apache.org/jira/browse/RATIS-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17091159#comment-17091159 ] Tsz-wo Sze commented on RATIS-840: -- [~yjxxtd], the test failures seem related. Could you take a look? >

[jira] [Commented] (RATIS-840) Memory leak of LogAppender

[ https://issues.apache.org/jira/browse/RATIS-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090498#comment-17090498 ] Hadoop QA commented on RATIS-840: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (RATIS-840) Memory leak of LogAppender

[ https://issues.apache.org/jira/browse/RATIS-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090457#comment-17090457 ] runzhiwang commented on RATIS-840: -- [~szetszwo] Hi, I have updated the patch. Could you help review it

[jira] [Commented] (RATIS-840) Memory leak of LogAppender

[ https://issues.apache.org/jira/browse/RATIS-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090361#comment-17090361 ] runzhiwang commented on RATIS-840: -- [~szetszwo] Sounds good. I will open another JIRA and fix the

[jira] [Commented] (RATIS-840) Memory leak of LogAppender

[ https://issues.apache.org/jira/browse/RATIS-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089143#comment-17089143 ] runzhiwang commented on RATIS-840: -- {quote}There may be a bug but the correct fix is not to pollute

[jira] [Commented] (RATIS-840) Memory leak of LogAppender

[ https://issues.apache.org/jira/browse/RATIS-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088969#comment-17088969 ] Tsz-wo Sze commented on RATIS-840: -- > ...  It passed because it forget to stop the old GrpcLogAppender,

[jira] [Commented] (RATIS-840) Memory leak of LogAppender

[ https://issues.apache.org/jira/browse/RATIS-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088248#comment-17088248 ] runzhiwang commented on RATIS-840: -- [~szetszwo] {quote} It is unimportant to wait for the thread

[jira] [Commented] (RATIS-840) Memory leak of LogAppender

[ https://issues.apache.org/jira/browse/RATIS-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088236#comment-17088236 ] Tsz-wo Sze commented on RATIS-840: -- > ...  because someone may forget to startAppender/stopAppender ...

[jira] [Commented] (RATIS-840) Memory leak of LogAppender

[ https://issues.apache.org/jira/browse/RATIS-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088167#comment-17088167 ] runzhiwang commented on RATIS-840: -- [~szetszwo] Hi, Thanks for your comments. {quote}SenderList is

[jira] [Commented] (RATIS-840) Memory leak of LogAppender

[ https://issues.apache.org/jira/browse/RATIS-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088015#comment-17088015 ] Tsz-wo Sze commented on RATIS-840: -- [~yjxxtd], thanks for the patch! Some comments - SenderList is

[jira] [Commented] (RATIS-840) Memory leak of LogAppender

[ https://issues.apache.org/jira/browse/RATIS-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17087787#comment-17087787 ] Hadoop QA commented on RATIS-840: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (RATIS-840) Memory leak of LogAppender

[ https://issues.apache.org/jira/browse/RATIS-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17087752#comment-17087752 ] runzhiwang commented on RATIS-840: -- [~ljain] Thanks for your comments. I have updated the patch. >

[jira] [Commented] (RATIS-840) Memory leak of LogAppender

[ https://issues.apache.org/jira/browse/RATIS-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17087664#comment-17087664 ] Lokesh Jain commented on RATIS-840: --- [~yjxxtd] Thanks for updating the patch! Please find my comments

[jira] [Commented] (RATIS-840) Memory leak of LogAppender

[ https://issues.apache.org/jira/browse/RATIS-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17086898#comment-17086898 ] Hadoop QA commented on RATIS-840: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (RATIS-840) Memory leak of LogAppender

[ https://issues.apache.org/jira/browse/RATIS-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17086874#comment-17086874 ] Hadoop QA commented on RATIS-840: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (RATIS-840) Memory leak of LogAppender

[ https://issues.apache.org/jira/browse/RATIS-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17086870#comment-17086870 ] Hadoop QA commented on RATIS-840: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (RATIS-840) Memory leak of LogAppender

[ https://issues.apache.org/jira/browse/RATIS-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17086851#comment-17086851 ] Hadoop QA commented on RATIS-840: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (RATIS-840) Memory leak of LogAppender

[ https://issues.apache.org/jira/browse/RATIS-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17086847#comment-17086847 ] runzhiwang commented on RATIS-840: -- [~ljain][~szetszwo][~shashikant] Hi, all. I have submitted a new

[jira] [Commented] (RATIS-840) Memory leak of LogAppender

[ https://issues.apache.org/jira/browse/RATIS-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17085463#comment-17085463 ] runzhiwang commented on RATIS-840: -- Please wait for me. I need to find where a lot of GrpcLogAppend

[jira] [Commented] (RATIS-840) Memory leak of LogAppender

[ https://issues.apache.org/jira/browse/RATIS-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17085273#comment-17085273 ] Tsz-wo Sze commented on RATIS-840: -- > ... Error happens because voterLists.get(0) return the FollowerInfo

[jira] [Commented] (RATIS-840) Memory leak of LogAppender

[ https://issues.apache.org/jira/browse/RATIS-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081962#comment-17081962 ] Hadoop QA commented on RATIS-840: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (RATIS-840) Memory leak of LogAppender

[ https://issues.apache.org/jira/browse/RATIS-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17078267#comment-17078267 ] Lokesh Jain commented on RATIS-840: --- I mean we can call LogAppender#startAppender as part of

[jira] [Commented] (RATIS-840) Memory leak of LogAppender

[ https://issues.apache.org/jira/browse/RATIS-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17078242#comment-17078242 ] runzhiwang commented on RATIS-840: -- I will fix the related failed UT. > Memory leak of LogAppender >

[jira] [Commented] (RATIS-840) Memory leak of LogAppender

[ https://issues.apache.org/jira/browse/RATIS-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17078089#comment-17078089 ] runzhiwang commented on RATIS-840: -- [~ljain] Thanks for your review. And what do you mean of "I think we

[jira] [Commented] (RATIS-840) Memory leak of LogAppender

[ https://issues.apache.org/jira/browse/RATIS-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17078085#comment-17078085 ] Hadoop QA commented on RATIS-840: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (RATIS-840) Memory leak of LogAppender

[ https://issues.apache.org/jira/browse/RATIS-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17078060#comment-17078060 ] Lokesh Jain commented on RATIS-840: --- Also did you find reason for why restartSender was called multiple

[jira] [Commented] (RATIS-840) Memory leak of LogAppender

[ https://issues.apache.org/jira/browse/RATIS-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17078053#comment-17078053 ] Lokesh Jain commented on RATIS-840: --- [~yjxxtd] Thanks for working on this! Good catch on the bug! The

[jira] [Commented] (RATIS-840) Memory leak of LogAppender

[ https://issues.apache.org/jira/browse/RATIS-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17076067#comment-17076067 ] runzhiwang commented on RATIS-840: -- [~mukul724][~shashikant] Could you help review this patch ? Thank you