[GitHub] [solr] dsmiley commented on a change in pull request #47: SOLR-15217: Rename shardsWhitelist and extract AllowListUrlChecker to use it more broadly.

2021-03-26 Thread GitBox
dsmiley commented on a change in pull request #47: URL: https://github.com/apache/solr/pull/47#discussion_r602671024 ## File path: solr/solr-ref-guide/src/distributed-requests.adoc ## @@ -115,17 +115,19 @@ If specified, the thread pool will use a backing queue instead of a

[GitHub] [solr] dsmiley commented on a change in pull request #47: SOLR-15217: Rename shardsWhitelist and extract AllowListUrlChecker to use it more broadly.

2021-03-26 Thread GitBox
dsmiley commented on a change in pull request #47: URL: https://github.com/apache/solr/pull/47#discussion_r602670860 ## File path: solr/server/solr/solr.xml ## @@ -53,7 +54,6 @@ class="HttpShardHandlerFactory"> ${socketTimeout:60} ${connTimeout:6} -

[GitHub] [solr] dsmiley commented on a change in pull request #23: SOLR-15258: ConfigSetService add CRUD operations, subsume ZkConfigManager

2021-03-26 Thread GitBox
dsmiley commented on a change in pull request #23: URL: https://github.com/apache/solr/pull/23#discussion_r602656335 ## File path: solr/solrj/src/java/org/apache/solr/common/cloud/SolrZkClient.java ## @@ -781,6 +785,14 @@ public String getConfig() { } } + public

[GitHub] [solr] dsmiley commented on a change in pull request #23: SOLR-15258: ConfigSetService add CRUD operations, subsume ZkConfigManager

2021-03-26 Thread GitBox
dsmiley commented on a change in pull request #23: URL: https://github.com/apache/solr/pull/23#discussion_r602653831 ## File path: solr/core/src/java/org/apache/solr/cloud/ZkConfigSetService.java ## @@ -276,20 +270,11 @@ public void downloadConfig(String configName, Path dir)

[jira] [Commented] (SOLR-15296) Provide allowlisting mechanism in the JWT auth plugin to ignore paths like login

2021-03-26 Thread Zhenxu Ke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309838#comment-17309838 ] Zhenxu Ke commented on SOLR-15296: -- Yes! I also found  PermissionNameProvider might be a better place to

[GitHub] [solr] tflobbe opened a new pull request #51: SOLR-15155: Document how to set credentials in CloudHttp2SolrClient

2021-03-26 Thread GitBox
tflobbe opened a new pull request #51: URL: https://github.com/apache/solr/pull/51 Ref guide documentation for the changes introduced by https://github.com/apache/solr/pull/15 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Commented] (SOLR-15155) Let CloudHttp2SolrClient accept an external Http2SolrClient Builder

2021-03-26 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309808#comment-17309808 ] ASF subversion and git services commented on SOLR-15155: Commit

[jira] [Resolved] (SOLR-15154) Let Http2SolrClient pass Basic Auth credentials to all requests

2021-03-26 Thread Tomas Eduardo Fernandez Lobbe (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomas Eduardo Fernandez Lobbe resolved SOLR-15154. -- Fix Version/s: 8.9 main (9.0)

[jira] [Commented] (SOLR-15154) Let Http2SolrClient pass Basic Auth credentials to all requests

2021-03-26 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309800#comment-17309800 ] ASF subversion and git services commented on SOLR-15154: Commit

[jira] [Commented] (SOLR-15155) Let CloudHttp2SolrClient accept an external Http2SolrClient Builder

2021-03-26 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309797#comment-17309797 ] ASF subversion and git services commented on SOLR-15155: Commit

[GitHub] [solr] tflobbe merged pull request #15: SOLR-15155: Let CloudHttp2SolrClient accept an external Http2SolrClient Builder

2021-03-26 Thread GitBox
tflobbe merged pull request #15: URL: https://github.com/apache/solr/pull/15 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[jira] [Commented] (SOLR-15154) Let Http2SolrClient pass Basic Auth credentials to all requests

2021-03-26 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309796#comment-17309796 ] ASF subversion and git services commented on SOLR-15154: Commit

[GitHub] [solr] tflobbe merged pull request #14: SOLR-15154: Document new options for credentials

2021-03-26 Thread GitBox
tflobbe merged pull request #14: URL: https://github.com/apache/solr/pull/14 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [solr] tflobbe commented on a change in pull request #14: SOLR-15154: Document new options for credentials

2021-03-26 Thread GitBox
tflobbe commented on a change in pull request #14: URL: https://github.com/apache/solr/pull/14#discussion_r602618027 ## File path: solr/solr-ref-guide/src/basic-authentication-plugin.adoc ## @@ -220,6 +220,17 @@ QueryResponse rsp = req.process(solrClient); While this is

[jira] [Commented] (SOLR-15248) Remove login autocomplete

2021-03-26 Thread Lillie Hammer (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309782#comment-17309782 ] Lillie Hammer commented on SOLR-15248: -- [~janhoy] sure! thanks > Remove login autocomplete >

[GitHub] [solr] NazerkeBS commented on a change in pull request #23: SOLR-15258: ConfigSetService add CRUD operations, subsume ZkConfigManager

2021-03-26 Thread GitBox
NazerkeBS commented on a change in pull request #23: URL: https://github.com/apache/solr/pull/23#discussion_r602595930 ## File path: solr/core/src/java/org/apache/solr/cloud/ZkConfigSetService.java ## @@ -351,6 +282,19 @@ public void downloadConfig(String configName, Path dir)

[GitHub] [solr] NazerkeBS commented on a change in pull request #23: SOLR-15258: ConfigSetService add CRUD operations, subsume ZkConfigManager

2021-03-26 Thread GitBox
NazerkeBS commented on a change in pull request #23: URL: https://github.com/apache/solr/pull/23#discussion_r602596784 ## File path: solr/core/src/java/org/apache/solr/cloud/ZkController.java ## @@ -855,7 +855,11 @@ public static void createClusterZkNodes(SolrZkClient

[GitHub] [solr] NazerkeBS commented on a change in pull request #23: SOLR-15258: ConfigSetService add CRUD operations, subsume ZkConfigManager

2021-03-26 Thread GitBox
NazerkeBS commented on a change in pull request #23: URL: https://github.com/apache/solr/pull/23#discussion_r602595930 ## File path: solr/core/src/java/org/apache/solr/cloud/ZkConfigSetService.java ## @@ -351,6 +282,19 @@ public void downloadConfig(String configName, Path dir)

[GitHub] [solr] dsmiley commented on a change in pull request #23: SOLR-15258: ConfigSetService add CRUD operations, subsume ZkConfigManager

2021-03-26 Thread GitBox
dsmiley commented on a change in pull request #23: URL: https://github.com/apache/solr/pull/23#discussion_r602575524 ## File path: solr/core/src/java/org/apache/solr/cloud/ZkConfigSetService.java ## @@ -295,9 +248,9 @@ public void downloadConfig(String configName, Path dir)

[jira] [Commented] (SOLR-15248) Remove login autocomplete

2021-03-26 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309729#comment-17309729 ] Jan Høydahl commented on SOLR-15248: It's the smallest patch ever, very easy to backport. I just

[jira] [Updated] (SOLR-15292) Warn/Fail SignatureUpdateProcessorFactory init if cloud=true & overwriteDupes=true & signatureField != id

2021-03-26 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter updated SOLR-15292: -- Attachment: SOLR-15292.patch Status: Open (was: Open) 90% of the patch i'm

[GitHub] [solr-operator] HoustonPutman merged pull request #245: Add scripts to manipulate the version and update references around the project.

2021-03-26 Thread GitBox
HoustonPutman merged pull request #245: URL: https://github.com/apache/solr-operator/pull/245 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [solr-operator] HoustonPutman opened a new pull request #245: Add scripts to manipulate the version and update references around the project.

2021-03-26 Thread GitBox
HoustonPutman opened a new pull request #245: URL: https://github.com/apache/solr-operator/pull/245 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about

[jira] [Commented] (SOLR-15191) Faceting on EnumFieldType does not work if allBuckets, numBuckets or missing is set

2021-03-26 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309706#comment-17309706 ] ASF subversion and git services commented on SOLR-15191: Commit

[jira] [Commented] (SOLR-15191) Faceting on EnumFieldType does not work if allBuckets, numBuckets or missing is set

2021-03-26 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309705#comment-17309705 ] ASF subversion and git services commented on SOLR-15191: Commit

[jira] [Resolved] (SOLR-15299) ECJ linting doesn't seem to work

2021-03-26 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved SOLR-15299. Fix Version/s: main (9.0) Resolution: Fixed Thanks [~hossman] > ECJ linting doesn't seem

[jira] [Commented] (SOLR-15299) ECJ linting doesn't seem to work

2021-03-26 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309701#comment-17309701 ] ASF subversion and git services commented on SOLR-15299: Commit

[jira] [Commented] (SOLR-15224) Resolve the two ignored tests after Lucene test sources become unavailable

2021-03-26 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309700#comment-17309700 ] ASF subversion and git services commented on SOLR-15224: Commit

[jira] [Commented] (SOLR-15224) Resolve the two ignored tests after Lucene test sources become unavailable

2021-03-26 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309698#comment-17309698 ] ASF subversion and git services commented on SOLR-15224: Commit

[jira] [Commented] (SOLR-15299) ECJ linting doesn't seem to work

2021-03-26 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309699#comment-17309699 ] ASF subversion and git services commented on SOLR-15299: Commit

[GitHub] [solr] asfgit merged pull request #50: SOLR-15299: make ecj work again

2021-03-26 Thread GitBox
asfgit merged pull request #50: URL: https://github.com/apache/solr/pull/50 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [solr] dweiss opened a new pull request #50: SOLR-15299: make ecj work again

2021-03-26 Thread GitBox
dweiss opened a new pull request #50: URL: https://github.com/apache/solr/pull/50 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [solr] madrob commented on pull request #22: SOLR-15169 SolrPaths.assertPathAllowed normalization problem

2021-03-26 Thread GitBox
madrob commented on pull request #22: URL: https://github.com/apache/solr/pull/22#issuecomment-808476648 I can't come up with a way that this allows inappropriate actions. I suspect that we need to fix something else as this is probably a symptom of a different issue, not a cause, but

[jira] [Commented] (SOLR-15244) Use NIO methods instead of IO when interacting with Lucene Directory

2021-03-26 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309689#comment-17309689 ] Chris M. Hostetter commented on SOLR-15244: --- I should clarity: the failures aren't all related

[jira] [Reopened] (SOLR-15244) Use NIO methods instead of IO when interacting with Lucene Directory

2021-03-26 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter reopened SOLR-15244: --- This change seems to be causing a lot of reproducible jenkins failures with a similar

[jira] [Resolved] (SOLR-15273) Distributed group query, if rename the unique key field name, will be java.lang.NullPointerException.

2021-03-26 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christine Poerschke resolved SOLR-15273. Fix Version/s: 8.9 main (9.0) Assignee: Christine

[jira] [Commented] (SOLR-15273) Distributed group query, if rename the unique key field name, will be java.lang.NullPointerException.

2021-03-26 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309661#comment-17309661 ] Christine Poerschke commented on SOLR-15273: Manually deleted duplicate bot comments for

[jira] [Issue Comment Deleted] (SOLR-15273) Distributed group query, if rename the unique key field name, will be java.lang.NullPointerException.

2021-03-26 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christine Poerschke updated SOLR-15273: --- Comment: was deleted (was: Commit 3a533aa2dfbe0e0a1a5e4710b52ebfee6546fa9f in solr's

[jira] [Issue Comment Deleted] (SOLR-15273) Distributed group query, if rename the unique key field name, will be java.lang.NullPointerException.

2021-03-26 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christine Poerschke updated SOLR-15273: --- Comment: was deleted (was: Commit c83f321fd22dd67f6dbf420cf4ddcb562ae83897 in

[jira] [Resolved] (SOLR-15291) Test + ref-guide note about "safe" way to de-duplicate documents in SolrCloud

2021-03-26 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter resolved SOLR-15291. --- Fix Version/s: main (9.0) Resolution: Fixed > Test + ref-guide note about

[jira] [Commented] (SOLR-15296) Provide allowlisting mechanism in the JWT auth plugin to ignore paths like login

2021-03-26 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309557#comment-17309557 ] Jan Høydahl commented on SOLR-15296: You are right that we have disabled auth on the backend

[GitHub] [solr-operator] HoustonPutman opened a new pull request #244: Better dependency installation method. Update Controller-gen.

2021-03-26 Thread GitBox
HoustonPutman opened a new pull request #244: URL: https://github.com/apache/solr-operator/pull/244 Controller-gen needs to be updated, to keep the current look of the CRDs with go 1.16. Dependency installation can now be done via `make install-dependencies`, and uses `go install`

[GitHub] [solr-operator] HoustonPutman merged pull request #242: Add better versioning control in project.

2021-03-26 Thread GitBox
HoustonPutman merged pull request #242: URL: https://github.com/apache/solr-operator/pull/242 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[jira] [Commented] (SOLR-15291) Test + ref-guide note about "safe" way to de-duplicate documents in SolrCloud

2021-03-26 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309533#comment-17309533 ] ASF subversion and git services commented on SOLR-15291: Commit

[GitHub] [solr] bruno-roustant commented on a change in pull request #47: SOLR-15217: Rename shardsWhitelist and extract AllowListUrlChecker to use it more broadly.

2021-03-26 Thread GitBox
bruno-roustant commented on a change in pull request #47: URL: https://github.com/apache/solr/pull/47#discussion_r602408258 ## File path: solr/core/src/java/org/apache/solr/core/NodeConfig.java ## @@ -44,6 +44,8 @@ private final Set allowPaths; + private final String

[GitHub] [solr] janhoy commented on pull request #22: SOLR-15169 SolrPaths.assertPathAllowed normalization problem

2021-03-26 Thread GitBox
janhoy commented on pull request #22: URL: https://github.com/apache/solr/pull/22#issuecomment-808325717 So, what's your verdict @madrob ? :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Created] (SOLR-15298) Prometheus Exporter support cloud mode even with -b

2021-03-26 Thread Jira
Jan Høydahl created SOLR-15298: -- Summary: Prometheus Exporter support cloud mode even with -b Key: SOLR-15298 URL: https://issues.apache.org/jira/browse/SOLR-15298 Project: Solr Issue Type:

[GitHub] [solr] bruno-roustant commented on a change in pull request #47: SOLR-15217: Rename shardsWhitelist and extract AllowListUrlChecker to use it more broadly.

2021-03-26 Thread GitBox
bruno-roustant commented on a change in pull request #47: URL: https://github.com/apache/solr/pull/47#discussion_r602355865 ## File path: solr/solr-ref-guide/src/distributed-requests.adoc ## @@ -115,17 +115,19 @@ If specified, the thread pool will use a backing queue instead

[GitHub] [solr] bruno-roustant commented on a change in pull request #47: SOLR-15217: Rename shardsWhitelist and extract AllowListUrlChecker to use it more broadly.

2021-03-26 Thread GitBox
bruno-roustant commented on a change in pull request #47: URL: https://github.com/apache/solr/pull/47#discussion_r602362895 ## File path: solr/core/src/java/org/apache/solr/core/NodeConfig.java ## @@ -44,6 +44,8 @@ private final Set allowPaths; + private final String

[GitHub] [solr] bruno-roustant commented on a change in pull request #47: SOLR-15217: Rename shardsWhitelist and extract AllowListUrlChecker to use it more broadly.

2021-03-26 Thread GitBox
bruno-roustant commented on a change in pull request #47: URL: https://github.com/apache/solr/pull/47#discussion_r602360428 ## File path: solr/server/solr/solr.xml ## @@ -53,7 +54,6 @@ class="HttpShardHandlerFactory"> ${socketTimeout:60} ${connTimeout:6}

[GitHub] [solr] bruno-roustant commented on a change in pull request #47: SOLR-15217: Rename shardsWhitelist and extract AllowListUrlChecker to use it more broadly.

2021-03-26 Thread GitBox
bruno-roustant commented on a change in pull request #47: URL: https://github.com/apache/solr/pull/47#discussion_r602355865 ## File path: solr/solr-ref-guide/src/distributed-requests.adoc ## @@ -115,17 +115,19 @@ If specified, the thread pool will use a backing queue instead

[GitHub] [solr] bruno-roustant commented on a change in pull request #47: SOLR-15217: Rename shardsWhitelist and extract AllowListUrlChecker to use it more broadly.

2021-03-26 Thread GitBox
bruno-roustant commented on a change in pull request #47: URL: https://github.com/apache/solr/pull/47#discussion_r602352717 ## File path: solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java ## @@ -1231,6 +1231,9 @@ private void setupPolling(String intervalStr) {

[GitHub] [solr] bruno-roustant commented on a change in pull request #47: SOLR-15217: Rename shardsWhitelist and extract AllowListUrlChecker to use it more broadly.

2021-03-26 Thread GitBox
bruno-roustant commented on a change in pull request #47: URL: https://github.com/apache/solr/pull/47#discussion_r602348555 ## File path: solr/core/src/java/org/apache/solr/core/CoreContainer.java ## @@ -385,6 +388,9 @@ public CoreContainer(NodeConfig config, CoresLocator

[GitHub] [solr] bruno-roustant commented on a change in pull request #47: SOLR-15217: Rename shardsWhitelist and extract AllowListUrlChecker to use it more broadly.

2021-03-26 Thread GitBox
bruno-roustant commented on a change in pull request #47: URL: https://github.com/apache/solr/pull/47#discussion_r602345194 ## File path: solr/core/src/java/org/apache/solr/cloud/RecoveryStrategy.java ## @@ -220,7 +220,7 @@ protected String getReplicateLeaderUrl(ZkNodeProps

[GitHub] [solr] bruno-roustant commented on a change in pull request #20: SOLR-15051 Blob, DRAFT WIP

2021-03-26 Thread GitBox
bruno-roustant commented on a change in pull request #20: URL: https://github.com/apache/solr/pull/20#discussion_r602343365 ## File path: solr/contrib/blob-directory/src/java/org/apache/solr/blob/IndexInputInputStream.java ## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache

[jira] [Created] (SOLR-15297) Creating a collection with TLOG replicas fails with placement rules

2021-03-26 Thread Webster Homer (Jira)
Webster Homer created SOLR-15297: Summary: Creating a collection with TLOG replicas fails with placement rules Key: SOLR-15297 URL: https://issues.apache.org/jira/browse/SOLR-15297 Project: Solr

[GitHub] [solr] limingnihao commented on pull request #35: SOLR-15273: Distributed Group Query supports rename unique key field name

2021-03-26 Thread GitBox
limingnihao commented on pull request #35: URL: https://github.com/apache/solr/pull/35#issuecomment-808203920 @cpoerschke I have added the solr/CHANGES.txt entry for this change in the Bug Fixes section for the 8.9.0. Please help to review it. Thanks. -- This is an automated message

[GitHub] [solr] dsmiley commented on a change in pull request #47: SOLR-15217: Rename shardsWhitelist and extract AllowListUrlChecker to use it more broadly.

2021-03-26 Thread GitBox
dsmiley commented on a change in pull request #47: URL: https://github.com/apache/solr/pull/47#discussion_r602231577 ## File path: solr/core/src/java/org/apache/solr/cloud/RecoveryStrategy.java ## @@ -220,7 +220,7 @@ protected String getReplicateLeaderUrl(ZkNodeProps

[jira] [Created] (SOLR-15295) Provide allowlisting mechanism in the JWT auth plugin to ignore paths like login

2021-03-26 Thread Zhenxu Ke (Jira)
Zhenxu Ke created SOLR-15295: Summary: Provide allowlisting mechanism in the JWT auth plugin to ignore paths like login Key: SOLR-15295 URL: https://issues.apache.org/jira/browse/SOLR-15295 Project: Solr

[jira] [Created] (SOLR-15296) Provide allowlisting mechanism in the JWT auth plugin to ignore paths like login

2021-03-26 Thread Zhenxu Ke (Jira)
Zhenxu Ke created SOLR-15296: Summary: Provide allowlisting mechanism in the JWT auth plugin to ignore paths like login Key: SOLR-15296 URL: https://issues.apache.org/jira/browse/SOLR-15296 Project: Solr

[GitHub] [solr] dsmiley commented on a change in pull request #20: SOLR-15051 Blob, DRAFT WIP

2021-03-26 Thread GitBox
dsmiley commented on a change in pull request #20: URL: https://github.com/apache/solr/pull/20#discussion_r602226773 ## File path: solr/contrib/blob-directory/src/java/org/apache/solr/blob/IndexInputInputStream.java ## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software