[jira] [Commented] (SOLR-15427) [child limit=...] should be unlimited by default

2021-05-21 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17349601#comment-17349601 ] David Smiley commented on SOLR-15427: - I'm thinking this is 9.0 because it changes a

[GitHub] [solr] dsmiley opened a new pull request #144: SOLR-15427: Nested docs: [child limit=...] now defaults to -1

2021-05-21 Thread GitBox
dsmiley opened a new pull request #144: URL: https://github.com/apache/solr/pull/144 And -1 is now understood to be unlimited. https://issues.apache.org/jira/browse/SOLR-15427 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[jira] [Updated] (SOLR-14963) [child limit=...] param should apply per level

2021-05-21 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-14963: Description: The {{[child limit=10]}} doc transformer "limit" param _should_ apply per parent, and

[jira] [Updated] (SOLR-14963) [child limit=...] param should apply per level

2021-05-21 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-14963: Summary: [child limit=...] param should apply per level (was: Child "rows" param should apply per

[jira] [Updated] (SOLR-15427) [child limit=...] should be unlimited by default

2021-05-21 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-15427: Description: The {{[child]}} doc transformer's {{limit}} param defaults to 10, probably for consist

[jira] [Updated] (SOLR-15427) [child limit=...] should be unlimited by default

2021-05-21 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-15427: Summary: [child limit=...] should be unlimited by default (was: [child rows=...] should be unlimi

[jira] [Commented] (SOLR-14963) Child "rows" param should apply per level

2021-05-21 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17349594#comment-17349594 ] David Smiley commented on SOLR-14963: - I'm filing SOLR-15427 as a simpler change that

[jira] [Created] (SOLR-15428) Integrate the OpenJDK JMH micro benchmark framework for micro benchmarks and performance comparisons and investigation.

2021-05-21 Thread Mark Robert Miller (Jira)
Mark Robert Miller created SOLR-15428: - Summary: Integrate the OpenJDK JMH micro benchmark framework for micro benchmarks and performance comparisons and investigation. Key: SOLR-15428 URL: https://issues.apac

[GitHub] [solr] janhoy commented on pull request #139: SOLR-15423 JWTAuthPlugin support for custom truststore

2021-05-21 Thread GitBox
janhoy commented on pull request #139: URL: https://github.com/apache/solr/pull/139#issuecomment-846307923 Committed latest changes. Please resolve outstanding conversations if you're happy. Still would like some integration test to check the actual certificate usage. Think I'll try to spi

[GitHub] [solr] janhoy commented on a change in pull request #139: SOLR-15423 JWTAuthPlugin support for custom truststore

2021-05-21 Thread GitBox
janhoy commented on a change in pull request #139: URL: https://github.com/apache/solr/pull/139#discussion_r637278099 ## File path: solr/core/src/java/org/apache/solr/security/JWTAuthPlugin.java ## @@ -199,6 +237,28 @@ public void init(Map pluginConfig) { lastInitTime = In

[GitHub] [solr] janhoy commented on a change in pull request #139: SOLR-15423 JWTAuthPlugin support for custom truststore

2021-05-21 Thread GitBox
janhoy commented on a change in pull request #139: URL: https://github.com/apache/solr/pull/139#discussion_r637277985 ## File path: solr/core/src/java/org/apache/solr/security/JWTIssuerConfig.java ## @@ -335,33 +346,49 @@ public boolean isValid() { return jwkConfigured > 0

[GitHub] [solr] janhoy commented on a change in pull request #139: SOLR-15423 JWTAuthPlugin support for custom truststore

2021-05-21 Thread GitBox
janhoy commented on a change in pull request #139: URL: https://github.com/apache/solr/pull/139#discussion_r637277310 ## File path: solr/solr-ref-guide/src/jwt-authentication-plugin.adoc ## @@ -54,6 +54,8 @@ rolesClaim ; What claim id to pull user roles from. The cla

[GitHub] [solr] janhoy commented on a change in pull request #139: SOLR-15423 JWTAuthPlugin support for custom truststore

2021-05-21 Thread GitBox
janhoy commented on a change in pull request #139: URL: https://github.com/apache/solr/pull/139#discussion_r637276860 ## File path: solr/core/src/test/org/apache/solr/security/JWTAuthPluginTest.java ## @@ -477,4 +484,51 @@ public void initWithToplevelAndIssuersCombined() {

[GitHub] [solr-operator] HoustonPutman commented on issue #272: Solr Cloud only allows 1 exposed port.

2021-05-21 Thread GitBox
HoustonPutman commented on issue #272: URL: https://github.com/apache/solr-operator/issues/272#issuecomment-846283543 Also I guess that there need to be options to allow exposing the ports via the services and ingresses... -- This is an automated message from the Apache Git Service. To r

[GitHub] [solr] madrob commented on a change in pull request #114: SOLR-15390: Deprecate "segmentTerminateEarly" in favor of "minExactCount

2021-05-21 Thread GitBox
madrob commented on a change in pull request #114: URL: https://github.com/apache/solr/pull/114#discussion_r637243419 ## File path: solr/solr-ref-guide/src/common-query-parameters.adoc ## @@ -250,18 +250,6 @@ This value is only checked at the time of: As this check is period

[GitHub] [solr] madrob commented on a change in pull request #141: SOLR-15241: Add Docker & Kubernetes info to the README

2021-05-21 Thread GitBox
madrob commented on a change in pull request #141: URL: https://github.com/apache/solr/pull/141#discussion_r637240118 ## File path: README.md ## @@ -90,6 +90,36 @@ Common options are described in some detail in solr/README.txt. For an exhaustive treatment of options, run `bi

[GitHub] [solr] janhoy commented on a change in pull request #139: SOLR-15423 JWTAuthPlugin support for custom truststore

2021-05-21 Thread GitBox
janhoy commented on a change in pull request #139: URL: https://github.com/apache/solr/pull/139#discussion_r637238036 ## File path: solr/core/src/java/org/apache/solr/security/JWTAuthPlugin.java ## @@ -155,8 +168,33 @@ public void init(Map pluginConfig) { requiredScopes

[jira] [Commented] (SOLR-14656) Deprecate current autoscaling framework, remove from master

2021-05-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17349484#comment-17349484 ] ASF subversion and git services commented on SOLR-14656: Commit 2

[jira] [Created] (SOLR-15427) [child rows=...] should be unlimited by default

2021-05-21 Thread David Smiley (Jira)
David Smiley created SOLR-15427: --- Summary: [child rows=...] should be unlimited by default Key: SOLR-15427 URL: https://issues.apache.org/jira/browse/SOLR-15427 Project: Solr Issue Type: Impro

[GitHub] [solr] dsmiley opened a new pull request #143: SOLR-15044: JSON Loading: nested docs don't need ID

2021-05-21 Thread GitBox
dsmiley opened a new pull request #143: URL: https://github.com/apache/solr/pull/143 When indexing nested docs via JSON, it is no longer necessary to provide child doc IDs. This was already working for XML & "javabin"/SolrJ. Previously, omitting the ID would be confused for a partial/

[GitHub] [solr] epugh commented on pull request #42: SOLR-15277: Schema designer UI and supporting backend

2021-05-21 Thread GitBox
epugh commented on pull request #42: URL: https://github.com/apache/solr/pull/42#issuecomment-846247471 1. when "Analyzing your sample data, schema will load momentarily" text comes up, could we swap the gear for a moving animated gear icon? 1. download products a file called "down

[jira] [Updated] (SOLR-15426) Delete or Provide Attribution for evpBytesToKey

2021-05-21 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated SOLR-15426: - Summary: Delete or Provide Attribution for evpBytesToKey (was: Provide Attribution for evpBytesToKey) >

[GitHub] [solr] madrob opened a new pull request #142: SOLR-15426 Remove unused decrypt AES methods

2021-05-21 Thread GitBox
madrob opened a new pull request #142: URL: https://github.com/apache/solr/pull/142 https://issues.apache.org/jira/browse/SOLR-15426 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Created] (SOLR-15426) Provide Attribution for evpBytesToKey

2021-05-21 Thread Mike Drob (Jira)
Mike Drob created SOLR-15426: Summary: Provide Attribution for evpBytesToKey Key: SOLR-15426 URL: https://issues.apache.org/jira/browse/SOLR-15426 Project: Solr Issue Type: Task Security Le

[GitHub] [solr-operator] HoustonPutman commented on issue #272: Solr Cloud only allows 1 exposed port.

2021-05-21 Thread GitBox
HoustonPutman commented on issue #272: URL: https://github.com/apache/solr-operator/issues/272#issuecomment-846190646 So would you need anything else beyond just having an additional list of ports in the customPodOptions? This should be pretty straightforward to add. -- This is an

[jira] [Commented] (SOLR-11134) TestLTRReRankingPipeline.testDifferentTopN test fails

2021-05-21 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17349405#comment-17349405 ] Christine Poerschke commented on SOLR-11134: An explanation and proposed fix

[jira] [Assigned] (SOLR-11134) TestLTRReRankingPipeline.testDifferentTopN test fails

2021-05-21 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christine Poerschke reassigned SOLR-11134: -- Assignee: Christine Poerschke > TestLTRReRankingPipeline.testDifferentTopN tes

[GitHub] [solr] epugh commented on a change in pull request #42: SOLR-15277: Schema designer UI and supporting backend

2021-05-21 Thread GitBox
epugh commented on a change in pull request #42: URL: https://github.com/apache/solr/pull/42#discussion_r637090855 ## File path: solr/webapp/web/partials/schema-designer.html ## @@ -0,0 +1,919 @@ + + + + + + + + + + New Schema +

[GitHub] [solr] epugh commented on a change in pull request #42: SOLR-15277: Schema designer UI and supporting backend

2021-05-21 Thread GitBox
epugh commented on a change in pull request #42: URL: https://github.com/apache/solr/pull/42#discussion_r637090384 ## File path: solr/webapp/web/partials/schema-designer.html ## @@ -0,0 +1,919 @@ + + + + + + + + + + New Schema +

[jira] [Commented] (SOLR-15420) Exception thrown during intensive batch partial updating and segment merging

2021-05-21 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17349402#comment-17349402 ] Christine Poerschke commented on SOLR-15420: Hello. I was just browsing the c

[jira] [Commented] (SOLR-15421) ConfigSetService.checkConfigExists accepts empty configs

2021-05-21 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17349401#comment-17349401 ] David Smiley commented on SOLR-15421: - Arguably, the code you point to needn't check

[GitHub] [solr] epugh commented on pull request #131: SOLR-15410: Always use -Xverbosegclog for OpenJ9

2021-05-21 Thread GitBox
epugh commented on pull request #131: URL: https://github.com/apache/solr/pull/131#issuecomment-846117599 @risdenk just a mild ping to remind you about testing this on windows, and I'm going to try and test it on unix today ;-) -- This is an automated message from the Apache Git Service.

[jira] [Resolved] (SOLR-15422) Remove commons-lang2 license files

2021-05-21 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob resolved SOLR-15422. -- Fix Version/s: main (9.0) Resolution: Fixed Thanks, [~asalamon74]! > Remove commons-lang2 licen

[jira] [Commented] (SOLR-15422) Remove commons-lang2 license files

2021-05-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17349379#comment-17349379 ] ASF subversion and git services commented on SOLR-15422: Commit a

[GitHub] [solr] madrob merged pull request #136: SOLR-15422 Remove commons-lang2 license files

2021-05-21 Thread GitBox
madrob merged pull request #136: URL: https://github.com/apache/solr/pull/136 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please conta

[jira] [Resolved] (SOLR-15414) Use configset api to list configs on Admin UI configset picker instead of ZK config node

2021-05-21 Thread David Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Eric Pugh resolved SOLR-15414. Fix Version/s: main (9.0) Resolution: Fixed > Use configset api to list configs on A

[jira] [Assigned] (SOLR-15414) Use configset api to list configs on Admin UI configset picker instead of ZK config node

2021-05-21 Thread David Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Eric Pugh reassigned SOLR-15414: -- Assignee: David Eric Pugh > Use configset api to list configs on Admin UI configset pi

[jira] [Commented] (SOLR-15414) Use configset api to list configs on Admin UI configset picker instead of ZK config node

2021-05-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17349374#comment-17349374 ] ASF subversion and git services commented on SOLR-15414: Commit 1

[jira] [Commented] (SOLR-15414) Use configset api to list configs on Admin UI configset picker instead of ZK config node

2021-05-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17349375#comment-17349375 ] ASF subversion and git services commented on SOLR-15414: Commit 1

[GitHub] [solr] epugh merged pull request #140: SOLR-15414 Use ConfigSetAPI to list configs on AdminUI

2021-05-21 Thread GitBox
epugh merged pull request #140: URL: https://github.com/apache/solr/pull/140 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contac

[GitHub] [solr] NazerkeBS edited a comment on pull request #140: SOLR-15414 Use ConfigSetAPI to list configs on AdminUI

2021-05-21 Thread GitBox
NazerkeBS edited a comment on pull request #140: URL: https://github.com/apache/solr/pull/140#issuecomment-846090621 I think it is ok to have it only on 9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [solr] NazerkeBS commented on pull request #140: SOLR-15414 Use ConfigSetAPI to list configs on AdminUI

2021-05-21 Thread GitBox
NazerkeBS commented on pull request #140: URL: https://github.com/apache/solr/pull/140#issuecomment-846090621 I think it is ok to have it on 9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [solr] epugh commented on pull request #140: SOLR-15414 Use ConfigSetAPI to list configs on AdminUI

2021-05-21 Thread GitBox
epugh commented on pull request #140: URL: https://github.com/apache/solr/pull/140#issuecomment-846089517 Sure..I typically only merge to 9, because I haven't really figured out the extra steps to backport to branch_8x in the other repo.. Is that okay? -- This is an automated mess

[GitHub] [solr] tomglk commented on a change in pull request #123: SOLR-12697 Add pure DocValues support to FieldValueFeature

2021-05-21 Thread GitBox
tomglk commented on a change in pull request #123: URL: https://github.com/apache/solr/pull/123#discussion_r637047507 ## File path: solr/contrib/ltr/src/test/org/apache/solr/ltr/TestLTRReRankingPipeline.java ## @@ -41,25 +37,33 @@ import org.apache.lucene.search.ScoreMode; i

[jira] [Assigned] (SOLR-15241) Mention Docker in main README file

2021-05-21 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman reassigned SOLR-15241: - Assignee: Houston Putman > Mention Docker in main README file >

[GitHub] [solr] HoustonPutman opened a new pull request #141: SOLR-15241: Add Docker & Kubernetes info to the README

2021-05-21 Thread GitBox
HoustonPutman opened a new pull request #141: URL: https://github.com/apache/solr/pull/141 https://issues.apache.org/jira/browse/SOLR-15241 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [solr] NazerkeBS commented on pull request #140: SOLR-15414 Use ConfigSetAPI to list configs on AdminUI

2021-05-21 Thread GitBox
NazerkeBS commented on pull request #140: URL: https://github.com/apache/solr/pull/140#issuecomment-846057560 @epugh Thank you Eric for taking a look! Could you merge it please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[jira] [Assigned] (SOLR-15422) Remove commons-lang2 license files

2021-05-21 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob reassigned SOLR-15422: Assignee: Mike Drob > Remove commons-lang2 license files > -- > >

[jira] [Commented] (SOLR-15421) ConfigSetService.checkConfigExists accepts empty configs

2021-05-21 Thread Andras Salamon (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17349324#comment-17349324 ] Andras Salamon commented on SOLR-15421: --- I have tried to add the logic to the exist

[GitHub] [solr] madrob commented on a change in pull request #139: SOLR-15423 JWTAuthPlugin support for custom truststore

2021-05-21 Thread GitBox
madrob commented on a change in pull request #139: URL: https://github.com/apache/solr/pull/139#discussion_r636972401 ## File path: solr/core/src/java/org/apache/solr/security/JWTAuthPlugin.java ## @@ -199,6 +237,28 @@ public void init(Map pluginConfig) { lastInitTime = In

[GitHub] [solr] epugh commented on pull request #140: SOLR-15414 Use ConfigSetAPI to list configs on AdminUI

2021-05-21 Thread GitBox
epugh commented on pull request #140: URL: https://github.com/apache/solr/pull/140#issuecomment-845993054 Do you need help having it be merged? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [solr] epugh commented on pull request #140: SOLR-15414 Use ConfigSetAPI to list configs on AdminUI

2021-05-21 Thread GitBox
epugh commented on pull request #140: URL: https://github.com/apache/solr/pull/140#issuecomment-845991742 I just tested it, and LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [solr] madrob commented on a change in pull request #139: SOLR-15423 JWTAuthPlugin support for custom truststore

2021-05-21 Thread GitBox
madrob commented on a change in pull request #139: URL: https://github.com/apache/solr/pull/139#discussion_r636967838 ## File path: solr/core/src/java/org/apache/solr/security/JWTAuthPlugin.java ## @@ -155,8 +168,33 @@ public void init(Map pluginConfig) { requiredScopes

[GitHub] [solr] dsmiley commented on a change in pull request #115: SOLR-15392 Tracing span operation name and tags

2021-05-21 Thread GitBox
dsmiley commented on a change in pull request #115: URL: https://github.com/apache/solr/pull/115#discussion_r636951862 ## File path: solr/core/src/java/org/apache/solr/api/V2HttpCall.java ## @@ -360,6 +366,80 @@ protected void execute(SolrQueryResponse rsp) { SolrCore.post

[GitHub] [solr] dsmiley commented on a change in pull request #115: SOLR-15392 Tracing span operation name and tags

2021-05-21 Thread GitBox
dsmiley commented on a change in pull request #115: URL: https://github.com/apache/solr/pull/115#discussion_r636950622 ## File path: solr/core/src/java/org/apache/solr/api/V2HttpCall.java ## @@ -360,6 +366,80 @@ protected void execute(SolrQueryResponse rsp) { SolrCore.post

[GitHub] [solr] dsmiley commented on a change in pull request #115: SOLR-15392 Tracing span operation name and tags

2021-05-21 Thread GitBox
dsmiley commented on a change in pull request #115: URL: https://github.com/apache/solr/pull/115#discussion_r636936086 ## File path: solr/core/src/java/org/apache/solr/api/V2HttpCall.java ## @@ -360,6 +366,85 @@ protected void execute(SolrQueryResponse rsp) { SolrCore.post

[GitHub] [solr] epugh edited a comment on pull request #140: SOLR-15414 Use ConfigSetAPI to list configs on AdminUI

2021-05-21 Thread GitBox
epugh edited a comment on pull request #140: URL: https://github.com/apache/solr/pull/140#issuecomment-845963052 I love this! I was poking through the API calls from the front end, thinking about migrating them to the V2 equivalents, and noticed this one was odd. -- This is an autom

[GitHub] [solr] epugh commented on pull request #140: SOLR-15414 Use ConfigSetAPI to list configs on AdminUI

2021-05-21 Thread GitBox
epugh commented on pull request #140: URL: https://github.com/apache/solr/pull/140#issuecomment-845963052 I love this! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [solr-operator] RichieHowell opened a new issue #272: Solr Cloud only allows 1 exposed port.

2021-05-21 Thread GitBox
RichieHowell opened a new issue #272: URL: https://github.com/apache/solr-operator/issues/272 It would be helpful to be able to supply a list of ports in the solrAddressability instead of only have a single podPort possible. My specific use case is to be able to have both the normal port e

[GitHub] [solr] janhoy commented on a change in pull request #139: SOLR-15423 JWTAuthPlugin support for custom truststore

2021-05-21 Thread GitBox
janhoy commented on a change in pull request #139: URL: https://github.com/apache/solr/pull/139#discussion_r636899014 ## File path: solr/core/src/java/org/apache/solr/security/JWTAuthPlugin.java ## @@ -155,8 +168,33 @@ public void init(Map pluginConfig) { requiredScopes

[jira] [Commented] (SOLR-15421) ConfigSetService.checkConfigExists accepts empty configs

2021-05-21 Thread Andras Salamon (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17349102#comment-17349102 ] Andras Salamon commented on SOLR-15421: --- Wow, lots of responses. Thanks for everyon

[GitHub] [solr] NazerkeBS opened a new pull request #140: SOLR-15414 Use ConfigSetAPI to list configs on AdminUI

2021-05-21 Thread GitBox
NazerkeBS opened a new pull request #140: URL: https://github.com/apache/solr/pull/140 https://issues.apache.org/jira/browse/SOLR-X # Description Please provide a short description of the changes you're making with this pull request. # Solution Pl

[GitHub] [solr] alessandrobenedetti commented on pull request #129: SOLR-15407 untokenized field type with sow=false fix + tests

2021-05-21 Thread GitBox
alessandrobenedetti commented on pull request #129: URL: https://github.com/apache/solr/pull/129#issuecomment-845808565 that's much appreciated, I want a second pair of eyes minimum before merging this, so thanks David for your time. I would be delighted to have an opinion also from the

[jira] [Comment Edited] (SOLR-15421) ConfigSetService.checkConfigExists accepts empty configs

2021-05-21 Thread Nazerke Seidan (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17349076#comment-17349076 ] Nazerke Seidan edited comment on SOLR-15421 at 5/21/21, 8:29 AM: --

[jira] [Commented] (SOLR-15421) ConfigSetService.checkConfigExists accepts empty configs

2021-05-21 Thread Nazerke Seidan (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17349076#comment-17349076 ] Nazerke Seidan commented on SOLR-15421: --- if solrconfig.xml is not configurable, we

[jira] [Commented] (SOLR-15412) Strict validation on Replica metadata can cause complete outage

2021-05-21 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17349057#comment-17349057 ] Jan Høydahl commented on SOLR-15412: {quote}Or if bad data gets into a running cluste

[GitHub] [solr] muse-dev[bot] commented on a change in pull request #139: SOLR-15423 JWTAuthPlugin support for custom truststore

2021-05-21 Thread GitBox
muse-dev[bot] commented on a change in pull request #139: URL: https://github.com/apache/solr/pull/139#discussion_r636708465 ## File path: solr/core/src/java/org/apache/solr/security/JWTAuthPlugin.java ## @@ -155,8 +168,33 @@ public void init(Map pluginConfig) { required

[GitHub] [solr] janhoy commented on pull request #139: SOLR-15423 JWTAuthPlugin support for custom truststore

2021-05-21 Thread GitBox
janhoy commented on pull request #139: URL: https://github.com/apache/solr/pull/139#issuecomment-845731816 Feedback welcome. I could not think of a good way to actually test that the certificates are used (do we have a mock HTTPS server somewhere?). -- This is an automated message from

[jira] [Commented] (SOLR-15423) JWTAuthPlugin support for custom truststore

2021-05-21 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17349047#comment-17349047 ] Jan Høydahl commented on SOLR-15423: See PR for proposed implementation. I chose to n

[jira] [Updated] (SOLR-15423) JWTAuthPlugin support for custom truststore

2021-05-21 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-15423: --- Attachment: jwt-refguide.png > JWTAuthPlugin support for custom truststore >

[GitHub] [solr] janhoy opened a new pull request #139: SOLR-15423 JWTAuthPlugin support for custom truststore

2021-05-21 Thread GitBox
janhoy opened a new pull request #139: URL: https://github.com/apache/solr/pull/139 https://issues.apache.org/jira/browse/SOLR-15423 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [solr] tomglk commented on pull request #123: SOLR-12697 Add pure DocValues support to FieldValueFeature

2021-05-21 Thread GitBox
tomglk commented on pull request #123: URL: https://github.com/apache/solr/pull/123#issuecomment-845719776 I am currently debugging some ltr stuff and stumbled upon this: ``` java final String string = indexableField.stringValue(); if (string.length() == 1) { // boolean value