[jira] [Commented] (SOLR-14758) NPE in QueryComponent.mergeIds when using timeAllowed and sorting

[ https://issues.apache.org/jira/browse/SOLR-14758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354747#comment-17354747 ] Hu Dong commented on SOLR-14758: I ran into the same problem with multi-shards + timeAllo

[jira] [Commented] (SOLR-14674) NPE when TimeAllowed exceeded with sorting

[ https://issues.apache.org/jira/browse/SOLR-14674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354745#comment-17354745 ] Hu Dong commented on SOLR-14674: possibly related to https://issues.apache.org/jira/brows

[GitHub] [solr] cpoerschke commented on a change in pull request #151: SOLR-15437: ReRanking/LTR does not work in combination with custom sort and SolrCloud

cpoerschke commented on a change in pull request #151: URL: https://github.com/apache/solr/pull/151#discussion_r642675160 ## File path: solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java ## @@ -999,20 +1013,34 @@ protected void mergeIds(ResponseBuilder rb

[GitHub] [solr] dsmiley commented on a change in pull request #135: SOLR-15421 ConfigSetService.checkConfigExists accepts empty configs

dsmiley commented on a change in pull request #135: URL: https://github.com/apache/solr/pull/135#discussion_r642624278 ## File path: solr/core/src/test/org/apache/solr/cloud/TestConfigSetsAPI.java ## @@ -1121,10 +1121,6 @@ public void testDeleteErrors() throws Exception {

[GitHub] [solr] NazerkeBS commented on a change in pull request #17: SOLR-14341: Move configName into DocCollection class

NazerkeBS commented on a change in pull request #17: URL: https://github.com/apache/solr/pull/17#discussion_r642606592 ## File path: solr/core/src/java/org/apache/solr/cloud/overseer/ClusterStateMutator.java ## @@ -109,11 +110,27 @@ public ZkWriteCommand createCollection(Clust

[GitHub] [solr] NazerkeBS commented on pull request #17: SOLR-14341: Move configName into DocCollection class

NazerkeBS commented on pull request #17: URL: https://github.com/apache/solr/pull/17#issuecomment-851602029 I run tests locally and they passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [solr] tomglk commented on a change in pull request #151: SOLR-15437: ReRanking/LTR does not work in combination with custom sort and SolrCloud

tomglk commented on a change in pull request #151: URL: https://github.com/apache/solr/pull/151#discussion_r642512046 ## File path: solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java ## @@ -999,20 +1013,34 @@ protected void mergeIds(ResponseBuilder rb, Sh

[GitHub] [solr] tomglk commented on a change in pull request #151: SOLR-15437: ReRanking/LTR does not work in combination with custom sort and SolrCloud

tomglk commented on a change in pull request #151: URL: https://github.com/apache/solr/pull/151#discussion_r642354048 ## File path: solr/contrib/ltr/src/test/org/apache/solr/ltr/TestLTROnSolrCloud.java ## @@ -70,6 +72,63 @@ public void tearDown() throws Exception { super.t

[GitHub] [solr] tkaessmann commented on a change in pull request #151: SOLR-15437: ReRanking/LTR does not work in combination with custom sort and SolrCloud

tkaessmann commented on a change in pull request #151: URL: https://github.com/apache/solr/pull/151#discussion_r642352812 ## File path: solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java ## @@ -999,20 +1013,34 @@ protected void mergeIds(ResponseBuilder rb

[GitHub] [solr] asalamon74 commented on a change in pull request #135: SOLR-15421 ConfigSetService.checkConfigExists accepts empty configs

asalamon74 commented on a change in pull request #135: URL: https://github.com/apache/solr/pull/135#discussion_r642301113 ## File path: solr/core/src/java/org/apache/solr/cloud/ZkConfigSetService.java ## @@ -151,6 +151,19 @@ public boolean checkConfigExists(String configName) t

[GitHub] [solr] asalamon74 commented on a change in pull request #135: SOLR-15421 ConfigSetService.checkConfigExists accepts empty configs

asalamon74 commented on a change in pull request #135: URL: https://github.com/apache/solr/pull/135#discussion_r642300758 ## File path: solr/core/src/java/org/apache/solr/core/FileSystemConfigSetService.java ## @@ -62,7 +62,12 @@ public String configSetName(CoreDescriptor cd)