[GitHub] [solr] NazerkeBS opened a new pull request #198: SOLR-15124 Remove node/container level admin handlers from ImplicitPl…

2021-06-29 Thread GitBox
NazerkeBS opened a new pull request #198: URL: https://github.com/apache/solr/pull/198 …ugins.json https://issues.apache.org/jira/browse/SOLR-X # Description Please provide a short description of the changes you're making with this pull request. #

[jira] [Resolved] (SOLR-15489) Solr SQL should respect OFFSET and FETCH criteria when used with ORDER BY

2021-06-29 Thread Timothy Potter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Potter resolved SOLR-15489. --- Fix Version/s: main (9.0) Resolution: Fixed > Solr SQL should respect OFFSET and FETCH

[jira] [Commented] (SOLR-15489) Solr SQL should respect OFFSET and FETCH criteria when used with ORDER BY

2021-06-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17371733#comment-17371733 ] ASF subversion and git services commented on SOLR-15489: Commit 0

[GitHub] [solr] thelabdude merged pull request #191: SOLR-15489: Implement OFFSET & FETCH for LIMIT queries

2021-06-29 Thread GitBox
thelabdude merged pull request #191: URL: https://github.com/apache/solr/pull/191 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [solr] thelabdude commented on pull request #191: SOLR-15489: Implement OFFSET & FETCH for LIMIT queries

2021-06-29 Thread GitBox
thelabdude commented on pull request #191: URL: https://github.com/apache/solr/pull/191#issuecomment-870961665 > I think it is possible to use CursorMark in some form for this. > > Given that pagination is semi accurate (and generally not very valuable :)), I think that leaves some a

[jira] [Resolved] (SOLR-15461) Upgrade Apache Calcite to latest release 1.27

2021-06-29 Thread Timothy Potter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Potter resolved SOLR-15461. --- Fix Version/s: main (9.0) Resolution: Fixed > Upgrade Apache Calcite to latest release

[jira] [Commented] (SOLR-15510) Add additional off heap data structure options and ByteBuffer caching for reduced GC at scale.

2021-06-29 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17371616#comment-17371616 ] Mark Robert Miller commented on SOLR-15510: --- Almost all large scale data struct

[jira] [Commented] (SOLR-15072) Support building and testing Solr on ARM64 architecture

2021-06-29 Thread Ganesh Raju (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17371605#comment-17371605 ] Ganesh Raju commented on SOLR-15072: If you need ARM hardware, we could provide that

[jira] [Commented] (SOLR-15510) Add additional off heap data structure options and ByteBuffer caching for reduced GC at scale.

2021-06-29 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17371530#comment-17371530 ] Mark Robert Miller commented on SOLR-15510: --- The idea here is to allow configur

[GitHub] [solr] markrmiller commented on pull request #194: SOLR-15475: Implement COUNT and APPROX_COUNT_DISTINCT aggregation functions for Parallel SQL

2021-06-29 Thread GitBox
markrmiller commented on pull request #194: URL: https://github.com/apache/solr/pull/194#issuecomment-870732569 Looks okay to me other than the todo to uncomment. In a other issue I have some work / ideas around taking advantage of the approx count in a caching somewhat lazy way to so we c

[jira] [Commented] (SOLR-15467) Enhance Parallel SQL documentation (new operators, limitations, and so on ...)

2021-06-29 Thread David Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17371464#comment-17371464 ] David Eric Pugh commented on SOLR-15467: +1 to [~aroopganguly] and [~ctargett] ! 

[jira] [Updated] (SOLR-15511) Add FastThreadLocal type design enhancement and some buffer / object reuse for reduced gc at scale.

2021-06-29 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Robert Miller updated SOLR-15511: -- Description: A FastThreadLocal object is an idea I've been circling with a common SolrT

[jira] [Updated] (SOLR-15511) Add FastThreadLocal type design enhancement and some buffer / object reuse for reduced gc at scale.

2021-06-29 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Robert Miller updated SOLR-15511: -- Description: A FastThreadLocal object is an idea I've been circling with a common SolrT

[GitHub] [solr] madrob commented on a change in pull request #177: SOLR-15461: Upgrade Apache Calcite to latest release.

2021-06-29 Thread GitBox
madrob commented on a change in pull request #177: URL: https://github.com/apache/solr/pull/177#discussion_r653712556 ## File path: solr/core/src/test-files/log4j2.xml ## @@ -34,6 +34,7 @@ + Review comment: This is only temporary, I hope? How verbo

[jira] [Commented] (SOLR-15477) Logging Performance

2021-06-29 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17371453#comment-17371453 ] Mark Robert Miller commented on SOLR-15477: --- The best performance from the log4

[jira] [Updated] (SOLR-15477) Logging Performance

2021-06-29 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Robert Miller updated SOLR-15477: -- Parent: SOLR-15509 Issue Type: Sub-task (was: Improvement) > Logging Performan

[jira] [Commented] (SOLR-15512) Add support for passing IndexSearcher an executor for multi-threaded multi-segment and possible future multi-threaded per segment search.

2021-06-29 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17371443#comment-17371443 ] Ishan Chattopadhyaya commented on SOLR-15512: - Also  see SOLR-13350 > Add su

[jira] [Created] (SOLR-15514) Add / Compare optional experimental MMapDirectory implementation via custom ByteBuffer lib (eg Agrona, Chronicle Bytes, ...)

2021-06-29 Thread Mark Robert Miller (Jira)
Mark Robert Miller created SOLR-15514: - Summary: Add / Compare optional experimental MMapDirectory implementation via custom ByteBuffer lib (eg Agrona, Chronicle Bytes, ...) Key: SOLR-15514 URL: https://issues

[jira] [Created] (SOLR-15513) Review, enhance(?), sql-connect multi-threaded SimpleFaceting impl/config

2021-06-29 Thread Mark Robert Miller (Jira)
Mark Robert Miller created SOLR-15513: - Summary: Review, enhance(?), sql-connect multi-threaded SimpleFaceting impl/config Key: SOLR-15513 URL: https://issues.apache.org/jira/browse/SOLR-15513 Pro

[jira] [Created] (SOLR-15512) Add support for passing IndexSearcher an executor for multi-threaded multi-segment and possible future multi-threaded per segment search.

2021-06-29 Thread Mark Robert Miller (Jira)
Mark Robert Miller created SOLR-15512: - Summary: Add support for passing IndexSearcher an executor for multi-threaded multi-segment and possible future multi-threaded per segment search. Key: SOLR-15512 URL:

[jira] [Created] (SOLR-15511) Add FastThreadLocal type design enhancement and some buffer / object reuse for reduced gc at scale.

2021-06-29 Thread Mark Robert Miller (Jira)
Mark Robert Miller created SOLR-15511: - Summary: Add FastThreadLocal type design enhancement and some buffer / object reuse for reduced gc at scale. Key: SOLR-15511 URL: https://issues.apache.org/jira/browse/S

[jira] [Created] (SOLR-15510) Add additional off heap data structure options and ByteBuffer caching for reduced GC at scale.

2021-06-29 Thread Mark Robert Miller (Jira)
Mark Robert Miller created SOLR-15510: - Summary: Add additional off heap data structure options and ByteBuffer caching for reduced GC at scale. Key: SOLR-15510 URL: https://issues.apache.org/jira/browse/SOLR-1

[jira] [Created] (SOLR-15509) Issues to potentially improve JSON faceting and Stats performance.

2021-06-29 Thread Mark Robert Miller (Jira)
Mark Robert Miller created SOLR-15509: - Summary: Issues to potentially improve JSON faceting and Stats performance. Key: SOLR-15509 URL: https://issues.apache.org/jira/browse/SOLR-15509 Project: S

[jira] [Commented] (SOLR-15461) Upgrade Apache Calcite to latest release 1.27

2021-06-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17371427#comment-17371427 ] ASF subversion and git services commented on SOLR-15461: Commit e

[GitHub] [solr] markrmiller merged pull request #177: SOLR-15461: Upgrade Apache Calcite to latest release.

2021-06-29 Thread GitBox
markrmiller merged pull request #177: URL: https://github.com/apache/solr/pull/177 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

[GitHub] [solr] epugh commented on pull request #196: SOLR-15385 RawTypes Part V

2021-06-29 Thread GitBox
epugh commented on pull request #196: URL: https://github.com/apache/solr/pull/196#issuecomment-870618414 This is a really impressive amount of work! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [solr] thelabdude commented on a change in pull request #191: SOLR-15489: Implement OFFSET & FETCH for LIMIT queries

2021-06-29 Thread GitBox
thelabdude commented on a change in pull request #191: URL: https://github.com/apache/solr/pull/191#discussion_r660562145 ## File path: solr/core/src/test/org/apache/solr/handler/TestSQLHandler.java ## @@ -1853,21 +1853,18 @@ public void testParallelTimeSeriesGrouping() throws

[GitHub] [solr] gerlowskija edited a comment on pull request #190: SOLR-14444: Ref Guide re-organization

2021-06-29 Thread GitBox
gerlowskija edited a comment on pull request #190: URL: https://github.com/apache/solr/pull/190#issuecomment-870154214 This LGTM and is a huge step forward for the ref-guide! The biggest nitpick I probably have here is that the breaking up of the old "Admin UI" section (a change I'm

[GitHub] [solr] gerlowskija commented on pull request #190: SOLR-14444: Ref Guide re-organization

2021-06-29 Thread GitBox
gerlowskija commented on pull request #190: URL: https://github.com/apache/solr/pull/190#issuecomment-870154214 This LGTM and is a huge step forward for the ref-guide! The biggest nitpick I probably have here is that the breaking up of the old "Admin UI" section (a change I'm hugely

[GitHub] [solr] madrob commented on a change in pull request #191: SOLR-15489: Implement OFFSET & FETCH for LIMIT queries

2021-06-29 Thread GitBox
madrob commented on a change in pull request #191: URL: https://github.com/apache/solr/pull/191#discussion_r660288462 ## File path: solr/core/src/test/org/apache/solr/handler/TestSQLHandler.java ## @@ -1853,21 +1853,18 @@ public void testParallelTimeSeriesGrouping() throws Exc

[GitHub] [solr] madrob commented on pull request #196: SOLR-15385 RawTypes Part V

2021-06-29 Thread GitBox
madrob commented on pull request #196: URL: https://github.com/apache/solr/pull/196#issuecomment-870027164 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

[GitHub] [solr] gerlowskija commented on pull request #120: SOLR-15089: Allow backup/restoration to Amazon's S3 blobstore

2021-06-29 Thread GitBox
gerlowskija commented on pull request #120: URL: https://github.com/apache/solr/pull/120#issuecomment-869787293 Hey @athrog - anything holding this up, or did you just miss the notification on the latest round of comments? (If it's a time thing, lmk and I can try to help out a bit myself.

[GitHub] [solr] madrob merged pull request #195: SOLR-15385 RawTypes Part IV, solr-core

2021-06-29 Thread GitBox
madrob merged pull request #195: URL: https://github.com/apache/solr/pull/195 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@s

[GitHub] [solr] madrob commented on pull request #195: SOLR-15385 RawTypes Part IV, solr-core

2021-06-29 Thread GitBox
madrob commented on pull request #195: URL: https://github.com/apache/solr/pull/195#issuecomment-869894976 @cpoerschke so this is the "easy" changes left in here, right? Do you want me to open a new PR for the remaining 254+5 files or did you mean to add them back here once you were done w

[GitHub] [solr] cpoerschke commented on pull request #196: SOLR-15385 RawTypes Part V

2021-06-29 Thread GitBox
cpoerschke commented on pull request #196: URL: https://github.com/apache/solr/pull/196#issuecomment-870020965 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[GitHub] [solr] madrob commented on a change in pull request #196: SOLR-15385 RawTypes Part V

2021-06-29 Thread GitBox
madrob commented on a change in pull request #196: URL: https://github.com/apache/solr/pull/196#discussion_r660134018 ## File path: solr/core/src/test/org/apache/solr/util/SolrPluginUtilsTest.java ## @@ -248,7 +248,7 @@ public void testDisjunctionMaxQueryParser() throws Except

[GitHub] [solr] cpoerschke commented on pull request #195: SOLR-15385 RawTypes Part IV, solr-core

2021-06-29 Thread GitBox
cpoerschke commented on pull request #195: URL: https://github.com/apache/solr/pull/195#issuecomment-869944074 Merging of this first batch and then a new PR for rest would be my preference. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [solr] psalagnac commented on pull request #120: SOLR-15089: Allow backup/restoration to Amazon's S3 blobstore

2021-06-29 Thread GitBox
psalagnac commented on pull request #120: URL: https://github.com/apache/solr/pull/120#issuecomment-869802855 Hey @gerlowskija, Sorry for the late answer here. Thanks for you feedback. I think we reached an agreement to keep`BlobIndexInput` and remove the abstraction of the generi

[GitHub] [solr] madrob commented on a change in pull request #195: SOLR-15385 RawTypes Part IV, solr-core

2021-06-29 Thread GitBox
madrob commented on a change in pull request #195: URL: https://github.com/apache/solr/pull/195#discussion_r660007488 ## File path: solr/core/src/java/org/apache/solr/handler/component/ExpandComponent.java ## @@ -442,23 +442,23 @@ public void modifyRequest(ResponseBuilder rb,

[GitHub] [solr] cpoerschke edited a comment on pull request #196: SOLR-15385 RawTypes Part V

2021-06-29 Thread GitBox
cpoerschke edited a comment on pull request #196: URL: https://github.com/apache/solr/pull/196#issuecomment-870063569 > How are you arriving at the resulting changes after removing some of the files? For example, in the original PR, the changes to DeleteBackupCmd seem pretty uninteresting

[GitHub] [solr] cpoerschke commented on a change in pull request #196: SOLR-15385 RawTypes Part V

2021-06-29 Thread GitBox
cpoerschke commented on a change in pull request #196: URL: https://github.com/apache/solr/pull/196#discussion_r660122371 ## File path: solr/core/src/test/org/apache/solr/TestRandomDVFaceting.java ## @@ -125,7 +125,7 @@ void deleteSomeDocs() { int percent = rand.nextInt(10

[GitHub] [solr] markrmiller commented on pull request #177: SOLR-15461: Upgrade Apache Calcite to latest release.

2021-06-29 Thread GitBox
markrmiller commented on pull request #177: URL: https://github.com/apache/solr/pull/177#issuecomment-869880889 I took a look at a flag to pull the change regarding the filter, expression, reduction rule that I removed, but initially I ended up leaving it for a couple of reasons: *

[jira] [Updated] (SOLR-15499) StatsStream should leverage the tiered support added to FacetStream

2021-06-29 Thread Timothy Potter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Potter updated SOLR-15499: -- Labels: Performance RobustSQL (was: RobustSQL) > StatsStream should leverage the tiered suppor

[GitHub] [solr] thelabdude commented on a change in pull request #191: SOLR-15489: Implement OFFSET & FETCH for LIMIT queries

2021-06-29 Thread GitBox
thelabdude commented on a change in pull request #191: URL: https://github.com/apache/solr/pull/191#discussion_r660562145 ## File path: solr/core/src/test/org/apache/solr/handler/TestSQLHandler.java ## @@ -1853,21 +1853,18 @@ public void testParallelTimeSeriesGrouping() throws

[jira] [Created] (SOLR-15508) Upgrade netty artifacts to >= netty-4.1.61.Final

2021-06-29 Thread Somesh Dhal (Jira)
Somesh Dhal created SOLR-15508: -- Summary: Upgrade netty artifacts to >= netty-4.1.61.Final Key: SOLR-15508 URL: https://issues.apache.org/jira/browse/SOLR-15508 Project: Solr Issue Type: Improv

[jira] [Created] (SOLR-15507) Upgrade Apache Thrift to 0.14.1

2021-06-29 Thread Somesh Dhal (Jira)
Somesh Dhal created SOLR-15507: -- Summary: Upgrade Apache Thrift to 0.14.1 Key: SOLR-15507 URL: https://issues.apache.org/jira/browse/SOLR-15507 Project: Solr Issue Type: Improvement Securi

[jira] [Created] (SOLR-15506) Upgrade Apache Derby to >=10.14.2.0

2021-06-29 Thread Somesh Dhal (Jira)
Somesh Dhal created SOLR-15506: -- Summary: Upgrade Apache Derby to >=10.14.2.0 Key: SOLR-15506 URL: https://issues.apache.org/jira/browse/SOLR-15506 Project: Solr Issue Type: Improvement Se

[jira] [Created] (SOLR-15505) Upgrade ICU4J to 67.1+

2021-06-29 Thread Somesh Dhal (Jira)
Somesh Dhal created SOLR-15505: -- Summary: Upgrade ICU4J to 67.1+ Key: SOLR-15505 URL: https://issues.apache.org/jira/browse/SOLR-15505 Project: Solr Issue Type: Improvement Security Level: