[GitHub] [solr] thelabdude opened a new pull request #219: SOLR-15525: Allow Zookeeper ACL credentials to be passed via env vars instead of Java system properties

2021-07-13 Thread GitBox
thelabdude opened a new pull request #219: URL: https://github.com/apache/solr/pull/219 https://issues.apache.org/jira/browse/SOLR-15525 # Description Get zk acl username and/or password from either a Java sys prop (current behavior) or from an environment variable. The code n

[GitHub] [solr] madrob commented on pull request #13: SOLR-14690: QueryResultKey.[nc_]minExactCount

2021-07-13 Thread GitBox
madrob commented on pull request #13: URL: https://github.com/apache/solr/pull/13#issuecomment-879454399 I tried to isolate this and it looks like something is happening in `testHighMinExactCountWithQueryResultCache` that is interfering with the other tests, like maybe it is inserting too

[GitHub] [solr] epugh commented on a change in pull request #218: SOLR-15536: Rewrite /c//shards v2 APIs using annotations

2021-07-13 Thread GitBox
epugh commented on a change in pull request #218: URL: https://github.com/apache/solr/pull/218#discussion_r669116901 ## File path: solr/solrj/src/java/org/apache/solr/common/params/CommonAdminParams.java ## @@ -27,6 +27,8 @@ String IN_PLACE_MOVE = "inPlaceMove"; /** Meth

[GitHub] [solr] epugh commented on a change in pull request #218: SOLR-15536: Rewrite /c//shards v2 APIs using annotations

2021-07-13 Thread GitBox
epugh commented on a change in pull request #218: URL: https://github.com/apache/solr/pull/218#discussion_r669116222 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/request/beans/AddReplicaPayload.java ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software

[GitHub] [solr] epugh commented on a change in pull request #218: SOLR-15536: Rewrite /c//shards v2 APIs using annotations

2021-07-13 Thread GitBox
epugh commented on a change in pull request #218: URL: https://github.com/apache/solr/pull/218#discussion_r669115816 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/request/beans/AddReplicaPayload.java ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (SOLR-14444) Ref Guide Redesign Phase 2: Page Organization Overhaul

2021-07-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17380156#comment-17380156 ] ASF subversion and git services commented on SOLR-1: Commit 5

[GitHub] [solr] ctargett merged pull request #217: SOLR-14444: add required/default tables to all params, part III (final)

2021-07-13 Thread GitBox
ctargett merged pull request #217: URL: https://github.com/apache/solr/pull/217 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[GitHub] [solr] cpoerschke commented on pull request #13: SOLR-14690: QueryResultKey.[nc_]minExactCount

2021-07-13 Thread GitBox
cpoerschke commented on pull request #13: URL: https://github.com/apache/solr/pull/13#issuecomment-879375401 Via `./gradlew :solr:core:test --tests "org.apache.solr.search.SolrIndexSearcherTest" -Ptests.jvms=4 -Ptests.jvmargs=-XX:TieredStopAtLevel=1 -Ptests.seed=B773ACC2C581EBBA -Ptests.f

[GitHub] [solr] epugh commented on a change in pull request #218: SOLR-15536: Rewrite /c//shards v2 APIs using annotations

2021-07-13 Thread GitBox
epugh commented on a change in pull request #218: URL: https://github.com/apache/solr/pull/218#discussion_r669079557 ## File path: solr/core/src/java/org/apache/solr/handler/admin/api/SplitShardAPI.java ## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] [solr] gerlowskija commented on pull request #218: SOLR-15536: Rewrite /c//shards v2 APIs using annotations

2021-07-13 Thread GitBox
gerlowskija commented on pull request #218: URL: https://github.com/apache/solr/pull/218#issuecomment-879360543 FYI @epugh since you've been kind enough to review similar patches in the past. -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [solr] gerlowskija opened a new pull request #218: SOLR-15536: Rewrite /c//shards v2 APIs using annotations

2021-07-13 Thread GitBox
gerlowskija opened a new pull request #218: URL: https://github.com/apache/solr/pull/218 # Description The community is in the process of migrating v2 API implementations over to an annotation-based framework that results in less duplication and easier to understand code. But the /

[jira] [Created] (SOLR-15536) Rewrite '/c//shards' v2 APIs to use annotation framework.

2021-07-13 Thread Jason Gerlowski (Jira)
Jason Gerlowski created SOLR-15536: -- Summary: Rewrite '/c//shards' v2 APIs to use annotation framework. Key: SOLR-15536 URL: https://issues.apache.org/jira/browse/SOLR-15536 Project: Solr I

[GitHub] [solr] ctargett opened a new pull request #217: SOLR-14444: add required/default tables to all params, part III (final)

2021-07-13 Thread GitBox
ctargett opened a new pull request #217: URL: https://github.com/apache/solr/pull/217 https://issues.apache.org/jira/browse/SOLR-1 Finish of work started with PRs #208 & #211. Same caveats apply as mentioned in those PRs. -- This is an automated message from the Apache Git Ser

[jira] [Commented] (SOLR-14894) Use annotations to implement V2 collection APIs

2021-07-13 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17380132#comment-17380132 ] Jason Gerlowski commented on SOLR-14894: [~noble.paul] what APIs were you trying

[jira] [Commented] (SOLR-14690) increased minExactCount related cache use

2021-07-13 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17380131#comment-17380131 ] Christine Poerschke commented on SOLR-14690: >From memory, the pull request c

[jira] [Updated] (SOLR-14894) Use annotations to implement V2 collection APIs

2021-07-13 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated SOLR-14894: --- Parent: SOLR-15182 Issue Type: Sub-task (was: Task) > Use annotations to implement V

[jira] [Updated] (SOLR-14871) Use Annotations for v2 APIs in/cluster path

2021-07-13 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated SOLR-14871: --- Parent: SOLR-15182 Issue Type: Sub-task (was: Task) > Use Annotations for v2 APIs in

[jira] [Commented] (SOLR-14871) Use Annotations for v2 APIs in/cluster path

2021-07-13 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17380128#comment-17380128 ] Jason Gerlowski commented on SOLR-14871: [~noble.paul] anything preventing this t

[jira] [Resolved] (SOLR-15490) Add v1-v2 API Mapping tests for /cluster/* APIs

2021-07-13 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski resolved SOLR-15490. Fix Version/s: main (9.0) Resolution: Fixed > Add v1-v2 API Mapping tests for /clust

[jira] [Commented] (SOLR-14690) increased minExactCount related cache use

2021-07-13 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17380126#comment-17380126 ] Mike Drob commented on SOLR-14690: -- This seems like a useful improvement, what are the c

[GitHub] [solr] cpoerschke opened a new pull request #216: SOLR-15535: remove rawtypes warnings in 'grouping' code

2021-07-13 Thread GitBox
cpoerschke opened a new pull request #216: URL: https://github.com/apache/solr/pull/216 https://issues.apache.org/jira/browse/SOLR-15535 (Keeping as draft until completion of full test run.) -- This is an automated message from the Apache Git Service. To respond to the message, ple

[jira] [Created] (SOLR-15535) Address rawtypes warnings (raw Comparable use)

2021-07-13 Thread Christine Poerschke (Jira)
Christine Poerschke created SOLR-15535: -- Summary: Address rawtypes warnings (raw Comparable use) Key: SOLR-15535 URL: https://issues.apache.org/jira/browse/SOLR-15535 Project: Solr Issue

[jira] [Commented] (SOLR-15523) Add a VirtualExecutor.

2021-07-13 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17380066#comment-17380066 ] Mark Robert Miller commented on SOLR-15523: --- A  virtual executor allows creatin

[GitHub] [solr] sonatype-lift[bot] commented on a change in pull request #214: SOLR-15428: Integrate the OpenJDK JMH micro benchmark framework for m…

2021-07-13 Thread GitBox
sonatype-lift[bot] commented on a change in pull request #214: URL: https://github.com/apache/solr/pull/214#discussion_r668955124 ## File path: solr/test-framework/src/java/org/apache/solr/util/RandomizeSSL.java ## @@ -104,10 +105,10 @@ public SSLRandomizer(double ssl, double c

[jira] [Created] (SOLR-15534) Consistently use /usr/bin/env in script shebangs

2021-07-13 Thread Houston Putman (Jira)
Houston Putman created SOLR-15534: - Summary: Consistently use /usr/bin/env in script shebangs Key: SOLR-15534 URL: https://issues.apache.org/jira/browse/SOLR-15534 Project: Solr Issue Type: I

[jira] [Updated] (SOLR-15335) templated (header + body) approach for building Dockerfile.local + Dockerfile.official w/common guts

2021-07-13 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman updated SOLR-15335: -- Attachment: SOLR-15335-body-template-cache.patch > templated (header + body) approach for build

[jira] [Commented] (SOLR-15335) templated (header + body) approach for building Dockerfile.local + Dockerfile.official w/common guts

2021-07-13 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17380030#comment-17380030 ] Houston Putman commented on SOLR-15335: --- [~hossman], while adding the license heade

[jira] [Resolved] (SOLR-15385) Address rawtypes warnings

2021-07-13 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob resolved SOLR-15385. -- Fix Version/s: main (9.0) Resolution: Fixed I've done as much as I feel like I reasonably can on

[jira] [Updated] (SOLR-15335) templated (header + body) approach for building Dockerfile.local + Dockerfile.official w/common guts

2021-07-13 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman updated SOLR-15335: -- Component/s: Docker > templated (header + body) approach for building Dockerfile.local + > Doc

[GitHub] [solr] HoustonPutman opened a new pull request #215: SOLR-15533: Add license headers to docker module

2021-07-13 Thread GitBox
HoustonPutman opened a new pull request #215: URL: https://github.com/apache/solr/pull/215 SOLR-15524: Remove unnecessary container_cleanup calls. https://issues.apache.org/jira/browse/SOLR-15533 https://issues.apache.org/jira/browse/SOLR-15524 -- This is an automated message fr

[jira] [Commented] (SOLR-15385) Address rawtypes warnings

2021-07-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17379993#comment-17379993 ] ASF subversion and git services commented on SOLR-15385: Commit 0

[GitHub] [solr] madrob merged pull request #207: SOLR-15385 RawTypes Part VI

2021-07-13 Thread GitBox
madrob merged pull request #207: URL: https://github.com/apache/solr/pull/207 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@s

[GitHub] [solr] markrmiller opened a new pull request #214: SOLR-15428: Integrate the OpenJDK JMH micro benchmark framework for m…

2021-07-13 Thread GitBox
markrmiller opened a new pull request #214: URL: https://github.com/apache/solr/pull/214 Draft stripped down PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[jira] [Created] (SOLR-15533) Add necessary headers to files in the docker module

2021-07-13 Thread Houston Putman (Jira)
Houston Putman created SOLR-15533: - Summary: Add necessary headers to files in the docker module Key: SOLR-15533 URL: https://issues.apache.org/jira/browse/SOLR-15533 Project: Solr Issue Type

[jira] [Issue Comment Deleted] (SOLR-14758) NPE in QueryComponent.mergeIds when using timeAllowed and sorting

2021-07-13 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gus Heck updated SOLR-14758: Comment: was deleted (was: Jag är ledig och återkommer 2 augusti 2021. I'm on vacation and will be back 2

[jira] [Comment Edited] (SOLR-14758) NPE in QueryComponent.mergeIds when using timeAllowed and sorting

2021-07-13 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17379906#comment-17379906 ] Gus Heck edited comment on SOLR-14758 at 7/13/21, 2:14 PM: --- Am

[jira] [Comment Edited] (SOLR-14758) NPE in QueryComponent.mergeIds when using timeAllowed and sorting

2021-07-13 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17379906#comment-17379906 ] Gus Heck edited comment on SOLR-14758 at 7/13/21, 2:09 PM: --- Am

[jira] [Commented] (SOLR-14758) NPE in QueryComponent.mergeIds when using timeAllowed and sorting

2021-07-13 Thread Magnus Welander (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17379907#comment-17379907 ] Magnus Welander commented on SOLR-14758: Jag är ledig och återkommer 2 augusti 20

[jira] [Commented] (SOLR-14758) NPE in QueryComponent.mergeIds when using timeAllowed and sorting

2021-07-13 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17379906#comment-17379906 ] Gus Heck commented on SOLR-14758: - Am seeing this NPE as well, showed up in a gatling run

[jira] [Resolved] (SOLR-15485) remove Collections.singleton.forEach use

2021-07-13 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christine Poerschke resolved SOLR-15485. Resolution: Fixed > remove Collections.singleton.forEach use >

[jira] [Updated] (SOLR-15485) remove Collections.singleton.forEach use

2021-07-13 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christine Poerschke updated SOLR-15485: --- Summary: remove Collections.singleton.forEach use (was: discourage Collections.singl

[jira] [Commented] (SOLR-15485) discourage Collections.singleton.forEach use

2021-07-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17379829#comment-17379829 ] ASF subversion and git services commented on SOLR-15485: Commit 3

[jira] [Commented] (SOLR-15526) LeaderTragicEventTest has been failing on 8x

2021-07-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17379830#comment-17379830 ] ASF subversion and git services commented on SOLR-15526: Commit 6

[GitHub] [solr] cpoerschke commented on a change in pull request #207: SOLR-15385 RawTypes Part VI

2021-07-13 Thread GitBox
cpoerschke commented on a change in pull request #207: URL: https://github.com/apache/solr/pull/207#discussion_r668646663 ## File path: solr/core/src/java/org/apache/solr/search/grouping/distributed/shardresultserializer/TopGroupsResultTransformer.java ## @@ -151,6 +150,11 @@

[jira] [Commented] (SOLR-15485) discourage Collections.singleton.forEach use

2021-07-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17379807#comment-17379807 ] ASF subversion and git services commented on SOLR-15485: Commit 1

[GitHub] [solr] cpoerschke merged pull request #213: SOLR-15485: action post-commit review feedback

2021-07-13 Thread GitBox
cpoerschke merged pull request #213: URL: https://github.com/apache/solr/pull/213 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [solr] benediktarnold commented on a change in pull request #212: SOLR-15531: significantTerms streaming function should not fail on empty collections

2021-07-13 Thread GitBox
benediktarnold commented on a change in pull request #212: URL: https://github.com/apache/solr/pull/212#discussion_r668501486 ## File path: solr/core/src/java/org/apache/solr/search/SignificantTermsQParserPlugin.java ## @@ -28,9 +28,7 @@ import org.apache.lucene.index.Posting

[GitHub] [solr] benediktarnold commented on a change in pull request #212: SOLR-15531: significantTerms streaming function should not fail on empty collections

2021-07-13 Thread GitBox
benediktarnold commented on a change in pull request #212: URL: https://github.com/apache/solr/pull/212#discussion_r668499091 ## File path: solr/core/src/test/org/apache/solr/search/SignificantTermsQParserPluginTest.java ## @@ -17,19 +17,130 @@ package org.apache.solr.searc

[GitHub] [solr] benediktarnold commented on a change in pull request #212: SOLR-15531: significantTerms streaming function should not fail on empty collections

2021-07-13 Thread GitBox
benediktarnold commented on a change in pull request #212: URL: https://github.com/apache/solr/pull/212#discussion_r668497734 ## File path: solr/core/src/java/org/apache/solr/search/SignificantTermsQParserPlugin.java ## @@ -89,10 +87,43 @@ public SignificantTermsQuery(String f