[GitHub] [solr] HoustonPutman opened a new pull request #223: SOLR-15545: Properly source run-initdb in docker commands

2021-07-15 Thread GitBox
HoustonPutman opened a new pull request #223: URL: https://github.com/apache/solr/pull/223 https://issues.apache.org/jira/browse/SOLR-15545 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[jira] [Created] (SOLR-15545) Properly source run-initdb in docker commands

2021-07-15 Thread Houston Putman (Jira)
Houston Putman created SOLR-15545: - Summary: Properly source run-initdb in docker commands Key: SOLR-15545 URL: https://issues.apache.org/jira/browse/SOLR-15545 Project: Solr Issue Type: Bug

[GitHub] [solr] madrob commented on pull request #222: SOLR-15525: Read ZK credentials from a file specified using a system property instead of exposing plain-text credentials

2021-07-15 Thread GitBox
madrob commented on pull request #222: URL: https://github.com/apache/solr/pull/222#issuecomment-881035513 Yea but I didn’t test it 😅 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [solr] thelabdude commented on a change in pull request #222: SOLR-15525: Read ZK credentials from a file specified using a system property instead of exposing plain-text credentials

2021-07-15 Thread GitBox
thelabdude commented on a change in pull request #222: URL: https://github.com/apache/solr/pull/222#discussion_r670825201 ## File path: solr/core/src/test/org/apache/solr/cloud/VMParamsZkACLAndCredentialsProvidersTest.java ## @@ -250,6 +276,33 @@ private void useReadonlyCreden

[jira] [Commented] (SOLR-15524) Fix Solr Docker test cleanup

2021-07-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17381603#comment-17381603 ] ASF subversion and git services commented on SOLR-15524: Commit 7

[jira] [Resolved] (SOLR-15533) Add necessary headers to files in the docker module

2021-07-15 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman resolved SOLR-15533. --- Fix Version/s: main (9.0) Resolution: Fixed > Add necessary headers to files in the do

[jira] [Commented] (SOLR-15533) Add necessary headers to files in the docker module

2021-07-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17381600#comment-17381600 ] ASF subversion and git services commented on SOLR-15533: Commit e

[GitHub] [solr] HoustonPutman merged pull request #215: SOLR-15533: Add license headers to docker module

2021-07-15 Thread GitBox
HoustonPutman merged pull request #215: URL: https://github.com/apache/solr/pull/215 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubs

[GitHub] [solr] madrob commented on pull request #192: SOLR-15537: split 10-args LTRRescorer.scoreSingleHit method

2021-07-15 Thread GitBox
madrob commented on pull request #192: URL: https://github.com/apache/solr/pull/192#issuecomment-881005673 It's still a little cumbersome, but probably better than what we had before in terms of readability. Add a javadoc comment for those methods explaining their relationship and then it'

[GitHub] [solr] madrob commented on a change in pull request #193: SOLR-15474: Support Pluggable Circuit Breakers

2021-07-15 Thread GitBox
madrob commented on a change in pull request #193: URL: https://github.com/apache/solr/pull/193#discussion_r670796347 ## File path: solr/solr-ref-guide/src/circuit-breakers.adoc ## @@ -27,23 +27,16 @@ If circuit breakers are enabled, requests may be rejected under the conditio

[GitHub] [solr] madrob commented on pull request #215: SOLR-15533: Add license headers to docker module

2021-07-15 Thread GitBox
madrob commented on pull request #215: URL: https://github.com/apache/solr/pull/215#issuecomment-880997644 LGTM, but I'd prefer it as two separate commits. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [solr] madrob commented on a change in pull request #216: SOLR-15535: remove rawtypes warnings in 'grouping' code

2021-07-15 Thread GitBox
madrob commented on a change in pull request #216: URL: https://github.com/apache/solr/pull/216#discussion_r669161015 ## File path: solr/core/src/java/org/apache/solr/search/grouping/distributed/command/SearchGroupsFieldCommand.java ## @@ -123,14 +123,15 @@ private SearchGroup

[jira] [Commented] (SOLR-15541) opt-in support to INFO log all parameters on error

2021-07-15 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17381576#comment-17381576 ] Mike Drob commented on SOLR-15541: -- I'm not a fan of the duplicated information between

[GitHub] [solr] madrob commented on pull request #221: getCurrentSchemaModificationVersion in ConfigSetService throws IOException

2021-07-15 Thread GitBox
madrob commented on pull request #221: URL: https://github.com/apache/solr/pull/221#issuecomment-880985173 I'm not sure I understand the motivation for this change, can you please open a JIRA issue describing what this aims to solve or improve? Thanks! -- This is an automated message fro

[GitHub] [solr] madrob commented on a change in pull request #222: SOLR-15525: Read ZK credentials from a file specified using a system property instead of exposing plain-text credentials

2021-07-15 Thread GitBox
madrob commented on a change in pull request #222: URL: https://github.com/apache/solr/pull/222#discussion_r670775643 ## File path: solr/core/src/test/org/apache/solr/cloud/VMParamsZkACLAndCredentialsProvidersTest.java ## @@ -250,6 +276,33 @@ private void useReadonlyCredential

[jira] [Resolved] (SOLR-15531) IllegalArgumentException while executing streaming expression with significantTerms on an empty collection

2021-07-15 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob resolved SOLR-15531. -- Fix Version/s: 8.10 main (9.0) Assignee: Mike Drob Resolution: Fixed

[jira] [Commented] (SOLR-15531) IllegalArgumentException while executing streaming expression with significantTerms on an empty collection

2021-07-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17381559#comment-17381559 ] ASF subversion and git services commented on SOLR-15531: Commit b

[jira] [Commented] (SOLR-15531) IllegalArgumentException while executing streaming expression with significantTerms on an empty collection

2021-07-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17381558#comment-17381558 ] ASF subversion and git services commented on SOLR-15531: Commit 5

[GitHub] [solr] madrob merged pull request #212: SOLR-15531: significantTerms streaming function should not fail on empty collections

2021-07-15 Thread GitBox
madrob merged pull request #212: URL: https://github.com/apache/solr/pull/212 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@s

[jira] [Updated] (SOLR-15544) ValueSourceParser init gets called twice

2021-07-15 Thread Simon Kuo (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simon Kuo updated SOLR-15544: - Description: Our structure is single solr node which is slave. There is master keeps doing imports and t

[jira] [Updated] (SOLR-15544) ValueSourceParser init gets called twice

2021-07-15 Thread Simon Kuo (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simon Kuo updated SOLR-15544: - Description: Our structure is single solr node which is slave. There is master keeps doing imports and t

[jira] [Updated] (SOLR-15544) ValueSourceParser init gets called twice

2021-07-15 Thread Simon Kuo (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simon Kuo updated SOLR-15544: - Description: Our structure is single solr node which is slave. There is master keeps doing imports and t

[jira] [Updated] (SOLR-15544) ValueSourceParser init gets called twice

2021-07-15 Thread Simon Kuo (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simon Kuo updated SOLR-15544: - Description: Our structure is single solr node which is slave. There is master keeps doing imports and t

[jira] [Updated] (SOLR-15544) ValueSourceParser init gets called twice

2021-07-15 Thread Simon Kuo (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simon Kuo updated SOLR-15544: - Description: Our structure is single solr node which is slave. There is master keeps doing imports and t

[jira] [Updated] (SOLR-15544) ValueSourceParser init gets called twice

2021-07-15 Thread Simon Kuo (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simon Kuo updated SOLR-15544: - Description: Our structure is single solr node which is slave. There is master keeps doing imports and t

[jira] [Created] (SOLR-15544) ValueSourceParser init gets called twice

2021-07-15 Thread Simon Kuo (Jira)
Simon Kuo created SOLR-15544: Summary: ValueSourceParser init gets called twice Key: SOLR-15544 URL: https://issues.apache.org/jira/browse/SOLR-15544 Project: Solr Issue Type: Bug Security

[jira] [Updated] (SOLR-15543) docker tests should fail more transparently if 'setfacl' is not available

2021-07-15 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter updated SOLR-15543: -- Attachment: SOLR-15543.patch Assignee: Chris M. Hostetter Status: Open (w

[GitHub] [solr-operator] HoustonPutman opened a new pull request #288: Remove deprecations for v0.4.0 release.

2021-07-15 Thread GitBox
HoustonPutman opened a new pull request #288: URL: https://github.com/apache/solr-operator/pull/288 Resolves #286 See linked issue for information on the removed deprecations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [solr] madrob commented on a change in pull request #212: SOLR-15531: significantTerms streaming function should not fail on empty collections

2021-07-15 Thread GitBox
madrob commented on a change in pull request #212: URL: https://github.com/apache/solr/pull/212#discussion_r670652916 ## File path: solr/core/src/test/org/apache/solr/search/SignificantTermsQParserPluginTest.java ## @@ -17,19 +17,130 @@ package org.apache.solr.search; +im

[GitHub] [solr-operator] HoustonPutman opened a new pull request #287: Upgrade default Solr version to 8.9

2021-07-15 Thread GitBox
HoustonPutman opened a new pull request #287: URL: https://github.com/apache/solr-operator/pull/287 Resolves #285 Upgrades the default Solr version to `8.9` from `7.7.0`. No existing `SolrCloud` or `SolrPrometheusExporter` resources will be effected by this change, only new re

[GitHub] [solr-operator] HoustonPutman opened a new issue #286: Remove deprecations for the v0.4.0 release

2021-07-15 Thread GitBox
HoustonPutman opened a new issue #286: URL: https://github.com/apache/solr-operator/issues/286 There is only one deprecation for this release: The **Solr Operator Helm chart** option: ```yaml useZkOperator: "true" ``` has been replaced by: ```yaml zookeep

[GitHub] [solr-operator] HoustonPutman opened a new issue #285: Upgrade the default version of Solr

2021-07-15 Thread GitBox
HoustonPutman opened a new issue #285: URL: https://github.com/apache/solr-operator/issues/285 Currently the Solr Operator will choose the Solr version (tag) `7.7.0` for Solr Clouds and Prometheus Exporters if none is provided. This is extremely out of date, and should not be recommended f

[jira] [Commented] (SOLR-15525) Provide zkCredentialsProvider and zkACLProvider that loads credentials from a file or env vars instead of sys props

2021-07-15 Thread Timothy Potter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17381412#comment-17381412 ] Timothy Potter commented on SOLR-15525: --- I ended up bailing on the ENV var approach

[GitHub] [solr] thelabdude opened a new pull request #222: SOLR-15525: Read ZK credentials from a file specified using a system property instead of exposing plain-text credentials

2021-07-15 Thread GitBox
thelabdude opened a new pull request #222: URL: https://github.com/apache/solr/pull/222 https://issues.apache.org/jira/browse/SOLR-15525 # Description Added new Java system property `zkDigestCredentialsFile` to allow loading of zk creds from a file instead of from system p

[GitHub] [solr] thelabdude closed pull request #219: SOLR-15525: Allow Zookeeper ACL credentials to be passed via env vars instead of Java system properties

2021-07-15 Thread GitBox
thelabdude closed pull request #219: URL: https://github.com/apache/solr/pull/219 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[jira] [Commented] (SOLR-15542) Combine 'node', 'createNodeSet' parameters for ADDREPLICA API

2021-07-15 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17381326#comment-17381326 ] Jason Gerlowski commented on SOLR-15542: That makes sense to me - it'd give the p

[GitHub] [solr] NazerkeBS opened a new pull request #221: getCurrentSchemaModificationVersion in ConfigSetService throws IOException

2021-07-15 Thread GitBox
NazerkeBS opened a new pull request #221: URL: https://github.com/apache/solr/pull/221 https://issues.apache.org/jira/browse/SOLR-X # Description Please provide a short description of the changes you're making with this pull request. # Solution