[GitHub] [solr] dsmiley merged pull request #263: Ref Guide: Docker, add headings

2021-08-21 Thread GitBox
dsmiley merged pull request #263: URL: https://github.com/apache/solr/pull/263 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[GitHub] [solr] dsmiley commented on a change in pull request #264: SOLR-10887: Append .xml to managed-schema file

2021-08-21 Thread GitBox
dsmiley commented on a change in pull request #264: URL: https://github.com/apache/solr/pull/264#discussion_r693444308 ## File path: solr/core/src/java/org/apache/solr/schema/ManagedIndexSchemaFactory.java ## @@ -91,6 +92,33 @@ public void init(NamedList args) { public Stri

[GitHub] [solr] dsmiley commented on a change in pull request #264: SOLR-10887: Append .xml to managed-schema file

2021-08-21 Thread GitBox
dsmiley commented on a change in pull request #264: URL: https://github.com/apache/solr/pull/264#discussion_r693439374 ## File path: solr/core/src/java/org/apache/solr/schema/ManagedIndexSchemaFactory.java ## @@ -195,7 +223,16 @@ private InputStream readSchemaLocally() {

[GitHub] [solr] epugh commented on pull request #264: SOLR-10887: Append .xml to managed-schema file

2021-08-21 Thread GitBox
epugh commented on pull request #264: URL: https://github.com/apache/solr/pull/264#issuecomment-903103237 Can I just say that all of this logic is very convoluted? We're constantly checking what type of loader we have, we constantly manually create the paths to lookup the schema resourc