[GitHub] [solr] markrmiller commented on a change in pull request #301: SOLR-15640: Flush / Shutdown Async Loggers and LogManager after a test.

2021-10-04 Thread GitBox
markrmiller commented on a change in pull request #301: URL: https://github.com/apache/solr/pull/301#discussion_r721881065 ## File path: solr/test-framework/src/java/org/apache/solr/SolrTestCase.java ## @@ -64,17 +64,6 @@ @ThreadLeakLingering(linger = 1) public class Solr

[GitHub] [solr] markrmiller commented on pull request #225: SOLR-15538 Update Lucene Preview Release dependency

2021-10-04 Thread GitBox
markrmiller commented on pull request #225: URL: https://github.com/apache/solr/pull/225#issuecomment-933954597 > we can leave it to be consistent. Yeah, I ended up leaving it. The code you dropped is deprecated, the code that points to takes a .class argument, but simply moving to it wa

[GitHub] [solr] markrmiller commented on pull request #316: SOLR-15659: ObjectReleaseTracker is now in the wrong class, should le…

2021-10-04 Thread GitBox
markrmiller commented on pull request #316: URL: https://github.com/apache/solr/pull/316#issuecomment-933952610 ObjectReleaseTracker is not in the test framework code and those methods moved to SolrTestCase reference a carrot test framework class, so I removed that the timeout and retries

[GitHub] [solr] markrmiller commented on pull request #253: SOLR-15580: Allow setting the base work directory to another location…

2021-10-04 Thread GitBox
markrmiller commented on pull request #253: URL: https://github.com/apache/solr/pull/253#issuecomment-933945207 Some of this already made it in as part of the data gen dsl issue as I had been using it. I've merged into main and there is some minor cleanup and the README update. -- This

[jira] [Commented] (SOLR-15670) Introduce Gradle parameter to skip ref-guide tasks

2021-10-04 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424172#comment-17424172 ] Dawid Weiss commented on SOLR-15670: Something like this, perhaps? I still see gems b

[jira] [Updated] (SOLR-15670) Introduce Gradle parameter to skip ref-guide tasks

2021-10-04 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated SOLR-15670: --- Attachment: SOLR-15670.patch > Introduce Gradle parameter to skip ref-guide tasks > -

[jira] [Commented] (SOLR-15670) Introduce Gradle parameter to skip ref-guide tasks

2021-10-04 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424171#comment-17424171 ] Dawid Weiss commented on SOLR-15670: It won't work because palantir's plugin stands i

[jira] [Updated] (SOLR-15670) Introduce Gradle parameter to skip ref-guide tasks

2021-10-04 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated SOLR-15670: --- Attachment: SOLR-15670.patch > Introduce Gradle parameter to skip ref-guide tasks > -

[GitHub] [solr] markrmiller commented on a change in pull request #325: SOLR-15653: Fix collection creation race that assumes a local cluster…

2021-10-04 Thread GitBox
markrmiller commented on a change in pull request #325: URL: https://github.com/apache/solr/pull/325#discussion_r721651114 ## File path: solr/core/src/java/org/apache/solr/cloud/api/collections/Assign.java ## @@ -180,7 +180,7 @@ private static int defaultCounterValue(DocCollect

[GitHub] [solr] epugh commented on pull request #296: SOLR-15626: Fix `config-read` permission.

2021-10-04 Thread GitBox
epugh commented on pull request #296: URL: https://github.com/apache/solr/pull/296#issuecomment-933765706 thanks for the legwork @janhoy going to give this a try! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [solr] janhoy commented on pull request #296: SOLR-15626: Fix `config-read` permission.

2021-10-04 Thread GitBox
janhoy commented on pull request #296: URL: https://github.com/apache/solr/pull/296#issuecomment-933760301 @epugh I managed to reproduce the issue both on main and 8.10, and to verify the fix on this branch. The security.json I used was this ```json { "authentication": {

[jira] [Commented] (SOLR-7269) ZK as truth for SolrCloud

2021-10-04 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/SOLR-7269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424041#comment-17424041 ] Mark Robert Miller commented on SOLR-7269: -- We never fully went the route of what

[GitHub] [solr] epugh commented on pull request #296: SOLR-15626: Fix `config-read` permission.

2021-10-04 Thread GitBox
epugh commented on pull request #296: URL: https://github.com/apache/solr/pull/296#issuecomment-933652367 @janhoy I've been trying to duplicate this bug (and the fix) but haven't been able to duplicate it, it all seems to work as expected without being on this branch. I'd love your thoug

[jira] [Commented] (SOLR-15670) Introduce Gradle parameter to skip ref-guide tasks

2021-10-04 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424022#comment-17424022 ] Dawid Weiss commented on SOLR-15670: I'll take a look at it later, it should be fairl

[jira] [Commented] (SOLR-15670) Introduce Gradle parameter to skip ref-guide tasks

2021-10-04 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424020#comment-17424020 ] Dawid Weiss commented on SOLR-15670: I think the best option for the corporate world

[jira] [Created] (SOLR-15674) When attempting to recreate a deleted Solr Collection with a different initial schema the old schema appears to be present in the Solr UI.

2021-10-04 Thread Don (Jira)
Don created SOLR-15674: -- Summary: When attempting to recreate a deleted Solr Collection with a different initial schema the old schema appears to be present in the Solr UI. Key: SOLR-15674 URL: https://issues.apache.org/jir

[jira] [Commented] (SOLR-15673) Incremental backup attempt fails after a shard split operation has completed

2021-10-04 Thread Don (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424007#comment-17424007 ] Don commented on SOLR-15673: Every time we tried to put the stacktrace inline, even when usin

[jira] [Updated] (SOLR-15673) Incremental backup attempt fails after a shard split operation has completed

2021-10-04 Thread Don (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Don updated SOLR-15673: --- Attachment: StackTrace.odt > Incremental backup attempt fails after a shard split operation has completed > -

[jira] [Commented] (SOLR-15670) Introduce Gradle parameter to skip ref-guide tasks

2021-10-04 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423996#comment-17423996 ] Houston Putman commented on SOLR-15670: --- I think it is easier on the build side, bu

[jira] [Updated] (SOLR-15673) Incremental backup attempt fails after a shard split operation has completed

2021-10-04 Thread Sameer (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sameer updated SOLR-15673: -- Affects Version/s: 8.9 Description: I have been attempting to use the incremental backup API on Solr

[jira] [Updated] (SOLR-15673) Incremental backup attempt fails after a shard split operation has completed

2021-10-04 Thread Sameer (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sameer updated SOLR-15673: -- Component/s: Backup/Restore > Incremental backup attempt fails after a shard split operation has completed > --

[jira] [Created] (SOLR-15673) Incremental backup attempt fails after a shard split operation has completed

2021-10-04 Thread Sameer (Jira)
Sameer created SOLR-15673: - Summary: Incremental backup attempt fails after a shard split operation has completed Key: SOLR-15673 URL: https://issues.apache.org/jira/browse/SOLR-15673 Project: Solr

[GitHub] [solr-operator] HoustonPutman commented on issue #329: Support Contrib Modules and additional libraries

2021-10-04 Thread GitBox
HoustonPutman commented on issue #329: URL: https://github.com/apache/solr-operator/issues/329#issuecomment-933558252 Perfectly happy to use `modules` instead of `contrib modules`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[jira] [Commented] (SOLR-7269) ZK as truth for SolrCloud

2021-10-04 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-7269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423916#comment-17423916 ] David Smiley commented on SOLR-7269: [~markrmil...@gmail.com] is this issue already im

[jira] [Commented] (SOLR-15301) Eliminate repetitive index size calculation for Solr metrics

2021-10-04 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423905#comment-17423905 ] Andrzej Bialecki commented on SOLR-15301: - We should not use two different implem

[GitHub] [solr] dsmiley commented on pull request #324: SOLR-14660 - move HDFS to a contrib module

2021-10-04 Thread GitBox
dsmiley commented on pull request #324: URL: https://github.com/apache/solr/pull/324#issuecomment-933411418 > The block cache feature was only used by HDFS, moved to the contrib module) Is it _possible_ to use it in some other/generic Directory impl? I haven't looked at it closely b

[jira] [Commented] (SOLR-15301) Eliminate repetitive index size calculation for Solr metrics

2021-10-04 Thread Andras Salamon (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423898#comment-17423898 ] Andras Salamon commented on SOLR-15301: --- In this Jira my original problem was that

[jira] [Commented] (SOLR-15301) Eliminate repetitive index size calculation for Solr metrics

2021-10-04 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423896#comment-17423896 ] Andrzej Bialecki commented on SOLR-15301: - I agree, using {{CachedGauge}} is the

[jira] [Commented] (SOLR-15301) Eliminate repetitive index size calculation for Solr metrics

2021-10-04 Thread Andras Salamon (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423811#comment-17423811 ] Andras Salamon commented on SOLR-15301: --- [~markrmiller] added a comment to the pull

[jira] [Commented] (SOLR-15301) Eliminate repetitive index size calculation for Solr metrics

2021-10-04 Thread Andras Salamon (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423791#comment-17423791 ] Andras Salamon commented on SOLR-15301: --- Thanks for the tips [~dsmiley], I'll uploa