[jira] [Resolved] (SOLR-16284) Solr Jenkins CI - s390x support

2022-07-07 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler resolved SOLR-16284. -- Resolution: Resolved > Solr Jenkins CI - s390x support > > >

[GitHub] [solr] ackepenek opened a new pull request, #934: SOLR-9661 added missing operations[withField,withValue] for expression on stream operations

2022-07-07 Thread GitBox
ackepenek opened a new pull request, #934: URL: https://github.com/apache/solr/pull/934 https://issues.apache.org/jira/browse/SOLR-9661 # Description Fixed the `withField` and `withValue` usage problem while executing the stream enabled expression. # Solution

[GitHub] [solr] madrob commented on pull request #907: Update to Hadoop 3.3.3

2022-07-07 Thread GitBox
madrob commented on PR #907: URL: https://github.com/apache/solr/pull/907#issuecomment-1178312798 Looks like the only changes were two commits to FileUtil. Will work on incorporating those. https://github.com/apache/hadoop/commits/release-3.3.3-RC1/hadoop-common-project/hadoop-common

[GitHub] [solr] janhoy commented on pull request #753: SOLR-16005 added new feature in to schema screen: add new field type

2022-07-07 Thread GitBox
janhoy commented on PR #753: URL: https://github.com/apache/solr/pull/753#issuecomment-1178272042 Just as I hoped, LGTM. Cannot test (holiday). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [solr] madrob commented on pull request #927: SOLR-16278: remove unused declarations

2022-07-07 Thread GitBox
madrob commented on PR #927: URL: https://github.com/apache/solr/pull/927#issuecomment-1178257360 Yea, I don't have strong feelings about leaving the loggers in over taking them out, do what you gotta do man. -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [solr] epugh commented on a diff in pull request #745: SOLR-16096: Add createNodeSet to Advanced Collection Creation Options

2022-07-07 Thread GitBox
epugh commented on code in PR #745: URL: https://github.com/apache/solr/pull/745#discussion_r916276722 ## solr/webapp/web/js/angular/controllers/collections.js: ## @@ -23,6 +23,18 @@ solrAdminApp.controller('CollectionsController', $scope.rootUrl = Constants.ROOT_UR

[GitHub] [solr] risdenk commented on a diff in pull request #745: SOLR-16096: Add createNodeSet to Advanced Collection Creation Options

2022-07-07 Thread GitBox
risdenk commented on code in PR #745: URL: https://github.com/apache/solr/pull/745#discussion_r916263009 ## solr/webapp/web/js/angular/controllers/collections.js: ## @@ -23,6 +23,18 @@ solrAdminApp.controller('CollectionsController', $scope.rootUrl = Constants.ROOT_

[GitHub] [solr] epugh commented on a diff in pull request #745: SOLR-16096: Add createNodeSet to Advanced Collection Creation Options

2022-07-07 Thread GitBox
epugh commented on code in PR #745: URL: https://github.com/apache/solr/pull/745#discussion_r916268241 ## solr/webapp/web/libs/selectize.min.js: ## @@ -0,0 +1,2 @@ +/*! selectize.js - v0.13.4 | https://github.com/selectize/selectize.js | Apache License (v2) */ Review Comment:

[GitHub] [solr] risdenk commented on a diff in pull request #745: SOLR-16096: Add createNodeSet to Advanced Collection Creation Options

2022-07-07 Thread GitBox
risdenk commented on code in PR #745: URL: https://github.com/apache/solr/pull/745#discussion_r916263009 ## solr/webapp/web/js/angular/controllers/collections.js: ## @@ -23,6 +23,18 @@ solrAdminApp.controller('CollectionsController', $scope.rootUrl = Constants.ROOT_

[jira] [Commented] (SOLR-16096) Expose createNodeSet parameter in the Create Collection UI

2022-07-07 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17563933#comment-17563933 ] Eric Pugh commented on SOLR-16096: -- And by "ready for review" I mean, I jsut redid it t

[GitHub] [solr] sonatype-lift[bot] commented on a diff in pull request #909: SOLR-16257: `ZkStateReader` changes to avoid race condition between `collectionWatches` and `watchedCollectionStates`

2022-07-07 Thread GitBox
sonatype-lift[bot] commented on code in PR #909: URL: https://github.com/apache/solr/pull/909#discussion_r916221705 ## solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java: ## @@ -326,12 +432,11 @@ public void forciblyRefreshAllClusterStateSlow() throws KeeperExc

[GitHub] [solr] patsonluk commented on a diff in pull request #909: SOLR-16257: `ZkStateReader` changes to avoid race condition between `collectionWatches` and `watchedCollectionStates`

2022-07-07 Thread GitBox
patsonluk commented on code in PR #909: URL: https://github.com/apache/solr/pull/909#discussion_r916221594 ## solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java: ## @@ -326,12 +432,11 @@ public void forciblyRefreshAllClusterStateSlow() throws KeeperException, I

[GitHub] [solr] epugh commented on pull request #927: SOLR-16278: remove unused declarations

2022-07-07 Thread GitBox
epugh commented on PR #927: URL: https://github.com/apache/solr/pull/927#issuecomment-1178133308 I also get @madrob that keeping the unused log might just be a personal thing, and I'm happy to put them back in to avoid a bike shedding discussion! -- This is an automated message from the A

[GitHub] [solr] epugh commented on pull request #927: SOLR-16278: remove unused declarations

2022-07-07 Thread GitBox
epugh commented on PR #927: URL: https://github.com/apache/solr/pull/927#issuecomment-1178118429 > Even if a logger is unused, I would still leave it in. I was really hoping that I could just use the logger declared in the base class, so for `TestRandomFaceting`, use the `log` declare

[GitHub] [solr] epugh merged pull request #925: SOLR-16275 use standard charset instead of string forName version

2022-07-07 Thread GitBox
epugh merged PR #925: URL: https://github.com/apache/solr/pull/925 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org F

[GitHub] [solr] patsonluk commented on a diff in pull request #909: SOLR-16257: `ZkStateReader` changes to avoid race condition between `collectionWatches` and `watchedCollectionStates`

2022-07-07 Thread GitBox
patsonluk commented on code in PR #909: URL: https://github.com/apache/solr/pull/909#discussion_r916198593 ## solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java: ## @@ -246,6 +245,125 @@ public boolean canBeRemoved() { } } + /** + * A ConcurrentHash

[jira] [Resolved] (SOLR-16275) Replace Charset.forName("UTF-8") with StandardCharsets.UTF_8

2022-07-07 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh resolved SOLR-16275. -- Fix Version/s: 9.1 main (10.0) Resolution: Fixed > Replace Charset.forName("U

[jira] [Commented] (SOLR-16275) Replace Charset.forName("UTF-8") with StandardCharsets.UTF_8

2022-07-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17563922#comment-17563922 ] ASF subversion and git services commented on SOLR-16275: Commit c

[jira] [Commented] (SOLR-16275) Replace Charset.forName("UTF-8") with StandardCharsets.UTF_8

2022-07-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17563921#comment-17563921 ] ASF subversion and git services commented on SOLR-16275: Commit c

[GitHub] [solr] epugh commented on pull request #745: SOLR-16096: Add createNodeSet to Advanced Collection Creation Options

2022-07-07 Thread GitBox
epugh commented on PR #745: URL: https://github.com/apache/solr/pull/745#issuecomment-1178076281 I've redone this PR to use the existing `chosen` library and now I think it's ready. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [solr] patsonluk commented on a diff in pull request #909: SOLR-16257: `ZkStateReader` changes to avoid race condition between `collectionWatches` and `watchedCollectionStates`

2022-07-07 Thread GitBox
patsonluk commented on code in PR #909: URL: https://github.com/apache/solr/pull/909#discussion_r916144715 ## solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java: ## @@ -246,6 +244,90 @@ public boolean canBeRemoved() { } } + /** + * A ConcurrentHashM

[GitHub] [solr] patsonluk commented on a diff in pull request #909: SOLR-16257: `ZkStateReader` changes to avoid race condition between `collectionWatches` and `watchedCollectionStates`

2022-07-07 Thread GitBox
patsonluk commented on code in PR #909: URL: https://github.com/apache/solr/pull/909#discussion_r916134059 ## solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java: ## @@ -549,7 +636,7 @@ private void constructState(Set changedCollections) { log.trace(

[GitHub] [solr] patsonluk commented on a diff in pull request #909: SOLR-16257: `ZkStateReader` changes to avoid race condition between `collectionWatches` and `watchedCollectionStates`

2022-07-07 Thread GitBox
patsonluk commented on code in PR #909: URL: https://github.com/apache/solr/pull/909#discussion_r916132053 ## solr/core/src/test/org/apache/solr/cloud/overseer/ZkStateReaderTest.java: ## @@ -29,35 +38,68 @@ import org.apache.solr.cloud.ZkTestServer; import org.apache.solr.comm

[GitHub] [solr] epugh commented on a diff in pull request #745: SOLR-16096: Add createNodeSet to Advanced Collection Creation Options

2022-07-07 Thread GitBox
epugh commented on code in PR #745: URL: https://github.com/apache/solr/pull/745#discussion_r916119237 ## solr/webapp/web/libs/angular-selectize.js: ## @@ -0,0 +1,107 @@ +/** + * Angular Selectize2 + * https://github.com/machineboy2045/angular-selectize Review Comment: I am

[GitHub] [solr-sandbox] sikevux opened a new pull request, #29: Consumer: Add initial metrics

2022-07-07 Thread GitBox
sikevux opened a new pull request, #29: URL: https://github.com/apache/solr-sandbox/pull/29 This change adds initial support for Dropwizard Metrics to the Consumer. With this we could allow users to send metrics to a number of reporting backends. -- This is an automated message from

[GitHub] [solr] madrob commented on a diff in pull request #913: SOLR-16260: Add support for Instant, LocalDate and ZonedDateTime to JavaBinCodec

2022-07-07 Thread GitBox
madrob commented on code in PR #913: URL: https://github.com/apache/solr/pull/913#discussion_r916106001 ## solr/solrj/src/java/org/apache/solr/common/util/JavaBinCodec.java: ## @@ -1080,6 +1081,16 @@ public boolean writePrimitive(Object val) throws IOException { daos.wri

[GitHub] [solr] madrob commented on pull request #927: SOLR-16278: remove unused declarations

2022-07-07 Thread GitBox
madrob commented on PR #927: URL: https://github.com/apache/solr/pull/927#issuecomment-1177945815 Even if a logger is unused, I would still leave it in. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (SOLR-9661) Explain of select that uses replace() throws exception

2022-07-07 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-9661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17563881#comment-17563881 ] Eric Pugh commented on SOLR-9661: - I verified that this bug still exists ;-). 1) Run bin/

[GitHub] [solr-operator] HoustonPutman merged pull request #451: Ability to customize default initContainer resources

2022-07-07 Thread GitBox
HoustonPutman merged PR #451: URL: https://github.com/apache/solr-operator/pull/451 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@s

[GitHub] [solr-operator] HoustonPutman closed issue #448: Allow option to specify init-containers (setup-zk, cp-solr-xml etc.) resources

2022-07-07 Thread GitBox
HoustonPutman closed issue #448: Allow option to specify init-containers (setup-zk, cp-solr-xml etc.) resources URL: https://github.com/apache/solr-operator/issues/448 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [solr-operator] HoustonPutman commented on pull request #455: Recompute NextScheduled backup on each reconcile

2022-07-07 Thread GitBox
HoustonPutman commented on PR #455: URL: https://github.com/apache/solr-operator/pull/455#issuecomment-1177905353 We were discussing offline about how the schedule gets restarted if the user disables the recurrence and then re-enables it. Does this fix that? -- This is an automated messag

[jira] [Updated] (SOLR-15734) Prepare v2 API for v1 deprecation, eventual removal

2022-07-07 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated SOLR-15734: --- Summary: Prepare v2 API for v1 deprecation, eventual removal (was: Prepare v2 API for v2 dep

[jira] [Commented] (SOLR-15182) Rewrite V2 APIs using annotation framework

2022-07-07 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17563846#comment-17563846 ] Jason Gerlowski commented on SOLR-15182: Woohoo, I think we can finally close thi

[jira] [Resolved] (SOLR-15182) Rewrite V2 APIs using annotation framework

2022-07-07 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski resolved SOLR-15182. Fix Version/s: 9.1 main (10.0) Resolution: Fixed > Rewrite V2 API

[jira] [Assigned] (SOLR-15182) Rewrite V2 APIs using annotation framework

2022-07-07 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski reassigned SOLR-15182: -- Assignee: Jason Gerlowski > Rewrite V2 APIs using annotation framework > -

[jira] [Commented] (SOLR-15182) Rewrite V2 APIs using annotation framework

2022-07-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17563843#comment-17563843 ] ASF subversion and git services commented on SOLR-15182: Commit 5

[GitHub] [solr] gerlowskija merged pull request #932: SOLR-15182: Remove remaining apispec files

2022-07-07 Thread GitBox
gerlowskija merged PR #932: URL: https://github.com/apache/solr/pull/932 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.

[jira] [Commented] (SOLR-15182) Rewrite V2 APIs using annotation framework

2022-07-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17563834#comment-17563834 ] ASF subversion and git services commented on SOLR-15182: Commit 6

[GitHub] [solr-operator] HoustonPutman merged pull request #454: Use the Solr image as the default Prom Exp image

2022-07-07 Thread GitBox
HoustonPutman merged PR #454: URL: https://github.com/apache/solr-operator/pull/454 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@s

[GitHub] [solr-operator] HoustonPutman closed issue #386: SolrPrometheusExporter uses wrong image.

2022-07-07 Thread GitBox
HoustonPutman closed issue #386: SolrPrometheusExporter uses wrong image. URL: https://github.com/apache/solr-operator/issues/386 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [solr] alessandrobenedetti merged pull request #933: SOLR-16204: cherry-pick changes to branch_9x

2022-07-07 Thread GitBox
alessandrobenedetti merged PR #933: URL: https://github.com/apache/solr/pull/933 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr

[jira] [Commented] (SOLR-16245) Make DenseVectorField codec agnostic

2022-07-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17563802#comment-17563802 ] ASF subversion and git services commented on SOLR-16245: Commit a

[jira] [Commented] (SOLR-16204) Change Lucene dependency to Lucene 9.1.0

2022-07-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17563800#comment-17563800 ] ASF subversion and git services commented on SOLR-16204: Commit e

[GitHub] [solr] epugh merged pull request #926: SOLR-16223: unused throws identified by IntelliJ (round 2)

2022-07-07 Thread GitBox
epugh merged PR #926: URL: https://github.com/apache/solr/pull/926 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org F

[GitHub] [solr] epugh merged pull request #929: SOLR-16280: simplify for-loops in tests

2022-07-07 Thread GitBox
epugh merged PR #929: URL: https://github.com/apache/solr/pull/929 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org F

[jira] [Resolved] (SOLR-16223) Eliminate exceptions that aren't actually thrown

2022-07-07 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh resolved SOLR-16223. -- Resolution: Fixed Hopefully this stays resolved and we don't find more!!! > Eliminate exceptions that

[GitHub] [solr] epugh commented on a diff in pull request #926: SOLR-16223: unused throws identified by IntelliJ (round 2)

2022-07-07 Thread GitBox
epugh commented on code in PR #926: URL: https://github.com/apache/solr/pull/926#discussion_r915815261 ## solr/core/src/test/org/apache/solr/cloud/ForceLeaderTest.java: ## @@ -59,7 +59,7 @@ public static void beforeClassSetup() { @Test @Override @Ignore - public void t

[GitHub] [solr] epugh commented on pull request #927: SOLR-16278: remove unused declarations

2022-07-07 Thread GitBox
epugh commented on PR #927: URL: https://github.com/apache/solr/pull/927#issuecomment-1177532138 Thanks @cpoerschke for all the work reviewing these so far! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Resolved] (SOLR-16280) use simplified for loops where possible

2022-07-07 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh resolved SOLR-16280. -- Fix Version/s: 9.1 main (10.0) Resolution: Fixed > use simplified for loops w

[jira] [Commented] (SOLR-16280) use simplified for loops where possible

2022-07-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17563758#comment-17563758 ] ASF subversion and git services commented on SOLR-16280: Commit 8

[jira] [Commented] (SOLR-16280) use simplified for loops where possible

2022-07-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17563757#comment-17563757 ] ASF subversion and git services commented on SOLR-16280: Commit 8

[GitHub] [solr-operator] gerlowskija commented on a diff in pull request #451: Ability to customize default initContainer resources

2022-07-07 Thread GitBox
gerlowskija commented on code in PR #451: URL: https://github.com/apache/solr-operator/pull/451#discussion_r915742992 ## api/v1beta1/common_types.go: ## @@ -150,6 +149,10 @@ type PodOptions struct { // +listMapKey=whenUnsatisfiable // +optional TopologySp

[GitHub] [solr-operator] gerlowskija opened a new pull request, #455: Recompute NextScheduled backup on each reconcile

2022-07-07 Thread GitBox
gerlowskija opened a new pull request, #455: URL: https://github.com/apache/solr-operator/pull/455 Resolves #376 Prior to this commit, the 'NextScheduled' field of a solrbackup's status was never updated, even if the user the backup schedule in the solrbackup spec. This co

[GitHub] [solr] eliaporciani opened a new pull request, #933: SOLR-16204: cherry-pick changes to branch_9x

2022-07-07 Thread GitBox
eliaporciani opened a new pull request, #933: URL: https://github.com/apache/solr/pull/933 https://issues.apache.org/jira/browse/SOLR-16204 Cherry-picking changes of SOLR-16204 to branch 9x # Checklist Please review the following and check all that apply: - [x] I h