[GitHub] [solr] ijioio commented on pull request #931: SOLR-16282: Update core admin handler to use pluggable custom actions

2022-07-11 Thread GitBox
ijioio commented on PR #931: URL: https://github.com/apache/solr/pull/931#issuecomment-1181375536 Hi @cpoerschke! Thanks for the comment! > It's a bit subjective of course but the solr.xml needing to be changed, that seems a bit of a burden, both operationally and in terms of code co

[GitHub] [solr-operator] gerlowskija commented on pull request #455: Recompute NextScheduled backup on each reconcile

2022-07-11 Thread GitBox
gerlowskija commented on PR #455: URL: https://github.com/apache/solr-operator/pull/455#issuecomment-1180797762 > how the schedule gets restarted if the user disables the recurrence and then re-enables it This fixes that "problem", yep. Prior to this PR, a backup would immediately b

[GitHub] [solr-operator] gerlowskija opened a new pull request, #458: Remove remaining 'backupRestoreOptions' references

2022-07-11 Thread GitBox
gerlowskija opened a new pull request, #458: URL: https://github.com/apache/solr-operator/pull/458 The CRD option had been removed from 0.6.0 by a prior commit but a few dangling references still remainined. This cleans those up to help clarify the docs around backup functionality. -

[GitHub] [solr-operator] gerlowskija opened a new issue, #457: Purge remaining references to compression, "managed" backups, and "backupRestoreOptions" CRD field

2022-07-11 Thread GitBox
gerlowskija opened a new issue, #457: URL: https://github.com/apache/solr-operator/issues/457 PR #418 removed references to a number of deprecated CRD options that we're removing for 0.6.0. But it missed a few references, particularly to the "backupRestoreOptions" field that is referenced

[GitHub] [solr] cpoerschke commented on pull request #931: SOLR-16282: Update core admin handler to use pluggable custom actions

2022-07-11 Thread GitBox
cpoerschke commented on PR #931: URL: https://github.com/apache/solr/pull/931#issuecomment-1180705616 Hello @ijioio! Thanks for the detailed notes both on the https://issues.apache.org/jira/browse/SOLR-16282 JIRA and the pull request here, they really help with understanding of the e

[GitHub] [solr] patsonluk commented on pull request #909: SOLR-16257: `ZkStateReader` changes to avoid race condition between `collectionWatches` and `watchedCollectionStates`

2022-07-11 Thread GitBox
patsonluk commented on PR #909: URL: https://github.com/apache/solr/pull/909#issuecomment-1180690433 Thank you again for the helpful review @HoustonPutman and @madrob . It seems like there's this https://github.com/apache/solr/pull/909#discussion_r915129741 that is only one outstanding? @Ho

[jira] [Commented] (SOLR-15737) Ensure all (desired) v1 APIs have v2 equivalent

2022-07-11 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17565076#comment-17565076 ] Jason Gerlowski commented on SOLR-15737: It occurred to me recently that this tic

[GitHub] [solr] danrosher opened a new pull request, #935: SOLR-16286 : Topic stream not honoring initialCheckpoint in getPersis…

2022-07-11 Thread GitBox
danrosher opened a new pull request, #935: URL: https://github.com/apache/solr/pull/935 …tedCheckpoints https://issues.apache.org/jira/browse/SOLR-X # Description Please provide a short description of the changes you're making with this pull request.

[jira] [Created] (SOLR-16286) Topic stream not honoring initialCheckpoint in getPersistedCheckpoints

2022-07-11 Thread Dan Rosher (Jira)
Dan Rosher created SOLR-16286: - Summary: Topic stream not honoring initialCheckpoint in getPersistedCheckpoints Key: SOLR-16286 URL: https://issues.apache.org/jira/browse/SOLR-16286 Project: Solr

[GitHub] [solr] HoustonPutman commented on a diff in pull request #610: SOLR-15242: Consolidate README.md with solr/README.md

2022-07-11 Thread GitBox
HoustonPutman commented on code in PR #610: URL: https://github.com/apache/solr/pull/610#discussion_r918093282 ## README_v2.md: ## @@ -0,0 +1,176 @@ + + +# Welcome to the Apache Solr project! +--- + +Solr is the popular, blazing fast open source e

[GitHub] [solr] HoustonPutman commented on a diff in pull request #610: SOLR-15242: Consolidate README.md with solr/README.md

2022-07-11 Thread GitBox
HoustonPutman commented on code in PR #610: URL: https://github.com/apache/solr/pull/610#discussion_r918089128 ## README_v2.md: ## @@ -0,0 +1,307 @@ + + +# Welcome to the Apache Solr project! +--- + +Solr is the popular, blazing fast open source e

[GitHub] [solr] epugh commented on a diff in pull request #610: SOLR-15242: Consolidate README.md with solr/README.md

2022-07-11 Thread GitBox
epugh commented on code in PR #610: URL: https://github.com/apache/solr/pull/610#discussion_r917968183 ## README_v2.md: ## @@ -0,0 +1,307 @@ + + +# Welcome to the Apache Solr project! +--- + +Solr is the popular, blazing fast open source enterpris

[jira] [Commented] (SOLR-16278) Remove unused variables/methods from tests

2022-07-11 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17565009#comment-17565009 ] Eric Pugh commented on SOLR-16278: -- Thanks [~cpoerschke] for all the work on this one!

[jira] [Resolved] (SOLR-16278) Remove unused variables/methods from tests

2022-07-11 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh resolved SOLR-16278. -- Fix Version/s: 9.1 main (10.0) Resolution: Fixed > Remove unused variables/me

[jira] [Commented] (SOLR-16278) Remove unused variables/methods from tests

2022-07-11 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17565006#comment-17565006 ] ASF subversion and git services commented on SOLR-16278: Commit 4

[jira] [Commented] (SOLR-16278) Remove unused variables/methods from tests

2022-07-11 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17565008#comment-17565008 ] ASF subversion and git services commented on SOLR-16278: Commit a

[GitHub] [solr] epugh merged pull request #927: SOLR-16278: remove unused declarations

2022-07-11 Thread GitBox
epugh merged PR #927: URL: https://github.com/apache/solr/pull/927 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org F

[GitHub] [solr] gerlowskija commented on a diff in pull request #610: SOLR-15242: Consolidate README.md with solr/README.md

2022-07-11 Thread GitBox
gerlowskija commented on code in PR #610: URL: https://github.com/apache/solr/pull/610#discussion_r917882952 ## README_v2.md: ## @@ -0,0 +1,307 @@ + + +# Welcome to the Apache Solr project! +--- + +Solr is the popular, blazing fast open source ent