epugh commented on PR #938:
URL: https://github.com/apache/solr/pull/938#issuecomment-1183755518
> From my knowledge, spotless can deal with imports. It uses javac to scan
the code, so it understands how to expand wildcards.
From my investigation, spotless can reorder imports, but not
epugh opened a new pull request, #941:
URL: https://github.com/apache/solr/pull/941
https://issues.apache.org/jira/browse/SOLR-16294
# Description
update to current state of solr.
# Solution
text change
--
This is an automated message from the Apache Git
Eric Pugh created SOLR-16294:
Summary: Update formatting.txt post SOLR-14920 work
Key: SOLR-16294
URL: https://issues.apache.org/jira/browse/SOLR-16294
Project: Solr
Issue Type: Improvement
uschindler commented on PR #938:
URL: https://github.com/apache/solr/pull/938#issuecomment-1183607967
From my knowledge, spotless can deal with imports. It uses javac to scan the
code, so it understands how to expand wildcards.
--
This is an automated message from the Apache Git Service.
HoustonPutman commented on PR #857:
URL: https://github.com/apache/solr/pull/857#issuecomment-1183603486
@laminelam I'm not sure what the `merge` commit is, but you need to remove
it and re-do the merge, like the second merge commit. Otherwise we can't tell
which files this PR is actually t
epugh commented on PR #938:
URL: https://github.com/apache/solr/pull/938#issuecomment-1183587249
I believe that we have to manually deal with the import statements, that
spotless can alert, but can't fix it?
--
This is an automated message from the Apache Git Service.
To respond to th
uschindler commented on PR #938:
URL: https://github.com/apache/solr/pull/938#issuecomment-1183571067
I don't think this PR is needed. I'd just go with spotless.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
uschindler commented on PR #938:
URL: https://github.com/apache/solr/pull/938#issuecomment-1183569869
Lucene agreed to the Spotless code formatting with the Google Java. In
Lucene's precommit will fail, if you have code not formatted like that. In
general it's plain easy: run "./gradlew tid
madrob commented on code in PR #940:
URL: https://github.com/apache/solr/pull/940#discussion_r920385253
##
solr/core/src/test/org/apache/solr/util/NVectorUtilTest.java:
##
@@ -0,0 +1,65 @@
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contribut
epugh commented on PR #938:
URL: https://github.com/apache/solr/pull/938#issuecomment-1183557524
awesome, so, is everything in this style guide "solr community accepted"?
As in, can I reference this to understand what our style is? We should have a
FAQ entry about that for the next pers
dsmiley commented on PR #938:
URL: https://github.com/apache/solr/pull/938#issuecomment-1183551250
No wildcards -- not because of me or you or whatever IntelliJ or other IDE
ships by default, but because we are trying to adhere to a particular style
guide:
https://google.github.io/stylegui
anshumg commented on code in PR #30:
URL: https://github.com/apache/solr-sandbox/pull/30#discussion_r920327357
##
crossdc-consumer/src/main/java/org/apache/solr/crossdc/consumer/KafkaCrossDcConsumer.java:
##
@@ -135,6 +135,9 @@ boolean pollAndProcessRequests() {
IQu
madrob commented on PR #857:
URL: https://github.com/apache/solr/pull/857#issuecomment-1183485198
It looks like something went wrong, maybe this branch is out of date? Can
you check that it is current, I wanted to give it a final pass review but am
not able to do that.
--
This is an auto
madrob commented on PR #937:
URL: https://github.com/apache/solr/pull/937#issuecomment-1183479704
Thanks for the patch!
Can you add a unit test demonstrating this failure? I think from there it
will be easier to brainstorm a fuller solution in case you think the null check
is insuffi
[
https://issues.apache.org/jira/browse/SOLR-16293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17566409#comment-17566409
]
Thomas Corthals commented on SOLR-16293:
This is the full response of the Luke re
Thomas Corthals created SOLR-16293:
--
Summary: Luke request fails for document with a binary field
Key: SOLR-16293
URL: https://issues.apache.org/jira/browse/SOLR-16293
Project: Solr
Issue Ty
HoustonPutman commented on code in PR #452:
URL: https://github.com/apache/solr-operator/pull/452#discussion_r920289125
##
api/v1beta1/solrcloud_types.go:
##
@@ -576,8 +588,21 @@ const (
)
func (opts *ExternalAddressability) withDefaults(usesTLS bool) (changed bool) {
+
gerlowskija commented on code in PR #452:
URL: https://github.com/apache/solr-operator/pull/452#discussion_r920269219
##
api/v1beta1/solrcloud_types.go:
##
@@ -576,8 +588,21 @@ const (
)
func (opts *ExternalAddressability) withDefaults(usesTLS bool) (changed bool) {
+
danrosher opened a new pull request, #940:
URL: https://github.com/apache/solr/pull/940
https://issues.apache.org/jira/browse/SOLR-16292
# Description
[N-Vector](https://en.wikipedia.org/wiki/N-vector#Example:_Great_circle_distance)
is a three-parameter representation that can
[
https://issues.apache.org/jira/browse/SOLR-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Roustant resolved SOLR-16255.
---
Fix Version/s: 9.1
Resolution: Fixed
> Introduce DirectUpdateHandler2#shouldCommit
> -
[
https://issues.apache.org/jira/browse/SOLR-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17566345#comment-17566345
]
ASF subversion and git services commented on SOLR-16255:
Commit 4
bruno-roustant merged PR #906:
URL: https://github.com/apache/solr/pull/906
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apac
epugh commented on PR #938:
URL: https://github.com/apache/solr/pull/938#issuecomment-1183290940
@dsmiley before I go futhur, what do you think of the way I fixed the
imports? Does this pattern for both regular and statics make sense?
--
This is an automated message from the Apa
Dan Rosher created SOLR-16292:
-
Summary: NVector for alternative great-circle distance calculations
Key: SOLR-16292
URL: https://issues.apache.org/jira/browse/SOLR-16292
Project: Solr
Issue Type:
[
https://issues.apache.org/jira/browse/SOLR-7316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17566317#comment-17566317
]
Pascal van Oostenbrugge commented on SOLR-7316:
---
Here I am, 2022, checking d
[
https://issues.apache.org/jira/browse/SOLR-16291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Rosher updated SOLR-16291:
--
Description:
h2. Description
This is a Solr version of the Decay functions [available in
Elasticsearc
[
https://issues.apache.org/jira/browse/SOLR-16291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Rosher updated SOLR-16291:
--
Description:
h2. Description
This is a Solr version of the Decay functions [available in
Elasticsearc
[
https://issues.apache.org/jira/browse/SOLR-16291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Rosher updated SOLR-16291:
--
Description:
h2. Description
This is a Solr version of the Decay functions [available in
Elasticsearc
[
https://issues.apache.org/jira/browse/SOLR-16291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Rosher updated SOLR-16291:
--
Description:
h2. Description
This is a Solr version of the Decay functions [available in Elasticsearch
danrosher opened a new pull request, #939:
URL: https://github.com/apache/solr/pull/939
https://issues.apache.org/jira/browse/SOLR-16291
# Description
This is a Solr version of the Decay functions [available in Elasticsearch ]
(https://www.elastic.co/guide/en/elasticsearch/ref
[
https://issues.apache.org/jira/browse/SOLR-12224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17566305#comment-17566305
]
Franck Valentin commented on SOLR-12224:
Hi,
I'm using 8.9 and there is still no
epugh commented on PR #938:
URL: https://github.com/apache/solr/pull/938#issuecomment-1183159810
Just pushed up the spotless version. We don't get the nice report, since
it just stops on the first one with an exception:
```
> Task :solr:core:spotlessJava FAILED
Step 'Refuse wi
Dan Rosher created SOLR-16291:
-
Summary: Decay function queries gauss,linear,exponential
Key: SOLR-16291
URL: https://issues.apache.org/jira/browse/SOLR-16291
Project: Solr
Issue Type: Improvemen
cpoerschke commented on PR #931:
URL: https://github.com/apache/solr/pull/931#issuecomment-1183087347
> ... we can make an interface implying the action name definition ...
I wonder if with such an interface the `CoreAdminHandler` subclassing could
be more favourable after all e.g.
[
https://issues.apache.org/jira/browse/SOLR-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17566246#comment-17566246
]
Dan Rosher commented on SOLR-16287:
---
When used with the update stream, yes it can atomi
[
https://issues.apache.org/jira/browse/SOLR-16290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kerim updated SOLR-16290:
-
Description:
Hello,
I'm trying to combine Nested facet, excludeTags (for multiselect filter
searching) and a
[
https://issues.apache.org/jira/browse/SOLR-16290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kerim updated SOLR-16290:
-
Issue Type: Bug (was: Wish)
> Combine Nested Facet & excludeTags and BlockChildren not working for children
> f
[
https://issues.apache.org/jira/browse/SOLR-16290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kerim updated SOLR-16290:
-
Description:
Hello,
I'm trying to combine Nested facet, excludeTags (for multiselect filter
searching) and a
[
https://issues.apache.org/jira/browse/SOLR-16290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kerim updated SOLR-16290:
-
Summary: Combine Nested Facet & excludeTags and BlockChildren not working
for children facets (multi select facet
Kerim created SOLR-16290:
Summary: Combine Nested Facet & excludeTags and BlockChildren not
working for children facets
Key: SOLR-16290
URL: https://issues.apache.org/jira/browse/SOLR-16290
Project: Solr
40 matches
Mail list logo
