haythemkh commented on code in PR #943:
URL: https://github.com/apache/solr/pull/943#discussion_r930595757
##
solr/solrj/src/java/org/apache/solr/client/solrj/io/stream/DeepRandomStream.java:
##
@@ -293,7 +293,7 @@ public static Slice[] getSlices(
// check for alias or co
haythemkh commented on code in PR #943:
URL: https://github.com/apache/solr/pull/943#discussion_r930594836
##
solr/solrj/src/java/org/apache/solr/client/solrj/io/stream/DeepRandomStream.java:
##
@@ -282,50 +277,6 @@ public List children() {
return solrStreams;
}
- pub
haythemkh commented on code in PR #943:
URL: https://github.com/apache/solr/pull/943#discussion_r930593883
##
solr/solrj/src/java/org/apache/solr/client/solrj/io/stream/DeepRandomStream.java:
##
@@ -293,7 +293,7 @@ public static Slice[] getSlices(
// check for alias or co
dsmiley commented on code in PR #943:
URL: https://github.com/apache/solr/pull/943#discussion_r930468981
##
solr/solrj-zookeeper/src/java/org/apache/solr/common/util/ZkUtils.java:
##
@@ -32,4 +40,45 @@ public static Map getJson(
}
return Collections.emptyMap();
justinrsweeney commented on code in PR #948:
URL: https://github.com/apache/solr/pull/948#discussion_r930444571
##
solr/core/src/test/org/apache/solr/metrics/DelegateRegistryTimerTest.java:
##
@@ -0,0 +1,218 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one o
justinrsweeney commented on code in PR #948:
URL: https://github.com/apache/solr/pull/948#discussion_r930444339
##
solr/core/src/test/org/apache/solr/metrics/DelegateRegistryTimerTest.java:
##
@@ -0,0 +1,218 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one o
justinrsweeney commented on code in PR #948:
URL: https://github.com/apache/solr/pull/948#discussion_r930429630
##
solr/core/src/java/org/apache/solr/metrics/DelegateRegistryCounter.java:
##
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or m
justinrsweeney commented on code in PR #948:
URL: https://github.com/apache/solr/pull/948#discussion_r930416037
##
solr/core/src/test/org/apache/solr/handler/RequestHandlerMetricsTest.java:
##
@@ -0,0 +1,196 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one o
madrob commented on code in PR #857:
URL: https://github.com/apache/solr/pull/857#discussion_r930348564
##
solr/solrj/src/java/org/apache/solr/common/cloud/SolrZkClient.java:
##
@@ -256,18 +261,44 @@ protected ZkACLProvider createZkACLProvider() {
if (!StringUtils.isEmpty(z
epugh opened a new pull request, #954:
URL: https://github.com/apache/solr/pull/954
https://issues.apache.org/jira/browse/SOLR-16314
# Description
IntelliJ flagged we use private methods with our `@Before` etc annotations.
They do actually get called however.
# Soluti
[
https://issues.apache.org/jira/browse/SOLR-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571575#comment-17571575
]
Joel Bernstein commented on SOLR-16287:
---
This is a nice transformation to have in t
HoustonPutman opened a new pull request, #460:
URL: https://github.com/apache/solr-operator/pull/460
Users will just need to run `make idea` first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
[
https://issues.apache.org/jira/browse/SOLR-15727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571567#comment-17571567
]
Shawn Heisey commented on SOLR-15727:
-
By default, SolrCloud only guarantees that the
laminelam commented on code in PR #857:
URL: https://github.com/apache/solr/pull/857#discussion_r930273716
##
solr/solrj/src/java/org/apache/solr/common/cloud/DigestZkACLProvider.java:
##
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
laminelam commented on code in PR #857:
URL: https://github.com/apache/solr/pull/857#discussion_r930273100
##
solr/solrj/src/java/org/apache/solr/common/cloud/DigestZkACLProvider.java:
##
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
laminelam commented on code in PR #857:
URL: https://github.com/apache/solr/pull/857#discussion_r930270525
##
solr/solrj/src/java/org/apache/solr/common/cloud/ZkCredentialsInjector.java:
##
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mo
[
https://issues.apache.org/jira/browse/SOLR-15727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571559#comment-17571559
]
Shawn Heisey commented on SOLR-15727:
-
If you do a manual hard commit, openSearcher a
Eric Pugh created SOLR-16314:
Summary: Annotations like @Before etc should be public visiblity
Key: SOLR-16314
URL: https://issues.apache.org/jira/browse/SOLR-16314
Project: Solr
Issue Type: Sub-
madrob commented on PR #947:
URL: https://github.com/apache/solr/pull/947#issuecomment-1195756067
See also https://github.com/apache/lucene/pull/1049 and LUCENE-10662
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
epugh opened a new pull request, #953:
URL: https://github.com/apache/solr/pull/953
https://issues.apache.org/jira/browse/SOLR-16311
# Description
This may be very stylistic in a nature, some people may like the
`assertTrue` used everywhere, instead of using the various conditi
Mike Drob created SOLR-16313:
Summary: RequestStatus.waitFor should accept a poll interval
Key: SOLR-16313
URL: https://issues.apache.org/jira/browse/SOLR-16313
Project: Solr
Issue Type: Task
[
https://issues.apache.org/jira/browse/SOLR-16245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alessandro Benedetti reassigned SOLR-16245:
---
Assignee: Alessandro Benedetti
> Make DenseVectorField codec agnostic
>
[
https://issues.apache.org/jira/browse/SOLR-16245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alessandro Benedetti resolved SOLR-16245.
-
Resolution: Done
Merged and builds are happy! closing
> Make DenseVectorField co
[
https://issues.apache.org/jira/browse/SOLR-16245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alessandro Benedetti updated SOLR-16245:
Fix Version/s: 9.1
> Make DenseVectorField codec agnostic
> ---
[
https://issues.apache.org/jira/browse/SOLR-16246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alessandro Benedetti resolved SOLR-16246.
-
Resolution: Done
merged and buld are happy! closing
> Implement pre-filtering fu
[
https://issues.apache.org/jira/browse/SOLR-16246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alessandro Benedetti reassigned SOLR-16246:
---
Assignee: Alessandro Benedetti
> Implement pre-filtering functionallity for
[
https://issues.apache.org/jira/browse/SOLR-16246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alessandro Benedetti updated SOLR-16246:
Fix Version/s: 9.1
> Implement pre-filtering functionallity for KnnQParser
> --
Mike Drob created SOLR-16312:
Summary: Merge AbstractDistribZkTestBase and
AbstractFullDistribZkTestBase
Key: SOLR-16312
URL: https://issues.apache.org/jira/browse/SOLR-16312
Project: Solr
Issue
[
https://issues.apache.org/jira/browse/SOLR-15727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571517#comment-17571517
]
Shawn Heisey commented on SOLR-15727:
-
Code says that the default for openSearcher on
Eric Pugh created SOLR-16311:
Summary: Simplify logic in asserts by using most specific form
Key: SOLR-16311
URL: https://issues.apache.org/jira/browse/SOLR-16311
Project: Solr
Issue Type: Sub-ta
epugh commented on PR #947:
URL: https://github.com/apache/solr/pull/947#issuecomment-1195594149
@cpoerschke I'd love a review, I think this is ready!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/SOLR-15727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571477#comment-17571477
]
Don commented on SOLR-15727:
[~houston] I just checked our solrconfig.xml file and the only p
[
https://issues.apache.org/jira/browse/SOLR-16307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571474#comment-17571474
]
Mike Drob commented on SOLR-16307:
--
The list of supported languages for code blocks is b
[
https://issues.apache.org/jira/browse/SOLR-16307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob updated SOLR-16307:
-
Summary: ref guide powershell blocks don't have syntax highlighting (was:
ref guide powershelgl blocks d
epugh commented on PR #947:
URL: https://github.com/apache/solr/pull/947#issuecomment-1195548367
So, I am rethinking this PR... I think I was falling into the trap of
having too many different changes in one PR... So, I'm going to remove the
task "Double check all the files for other ass
danrosher commented on PR #936:
URL: https://github.com/apache/solr/pull/936#issuecomment-1195527186
Will do @epugh . I'll be away for a week after that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
epugh commented on PR #875:
URL: https://github.com/apache/solr/pull/875#issuecomment-1195507681
@andywebb1975 getting back to this... So, I think the use case here is
that if, over time, I want to change my warming queries, I can do it at run
time, correct? So the exciting, powerful th
epugh commented on PR #936:
URL: https://github.com/apache/solr/pull/936#issuecomment-1195499450
Let's give it another few days, and then, if I don't review/merge it, can
you bug me? Say Thursday??? Thanks for this @danrosher
--
This is an automated message from the Apache Git Service
[
https://issues.apache.org/jira/browse/SOLR-16220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571435#comment-17571435
]
Eric Pugh commented on SOLR-16220:
--
https://search.maven.org/solrsearch/select?q=guice&r
[
https://issues.apache.org/jira/browse/SOLR-15727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571430#comment-17571430
]
Manas Ajwalia commented on SOLR-15727:
--
Kindly try once by *reloading a collection*
[
https://issues.apache.org/jira/browse/SOLR-16220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571389#comment-17571389
]
Philip Dakowitz commented on SOLR-16220:
We're facing the same issue and would ap
41 matches
Mail list logo
