[GitHub] [solr] risdenk commented on a diff in pull request #1184: SOLR-16555: SolrIndexSearcher - FilterCache intersections/andNot should not clone bitsets repeatedly

risdenk commented on code in PR #1184: URL: https://github.com/apache/solr/pull/1184#discussion_r1026961673 ## solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java: ## @@ -1190,38 +1187,53 @@ public ProcessedFilter getProcessedFilter(DocSet setFilter, List queries)

[jira] [Commented] (SOLR-16555) SolrIndexSearcher - FilterCache intersections/andNot should not clone bitsets repeatedly

[ https://issues.apache.org/jira/browse/SOLR-16555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636064#comment-17636064 ] Kevin Risden commented on SOLR-16555: - https://github.com/apache/solr/pull/1184 is th

[GitHub] [solr] risdenk commented on pull request #1184: SOLR-16555: SolrIndexSearcher - FilterCache intersections/andNot should not clone bitsets repeatedly

risdenk commented on PR #1184: URL: https://github.com/apache/solr/pull/1184#issuecomment-1320600677 So I reran this update especially after f1fe35c but included the review changes as well. Memory allocation is no longer dominated by getProcessedFilter. I'd share screenshots, but cus

[GitHub] [solr] risdenk commented on a diff in pull request #1184: SOLR-16555: SolrIndexSearcher - FilterCache intersections/andNot should not clone bitsets repeatedly

risdenk commented on code in PR #1184: URL: https://github.com/apache/solr/pull/1184#discussion_r1026840953 ## solr/core/src/java/org/apache/solr/search/MutableBitDocSet.java: ## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * cont

[GitHub] [solr] risdenk commented on a diff in pull request #1184: SOLR-16555: SolrIndexSearcher - FilterCache intersections/andNot should not clone bitsets repeatedly

risdenk commented on code in PR #1184: URL: https://github.com/apache/solr/pull/1184#discussion_r1026840803 ## solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java: ## @@ -1211,17 +1211,28 @@ public ProcessedFilter getProcessedFilter(DocSet setFilter, List queries)

[GitHub] [solr] risdenk commented on a diff in pull request #1184: SOLR-16555: SolrIndexSearcher - FilterCache intersections/andNot should not clone bitsets repeatedly

risdenk commented on code in PR #1184: URL: https://github.com/apache/solr/pull/1184#discussion_r1026817305 ## solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java: ## @@ -1211,17 +1211,28 @@ public ProcessedFilter getProcessedFilter(DocSet setFilter, List queries)

[GitHub] [solr] dsmiley commented on a diff in pull request #1184: SOLR-16555: SolrIndexSearcher - FilterCache intersections/andNot should not clone bitsets repeatedly

dsmiley commented on code in PR #1184: URL: https://github.com/apache/solr/pull/1184#discussion_r1026822293 ## solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java: ## @@ -1211,17 +1211,22 @@ public ProcessedFilter getProcessedFilter(DocSet setFilter, List queries)

[GitHub] [solr] risdenk commented on pull request #1184: SOLR-16555: SolrIndexSearcher - FilterCache intersections/andNot should not clone bitsets repeatedly

risdenk commented on PR #1184: URL: https://github.com/apache/solr/pull/1184#issuecomment-1320455964 I ran this through some benchmarks - same one as the screenshots on SOLR-16555 and got the following: https://user-images.githubusercontent.com/3384157/202789352-1fb6af4c-28f3-44df-bc1

[GitHub] [solr] risdenk commented on a diff in pull request #1184: SOLR-16555: SolrIndexSearcher - FilterCache intersections/andNot should not clone bitsets repeatedly

risdenk commented on code in PR #1184: URL: https://github.com/apache/solr/pull/1184#discussion_r1026817479 ## solr/core/src/java/org/apache/solr/search/MutableBitDocSet.java: ## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * cont

[GitHub] [solr] risdenk commented on a diff in pull request #1184: SOLR-16555: SolrIndexSearcher - FilterCache intersections/andNot should not clone bitsets repeatedly

risdenk commented on code in PR #1184: URL: https://github.com/apache/solr/pull/1184#discussion_r1026817305 ## solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java: ## @@ -1211,17 +1211,28 @@ public ProcessedFilter getProcessedFilter(DocSet setFilter, List queries)

[GitHub] [solr] dsmiley commented on a diff in pull request #1184: SOLR-16555: SolrIndexSearcher - FilterCache intersections/andNot should not clone bitsets repeatedly

dsmiley commented on code in PR #1184: URL: https://github.com/apache/solr/pull/1184#discussion_r1026790611 ## solr/core/src/java/org/apache/solr/search/MutableBitDocSet.java: ## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * cont

[jira] [Commented] (SOLR-16553) SolrTestCaseJ4 solr.install.dir property not initialized

[ https://issues.apache.org/jira/browse/SOLR-16553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17635982#comment-17635982 ] Kevin Risden commented on SOLR-16553: - Based on looking for `solr.install.dir` and So

[GitHub] [solr] risdenk commented on a diff in pull request #1184: SOLR-16555: SolrIndexSearcher - FilterCache intersections/andNot should not clone bitsets repeatedly

risdenk commented on code in PR #1184: URL: https://github.com/apache/solr/pull/1184#discussion_r1026723125 ## solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java: ## @@ -1211,17 +1211,22 @@ public ProcessedFilter getProcessedFilter(DocSet setFilter, List queries)

[GitHub] [solr] risdenk commented on a diff in pull request #1184: SOLR-16555: SolrIndexSearcher - FilterCache intersections/andNot should not clone bitsets repeatedly

risdenk commented on code in PR #1184: URL: https://github.com/apache/solr/pull/1184#discussion_r1026722477 ## solr/core/src/java/org/apache/solr/search/MutableBitDocSet.java: ## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * cont

[jira] [Commented] (SOLR-16498) Tests need the URL from a SolrClient; don't require legacy clients

[ https://issues.apache.org/jira/browse/SOLR-16498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17635967#comment-17635967 ] Joshua Ouma commented on SOLR-16498: I have searched the codebase and it seems only {

[GitHub] [solr] risdenk closed pull request #1183: SOLR-16555: SolrIndexSearcher - FilterCache intersections/andNot should not clone bitsets repeatedly

risdenk closed pull request #1183: SOLR-16555: SolrIndexSearcher - FilterCache intersections/andNot should not clone bitsets repeatedly URL: https://github.com/apache/solr/pull/1183 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [solr] risdenk commented on pull request #1183: SOLR-16555: SolrIndexSearcher - FilterCache intersections/andNot should not clone bitsets repeatedly

risdenk commented on PR #1183: URL: https://github.com/apache/solr/pull/1183#issuecomment-1320309454 This is inefficient as David pointed out and caused timeouts on a bunch of queries during testing. I was hoping to at least capture some profile from it but didn't last long enough to do tha

[GitHub] [solr] risdenk commented on a diff in pull request #1184: SOLR-16555: SolrIndexSearcher - FilterCache intersections/andNot should not clone bitsets repeatedly

risdenk commented on code in PR #1184: URL: https://github.com/apache/solr/pull/1184#discussion_r1026687927 ## solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java: ## @@ -1211,17 +1211,22 @@ public ProcessedFilter getProcessedFilter(DocSet setFilter, List queries)

[GitHub] [solr] risdenk commented on a diff in pull request #1184: SOLR-16555: SolrIndexSearcher - FilterCache intersections/andNot should not clone bitsets repeatedly

risdenk commented on code in PR #1184: URL: https://github.com/apache/solr/pull/1184#discussion_r1026682252 ## solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java: ## @@ -1211,17 +1211,22 @@ public ProcessedFilter getProcessedFilter(DocSet setFilter, List queries)

[GitHub] [solr] dsmiley commented on a diff in pull request #1184: SOLR-16555: SolrIndexSearcher - FilterCache intersections/andNot should not clone bitsets repeatedly

dsmiley commented on code in PR #1184: URL: https://github.com/apache/solr/pull/1184#discussion_r1026647448 ## solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java: ## @@ -1211,17 +1211,22 @@ public ProcessedFilter getProcessedFilter(DocSet setFilter, List queries)

[jira] [Commented] (SOLR-16555) SolrIndexSearcher - FilterCache intersections/andNot should not clone bitsets repeatedly

[ https://issues.apache.org/jira/browse/SOLR-16555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17635928#comment-17635928 ] Kevin Risden commented on SOLR-16555: - MutableBitDocSet idea from David is implemente

[GitHub] [solr] risdenk commented on pull request #1184: SOLR-16555: SolrIndexSearcher - FilterCache intersections/andNot should not clone bitsets repeatedly

risdenk commented on PR #1184: URL: https://github.com/apache/solr/pull/1184#issuecomment-1320218975 @dsmiley here is the `MutableBitDocSet` version. I'll consolidate down to one PR once I do some testing and get some perf numbers. I just pushed it up separate to get some eyes on it. --

[GitHub] [solr] risdenk commented on a diff in pull request #1184: SOLR-16555: SolrIndexSearcher - FilterCache intersections/andNot should not clone bitsets repeatedly

risdenk commented on code in PR #1184: URL: https://github.com/apache/solr/pull/1184#discussion_r1026607957 ## solr/core/src/java/org/apache/solr/search/MutableBitDocSet.java: ## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * cont

[GitHub] [solr] risdenk opened a new pull request, #1184: SOLR-16555: SolrIndexSearcher - FilterCache intersections/andNot should not clone bitsets repeatedly

risdenk opened a new pull request, #1184: URL: https://github.com/apache/solr/pull/1184 https://issues.apache.org/jira/browse/SOLR-16555 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[jira] [Commented] (SOLR-16549) Solr core memory usage study

[ https://issues.apache.org/jira/browse/SOLR-16549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17635844#comment-17635844 ] Ilan Ginzburg commented on SOLR-16549: -- Based on the heap usage table it seems each

[GitHub] [solr-operator] ollixy commented on issue #489: Add support to set capabilities on Solr cloud container's security context

ollixy commented on issue #489: URL: https://github.com/apache/solr-operator/issues/489#issuecomment-1319777609 @HoustonPutman is support for setting capabilities on the pod security context confirmed to be added eventually (and if it is, is there already an indication on when)? Or is this