[GitHub] [solr-operator] vipul-06 opened a new issue, #501: Apache-solr:Solr-exporter

2022-12-05 Thread GitBox
vipul-06 opened a new issue, #501: URL: https://github.com/apache/solr-operator/issues/501 I have deployed solr cloud using helm in gke cluster, below are the steps for deploying which I used (1) helm repo add apache-solr https://solr.apache.org/charts (2) kubectl create -f ht

[GitHub] [solr] dsmiley commented on a diff in pull request #1208: SOLR-16571: Add java system property to disable config watch

2022-12-05 Thread GitBox
dsmiley commented on code in PR #1208: URL: https://github.com/apache/solr/pull/1208#discussion_r1040469355 ## solr/core/src/java/org/apache/solr/core/SolrCore.java: ## @@ -188,6 +188,7 @@ public class SolrCore implements SolrInfoBean, Closeable { public static final Strin

[jira] [Comment Edited] (SOLR-16556) Solr stream expression: Implement Page Streaming Decorator to allow results to be displayed with pagination.

2022-12-05 Thread Maulin (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643659#comment-17643659 ] Maulin edited comment on SOLR-16556 at 12/6/22 4:55 AM: Hi [~epug

[jira] [Commented] (SOLR-16556) Solr stream expression: Implement Page Streaming Decorator to allow results to be displayed with pagination.

2022-12-05 Thread Maulin (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643659#comment-17643659 ] Maulin commented on SOLR-16556: --- Hi [~epugh]   I have taken reading with a collection (ord

[jira] [Updated] (SOLR-16556) Solr stream expression: Implement Page Streaming Decorator to allow results to be displayed with pagination.

2022-12-05 Thread Maulin (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maulin updated SOLR-16556: -- Attachment: Page Decorator Performance Reading.xlsx > Solr stream expression: Implement Page Streaming Decorato

[jira] [Commented] (SOLR-15732) queries to missing collection are slow

2022-12-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643647#comment-17643647 ] ASF subversion and git services commented on SOLR-15732: Commit f

[jira] [Commented] (SOLR-15732) queries to missing collection are slow

2022-12-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643646#comment-17643646 ] ASF subversion and git services commented on SOLR-15732: Commit 7

[GitHub] [solr] noblepaul merged pull request #1207: SOLR-15732: queries to missing collection are slow

2022-12-05 Thread GitBox
noblepaul merged PR #1207: URL: https://github.com/apache/solr/pull/1207 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.

[GitHub] [solr] dsmiley commented on a diff in pull request #1048: SOLR-16438: Support optional split.setPreferredLeaders prop in shard split command.

2022-12-05 Thread GitBox
dsmiley commented on code in PR #1048: URL: https://github.com/apache/solr/pull/1048#discussion_r1040413560 ## solr/core/src/java/org/apache/solr/update/processor/DistributedZkUpdateProcessor.java: ## @@ -1205,7 +1205,6 @@ private void doDefensiveChecks(DistribPhase phase) {

[GitHub] [solr] dsmiley commented on pull request #1211: SOLR-8975: Use Builder Pattern with Solr Clients

2022-12-05 Thread GitBox
dsmiley commented on PR #1211: URL: https://github.com/apache/solr/pull/1211#issuecomment-1338673045 It would be nice if the scope of this PR could be clearer -- like the setters (... specify here ...) on all SolrClients are now supported on the Builder of these SolrClients, and their sette

[GitHub] [solr] dsmiley commented on a diff in pull request #146: SOLR-15787: Implement FileSystemConfigSetService

2022-12-05 Thread GitBox
dsmiley commented on code in PR #146: URL: https://github.com/apache/solr/pull/146#discussion_r1040336243 ## solr/core/src/java/org/apache/solr/core/FileSystemConfigSetService.java: ## @@ -287,9 +287,11 @@ public Long getCurrentSchemaModificationVersion( } protected Path

[jira] [Commented] (SOLR-16551) Provide a way to disable the PKIAuthenticationPlugin

2022-12-05 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643598#comment-17643598 ] Jan Høydahl commented on SOLR-16551: The TTL is also a security feature in that it na

[jira] [Deleted] (SOLR-12764) refer main query params for [subquery]

2022-12-05 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Khludnev deleted SOLR-12764: > refer main query params for [subquery] > -- > >

[GitHub] [solr] sonatype-lift[bot] commented on a diff in pull request #146: SOLR-15787: Implement FileSystemConfigSetService

2022-12-05 Thread GitBox
sonatype-lift[bot] commented on code in PR #146: URL: https://github.com/apache/solr/pull/146#discussion_r1040099885 ## solr/core/src/java/org/apache/solr/core/FileSystemConfigSetService.java: ## @@ -148,4 +285,13 @@ protected Long getCurrentSchemaModificationVersion( ret

[jira] [Commented] (SOLR-16551) Provide a way to disable the PKIAuthenticationPlugin

2022-12-05 Thread Alex Deparvu (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643554#comment-17643554 ] Alex Deparvu commented on SOLR-16551: - Thank you for clarifying [~houston] it is taki

[GitHub] [solr] stillalex commented on pull request #1211: SOLR-8975: Use Builder Pattern with Solr Clients

2022-12-05 Thread GitBox
stillalex commented on PR #1211: URL: https://github.com/apache/solr/pull/1211#issuecomment-1338148884 looks good to me! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [solr] stillalex commented on a diff in pull request #1211: SOLR-8975: Use Builder Pattern with Solr Clients

2022-12-05 Thread GitBox
stillalex commented on code in PR #1211: URL: https://github.com/apache/solr/pull/1211#discussion_r1040083573 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBHttp2SolrClient.java: ## @@ -88,23 +89,63 @@ public LBHttp2SolrClient(Http2SolrClient httpClient, String... b

[GitHub] [solr] epugh commented on pull request #1211: SOLR-8975: Use Builder Pattern with Solr Clients

2022-12-05 Thread GitBox
epugh commented on PR #1211: URL: https://github.com/apache/solr/pull/1211#issuecomment-1338126326 > > > I'm going to remove those two methods on the LBSolrClient > > > > > > sorry, I am not seeing any changes in LBSolrClient, if not removing maybe marking as deprecated for future

[GitHub] [solr] epugh commented on pull request #1211: SOLR-8975: Use Builder Pattern with Solr Clients

2022-12-05 Thread GitBox
epugh commented on PR #1211: URL: https://github.com/apache/solr/pull/1211#issuecomment-1338116411 > > I'm going to remove those two methods on the LBSolrClient > > sorry, I am not seeing any changes in LBSolrClient, if not removing maybe marking as deprecated for future removal.

[GitHub] [solr] epugh commented on a diff in pull request #1211: SOLR-8975: Use Builder Pattern with Solr Clients

2022-12-05 Thread GitBox
epugh commented on code in PR #1211: URL: https://github.com/apache/solr/pull/1211#discussion_r1040052738 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBHttp2SolrClient.java: ## @@ -88,23 +89,63 @@ public LBHttp2SolrClient(Http2SolrClient httpClient, String... baseS

[jira] [Commented] (SOLR-16347) Add JAX-RS integration for defining v2 APIs

2022-12-05 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643531#comment-17643531 ] Ishan Chattopadhyaya commented on SOLR-16347: - bq. I promise to start the re

[jira] [Commented] (SOLR-16347) Add JAX-RS integration for defining v2 APIs

2022-12-05 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643530#comment-17643530 ] Jason Gerlowski commented on SOLR-16347: Thanks for suggesting the Jan 11th "dead

[GitHub] [solr] stillalex commented on a diff in pull request #1211: SOLR-8975: Use Builder Pattern with Solr Clients

2022-12-05 Thread GitBox
stillalex commented on code in PR #1211: URL: https://github.com/apache/solr/pull/1211#discussion_r1040002378 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBHttp2SolrClient.java: ## @@ -88,23 +89,63 @@ public LBHttp2SolrClient(Http2SolrClient httpClient, String... b

[GitHub] [solr] stillalex commented on pull request #1211: SOLR-8975: Use Builder Pattern with Solr Clients

2022-12-05 Thread GitBox
stillalex commented on PR #1211: URL: https://github.com/apache/solr/pull/1211#issuecomment-1338033643 > I'm going to remove those two methods on the LBSolrClient sorry, I am not seeing any changes in LBSolrClient, if not removing maybe marking as deprecated for future removal.

[GitHub] [solr] epugh commented on a diff in pull request #1211: SOLR-8975: Use Builder Pattern with Solr Clients

2022-12-05 Thread GitBox
epugh commented on code in PR #1211: URL: https://github.com/apache/solr/pull/1211#discussion_r1039994242 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBHttp2SolrClient.java: ## @@ -88,23 +89,63 @@ public LBHttp2SolrClient(Http2SolrClient httpClient, String... baseS

[jira] [Comment Edited] (SOLR-16347) Add JAX-RS integration for defining v2 APIs

2022-12-05 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643515#comment-17643515 ] Noble Paul edited comment on SOLR-16347 at 12/5/22 7:09 PM: {

[jira] [Commented] (SOLR-16347) Add JAX-RS integration for defining v2 APIs

2022-12-05 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643518#comment-17643518 ] Ishan Chattopadhyaya commented on SOLR-16347: - Sure, I withdraw my veto based

[jira] [Commented] (SOLR-16347) Add JAX-RS integration for defining v2 APIs

2022-12-05 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643515#comment-17643515 ] Noble Paul commented on SOLR-16347: --- {quote}I seriously doubt we are going to release 9

[jira] [Comment Edited] (SOLR-16347) Add JAX-RS integration for defining v2 APIs

2022-12-05 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643506#comment-17643506 ] Ishan Chattopadhyaya edited comment on SOLR-16347 at 12/5/22 6:44 PM: -

[GitHub] [solr] nginthfs commented on a diff in pull request #1205: SOLR-16569: Add java system property to overseer queue size

2022-12-05 Thread GitBox
nginthfs commented on code in PR #1205: URL: https://github.com/apache/solr/pull/1205#discussion_r1039949754 ## solr/core/src/java/org/apache/solr/cloud/Overseer.java: ## @@ -336,8 +337,8 @@ public void run() { for (Pair head : queue) { byte[] dat

[jira] [Commented] (SOLR-16347) Add JAX-RS integration for defining v2 APIs

2022-12-05 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643506#comment-17643506 ] Ishan Chattopadhyaya commented on SOLR-16347: - My biggest fear is that if I r

[GitHub] [solr] stillalex commented on a diff in pull request #1211: SOLR-8975: Use Builder Pattern with Solr Clients

2022-12-05 Thread GitBox
stillalex commented on code in PR #1211: URL: https://github.com/apache/solr/pull/1211#discussion_r1039938801 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBHttp2SolrClient.java: ## @@ -88,23 +89,63 @@ public LBHttp2SolrClient(Http2SolrClient httpClient, String... b

[GitHub] [solr] epugh commented on pull request #1211: SOLR-8975: Use Builder Pattern with Solr Clients

2022-12-05 Thread GitBox
epugh commented on PR #1211: URL: https://github.com/apache/solr/pull/1211#issuecomment-1337884722 Okay @stillalex and @dsmiley ... Thoughts now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [solr] debe commented on pull request #1155: [SOLR-16497] Allow finer grained locking in SolrCores

2022-12-05 Thread GitBox
debe commented on PR #1155: URL: https://github.com/apache/solr/pull/1155#issuecomment-1337880470 Basically the changes around the Handler are needed to get the read write locking correct. It's an all or nothing change. Even the smallest mistake could lead to a deadlock or missing cores. We

[GitHub] [solr] debe commented on pull request #1155: [SOLR-16497] Allow finer grained locking in SolrCores

2022-12-05 Thread GitBox
debe commented on PR #1155: URL: https://github.com/apache/solr/pull/1155#issuecomment-1337878673 Basically the changes around the Handler are needed to get the read write locking correct. It's an all or nothing change. Even the smallest mistake could lead to a deadlock or missing cores. We

[jira] [Commented] (SOLR-16347) Add JAX-RS integration for defining v2 APIs

2022-12-05 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643486#comment-17643486 ] Ishan Chattopadhyaya commented on SOLR-16347: - bq. You do have this right, bu

[GitHub] [solr] stillalex commented on pull request #1155: [SOLR-16497] Allow finer grained locking in SolrCores

2022-12-05 Thread GitBox
stillalex commented on PR #1155: URL: https://github.com/apache/solr/pull/1155#issuecomment-1337824454 I was surprised at the results too, but I figured it's just my limited understanding of this code :) . I think the benchmark is too basic in its approach to cover the PR correctly, so plea

[GitHub] [solr] stillalex commented on a diff in pull request #1211: SOLR-8975: Use Builder Pattern with Solr Clients

2022-12-05 Thread GitBox
stillalex commented on code in PR #1211: URL: https://github.com/apache/solr/pull/1211#discussion_r1039884568 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBHttp2SolrClient.java: ## @@ -258,4 +299,32 @@ public void onFailure(Throwable oe) { }

[GitHub] [solr] epugh commented on a diff in pull request #1211: SOLR-8975: Use Builder Pattern with Solr Clients

2022-12-05 Thread GitBox
epugh commented on code in PR #1211: URL: https://github.com/apache/solr/pull/1211#discussion_r1039879271 ## solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java: ## @@ -2871,10 +2871,30 @@ public static LBHttpSolrClient getLBHttpSolrClient(String... solrUrls)

[jira] [Commented] (SOLR-16347) Add JAX-RS integration for defining v2 APIs

2022-12-05 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643475#comment-17643475 ] Houston Putman commented on SOLR-16347: --- bq. If you plan to disable by default an A

[GitHub] [solr] dsmiley commented on a diff in pull request #1211: SOLR-8975: Use Builder Pattern with Solr Clients

2022-12-05 Thread GitBox
dsmiley commented on code in PR #1211: URL: https://github.com/apache/solr/pull/1211#discussion_r1039860132 ## solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java: ## @@ -2871,10 +2871,30 @@ public static LBHttpSolrClient getLBHttpSolrClient(String... solrUrls)

[GitHub] [solr] epugh commented on a diff in pull request #1211: SOLR-8975: Use Builder Pattern with Solr Clients

2022-12-05 Thread GitBox
epugh commented on code in PR #1211: URL: https://github.com/apache/solr/pull/1211#discussion_r1039871082 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBHttp2SolrClient.java: ## @@ -88,23 +89,63 @@ public LBHttp2SolrClient(Http2SolrClient httpClient, String... baseS

[jira] [Commented] (SOLR-16347) Add JAX-RS integration for defining v2 APIs

2022-12-05 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643467#comment-17643467 ] Ishan Chattopadhyaya commented on SOLR-16347: - bq. Making simplified claims

[jira] [Commented] (SOLR-16347) Add JAX-RS integration for defining v2 APIs

2022-12-05 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643462#comment-17643462 ] Ishan Chattopadhyaya commented on SOLR-16347: - bq. In terms of the veto, if y

[GitHub] [solr] dsmiley commented on a diff in pull request #1211: SOLR-8975: Use Builder Pattern with Solr Clients

2022-12-05 Thread GitBox
dsmiley commented on code in PR #1211: URL: https://github.com/apache/solr/pull/1211#discussion_r1039858105 ## solr/test-framework/src/java/org/apache/solr/BaseDistributedSearchTestCase.java: ## @@ -534,16 +534,15 @@ public SortedMap, String> getExtraRequestFilters() { }

[jira] [Commented] (SOLR-16473) Race condition in shard split when a sub-shard is put in recovery state

2022-12-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643460#comment-17643460 ] ASF subversion and git services commented on SOLR-16473: Commit 4

[GitHub] [solr] bruno-roustant merged pull request #1088: SOLR-16473: Fix race condition in shard split when a sub-shard is put in recovery state.

2022-12-05 Thread GitBox
bruno-roustant merged PR #1088: URL: https://github.com/apache/solr/pull/1088 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.ap

[GitHub] [solr] dsmiley commented on a diff in pull request #1211: SOLR-8975: Use Builder Pattern with Solr Clients

2022-12-05 Thread GitBox
dsmiley commented on code in PR #1211: URL: https://github.com/apache/solr/pull/1211#discussion_r1039855030 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBHttp2SolrClient.java: ## @@ -258,4 +299,32 @@ public void onFailure(Throwable oe) { }

[GitHub] [solr] dsmiley commented on a diff in pull request #1211: SOLR-8975: Use Builder Pattern with Solr Clients

2022-12-05 Thread GitBox
dsmiley commented on code in PR #1211: URL: https://github.com/apache/solr/pull/1211#discussion_r1039853213 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBHttp2SolrClient.java: ## @@ -88,23 +89,63 @@ public LBHttp2SolrClient(Http2SolrClient httpClient, String... bas

[GitHub] [solr] dsmiley commented on a diff in pull request #1211: SOLR-8975: Use Builder Pattern with Solr Clients

2022-12-05 Thread GitBox
dsmiley commented on code in PR #1211: URL: https://github.com/apache/solr/pull/1211#discussion_r1039832255 ## solr/core/src/test/org/apache/solr/request/TestRemoteStreaming.java: ## @@ -116,8 +116,10 @@ public void testNoUrlAccess() throws Exception { SolrQuery query = new

[GitHub] [solr] nosvalds opened a new pull request, #1214: SOLR-16576: Add information about large StrField configuration to documentation

2022-12-05 Thread GitBox
nosvalds opened a new pull request, #1214: URL: https://github.com/apache/solr/pull/1214 https://issues.apache.org/jira/browse/SOLR-16576 # Description The existing documentation for the `StrField` field type makes some assumptions about the configuration and steers

[GitHub] [solr] stillalex commented on a diff in pull request #1211: SOLR-8975: Use Builder Pattern with Solr Clients

2022-12-05 Thread GitBox
stillalex commented on code in PR #1211: URL: https://github.com/apache/solr/pull/1211#discussion_r1039812882 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBHttp2SolrClient.java: ## @@ -88,23 +89,63 @@ public LBHttp2SolrClient(Http2SolrClient httpClient, String... b

[GitHub] [solr] stillalex commented on a diff in pull request #1211: SOLR-8975: Use Builder Pattern with Solr Clients

2022-12-05 Thread GitBox
stillalex commented on code in PR #1211: URL: https://github.com/apache/solr/pull/1211#discussion_r1039812882 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBHttp2SolrClient.java: ## @@ -88,23 +89,63 @@ public LBHttp2SolrClient(Http2SolrClient httpClient, String... b

[GitHub] [solr] stillalex commented on a diff in pull request #1211: SOLR-8975: Use Builder Pattern with Solr Clients

2022-12-05 Thread GitBox
stillalex commented on code in PR #1211: URL: https://github.com/apache/solr/pull/1211#discussion_r1039797943 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBHttp2SolrClient.java: ## @@ -88,23 +89,63 @@ public LBHttp2SolrClient(Http2SolrClient httpClient, String... b

[GitHub] [solr] stillalex commented on a diff in pull request #1211: SOLR-8975: Use Builder Pattern with Solr Clients

2022-12-05 Thread GitBox
stillalex commented on code in PR #1211: URL: https://github.com/apache/solr/pull/1211#discussion_r1039797943 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBHttp2SolrClient.java: ## @@ -88,23 +89,63 @@ public LBHttp2SolrClient(Http2SolrClient httpClient, String... b

[GitHub] [solr] epugh commented on pull request #1211: SOLR-8975: Use Builder Pattern with Solr Clients

2022-12-05 Thread GitBox
epugh commented on PR #1211: URL: https://github.com/apache/solr/pull/1211#issuecomment-1337579391 @dsmiley I think I've responded to all your comments, thanks for doing that. The only i think big outstanding issue is the question about the two LB clients... Does it ever make sense to c

[jira] [Assigned] (SOLR-16576) Improve StrField field type documentation for large string storage

2022-12-05 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Gibney reassigned SOLR-16576: - Assignee: Michael Gibney > Improve StrField field type documentation for large string st

[GitHub] [solr] epugh commented on a diff in pull request #1211: SOLR-8975: Use Builder Pattern with Solr Clients

2022-12-05 Thread GitBox
epugh commented on code in PR #1211: URL: https://github.com/apache/solr/pull/1211#discussion_r1039737488 ## solr/solrj/src/test/org/apache/solr/client/solrj/impl/BasicHttpSolrClientTest.java: ## @@ -476,9 +484,20 @@ public void testUpdate() throws Exception { // paramete

[GitHub] [solr] magibney commented on a diff in pull request #1205: SOLR-16569: Add java system property to overseer queue size

2022-12-05 Thread GitBox
magibney commented on code in PR #1205: URL: https://github.com/apache/solr/pull/1205#discussion_r1039729084 ## solr/core/src/java/org/apache/solr/cloud/Overseer.java: ## @@ -336,8 +337,8 @@ public void run() { for (Pair head : queue) { byte[] dat

[GitHub] [solr] epugh commented on a diff in pull request #1211: SOLR-8975: Use Builder Pattern with Solr Clients

2022-12-05 Thread GitBox
epugh commented on code in PR #1211: URL: https://github.com/apache/solr/pull/1211#discussion_r1039717680 ## solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java: ## @@ -2886,28 +2906,25 @@ public static HttpSolrClient getHttpSolrClient( } /** - * This meth

[GitHub] [solr] epugh commented on a diff in pull request #1211: SOLR-8975: Use Builder Pattern with Solr Clients

2022-12-05 Thread GitBox
epugh commented on code in PR #1211: URL: https://github.com/apache/solr/pull/1211#discussion_r1039715151 ## solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java: ## @@ -2871,10 +2871,30 @@ public static LBHttpSolrClient getLBHttpSolrClient(String... solrUrls)

[jira] [Comment Edited] (SOLR-16347) Add JAX-RS integration for defining v2 APIs

2022-12-05 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643380#comment-17643380 ] Jason Gerlowski edited comment on SOLR-16347 at 12/5/22 3:03 PM: --

[GitHub] [solr] epugh commented on a diff in pull request #1211: SOLR-8975: Use Builder Pattern with Solr Clients

2022-12-05 Thread GitBox
epugh commented on code in PR #1211: URL: https://github.com/apache/solr/pull/1211#discussion_r1039711167 ## solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java: ## @@ -2871,10 +2871,30 @@ public static LBHttpSolrClient getLBHttpSolrClient(String... solrUrls)

[GitHub] [solr] epugh commented on a diff in pull request #1211: SOLR-8975: Use Builder Pattern with Solr Clients

2022-12-05 Thread GitBox
epugh commented on code in PR #1211: URL: https://github.com/apache/solr/pull/1211#discussion_r1039704639 ## solr/test-framework/src/java/org/apache/solr/BaseDistributedSearchTestCase.java: ## @@ -534,16 +534,15 @@ public SortedMap, String> getExtraRequestFilters() { }

[GitHub] [solr] epugh commented on a diff in pull request #1211: SOLR-8975: Use Builder Pattern with Solr Clients

2022-12-05 Thread GitBox
epugh commented on code in PR #1211: URL: https://github.com/apache/solr/pull/1211#discussion_r1039704639 ## solr/test-framework/src/java/org/apache/solr/BaseDistributedSearchTestCase.java: ## @@ -534,16 +534,15 @@ public SortedMap, String> getExtraRequestFilters() { }

[GitHub] [solr] epugh commented on a diff in pull request #1211: SOLR-8975: Use Builder Pattern with Solr Clients

2022-12-05 Thread GitBox
epugh commented on code in PR #1211: URL: https://github.com/apache/solr/pull/1211#discussion_r1039703992 ## solr/solrj/src/test/org/apache/solr/client/solrj/embedded/SolrExampleJettyTest.java: ## @@ -120,72 +112,22 @@ public void testUtf8PerfDegradation() throws Exception {

[GitHub] [solr] epugh commented on a diff in pull request #1211: SOLR-8975: Use Builder Pattern with Solr Clients

2022-12-05 Thread GitBox
epugh commented on code in PR #1211: URL: https://github.com/apache/solr/pull/1211#discussion_r1039703254 ## solr/solrj/src/test/org/apache/solr/client/solrj/TestSolrJErrorHandling.java: ## @@ -102,18 +102,23 @@ public void showExceptions() throws Exception { @Test publi

[GitHub] [solr] epugh commented on a diff in pull request #1211: SOLR-8975: Use Builder Pattern with Solr Clients

2022-12-05 Thread GitBox
epugh commented on code in PR #1211: URL: https://github.com/apache/solr/pull/1211#discussion_r1039702040 ## solr/solrj/src/test/org/apache/solr/client/solrj/TestBatchUpdate.java: ## @@ -46,61 +46,68 @@ public static void beforeTest() throws Exception { @Test public void

[jira] [Comment Edited] (SOLR-16347) Add JAX-RS integration for defining v2 APIs

2022-12-05 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643380#comment-17643380 ] Jason Gerlowski edited comment on SOLR-16347 at 12/5/22 2:53 PM: --

[GitHub] [solr] epugh commented on a diff in pull request #1211: SOLR-8975: Use Builder Pattern with Solr Clients

2022-12-05 Thread GitBox
epugh commented on code in PR #1211: URL: https://github.com/apache/solr/pull/1211#discussion_r1039698417 ## solr/solrj/src/test/org/apache/solr/client/solrj/SolrSchemalessExampleTest.java: ## @@ -132,20 +132,14 @@ public void testFieldMutating() throws Exception { @Overrid

[jira] [Commented] (SOLR-16347) Add JAX-RS integration for defining v2 APIs

2022-12-05 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643380#comment-17643380 ] Jason Gerlowski commented on SOLR-16347: Sure - to clarify I wasn't "alleging" an

[GitHub] [solr] nginthfs commented on a diff in pull request #1205: SOLR-16569: Add java system property to overseer queue size

2022-12-05 Thread GitBox
nginthfs commented on code in PR #1205: URL: https://github.com/apache/solr/pull/1205#discussion_r1039694008 ## solr/core/src/java/org/apache/solr/cloud/Overseer.java: ## @@ -336,8 +337,8 @@ public void run() { for (Pair head : queue) { byte[] dat

[GitHub] [solr] gabrielmagno commented on pull request #1213: SOLR-16574: Demonstrate Dense Vectors and KNN as part of the Films example

2022-12-05 Thread GitBox
gabrielmagno commented on PR #1213: URL: https://github.com/apache/solr/pull/1213#issuecomment-1337499929 Having a builtin model loader and vector encoder in Solr would be amazing! Regarding the current vector example, how about I recreate the vectors with the 1-algorithm solution (ex

[jira] [Updated] (SOLR-16576) Improve StrField field type documentation for large string storage

2022-12-05 Thread Nikolas Osvalds (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nikolas Osvalds updated SOLR-16576: --- Description: The existing documentation for the `StrField` field type makes some assumptions

[GitHub] [solr] epugh commented on a diff in pull request #1211: SOLR-8975: Use Builder Pattern with Solr Clients

2022-12-05 Thread GitBox
epugh commented on code in PR #1211: URL: https://github.com/apache/solr/pull/1211#discussion_r1039669909 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/SolrClientBuilder.java: ## @@ -28,8 +30,12 @@ protected HttpClient httpClient; protected ResponseParser resp

[GitHub] [solr] epugh commented on a diff in pull request #1211: SOLR-8975: Use Builder Pattern with Solr Clients

2022-12-05 Thread GitBox
epugh commented on code in PR #1211: URL: https://github.com/apache/solr/pull/1211#discussion_r1039667900 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBHttp2SolrClient.java: ## @@ -258,4 +299,32 @@ public void onFailure(Throwable oe) { }

[GitHub] [solr] epugh commented on a diff in pull request #1211: SOLR-8975: Use Builder Pattern with Solr Clients

2022-12-05 Thread GitBox
epugh commented on code in PR #1211: URL: https://github.com/apache/solr/pull/1211#discussion_r1039660985 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java: ## @@ -62,6 +64,12 @@ protected CloudHttp2SolrClient(Builder builder) { this.clien

[GitHub] [solr] epugh commented on pull request #1213: SOLR-16574: Demonstrate Dense Vectors and KNN as part of the Films example

2022-12-05 Thread GitBox
epugh commented on PR #1213: URL: https://github.com/apache/solr/pull/1213#issuecomment-1337446213 i think I'm mostly thinking, what if I add a new movie to the list... or want to play with it, can we provide that script as well? I sometimes dream that the vecotrization process is suppo

[GitHub] [solr] gabrielmagno commented on pull request #1213: SOLR-16574: Demonstrate Dense Vectors and KNN as part of the Films example

2022-12-05 Thread GitBox
gabrielmagno commented on PR #1213: URL: https://github.com/apache/solr/pull/1213#issuecomment-1337440280 @epugh for this version I combined two "example" models (BERT + item2vec), just to server as an example. If we are willing provide the instructions on how to create the models and

[GitHub] [solr] epugh commented on a diff in pull request #1211: SOLR-8975: Use Builder Pattern with Solr Clients

2022-12-05 Thread GitBox
epugh commented on code in PR #1211: URL: https://github.com/apache/solr/pull/1211#discussion_r1039646202 ## solr/core/src/test/org/apache/solr/request/TestRemoteStreaming.java: ## @@ -116,8 +116,10 @@ public void testNoUrlAccess() throws Exception { SolrQuery query = new S

[GitHub] [solr] epugh commented on a diff in pull request #1211: SOLR-8975: Use Builder Pattern with Solr Clients

2022-12-05 Thread GitBox
epugh commented on code in PR #1211: URL: https://github.com/apache/solr/pull/1211#discussion_r1039635774 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java: ## @@ -132,6 +141,8 @@ public static class Builder { protected boolean parallelUpdat

[GitHub] [solr] epugh commented on pull request #1213: SOLR-16574: Demonstrate Dense Vectors and KNN as part of the Films example

2022-12-05 Thread GitBox
epugh commented on PR #1213: URL: https://github.com/apache/solr/pull/1213#issuecomment-1337388716 How hard would it be to include the steps you did for vectorization? I notice that most tutorials start with the vectors... However, what if I wanted to play with this example and add my ow

[GitHub] [solr] gabrielmagno commented on pull request #1213: SOLR-16574: Demonstrate Dense Vectors and KNN as part of the Films example

2022-12-05 Thread GitBox
gabrielmagno commented on PR #1213: URL: https://github.com/apache/solr/pull/1213#issuecomment-1337336214 I tried running `gradlew check`, but got an error that I don't think is related to the changes of this PR: ``` > Task :solr:solr-ref-guide:buildLocalAntoraSite FAILED /home/gab

[GitHub] [solr] gabrielmagno opened a new pull request, #1213: SOLR-16574: Demonstrate Dense Vectors and KNN as part of the Films example

2022-12-05 Thread GitBox
gabrielmagno opened a new pull request, #1213: URL: https://github.com/apache/solr/pull/1213 https://issues.apache.org/jira/browse/SOLR-16574 # Description Enrich the `films` example to demonstrate how to use the Dense Vectors feature. # Solution Added the field `

[jira] [Commented] (SOLR-16576) Improve StrField field type documentation for large string storage

2022-12-05 Thread Nikolas Osvalds (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643315#comment-17643315 ] Nikolas Osvalds commented on SOLR-16576: Working on a patch for this myself short

[jira] [Created] (SOLR-16576) Improve StrField field type documentation for large string storage

2022-12-05 Thread Nikolas Osvalds (Jira)
Nikolas Osvalds created SOLR-16576: -- Summary: Improve StrField field type documentation for large string storage Key: SOLR-16576 URL: https://issues.apache.org/jira/browse/SOLR-16576 Project: Solr

[jira] [Assigned] (SOLR-16575) splitshard should honour createNodeSet

2022-12-05 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul reassigned SOLR-16575: - Assignee: Noble Paul > splitshard should honour createNodeSet >

[jira] [Created] (SOLR-16575) splitshard should honour createNodeSet

2022-12-05 Thread Noble Paul (Jira)
Noble Paul created SOLR-16575: - Summary: splitshard should honour createNodeSet Key: SOLR-16575 URL: https://issues.apache.org/jira/browse/SOLR-16575 Project: Solr Issue Type: Task Security

[jira] [Commented] (SOLR-15732) queries to missing collection are slow

2022-12-05 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643286#comment-17643286 ] Noble Paul commented on SOLR-15732: --- [~dsmiley] I have updated the PR now > queries to

[GitHub] [solr] bruno-roustant commented on pull request #1048: SOLR-16438: Support optional split.setPreferredLeaders prop in shard split command.

2022-12-05 Thread GitBox
bruno-roustant commented on PR #1048: URL: https://github.com/apache/solr/pull/1048#issuecomment-1337147180 @dsmiley I refreshed to be up to date, and I added the solr.autoPreferredLeader property. -- This is an automated message from the Apache Git Service. To respond to the message, ple