[GitHub] [solr] dsmiley commented on a diff in pull request #1220: SOLR-10463: setRetryExpiryTime should be deprecated in favor of Solr Client Builder methods

dsmiley commented on code in PR #1220: URL: https://github.com/apache/solr/pull/1220#discussion_r1045179129 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/SolrClientBuilder.java: ## @@ -34,6 +35,8 @@ protected boolean useMultiPartPost; protected Integer

[GitHub] [solr] dsmiley commented on pull request #1208: SOLR-16571: Add java system property to disable config watch

dsmiley commented on PR #1208: URL: https://github.com/apache/solr/pull/1208#issuecomment-1345468456 Yeah so just move the test to the existing TestConfigReload and let's be done with it. If you want to increase the scope to mark these things deprecated, that's be nice! CC

[jira] [Comment Edited] (SOLR-16585) All docs query with any nonzero positive start value throws NPE with "this.docs is null"

[ https://issues.apache.org/jira/browse/SOLR-16585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645724#comment-17645724 ] Shawn Heisey edited comment on SOLR-16585 at 12/11/22 6:02 AM: --- Just for

[jira] [Updated] (SOLR-16585) All docs query with any nonzero positive start value throws NPE with "this.docs is null"

[ https://issues.apache.org/jira/browse/SOLR-16585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shawn Heisey updated SOLR-16585: Description: An all docs query that has a nonzero positive value in the start parameter will

[jira] [Comment Edited] (SOLR-16585) All docs query with any nonzero positive start value throws NPE with "this.docs is null"

[ https://issues.apache.org/jira/browse/SOLR-16585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645724#comment-17645724 ] Shawn Heisey edited comment on SOLR-16585 at 12/11/22 6:01 AM: --- Just for

[jira] [Comment Edited] (SOLR-16585) All docs query with any nonzero positive start value throws NPE with "this.docs is null"

[ https://issues.apache.org/jira/browse/SOLR-16585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645724#comment-17645724 ] Shawn Heisey edited comment on SOLR-16585 at 12/11/22 6:00 AM: --- Just for

[jira] [Commented] (SOLR-16585) All docs query with any nonzero positive start value throws NPE with "this.docs is null"

[ https://issues.apache.org/jira/browse/SOLR-16585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645724#comment-17645724 ] Shawn Heisey commented on SOLR-16585: - Just for completeness, I downloaded version 9.1.0, started the

[GitHub] [solr] alessandrobenedetti commented on pull request #1233: SOLR-788: POC transfer MLT queries back and forth.

alessandrobenedetti commented on PR #1233: URL: https://github.com/apache/solr/pull/1233#issuecomment-1345446127 Hi Mikhail, thanks for looking into this! I am currently in Japan with quite a tight schedule, but during the Christmas holidays I'll be more than happy to review it!

[jira] [Commented] (SOLR-16567) java.lang.StackOverflowError when combining KnnQParser and FunctionRangeQParser

[ https://issues.apache.org/jira/browse/SOLR-16567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645713#comment-17645713 ] Alessandro Benedetti commented on SOLR-16567: - Hi Gabriel, just shooting in the dark, what

[GitHub] [solr] sonatype-lift[bot] commented on a diff in pull request #1235: SOLR-14988: Rename #getCores of CoreContainer and SolrCores to #getLoadedCores

sonatype-lift[bot] commented on code in PR #1235: URL: https://github.com/apache/solr/pull/1235#discussion_r1045157746 ## solr/test-framework/src/java/org/apache/solr/cloud/AbstractUnloadDistributedZkTestBase.java: ## @@ -195,7 +195,7 @@ private void

[jira] [Commented] (SOLR-16585) All docs query with any nonzero positive start value throws NPE with "this.docs is null"

[ https://issues.apache.org/jira/browse/SOLR-16585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645711#comment-17645711 ] Shawn Heisey commented on SOLR-16585: - I tried the techproducts example in 9.0.0 and it did not have

[jira] [Updated] (SOLR-16585) All docs query with any nonzero positive start value throws NPE with "this.docs is null"

[ https://issues.apache.org/jira/browse/SOLR-16585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shawn Heisey updated SOLR-16585: Summary: All docs query with any nonzero positive start value throws NPE with "this.docs is null"

[jira] [Updated] (SOLR-16585) All docs query with any nonzero positive value throws NPE with "this.docs is null"

[ https://issues.apache.org/jira/browse/SOLR-16585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shawn Heisey updated SOLR-16585: Description: An all docs query that has a nonzero positive value in the start parameter will

[jira] [Commented] (SOLR-16585) All docs query with any nonzero positive value throws NPE with "this.docs is null"

[ https://issues.apache.org/jira/browse/SOLR-16585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645702#comment-17645702 ] Shawn Heisey commented on SOLR-16585: - I tried following the stacktrace, but I was not able to figure

[GitHub] [solr] heythm opened a new pull request, #1235: SOLR-14988: Rename #getCores of CoreContainer and SolrCores to #getLoadedCores

heythm opened a new pull request, #1235: URL: https://github.com/apache/solr/pull/1235 https://issues.apache.org/jira/browse/SOLR-14988 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Updated] (SOLR-16585) All docs query with any nonzero positive value throws NPE with "this.docs is null"

[ https://issues.apache.org/jira/browse/SOLR-16585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shawn Heisey updated SOLR-16585: Description: An all docs query that has a nonzero positive value in the start parameter will

[jira] [Created] (SOLR-16585) All docs query with any nonzero positive value throws NPE with "this.docs is null"

Shawn Heisey created SOLR-16585: --- Summary: All docs query with any nonzero positive value throws NPE with "this.docs is null" Key: SOLR-16585 URL: https://issues.apache.org/jira/browse/SOLR-16585

[GitHub] [solr] heythm opened a new pull request, #1234: SOLR-15981: Add logExcludedParamsList parameter to support specifying params not to log

heythm opened a new pull request, #1234: URL: https://github.com/apache/solr/pull/1234 https://issues.apache.org/jira/browse/SOLR-15981 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [solr] heythm commented on pull request #1232: SOLR-13243: Correct initial capacity of ops

heythm commented on PR #1232: URL: https://github.com/apache/solr/pull/1232#issuecomment-1345384811 I think it's more readable this way, but it's still a preference. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [solr] mkhludnev opened a new pull request, #1233: SOLR-788: POC transfer MLT queries back and forth.

mkhludnev opened a new pull request, #1233: URL: https://github.com/apache/solr/pull/1233 The way how distributed MLT works now lacks of perfection, you know. Here's not a real proposal, it just demonstrates current state. 1. MLT respond with Query instance. However, it might be

[GitHub] [solr] heythm opened a new pull request, #1232: SOLR-13243: Correct initial capacity of ops

heythm opened a new pull request, #1232: URL: https://github.com/apache/solr/pull/1232 https://issues.apache.org/jira/browse/SOLR-SOLR-13243 Quick fix for initial ops capacity -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [solr] janhoy opened a new pull request, #1231: SOLR-16584 Badapple the failing BATS test

janhoy opened a new pull request, #1231: URL: https://github.com/apache/solr/pull/1231 https://issues.apache.org/jira/browse/SOLR-16584 As a first step I thought we could "badapple" the failing BATS test by disabling it. Then we can iterate in #1223 until we find the root cause, and

[jira] [Created] (SOLR-16584) integrationTests (BATS) fail on GitHub and Jenkins

Jan Høydahl created SOLR-16584: -- Summary: integrationTests (BATS) fail on GitHub and Jenkins Key: SOLR-16584 URL: https://issues.apache.org/jira/browse/SOLR-16584 Project: Solr Issue Type: Bug

[GitHub] [solr] janhoy commented on pull request #1223: test bats

janhoy commented on PR #1223: URL: https://github.com/apache/solr/pull/1223#issuecomment-1345301625 > Perhaps we should modify all our "Check xxx" Jenkins jobs to do `check integrationTests`? Or should `check` include `integrationTests`? I added it to the `Project Solr-Check-main`

[GitHub] [solr] janhoy commented on a diff in pull request #1168: SOLR-16532 New OTEL module with OTLP trace exporter

janhoy commented on code in PR #1168: URL: https://github.com/apache/solr/pull/1168#discussion_r1045099651 ## solr/modules/opentelemetry/build.gradle: ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license

[GitHub] [solr] janhoy commented on a diff in pull request #1168: SOLR-16532 New OTEL module with OTLP trace exporter

janhoy commented on code in PR #1168: URL: https://github.com/apache/solr/pull/1168#discussion_r1045099651 ## solr/modules/opentelemetry/build.gradle: ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license

[GitHub] [solr] epugh commented on pull request #1213: SOLR-16574: Demonstrate Dense Vectors and KNN as part of the Films example

epugh commented on PR #1213: URL: https://github.com/apache/solr/pull/1213#issuecomment-1345276093 progress is looking great! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [solr] sonatype-lift[bot] commented on a diff in pull request #1213: SOLR-16574: Demonstrate Dense Vectors and KNN as part of the Films example

sonatype-lift[bot] commented on code in PR #1213: URL: https://github.com/apache/solr/pull/1213#discussion_r1045090134 ## solr/example/films/vectors/films.py: ## @@ -0,0 +1,92 @@ +#!/usr/bin/env python3 +# -*- coding: utf-8 -*- +# Licensed to the Apache Software Foundation

[GitHub] [solr] epugh commented on pull request #1230: SOLR-16099: Upgrade to Jetty 10.0.13

epugh commented on PR #1230: URL: https://github.com/apache/solr/pull/1230#issuecomment-1345262013 > LGTM. No-brainer I suppose, being a patch release. > > New deps cannot “sneak” in unless a human adds License/Notice files manually. But if a new jetty includes a new jetty jar due to

[jira] [Created] (SOLR-16583) Rename CloudSolrClientBuilder in SolrTestCaseJ4 to RandomizingCloudSolrClientBuilder

Eric Pugh created SOLR-16583: Summary: Rename CloudSolrClientBuilder in SolrTestCaseJ4 to RandomizingCloudSolrClientBuilder Key: SOLR-16583 URL: https://issues.apache.org/jira/browse/SOLR-16583 Project: