[jira] [Commented] (SOLR-10467) setZkConnectTimeout should be deprecated in favor of SolrClientBuilder methods

[ https://issues.apache.org/jira/browse/SOLR-10467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17651899#comment-17651899 ] David Smiley commented on SOLR-10467: - I SOLR-16061 (9.0), this setter moved off from

[jira] [Commented] (SOLR-16590) Standardize Builder method names

[ https://issues.apache.org/jira/browse/SOLR-16590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17651894#comment-17651894 ] David Smiley commented on SOLR-16590: - As you are moving methods into Builders, *that

[GitHub] [solr] dsmiley commented on a diff in pull request #1247: SOLR-10464: setCollectionCacheTTL should be deprecated in favor of Solr Client Builder methods

dsmiley commented on code in PR #1247: URL: https://github.com/apache/solr/pull/1247#discussion_r1057006582 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudLegacySolrClient.java: ## @@ -270,6 +271,17 @@ public Builder withLBHttpSolrClient(LBHttpSolrClient loadBala

[GitHub] [solr] stillalex commented on a diff in pull request #1248: SOLR-10470: setParallelCacheRefreshes should be deprecated in favor of SolrClientBuilder methods

stillalex commented on code in PR #1248: URL: https://github.com/apache/solr/pull/1248#discussion_r1056980257 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudSolrClient.java: ## @@ -1222,11 +1222,22 @@ public boolean isDirectUpdatesToLeadersOnly() { /** * If

[GitHub] [solr] stillalex commented on pull request #1248: SOLR-10470: setParallelCacheRefreshes should be deprecated in favor of SolrClientBuilder methods

stillalex commented on PR #1248: URL: https://github.com/apache/solr/pull/1248#issuecomment-1364712912 left a few minor comments, overall this looks good. is updating the `objectList` method on the table? I find this code a bit ugly (bigger change would be to use an array everywhere,

[GitHub] [solr] stillalex commented on a diff in pull request #1248: SOLR-10470: setParallelCacheRefreshes should be deprecated in favor of SolrClientBuilder methods

stillalex commented on code in PR #1248: URL: https://github.com/apache/solr/pull/1248#discussion_r1056979156 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudSolrClient.java: ## @@ -126,7 +126,7 @@ public abstract class CloudSolrClient extends SolrClient { }

[GitHub] [solr] stillalex commented on a diff in pull request #1248: SOLR-10470: setParallelCacheRefreshes should be deprecated in favor of SolrClientBuilder methods

stillalex commented on code in PR #1248: URL: https://github.com/apache/solr/pull/1248#discussion_r1056978713 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java: ## @@ -134,6 +135,7 @@ protected boolean wasCommError(Throwable rootCause) { /**

[GitHub] [solr] stillalex commented on a diff in pull request #1248: SOLR-10470: setParallelCacheRefreshes should be deprecated in favor of SolrClientBuilder methods

stillalex commented on code in PR #1248: URL: https://github.com/apache/solr/pull/1248#discussion_r1056978513 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java: ## @@ -97,6 +97,7 @@ protected CloudHttp2SolrClient(Builder builder) { } else {

[GitHub] [solr] stillalex commented on a diff in pull request #1248: SOLR-10470: setParallelCacheRefreshes should be deprecated in favor of SolrClientBuilder methods

stillalex commented on code in PR #1248: URL: https://github.com/apache/solr/pull/1248#discussion_r1056978470 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java: ## @@ -249,6 +251,17 @@ public Builder withParallelUpdates(boolean parallelUpdates)

[jira] [Commented] (SOLR-10461) setAliveCheckInterval should be deprecated in favor of SolrClientBuilder methods

[ https://issues.apache.org/jira/browse/SOLR-10461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17651880#comment-17651880 ] ASF subversion and git services commented on SOLR-10461: Commit 3