[GitHub] [solr] dsmiley commented on a diff in pull request #1243: SOLR-16591 Make SolrCores pluggable.

2023-01-01 Thread GitBox
dsmiley commented on code in PR #1243: URL: https://github.com/apache/solr/pull/1243#discussion_r1059849427 ## solr/core/src/test-files/solr/solr.xml: ## @@ -35,11 +35,6 @@ ${connTimeout:15000} - Review Comment: ? This PR removes one "Factory" -- Transien

[GitHub] [solr] noblepaul commented on a diff in pull request #1243: SOLR-16591 Make SolrCores pluggable.

2023-01-01 Thread GitBox
noblepaul commented on code in PR #1243: URL: https://github.com/apache/solr/pull/1243#discussion_r1059845087 ## solr/core/src/test-files/solr/solr.xml: ## @@ -35,11 +35,6 @@ ${connTimeout:15000} - Review Comment: you mean there is a case for both `` **and** a

[GitHub] [solr] dsmiley commented on a diff in pull request #1243: SOLR-16591 Make SolrCores pluggable.

2023-01-01 Thread GitBox
dsmiley commented on code in PR #1243: URL: https://github.com/apache/solr/pull/1243#discussion_r1059840960 ## solr/core/src/test-files/solr/solr.xml: ## @@ -35,11 +35,6 @@ ${connTimeout:15000} - Review Comment: I don't think it's an either-or, I think of this a

[GitHub] [solr] noblepaul commented on a diff in pull request #1258: Refactoring to move live nodes handling out of ZkStateReader and into own class

2023-01-01 Thread GitBox
noblepaul commented on code in PR #1258: URL: https://github.com/apache/solr/pull/1258#discussion_r1059804623 ## solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkLiveNodes.java: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

[jira] [Updated] (SOLR-16603) Create a public constructor for SolrCore

2023-01-01 Thread Shawn Heisey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shawn Heisey updated SOLR-16603: Attachment: NoHtmlUpdateProcessorFactory.java Status: Open (was: Open) This is an update p

[GitHub] [solr] noblepaul commented on a diff in pull request #1243: SOLR-16591 Make SolrCores pluggable.

2023-01-01 Thread GitBox
noblepaul commented on code in PR #1243: URL: https://github.com/apache/solr/pull/1243#discussion_r1059804725 ## solr/core/src/test-files/solr/solr.xml: ## @@ -35,11 +35,6 @@ ${connTimeout:15000} - Review Comment: honestly , a `CoreFactory` is a better abstracti

[GitHub] [solr] noblepaul commented on a diff in pull request #1258: Refactoring to move live nodes handling out of ZkStateReader and into own class

2023-01-01 Thread GitBox
noblepaul commented on code in PR #1258: URL: https://github.com/apache/solr/pull/1258#discussion_r1059804623 ## solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkLiveNodes.java: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

[GitHub] [solr] noblepaul commented on a diff in pull request #1258: Refactoring to move live nodes handling out of ZkStateReader and into own class

2023-01-01 Thread GitBox
noblepaul commented on code in PR #1258: URL: https://github.com/apache/solr/pull/1258#discussion_r1059804588 ## solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkStateReader.java: ## @@ -105,7 +104,6 @@ public class ZkStateReader implements SolrCloseable { public

[jira] [Commented] (SOLR-16603) Create a public constructor for SolrCore

2023-01-01 Thread Shawn Heisey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653474#comment-17653474 ] Shawn Heisey commented on SOLR-16603: - I'm trying to figure out what you are trying t

[GitHub] [solr] janhoy commented on pull request #1114: Link Solr Operator for learning on Solr in Kubernetes, and better exp…

2023-01-01 Thread GitBox
janhoy commented on PR #1114: URL: https://github.com/apache/solr/pull/1114#issuecomment-1368552097 > @janhoy What link exactly? I'd just link to https://hub.docker.com/_/zookeeper and let users turn to the Zookeeper project for any support on how to make replicated Zookeeper work in

[jira] [Created] (SOLR-16603) Create a public constructor for SolrCore

2023-01-01 Thread Jeb Nix (Jira)
Jeb Nix created SOLR-16603: -- Summary: Create a public constructor for SolrCore Key: SOLR-16603 URL: https://issues.apache.org/jira/browse/SOLR-16603 Project: Solr Issue Type: Wish Security Lev

[GitHub] [solr] jebnix commented on pull request #1114: Link Solr Operator for learning on Solr in Kubernetes, and better exp…

2023-01-01 Thread GitBox
jebnix commented on PR #1114: URL: https://github.com/apache/solr/pull/1114#issuecomment-1368509088 @janhoy What link exactly? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [solr] jebnix commented on pull request #1139: Emphasize the meaning of using replicas without sharding

2023-01-01 Thread GitBox
jebnix commented on PR #1139: URL: https://github.com/apache/solr/pull/1139#issuecomment-1368508547 @noblepaul just for emphasizing the situation and the importance of sharding for new users -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Commented] (SOLR-788) MoreLikeThis should support distributed search

2023-01-01 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653420#comment-17653420 ] Mikhail Khludnev commented on SOLR-788: --- https://github.com/apache/solr/pull/1260 I t

[GitHub] [solr] mkhludnev opened a new pull request, #1260: Solr 778 transfer mlt right

2023-01-01 Thread GitBox
mkhludnev opened a new pull request, #1260: URL: https://github.com/apache/solr/pull/1260 I think this is a somewhat reliable solution for the problem with distributed mlt component. Reminder, now it naively relies on parsing `booleanQuery.toString()` that's unacceptable. -- This is an