[GitHub] [solr] noblepaul commented on pull request #1440: SOLR-16691 : Use Jackson for JSON serialization

2023-03-09 Thread via GitHub
noblepaul commented on PR #1440: URL: https://github.com/apache/solr/pull/1440#issuecomment-1463338007 >I could be mistaken, but iiuc most normal writes (what we've been benchmarking in the related dev@solr discussion) run through

[jira] [Commented] (SOLR-16694) Shortcut Http2SolrClient mimeType check for default response parse

2023-03-09 Thread Tomas Eduardo Fernandez Lobbe (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698683#comment-17698683 ] Tomas Eduardo Fernandez Lobbe commented on SOLR-16694: -- I ran the benchmark in [the

[jira] [Updated] (SOLR-16694) Shortcut Http2SolrClient mimeType check for default response parse

2023-03-09 Thread Tomas Eduardo Fernandez Lobbe (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomas Eduardo Fernandez Lobbe updated SOLR-16694: - Attachment: screenshot-2.png > Shortcut Http2SolrClient mimeType

[jira] [Updated] (SOLR-16694) Shortcut Http2SolrClient mimeType check for default response parse

2023-03-09 Thread Tomas Eduardo Fernandez Lobbe (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomas Eduardo Fernandez Lobbe updated SOLR-16694: - Attachment: screenshot-1.png > Shortcut Http2SolrClient mimeType

[jira] [Created] (SOLR-16694) Shortcut Http2SolrClient mimeType check for default response parse

2023-03-09 Thread Tomas Eduardo Fernandez Lobbe (Jira)
Tomas Eduardo Fernandez Lobbe created SOLR-16694: Summary: Shortcut Http2SolrClient mimeType check for default response parse Key: SOLR-16694 URL: https://issues.apache.org/jira/browse/SOLR-16694

[GitHub] [solr] uvatbc closed pull request #1446: Unshallow the clone so that the crave client can work properly

2023-03-09 Thread via GitHub
uvatbc closed pull request #1446: Unshallow the clone so that the crave client can work properly URL: https://github.com/apache/solr/pull/1446 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [solr] uvatbc commented on pull request #1446: Unshallow the clone so that the crave client can work properly

2023-03-09 Thread via GitHub
uvatbc commented on PR #1446: URL: https://github.com/apache/solr/pull/1446#issuecomment-1463059638 Hm. So the unshallow is NOT the problem :( -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [solr] uvatbc opened a new pull request, #1446: Unshallow the clone so that the crave client can work properly

2023-03-09 Thread via GitHub
uvatbc opened a new pull request, #1446: URL: https://github.com/apache/solr/pull/1446 # Description Every once in a while, the GHA CI fails because the crave client isn't able to identify the correct merge base. The usual reason for this is that the GH checkout

[jira] [Created] (SOLR-16693) Use TimeLimitingBulkScorer; stop using ExitableDirectoryReader

2023-03-09 Thread David Smiley (Jira)
David Smiley created SOLR-16693: --- Summary: Use TimeLimitingBulkScorer; stop using ExitableDirectoryReader Key: SOLR-16693 URL: https://issues.apache.org/jira/browse/SOLR-16693 Project: Solr

[GitHub] [solr] tflobbe commented on a diff in pull request #1445: SOLR-16692: Use HttpCookieStore.Empty in Http2SolrClient

2023-03-09 Thread via GitHub
tflobbe commented on code in PR #1445: URL: https://github.com/apache/solr/pull/1445#discussion_r1131736487 ## solr/benchmark/src/java/org/apache/solr/bench/MiniClusterState.java: ## @@ -273,7 +273,7 @@ public void startMiniCluster(int nodeCount) {

[jira] [Commented] (SOLR-16692) Evaluate using Empty CookieStore

2023-03-09 Thread Tomas Eduardo Fernandez Lobbe (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698646#comment-17698646 ] Tomas Eduardo Fernandez Lobbe commented on SOLR-16692: -- I ran the benchmark in the

[jira] [Updated] (SOLR-16692) Evaluate using Empty CookieStore

2023-03-09 Thread Tomas Eduardo Fernandez Lobbe (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomas Eduardo Fernandez Lobbe updated SOLR-16692: - Attachment: image-2023-03-09-15-15-07-793.png > Evaluate using

[jira] [Created] (SOLR-16692) Evaluate using Empty CookieStore

2023-03-09 Thread Tomas Eduardo Fernandez Lobbe (Jira)
Tomas Eduardo Fernandez Lobbe created SOLR-16692: Summary: Evaluate using Empty CookieStore Key: SOLR-16692 URL: https://issues.apache.org/jira/browse/SOLR-16692 Project: Solr

[jira] [Commented] (SOLR-16653) Shard split doesn't work when shard has NRT and pull replica and prs is enable on collection

2023-03-09 Thread Hitesh Khamesra (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698617#comment-17698617 ] Hitesh Khamesra commented on SOLR-16653: [~ichattopadhyaya] looks like both tests restart and

[jira] [Commented] (SOLR-16468) Create v2 equivalent of v1 'CREATESNAPSHOT', 'LISTSNAPSHOT' and 'DELETESNAPSHOT' (collection level)

2023-03-09 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698598#comment-17698598 ] Jason Gerlowski commented on SOLR-16468: Awesome, please do [~jdurham]! Also, short update - for

[GitHub] [solr] dsmiley commented on a diff in pull request #1437: SOLR-16487: Improve Pull Replica Interval

2023-03-09 Thread via GitHub
dsmiley commented on code in PR #1437: URL: https://github.com/apache/solr/pull/1437#discussion_r1131559894 ## solr/core/src/java/org/apache/solr/cloud/ReplicateFromLeader.java: ## @@ -155,6 +155,38 @@ public static String getCommitVersion(SolrCore solrCore) { } } +

[GitHub] [solr] risdenk commented on a diff in pull request #1442: Improving efficiency of replication process

2023-03-09 Thread via GitHub
risdenk commented on code in PR #1442: URL: https://github.com/apache/solr/pull/1442#discussion_r1131466824 ## solr/core/src/java/org/apache/solr/cloud/RecoveryStrategy.java: ## @@ -223,8 +223,10 @@ private final void replicate(String nodeName, SolrCore core, ZkNodeProps

[GitHub] [solr] magibney commented on pull request #1440: SOLR-16691 : Use Jackson for JSON serialization

2023-03-09 Thread via GitHub
magibney commented on PR #1440: URL: https://github.com/apache/solr/pull/1440#issuecomment-1462597683 I could be mistaken, but iiuc most normal writes (what we've been benchmarking in the related dev@solr discussion) run through

[jira] [Resolved] (SOLR-16676) Http2SolrClient loss of MDC context

2023-03-09 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden resolved SOLR-16676. - Resolution: Fixed Thanks [~stillalex] > Http2SolrClient loss of MDC context >

[jira] [Commented] (SOLR-16676) Http2SolrClient loss of MDC context

2023-03-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698548#comment-17698548 ] ASF subversion and git services commented on SOLR-16676: Commit

[GitHub] [solr] stillalex commented on pull request #1444: SOLR-16676: Http2SolrClient loss of MDC context - test fixes

2023-03-09 Thread via GitHub
stillalex commented on PR #1444: URL: https://github.com/apache/solr/pull/1444#issuecomment-1462456065 thanks a lot @risdenk! if it helps I also ran a 500 over night and it passed ``` solr$ ./gradlew beast -p solr/core --tests TestHttpRequestId -Ptests.dups=500 BUILD

[jira] [Commented] (SOLR-16676) Http2SolrClient loss of MDC context

2023-03-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698502#comment-17698502 ] ASF subversion and git services commented on SOLR-16676: Commit

[GitHub] [solr] risdenk merged pull request #1444: SOLR-16676: Http2SolrClient loss of MDC context - test fixes

2023-03-09 Thread via GitHub
risdenk merged PR #1444: URL: https://github.com/apache/solr/pull/1444 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [solr-operator] HoustonPutman opened a new pull request, #530: Add readinessCondition to stop traffic to pods that will be stopped

2023-03-09 Thread via GitHub
HoustonPutman opened a new pull request, #530: URL: https://github.com/apache/solr-operator/pull/530 Resolves #529 This uses the [pod readiness gates/conditions](https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/#pod-readiness-status) to ensure that traffic is stopped

[GitHub] [solr] epugh commented on a diff in pull request #1412: SOLR-16372: Migrate collection listing, deletion to JAX-RS

2023-03-09 Thread via GitHub
epugh commented on code in PR #1412: URL: https://github.com/apache/solr/pull/1412#discussion_r1131260147 ## solr/core/src/java/org/apache/solr/jersey/SubResponseAccumulatingJerseyResponse.java: ## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[jira] [Comment Edited] (SOLR-16393) Cosmetic, REST-fulness improvements to v2 alias, alias-prop CRUD APIs

2023-03-09 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17623216#comment-17623216 ] Jason Gerlowski edited comment on SOLR-16393 at 3/9/23 3:55 PM: To be a

[jira] [Comment Edited] (SOLR-16393) Cosmetic, REST-fulness improvements to v2 alias, alias-prop CRUD APIs

2023-03-09 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17623216#comment-17623216 ] Jason Gerlowski edited comment on SOLR-16393 at 3/9/23 3:54 PM: To be a

[jira] [Commented] (SOLR-16393) Cosmetic, REST-fulness improvements to v2 alias, alias-prop CRUD APIs

2023-03-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698470#comment-17698470 ] ASF subversion and git services commented on SOLR-16393: Commit

[GitHub] [solr] gerlowskija commented on a diff in pull request #1412: SOLR-16372: Migrate collection listing, deletion to JAX-RS

2023-03-09 Thread via GitHub
gerlowskija commented on code in PR #1412: URL: https://github.com/apache/solr/pull/1412#discussion_r1131186601 ## solr/core/src/java/org/apache/solr/jersey/SubResponseAccumulatingJerseyResponse.java: ## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[jira] [Commented] (SOLR-16372) Convert v2 "Collection" and "CollectionProp" APIs to JAX-RS

2023-03-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698439#comment-17698439 ] ASF subversion and git services commented on SOLR-16372: Commit

[GitHub] [solr] gerlowskija merged pull request #1412: SOLR-16372: Migrate collection listing, deletion to JAX-RS

2023-03-09 Thread via GitHub
gerlowskija merged PR #1412: URL: https://github.com/apache/solr/pull/1412 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (SOLR-16487) Improve calculation of poll interval for replicas

2023-03-09 Thread Justin Sweeney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698433#comment-17698433 ] Justin Sweeney commented on SOLR-16487: --- I'm planning to merge this improvement to polling in the

[GitHub] [solr] risdenk commented on pull request #1444: SOLR-16676 Http2SolrClient loss of MDC context - test fixes

2023-03-09 Thread via GitHub
risdenk commented on PR #1444: URL: https://github.com/apache/solr/pull/1444#issuecomment-1462185650 @stillalex change looks good. I merged main, merged https://github.com/apache/solr/pull/1443, and ran tidy. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [solr] risdenk commented on pull request #1443: SOLR-16676: Test improvements

2023-03-09 Thread via GitHub
risdenk commented on PR #1443: URL: https://github.com/apache/solr/pull/1443#issuecomment-1462180732 combined into https://github.com/apache/solr/pull/1444 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [solr] risdenk closed pull request #1443: SOLR-16676: Test improvements

2023-03-09 Thread via GitHub
risdenk closed pull request #1443: SOLR-16676: Test improvements URL: https://github.com/apache/solr/pull/1443 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [solr] andywebb1975 commented on pull request #1431: SOLR-16643: Add reRankOperator=multiply/replace options to ReRank query parser

2023-03-09 Thread via GitHub
andywebb1975 commented on PR #1431: URL: https://github.com/apache/solr/pull/1431#issuecomment-1461603109 > Wouldn't you cherry-pick it to `branch_9x`? Ah yes - done! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Commented] (SOLR-16643) Add multiply/replace options to ReRank query parser

2023-03-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698266#comment-17698266 ] ASF subversion and git services commented on SOLR-16643: Commit