[GitHub] [solr] stillalex commented on pull request #1459: SOLR-16393 Alias properties management

2023-03-15 Thread via GitHub
stillalex commented on PR #1459: URL: https://github.com/apache/solr/pull/1459#issuecomment-1470880898 @gerlowskija PR updated based on feedback. please take another look. thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [solr] dsmiley commented on pull request #1360: SOLR 16642 : upgrade Solr to use Lucene 9.5.0

2023-03-15 Thread via GitHub
dsmiley commented on PR #1360: URL: https://github.com/apache/solr/pull/1360#issuecomment-1470828417 No need to wait for me: https://github.com/apache/solr/pull/1450 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [solr] stillalex commented on a diff in pull request #1459: SOLR-16393 Alias properties management

2023-03-15 Thread via GitHub
stillalex commented on code in PR #1459: URL: https://github.com/apache/solr/pull/1459#discussion_r1137624480 ## solr/solr-ref-guide/modules/deployment-guide/pages/alias-management.adoc: ## @@ -657,7 +657,7 @@ If a key is set with a value that is empty it will be removed.

[GitHub] [solr] stillalex commented on pull request #1459: SOLR-16393 Alias properties management

2023-03-15 Thread via GitHub
stillalex commented on PR #1459: URL: https://github.com/apache/solr/pull/1459#issuecomment-1470566279 to answer the questions you posted: > Does this PR change any of the API responses (for those APIs which preexisted this PR? It doesn't look like it (which is good), but just

[GitHub] [solr] dsmiley commented on a diff in pull request #1450: SOLR-16693: timeAllowed: use more efficient TimeLimitingBulkScorer

2023-03-15 Thread via GitHub
dsmiley commented on code in PR #1450: URL: https://github.com/apache/solr/pull/1450#discussion_r1137585507 ## solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java: ## @@ -713,6 +713,33 @@ public QueryResult search(QueryResult qr, QueryCommand cmd) throws

[GitHub] [solr] stillalex commented on a diff in pull request #1459: SOLR-16393 Alias properties management

2023-03-15 Thread via GitHub
stillalex commented on code in PR #1459: URL: https://github.com/apache/solr/pull/1459#discussion_r1137581075 ## solr/solr-ref-guide/modules/deployment-guide/pages/alias-management.adoc: ## @@ -657,7 +657,7 @@ If a key is set with a value that is empty it will be removed.

[GitHub] [solr] stillalex commented on a diff in pull request #1459: SOLR-16393 Alias properties management

2023-03-15 Thread via GitHub
stillalex commented on code in PR #1459: URL: https://github.com/apache/solr/pull/1459#discussion_r1137578242 ## solr/core/src/java/org/apache/solr/handler/admin/api/AliasPropertyAPI.java: ## @@ -0,0 +1,262 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [solr] stillalex commented on a diff in pull request #1459: SOLR-16393 Alias properties management

2023-03-15 Thread via GitHub
stillalex commented on code in PR #1459: URL: https://github.com/apache/solr/pull/1459#discussion_r1137562476 ## solr/core/src/test/org/apache/solr/cloud/AliasIntegrationTest.java: ## @@ -291,20 +316,25 @@ public void testModifyPropertiesCAR() throws Exception {

[GitHub] [solr] stillalex commented on a diff in pull request #1459: SOLR-16393 Alias properties management

2023-03-15 Thread via GitHub
stillalex commented on code in PR #1459: URL: https://github.com/apache/solr/pull/1459#discussion_r1137543029 ## solr/core/src/java/org/apache/solr/handler/admin/api/AliasPropertyAPI.java: ## @@ -0,0 +1,262 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [solr] stillalex commented on pull request #1356: SOLR-16638 Fix Http2SolrClient's exception message when serverBaseUrl is null

2023-03-15 Thread via GitHub
stillalex commented on PR #1356: URL: https://github.com/apache/solr/pull/1356#issuecomment-1470483707 thanks @risdenk! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Comment Edited] (SOLR-16594) improve eDismax strategy for generating a term-centric query

2023-03-15 Thread Rudi Seitz (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17650967#comment-17650967 ] Rudi Seitz edited comment on SOLR-16594 at 3/15/23 4:23 PM: This is a rough

[jira] [Updated] (SOLR-16594) improve eDismax strategy for generating a term-centric query

2023-03-15 Thread Rudi Seitz (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rudi Seitz updated SOLR-16594: -- Description: When parsing a multi-term query that spans multiple fields, edismax attempts to generate

[GitHub] [solr] rseitz opened a new pull request, #1463: SOLR-16594: improve eDismax strategy for generating a term-centric query

2023-03-15 Thread via GitHub
rseitz opened a new pull request, #1463: URL: https://github.com/apache/solr/pull/1463 https://issues.apache.org/jira/browse/SOLR-16594 # Description When a query spans multiple fields, edismax first generates a clause for each field. Then it attempts to rewrite the clauses so

[GitHub] [solr] risdenk commented on a diff in pull request #1256: SOLR-10466: setDefaultCollection should be deprecated in favor of SolrClientBuilder methods

2023-03-15 Thread via GitHub
risdenk commented on code in PR #1256: URL: https://github.com/apache/solr/pull/1256#discussion_r1137365537 ## solr/core/src/test/org/apache/solr/cloud/MigrateRouteKeyTest.java: ## @@ -105,7 +105,6 @@ public void multipleShardMigrateTest() throws Exception {

[jira] [Commented] (SOLR-16393) Cosmetic improvements and migration to JAX-RS (alias, alias-prop CRUD APIs)

2023-03-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700760#comment-17700760 ] ASF subversion and git services commented on SOLR-16393: Commit

[jira] [Commented] (SOLR-16393) Cosmetic improvements and migration to JAX-RS (alias, alias-prop CRUD APIs)

2023-03-15 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700749#comment-17700749 ] Jason Gerlowski commented on SOLR-16393: Hmm, thanks for the heads up Kevin, I'll take a look. >

[jira] [Commented] (SOLR-16393) Cosmetic improvements and migration to JAX-RS (alias, alias-prop CRUD APIs)

2023-03-15 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700741#comment-17700741 ] Kevin Risden commented on SOLR-16393: - FYI [~gerlowskija] looks like the commit above caused the

[jira] [Assigned] (SOLR-16643) Add multiply/replace options to ReRank query parser

2023-03-15 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman reassigned SOLR-16643: - Assignee: Andy Webb > Add multiply/replace options to ReRank query parser >

[jira] [Updated] (SOLR-16594) improve eDismax strategy for generating a term-centric query

2023-03-15 Thread Rudi Seitz (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rudi Seitz updated SOLR-16594: -- Description: When parsing a multi-term query, edismax attempts to use a term-centric approach. The

[GitHub] [solr] HoustonPutman commented on pull request #1452: SOLR-16393: Migrate alias-deletion to JAX-RS

2023-03-15 Thread via GitHub
HoustonPutman commented on PR #1452: URL: https://github.com/apache/solr/pull/1452#issuecomment-1470127328 Nah, that sounds good to me! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (SOLR-16393) Cosmetic improvements and migration to JAX-RS (alias, alias-prop CRUD APIs)

2023-03-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700706#comment-17700706 ] ASF subversion and git services commented on SOLR-16393: Commit

[GitHub] [solr] gerlowskija merged pull request #1452: SOLR-16393: Migrate alias-deletion to JAX-RS

2023-03-15 Thread via GitHub
gerlowskija merged PR #1452: URL: https://github.com/apache/solr/pull/1452 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (SOLR-16594) improve eDismax strategy for generating a term-centric query

2023-03-15 Thread Rudi Seitz (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rudi Seitz updated SOLR-16594: -- Summary: improve eDismax strategy for generating a term-centric query (was: eDismax should use

[GitHub] [solr] gerlowskija commented on pull request #1452: SOLR-16393: Migrate alias-deletion to JAX-RS

2023-03-15 Thread via GitHub
gerlowskija commented on PR #1452: URL: https://github.com/apache/solr/pull/1452#issuecomment-1470094543 I've added some unit tests to cover the testing gap. Thought I'd done that earlier, my mistake. > Also are we adding upgrade notes info for V2 API changes, or just CHANGES.txt

[jira] [Commented] (SOLR-16391) Cosmetic improvements and migration to JAX-RS (collection, collection prop, core CRUD APIs)

2023-03-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700688#comment-17700688 ] ASF subversion and git services commented on SOLR-16391: Commit

[jira] [Commented] (SOLR-16372) Convert v2 "Collection" and "CollectionProp" APIs to JAX-RS

2023-03-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700687#comment-17700687 ] ASF subversion and git services commented on SOLR-16372: Commit

[GitHub] [solr] epugh commented on pull request #1256: SOLR-10466: setDefaultCollection should be deprecated in favor of SolrClientBuilder methods

2023-03-15 Thread via GitHub
epugh commented on PR #1256: URL: https://github.com/apache/solr/pull/1256#issuecomment-1470024729 I wish Crave was running these tests ;-) It's gotten in that weird state, and I'm nervous about messing with git to try and fix it... -- This is an automated message from the Apache Git

[GitHub] [solr] epugh commented on a diff in pull request #1256: SOLR-10466: setDefaultCollection should be deprecated in favor of SolrClientBuilder methods

2023-03-15 Thread via GitHub
epugh commented on code in PR #1256: URL: https://github.com/apache/solr/pull/1256#discussion_r1137082274 ## solr/test-framework/src/java/org/apache/solr/cloud/AbstractFullDistribZkTestBase.java: ## @@ -2283,6 +2291,26 @@ protected CloudSolrClient getCommonCloudSolrClient() {

[jira] [Commented] (SOLR-16638) Fix Http2SolrClient's exception message when serverBaseUrl is null

2023-03-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700672#comment-17700672 ] ASF subversion and git services commented on SOLR-16638: Commit

[jira] [Updated] (SOLR-16638) Fix Http2SolrClient's exception message when serverBaseUrl is null

2023-03-15 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16638: Fix Version/s: 9.2 > Fix Http2SolrClient's exception message when serverBaseUrl is null >

[jira] [Updated] (SOLR-16638) Fix Http2SolrClient's exception message when serverBaseUrl is null

2023-03-15 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16638: Resolution: Fixed Status: Resolved (was: Patch Available) > Fix Http2SolrClient's

[jira] [Updated] (SOLR-16638) Fix Http2SolrClient's exception message when serverBaseUrl is null

2023-03-15 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16638: Fix Version/s: main (10.0) > Fix Http2SolrClient's exception message when serverBaseUrl is null >

[jira] [Updated] (SOLR-16638) Fix Http2SolrClient's exception message when serverBaseUrl is null

2023-03-15 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16638: Status: Patch Available (was: Open) > Fix Http2SolrClient's exception message when serverBaseUrl

[jira] [Assigned] (SOLR-16638) Fix Http2SolrClient's exception message when serverBaseUrl is null

2023-03-15 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden reassigned SOLR-16638: --- Assignee: Kevin Risden > Fix Http2SolrClient's exception message when serverBaseUrl is null

[jira] [Commented] (SOLR-16638) Fix Http2SolrClient's exception message when serverBaseUrl is null

2023-03-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700669#comment-17700669 ] ASF subversion and git services commented on SOLR-16638: Commit

[GitHub] [solr] risdenk merged pull request #1356: SOLR-16638 Fix Http2SolrClient's exception message when serverBaseUrl is null

2023-03-15 Thread via GitHub
risdenk merged PR #1356: URL: https://github.com/apache/solr/pull/1356 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (SOLR-11741) Offline training mode for schema guessing

2023-03-15 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-11741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700667#comment-17700667 ] Jan Høydahl commented on SOLR-11741: I believe the schema designer overlaps and supercedes this. It

[GitHub] [solr] gerlowskija commented on a diff in pull request #1459: SOLR-16393 Alias properties management

2023-03-15 Thread via GitHub
gerlowskija commented on code in PR #1459: URL: https://github.com/apache/solr/pull/1459#discussion_r1136901816 ## solr/core/src/java/org/apache/solr/handler/admin/CollectionsHandler.java: ## @@ -1828,28 +1835,21 @@ public Map execute( }); /** - * Places all

[jira] [Resolved] (SOLR-14820) Create replica is broken

2023-03-15 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-14820. Resolution: Cannot Reproduce I tested this API on Solr 9.1 through the Admin UI, on a 2-node

[GitHub] [solr] cpoerschke commented on a diff in pull request #1435: SOLR-16674: Introduce dense vector byte encoding

2023-03-15 Thread via GitHub
cpoerschke commented on code in PR #1435: URL: https://github.com/apache/solr/pull/1435#discussion_r1136807166 ## solr/core/src/java/org/apache/solr/schema/DenseVectorField.java: ## @@ -46,19 +50,17 @@ */ public class DenseVectorField extends FloatPointField { public

[GitHub] [solr] gerlowskija commented on pull request #1459: SOLR-16393 Alias properties management

2023-03-15 Thread via GitHub
gerlowskija commented on PR #1459: URL: https://github.com/apache/solr/pull/1459#issuecomment-1469818743 Hey Alex, thanks for the PR! A few comments/questions on the v2 endpoints themselves (since you summarized them in a comment above): 1. Does this PR change any of the API

[GitHub] [solr] cpoerschke commented on a diff in pull request #1450: SOLR-16693: timeAllowed: use more efficient TimeLimitingBulkScorer

2023-03-15 Thread via GitHub
cpoerschke commented on code in PR #1450: URL: https://github.com/apache/solr/pull/1450#discussion_r1136792660 ## solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java: ## @@ -713,6 +713,33 @@ public QueryResult search(QueryResult qr, QueryCommand cmd) throws

[jira] [Commented] (SOLR-12813) SolrCloud + 2 shards + subquery + auth = 401 Exception

2023-03-15 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700579#comment-17700579 ] Jan Høydahl commented on SOLR-12813: I felt this Jira describes the issue better than SOLR-12583, so

[jira] [Updated] (SOLR-12813) SolrCloud + 2 shards + subquery + auth = 401 Exception

2023-03-15 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-12813: --- Summary: SolrCloud + 2 shards + subquery + auth = 401 Exception (was: SolrCloud + Basic

[jira] [Resolved] (SOLR-12583) Add basic authentication option for [subquery] document transformer

2023-03-15 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-12583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-12583. Resolution: Duplicate Closing as duplicate of SOLR-12813, to continue work there > Add basic

[jira] [Reopened] (SOLR-12813) SolrCloud + Basic Authentication + subquery = 401 Exception

2023-03-15 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl reopened SOLR-12813: > SolrCloud + Basic Authentication + subquery = 401 Exception >

[jira] [Updated] (SOLR-12813) SolrCloud + Basic Authentication + subquery = 401 Exception

2023-03-15 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-12813: --- Affects Version/s: 8.11 Re-opening to use this as primary issue for this bug > SolrCloud + Basic

[jira] [Commented] (SOLR-16183) XML Loader: support indexing single nested child document

2023-03-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700567#comment-17700567 ] ASF subversion and git services commented on SOLR-16183: Commit

[GitHub] [solr] mkhludnev merged pull request #1462: SOLR-16183: XML Loader: support indexing single nested child document…

2023-03-15 Thread via GitHub
mkhludnev merged PR #1462: URL: https://github.com/apache/solr/pull/1462 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [solr-operator] coolstim commented on issue #483: Servicemonitor for prometheus exporter is referring to cluster port instead of metrics pod port

2023-03-15 Thread via GitHub
coolstim commented on issue #483: URL: https://github.com/apache/solr-operator/issues/483#issuecomment-1469657782 Situation before Solr: - We aren't using the Prometheus operator. - All our other services are scraped correctly. Situation after Solr: We installed the

[GitHub] [solr] mkhludnev opened a new pull request, #1462: SOLR-16183: XML Loader: support indexing single nested child document…

2023-03-15 Thread via GitHub
mkhludnev opened a new pull request, #1462: URL: https://github.com/apache/solr/pull/1462 https://issues.apache.org/jira/browse/SOLR-16183 cc @vinayakphegde -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Commented] (SOLR-16699) Expose collection creation time from COLSTATUS API

2023-03-15 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700551#comment-17700551 ] Noble Paul commented on SOLR-16699: --- yes , the COLSTATUS API should return that info > Expose

[GitHub] [solr] vinayakphegde commented on pull request #1360: SOLR 16642 : upgrade Solr to use Lucene 9.5.0

2023-03-15 Thread via GitHub
vinayakphegde commented on PR #1360: URL: https://github.com/apache/solr/pull/1360#issuecomment-1469456142 can I make it a regular PR now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [solr] vinayakphegde commented on a diff in pull request #1360: SOLR 16642 : upgrade Solr to use Lucene 9.5.0

2023-03-15 Thread via GitHub
vinayakphegde commented on code in PR #1360: URL: https://github.com/apache/solr/pull/1360#discussion_r1136611886 ## solr/core/src/java/org/apache/solr/search/SolrQueryTimeoutImpl.java: ## @@ -45,7 +45,6 @@ public static Long getTimeoutAtNs() { return timeoutAt.get(); }