[GitHub] [solr] sonatype-lift[bot] commented on a diff in pull request #1497: ZkStateReader : refactor our `security.json` handling

2023-03-27 Thread via GitHub
sonatype-lift[bot] commented on code in PR #1497: URL: https://github.com/apache/solr/pull/1497#discussion_r1149990862 ## solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkStateReader.java: ## @@ -1363,28 +1299,9 @@ private VersionedCollectionProps fetchCollectionPro

[jira] [Updated] (SOLR-16721) Java version detection fails when `_JAVA_OPTIONS` is set

2023-03-27 Thread Ruoyu Zhong (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ruoyu Zhong updated SOLR-16721: --- Description: When the environment variable {{_JAVA_OPTIONS}} is set, {{solr}} fails with the followi

[jira] [Created] (SOLR-16721) Java version detection fails when `_JAVA_OPTIONS` is set

2023-03-27 Thread Ruoyu Zhong (Jira)
Ruoyu Zhong created SOLR-16721: -- Summary: Java version detection fails when `_JAVA_OPTIONS` is set Key: SOLR-16721 URL: https://issues.apache.org/jira/browse/SOLR-16721 Project: Solr Issue Type:

[GitHub] [solr] dsmiley commented on a diff in pull request #1407: SOLR-16427: Evaluate and fix errorprone rules - part 5

2023-03-27 Thread via GitHub
dsmiley commented on code in PR #1407: URL: https://github.com/apache/solr/pull/1407#discussion_r1149704304 ## solr/solrj/src/java/org/noggit/JSONUtil.java: ## @@ -17,11 +17,19 @@ package org.noggit; public class JSONUtil { + @SuppressWarnings("MutablePublicArray") publi

[jira] [Commented] (SOLR-16697) New API support to import index files generated by Embedded SOLR into SOLR Cloud

2023-03-27 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17705640#comment-17705640 ] Jason Gerlowski commented on SOLR-16697: I've merged this to main and plan on bac

[jira] [Assigned] (SOLR-16697) New API support to import index files generated by Embedded SOLR into SOLR Cloud

2023-03-27 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski reassigned SOLR-16697: -- Assignee: Jason Gerlowski > New API support to import index files generated by Embedde

[GitHub] [solr] noblepaul commented on pull request #1477: SOLR-16712: Simplify DocCollection ctor for PRS enabled collection

2023-03-27 Thread via GitHub
noblepaul commented on PR #1477: URL: https://github.com/apache/solr/pull/1477#issuecomment-1485639221 @patsonluk yes, the latest one doesn't create new Objects, I shall review it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[jira] [Resolved] (SOLR-1526) Client Side Tika integration

2023-03-27 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-1526. --- Resolution: Won't Fix > Client Side Tika integration > > >

[jira] [Commented] (SOLR-16604) Use Builders directly in tests instead of delegating to SolrTestCaseJ4

2023-03-27 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17705483#comment-17705483 ] David Smiley commented on SOLR-16604: - Yes > Use Builders directly in tests instead

[jira] [Resolved] (SOLR-8803) Generalize OOME handling to work for any OS

2023-03-27 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman resolved SOLR-8803. -- Resolution: Fixed > Generalize OOME handling to work for any OS > --

[jira] [Commented] (SOLR-16668) Use default Java SslContextFactory for HTTP2 when no system properties are given

2023-03-27 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17705462#comment-17705462 ] Kevin Risden commented on SOLR-16668: - [~elyograg] you might also need to upgrade Spr

[jira] [Commented] (SOLR-16668) Use default Java SslContextFactory for HTTP2 when no system properties are given

2023-03-27 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17705460#comment-17705460 ] Kevin Risden commented on SOLR-16668: - [~elyograg] for simplicity using Jetty bom sho

[GitHub] [solr] alessandrobenedetti commented on a diff in pull request #1435: SOLR-16674: Introduce dense vector byte encoding

2023-03-27 Thread via GitHub
alessandrobenedetti commented on code in PR #1435: URL: https://github.com/apache/solr/pull/1435#discussion_r1149553669 ## solr/core/src/java/org/apache/solr/schema/DenseVectorField.java: ## @@ -205,53 +257,144 @@ public IndexableField createField(SchemaField field, Object pars

[GitHub] [solr] epugh commented on pull request #1496: SOLR-16601: Remove Deprecated Methods from SolrClients

2023-03-27 Thread via GitHub
epugh commented on PR #1496: URL: https://github.com/apache/solr/pull/1496#issuecomment-1485508869 Check logic around ConcurrentUpdateSolrClient and `setPollQueueTime`... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [solr] epugh commented on pull request #1496: SOLR-16601: Remove Deprecated Methods from SolrClients

2023-03-27 Thread via GitHub
epugh commented on PR #1496: URL: https://github.com/apache/solr/pull/1496#issuecomment-1485488944 HttpSolrClient.setQueryParams is deprecated, but used ;-( Need to migrate it... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [solr] epugh commented on pull request #1496: SOLR-16601: Remove Deprecated Methods from SolrClients

2023-03-27 Thread via GitHub
epugh commented on PR #1496: URL: https://github.com/apache/solr/pull/1496#issuecomment-1485480799 Hoping Crave.io doesn't get in a weird git state, and it can run the tests as I remove methods for me! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [solr] epugh opened a new pull request, #1496: SOLR-16601: Remove Deprecated Methods from SolrClients

2023-03-27 Thread via GitHub
epugh opened a new pull request, #1496: URL: https://github.com/apache/solr/pull/1496 https://issues.apache.org/jira/browse/SOLR-16601 # Description Please provide a short description of the changes you're making with this pull request. # Solution Plea

[GitHub] [solr] gerlowskija opened a new pull request, #1495: SOLR-16720: Defer PKI header creation to send-time

2023-03-27 Thread via GitHub
gerlowskija opened a new pull request, #1495: URL: https://github.com/apache/solr/pull/1495 https://issues.apache.org/jira/browse/SOLR-16720 # Description Prior to this commit, the PKIAuthPlugin decorates outgoing requests at 'queue' time instead of later when they're actually

[jira] [Commented] (SOLR-16604) Use Builders directly in tests instead of delegating to SolrTestCaseJ4

2023-03-27 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17705446#comment-17705446 ] Eric Pugh commented on SOLR-16604: -- [~dsmiley]I wanted to confirm, before I did this, th

[jira] [Commented] (SOLR-10466) setDefaultCollection should be deprecated in favor of SolrClientBuilder methods

2023-03-27 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17705444#comment-17705444 ] Eric Pugh commented on SOLR-10466: -- They actually ran just fine this morning! I was a

[jira] [Commented] (SOLR-10466) setDefaultCollection should be deprecated in favor of SolrClientBuilder methods

2023-03-27 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17705442#comment-17705442 ] David Smiley commented on SOLR-10466: - bq. I have some fears that these changes may m

[jira] [Resolved] (SOLR-10466) setDefaultCollection should be deprecated in favor of SolrClientBuilder methods

2023-03-27 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh resolved SOLR-10466. -- Fix Version/s: main (10.0) 9.3 Resolution: Fixed > setDefaultCollection shoul

[jira] [Commented] (SOLR-10466) setDefaultCollection should be deprecated in favor of SolrClientBuilder methods

2023-03-27 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17705438#comment-17705438 ] ASF subversion and git services commented on SOLR-10466: Commit e

[jira] [Updated] (SOLR-16720) PKI should decorate outgoing requests at "sending", not "enqueueing" time

2023-03-27 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated SOLR-16720: --- Attachment: reproduce.sh > PKI should decorate outgoing requests at "sending", not "enqueuein

[jira] [Updated] (SOLR-16720) PKI should decorate outgoing requests at "sending", not "enqueueing" time

2023-03-27 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated SOLR-16720: --- Attachment: SOLR-16720-reproduce.patch > PKI should decorate outgoing requests at "sending",

[jira] [Commented] (SOLR-16720) PKI should decorate outgoing requests at "sending", not "enqueueing" time

2023-03-27 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17705431#comment-17705431 ] Jason Gerlowski commented on SOLR-16720: The biggest challenge for this change I

[jira] [Commented] (SOLR-1526) Client Side Tika integration

2023-03-27 Thread Tomas Eduardo Fernandez Lobbe (Jira)
[ https://issues.apache.org/jira/browse/SOLR-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17705428#comment-17705428 ] Tomas Eduardo Fernandez Lobbe commented on SOLR-1526: - +1. As much as

[jira] [Created] (SOLR-16720) PKI should decorate outgoing requests at "sending", not "enqueueing" time

2023-03-27 Thread Jason Gerlowski (Jira)
Jason Gerlowski created SOLR-16720: -- Summary: PKI should decorate outgoing requests at "sending", not "enqueueing" time Key: SOLR-16720 URL: https://issues.apache.org/jira/browse/SOLR-16720 Project:

[jira] [Commented] (SOLR-16716) Replace commons-io usages with pure Java

2023-03-27 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17705381#comment-17705381 ] ASF subversion and git services commented on SOLR-16716: Commit d

[jira] [Updated] (SOLR-16716) Replace commons-io usages with pure Java

2023-03-27 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16716: Resolution: Fixed Status: Resolved (was: Patch Available) > Replace commons-io usages with

[jira] [Commented] (SOLR-16716) Replace commons-io usages with pure Java

2023-03-27 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17705373#comment-17705373 ] ASF subversion and git services commented on SOLR-16716: Commit c

[GitHub] [solr] risdenk merged pull request #1491: SOLR-16716: Replace commons-io usages with pure Java

2023-03-27 Thread via GitHub
risdenk merged PR #1491: URL: https://github.com/apache/solr/pull/1491 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[GitHub] [solr] uschindler merged pull request #1494: Upgrade forbiddenapis to 3.5

2023-03-27 Thread via GitHub
uschindler merged PR #1494: URL: https://github.com/apache/solr/pull/1494 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache

[jira] [Commented] (SOLR-10466) setDefaultCollection should be deprecated in favor of SolrClientBuilder methods

2023-03-27 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17705288#comment-17705288 ] ASF subversion and git services commented on SOLR-10466: Commit 7

[GitHub] [solr] epugh merged pull request #1256: SOLR-10466: setDefaultCollection should be deprecated in favor of SolrClientBuilder methods

2023-03-27 Thread via GitHub
epugh merged PR #1256: URL: https://github.com/apache/solr/pull/1256 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org