[GitHub] [solr] dsmiley commented on a diff in pull request #1513: SOLR-15703: replace all SolrException.log usage in Solr to just call log.error(...) directly

2023-03-31 Thread via GitHub
dsmiley commented on code in PR #1513: URL: https://github.com/apache/solr/pull/1513#discussion_r1155056589 ## solr/core/src/java/org/apache/solr/core/ZkContainer.java: ## @@ -219,10 +219,10 @@ public void registerInZk(final SolrCore core, boolean background, boolean skipRe

[GitHub] [solr] MarcusSorealheis commented on pull request #1479: SOLR-16465: Replace Login w/ React App

2023-03-31 Thread via GitHub
MarcusSorealheis commented on PR #1479: URL: https://github.com/apache/solr/pull/1479#issuecomment-1492824628 As is the nature of these things, I need to blow away a lot of the work to take a different approach. As I mentioned before, it had been a while since I dusted off my JS chops. Look

[GitHub] [solr] dsmiley commented on a diff in pull request #1501: SOLR-16713: Replace Guava usages with pure Java (part 2)

2023-03-31 Thread via GitHub
dsmiley commented on code in PR #1501: URL: https://github.com/apache/solr/pull/1501#discussion_r1155050465 ## solr/solrj/src/java/org/apache/solr/common/util/StrUtils.java: ## @@ -363,4 +366,16 @@ public static String formatString(String pattern, Object... args) { public st

[GitHub] [solr] solrbot opened a new pull request, #1524: Update org.springframework.boot:spring-boot* to v2.7.10

2023-03-31 Thread via GitHub
solrbot opened a new pull request, #1524: URL: https://github.com/apache/solr/pull/1524 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [org.springframework.boot:spring-boot-starter-web](https://spring.io/projects/spring-boot) ([

[GitHub] [solr] solrbot opened a new pull request, #1523: Update org.apache.kerby:* to v1.1.1

2023-03-31 Thread via GitHub
solrbot opened a new pull request, #1523: URL: https://github.com/apache/solr/pull/1523 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [org.apache.kerby:kerb-simplekdc](https://directory.apache.org/kerby) ([source](https://togith

[GitHub] [solr] solrbot opened a new pull request, #1522: Update dependency org.mockito:mockito-core to v3.12.4

2023-03-31 Thread via GitHub
solrbot opened a new pull request, #1522: URL: https://github.com/apache/solr/pull/1522 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [org.mockito:mockito-core](https://togithub.com/mockito/mockito) | test | minor | `3.8.0` -> `

[GitHub] [solr] solrbot opened a new pull request, #1521: Update dependency org.hsqldb:hsqldb to v2.7.1

2023-03-31 Thread via GitHub
solrbot opened a new pull request, #1521: URL: https://github.com/apache/solr/pull/1521 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [org.hsqldb:hsqldb](http://hsqldb.org) ([source](http://sourceforge.net/p/hsqldb/svn/HEAD)) |

[GitHub] [solr] solrbot opened a new pull request, #1520: Update dependency no.nav.security:mock-oauth2-server to v0.5.8

2023-03-31 Thread via GitHub
solrbot opened a new pull request, #1520: URL: https://github.com/apache/solr/pull/1520 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [no.nav.security:mock-oauth2-server](https://togithub.com/navikt/mock-oauth2-server) | test |

[GitHub] [solr] solrbot opened a new pull request, #1519: Update dependency net.bytebuddy:byte-buddy to v1.14.2

2023-03-31 Thread via GitHub
solrbot opened a new pull request, #1519: URL: https://github.com/apache/solr/pull/1519 This PR contains the following updates: | Package | Type | Update | Change | Pending | |---|---|---|---|---| | [net.bytebuddy:byte-buddy](https://bytebuddy.net) | test | minor | `1.9.3` -> `1

[GitHub] [solr] solrbot opened a new pull request, #1518: Update dependency com.google.cloud:google-cloud-bom to v0.192.0

2023-03-31 Thread via GitHub
solrbot opened a new pull request, #1518: URL: https://github.com/apache/solr/pull/1518 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [com.google.cloud:google-cloud-bom](https://togithub.com/googleapis/java-cloud-bom) | depende

[GitHub] [solr] solrbot opened a new pull request, #1517: Update dependency com.adobe.testing:s3mock-junit4 to v2.11.0

2023-03-31 Thread via GitHub
solrbot opened a new pull request, #1517: URL: https://github.com/apache/solr/pull/1517 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [com.adobe.testing:s3mock-junit4](https://togithub.com/adobe/S3Mock) | test | minor | `2.1.34`

[GitHub] [solr] solrbot opened a new pull request, #1516: Update org.springframework:spring* to v5.3.26

2023-03-31 Thread via GitHub
solrbot opened a new pull request, #1516: URL: https://github.com/apache/solr/pull/1516 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [org.springframework:spring-webmvc](https://togithub.com/spring-projects/spring-framework) |

[GitHub] [solr] solrbot opened a new pull request, #1515: Update org.apache.hadoop:* to v3.3.5

2023-03-31 Thread via GitHub
solrbot opened a new pull request, #1515: URL: https://github.com/apache/solr/pull/1515 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | org.apache.hadoop:hadoop-minikdc | test | patch | `3.3.4` -> `3.3.5` | | org.apache.hadoop:h

[jira] [Commented] (SOLR-16220) Documentation leads to NPE Missing SslContextFactory for SolrJ client

2023-03-31 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17707465#comment-17707465 ] Jan Høydahl commented on SOLR-16220: Is this related to SOLR-16668? Perhaps it works

[jira] [Commented] (SOLR-15948) Server can't be stopped if there are startup errors

2023-03-31 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17707464#comment-17707464 ] Jan Høydahl commented on SOLR-15948: Any update on this? How do you provoke the start

[jira] [Resolved] (SOLR-16557) Solr 9.0.0 - Not able to install 3rd party DIH plugin

2023-03-31 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-16557. Assignee: (was: Ishan Chattopadhyaya) Resolution: Cannot Reproduce Closing as cannot repr

[jira] [Resolved] (SOLR-16605) CPU in UI cloud->nodes is always 0%, even when Solr is very busy.

2023-03-31 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-16605. Fix Version/s: 9.2 Resolution: Fixed Since the commit was released in 9.2, I'll go ahead and

[jira] [Commented] (SOLR-13182) NullPointerException due to an invariant violation in org/apache/lucene/search/BooleanClause.java[60]

2023-03-31 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-13182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17707452#comment-17707452 ] Jan Høydahl commented on SOLR-13182: What is the state of this JIRA? The PR is closed

[jira] [Commented] (SOLR-16659) DistribPackageStore.distribute may alter node name

2023-03-31 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17707451#comment-17707451 ] Jan Høydahl commented on SOLR-16659: [~defonion] feel free to ask if you need some gu

[jira] [Assigned] (SOLR-16649) Http2SolrClient.processErrorsAndResponse uses wrong instance of ResponseParser

2023-03-31 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl reassigned SOLR-16649: -- Assignee: Jan Høydahl > Http2SolrClient.processErrorsAndResponse uses wrong instance of Respon

[GitHub] [solr] janhoy opened a new pull request, #1514: SOLR-16649 Http2SolrClient.processErrorsAndResponse uses wrong instance of ResponseParser

2023-03-31 Thread via GitHub
janhoy opened a new pull request, #1514: URL: https://github.com/apache/solr/pull/1514 https://issues.apache.org/jira/browse/SOLR-16649 Converted patch into PR, added CHANGES -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[jira] [Commented] (SOLR-16688) RELOAD in collections admin does not work on aliases

2023-03-31 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17707449#comment-17707449 ] Jan Høydahl commented on SOLR-16688: I think you should change type to "Feature reque

[jira] [Resolved] (SOLR-16523) Upgrade jattach in 8.11 Dockerfile after Solr 9.2 release

2023-03-31 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-16523. Resolution: Fixed The PR [https://github.com/docker-library/official-images/pull/14382] needs to b

[GitHub] [solr-docker] janhoy merged pull request #14: SOLR-16523 Update the jattach version to 2.0

2023-03-31 Thread via GitHub
janhoy merged PR #14: URL: https://github.com/apache/solr-docker/pull/14 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.

[GitHub] [solr-docker] janhoy commented on pull request #14: SOLR-16523 Update the jattach version to 2.0

2023-03-31 Thread via GitHub
janhoy commented on PR #14: URL: https://github.com/apache/solr-docker/pull/14#issuecomment-1492715535 Think this is good now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [solr] risdenk commented on a diff in pull request #1513: SOLR-15703: replace all SolrException.log usage in Solr to just call log.error(...) directly

2023-03-31 Thread via GitHub
risdenk commented on code in PR #1513: URL: https://github.com/apache/solr/pull/1513#discussion_r1154885795 ## solr/core/src/java/org/apache/solr/core/SolrCore.java: ## @@ -3013,10 +3013,6 @@ public static void postDecorateResponse( } } - public static final void log(

[jira] [Commented] (SOLR-16721) Java version detection fails when `_JAVA_OPTIONS` is set

2023-03-31 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17707422#comment-17707422 ] ASF subversion and git services commented on SOLR-16721: Commit e

[jira] [Resolved] (SOLR-16721) Java version detection fails when `_JAVA_OPTIONS` is set

2023-03-31 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-16721. Fix Version/s: 9.3 Resolution: Fixed > Java version detection fails when `_JAVA_OPTIONS` is

[jira] [Commented] (SOLR-16721) Java version detection fails when `_JAVA_OPTIONS` is set

2023-03-31 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17707420#comment-17707420 ] ASF subversion and git services commented on SOLR-16721: Commit f

[GitHub] [solr] janhoy merged pull request #1502: SOLR-16721 Java version detection fails when `_JAVA_OPTIONS` is set

2023-03-31 Thread via GitHub
janhoy merged PR #1502: URL: https://github.com/apache/solr/pull/1502 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[GitHub] [solr] epugh closed pull request #1254: SOLR-16599: use ventilated prose only in docs

2023-03-31 Thread via GitHub
epugh closed pull request #1254: SOLR-16599: use ventilated prose only in docs URL: https://github.com/apache/solr/pull/1254 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [solr] epugh commented on pull request #1254: SOLR-16599: use ventilated prose only in docs

2023-03-31 Thread via GitHub
epugh commented on PR #1254: URL: https://github.com/apache/solr/pull/1254#issuecomment-1492592317 I am going to close this PR... It doesn't make sense to check it if we don't have a good way to convert everything over first. -- This is an automated message from the Apache Git Servic

[GitHub] [solr] epugh commented on pull request #1107: SOLR-9775 fixed NPEs

2023-03-31 Thread via GitHub
epugh commented on PR #1107: URL: https://github.com/apache/solr/pull/1107#issuecomment-1492589453 @stillalex can you push up to this PR the changes you were thinking about? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [solr] epugh commented on pull request #1107: SOLR-9775 fixed NPEs

2023-03-31 Thread via GitHub
epugh commented on PR #1107: URL: https://github.com/apache/solr/pull/1107#issuecomment-1492586901 @stillalex @risdenk I'm starting to look at various PR's that I've had open for a long time, and trying to get them merged or closed. Are we still happy with this one? -- This is an

[GitHub] [solr] janhoy commented on pull request #1512: SOLR-16731: Use the right cluster property for determining if TLS is enabled

2023-03-31 Thread via GitHub
janhoy commented on PR #1512: URL: https://github.com/apache/solr/pull/1512#issuecomment-1492585215 Ah, I see :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[jira] [Updated] (SOLR-15703) replace all SolrException.log usage in Solr to just call log.error(...) directly

2023-03-31 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-15703: Status: Patch Available (was: Open) > replace all SolrException.log usage in Solr to just call log

[GitHub] [solr] risdenk opened a new pull request, #1513: SOLR-15703: replace all SolrException.log usage in Solr to just call log.error(...) directly

2023-03-31 Thread via GitHub
risdenk opened a new pull request, #1513: URL: https://github.com/apache/solr/pull/1513 https://issues.apache.org/jira/browse/SOLR-15703 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [solr-operator] beettlle opened a new pull request, #541: Update local_tutorial.md

2023-03-31 Thread via GitHub
beettlle opened a new pull request, #541: URL: https://github.com/apache/solr-operator/pull/541 Updating the version of the Autoscaler as it's deprecated. `Warning: autoscaling/v2beta2 HorizontalPodAutoscaler is deprecated in v1.23+, unavailable in v1.26+; use autoscaling/v2 HorizontalPo

[jira] [Updated] (SOLR-15703) replace all SolrException.log usage in Solr to just call log.error(...) directly

2023-03-31 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-15703: Priority: Minor (was: Major) > replace all SolrException.log usage in Solr to just call log.error(

[jira] [Commented] (SOLR-16507) Remove NodeStateProvider & Snitch

2023-03-31 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17707407#comment-17707407 ] ASF subversion and git services commented on SOLR-16507: Commit e

[jira] [Assigned] (SOLR-15703) replace all SolrException.log usage in Solr to just call log.error(...) directly

2023-03-31 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden reassigned SOLR-15703: --- Assignee: Kevin Risden (was: Chris M. Hostetter) > replace all SolrException.log usage in S

[GitHub] [solr-operator] HoustonPutman opened a new pull request, #540: Add CRD options, helm options and a changelog entry

2023-03-31 Thread via GitHub
HoustonPutman opened a new pull request, #540: URL: https://github.com/apache/solr-operator/pull/540 resolves https://github.com/apache/solr-operator/issues/538 List to do: - [ ] Create CRD Options - [ ] Implement feature in controllers - [ ] Add unit tests - [ ] Add He

[GitHub] [solr] stillalex commented on pull request #1504: SOLR-7609 ShardSplitTest NPE investigation

2023-03-31 Thread via GitHub
stillalex commented on PR #1504: URL: https://github.com/apache/solr/pull/1504#issuecomment-1492480511 seeing some local failures due to the newly added 0 version check ``` org.apache.solr.search.TestRecovery > testLogReplayWithReorderedDBQByAsterixAndChildDocs FAILED java.l

[GitHub] [solr] risdenk commented on pull request #1501: SOLR-16713: Replace Guava usages with pure Java (part 2)

2023-03-31 Thread via GitHub
risdenk commented on PR #1501: URL: https://github.com/apache/solr/pull/1501#issuecomment-1492460113 > Ahh ok I get that, but why do all of the readers need to be wrapped by BufferedReader first? yea so they don't that is left over from a previous iteration where I was using Buffered

[jira] [Commented] (SOLR-7609) ShardSplitTest NPE

2023-03-31 Thread Alex Deparvu (Jira)
[ https://issues.apache.org/jira/browse/SOLR-7609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17707396#comment-17707396 ] Alex Deparvu commented on SOLR-7609: (pasting my PR comment here as well, for future r

[GitHub] [solr] tflobbe commented on pull request #1512: SOLR-16731: Use the right cluster property for determining if TLS is enabled

2023-03-31 Thread via GitHub
tflobbe commented on PR #1512: URL: https://github.com/apache/solr/pull/1512#issuecomment-1492448537 It used to work before [this change](https://github.com/apache/solr/pull/460/files#diff-83579b1681fbe3ea47f7340796963b034594921405afb41c62d9415f52f5adcfR360) -- This is an automated messag

[GitHub] [solr] HoustonPutman commented on pull request #1501: SOLR-16713: Replace Guava usages with pure Java (part 2)

2023-03-31 Thread via GitHub
HoustonPutman commented on PR #1501: URL: https://github.com/apache/solr/pull/1501#issuecomment-1492444801 > so added a simple helper to StrUtils to do that conversion. Ahh ok I get that, but why do all of the readers need to be wrapped by `BufferedReader` first? -- This is an auto

[jira] [Commented] (SOLR-16507) Remove NodeStateProvider & Snitch

2023-03-31 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17707393#comment-17707393 ] ASF subversion and git services commented on SOLR-16507: Commit 9

[GitHub] [solr] dsmiley merged pull request #1485: SOLR-16507: Remove NodeStateProvider & Snitch

2023-03-31 Thread via GitHub
dsmiley merged PR #1485: URL: https://github.com/apache/solr/pull/1485 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[GitHub] [solr] stillalex commented on pull request #1504: SOLR-7609 ShardSplitTest NPE investigation

2023-03-31 Thread via GitHub
stillalex commented on PR #1504: URL: https://github.com/apache/solr/pull/1504#issuecomment-1492441639 I have pushed a tentative patch for review and more importantly for discussion. I have ran this test extensively (hundreds of beast jobs) and it looks like this is the way to go, al

[GitHub] [solr] risdenk commented on pull request #1501: SOLR-16713: Replace Guava usages with pure Java (part 2)

2023-03-31 Thread via GitHub
risdenk commented on PR #1501: URL: https://github.com/apache/solr/pull/1501#issuecomment-1492432576 > Why do we want to get rid of `IOUtils.toString()` This is a specific version of IOUtils.toString() specifically one that deals with Java Reader. Basically limits usage of commons-io.

[GitHub] [solr] HoustonPutman commented on pull request #1501: SOLR-16713: Replace Guava usages with pure Java (part 2)

2023-03-31 Thread via GitHub
HoustonPutman commented on PR #1501: URL: https://github.com/apache/solr/pull/1501#issuecomment-1492423646 Why do we want to get rid of `IOUtils.toString()` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [solr] tflobbe opened a new pull request, #1512: SOLR-16731: Use the right cluster property for determining if TLS is enabled

2023-03-31 Thread via GitHub
tflobbe opened a new pull request, #1512: URL: https://github.com/apache/solr/pull/1512 Note that this only changes what's displayed by `SystemInfoHandler` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Updated] (SOLR-16713) Replace Guava usages with pure Java

2023-03-31 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16713: Description: Guava is used in a variety of places that can be simplified especially with Java stre

[jira] [Resolved] (SOLR-16729) NP because roles is null

2023-03-31 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-16729. Resolution: Duplicate See SOLR-16730 for patch > NP because roles is null > --

[GitHub] [solr] janhoy commented on pull request #1511: SOLR-16730: Exclude username, roles and permissions for inter-node requests to SystemInfoHandler

2023-03-31 Thread via GitHub
janhoy commented on PR #1511: URL: https://github.com/apache/solr/pull/1511#issuecomment-1492398190 According to RBAP api, the `[getUserRoles()](https://github.com/apache/solr/blob/main/solr/core/src/java/org/apache/solr/security/RuleBasedAuthorizationPluginBase.java#L371)` call should not

[jira] [Commented] (SOLR-16729) NP because roles is null

2023-03-31 Thread Tomas Eduardo Fernandez Lobbe (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17707384#comment-17707384 ] Tomas Eduardo Fernandez Lobbe commented on SOLR-16729: -- I didn't see

[GitHub] [solr] tflobbe commented on a diff in pull request #1359: SOLR-16658 List of permissions returned to Admin UI is not complete

2023-03-31 Thread via GitHub
tflobbe commented on code in PR #1359: URL: https://github.com/apache/solr/pull/1359#discussion_r1154757112 ## solr/core/src/java/org/apache/solr/handler/admin/SystemInfoHandler.java: ## @@ -339,7 +341,10 @@ public SimpleOrderedMap getSecurityInfo(SolrQueryRequest req) {

[jira] [Updated] (SOLR-16731) "tls" key incorrect in SystemInfoHandler requests

2023-03-31 Thread Tomas Eduardo Fernandez Lobbe (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomas Eduardo Fernandez Lobbe updated SOLR-16731: - Affects Version/s: 9.0 > "tls" key incorrect in SystemInfoHandler

[jira] [Commented] (SOLR-16731) "tls" key incorrect in SystemInfoHandler requests

2023-03-31 Thread Tomas Eduardo Fernandez Lobbe (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17707382#comment-17707382 ] Tomas Eduardo Fernandez Lobbe commented on SOLR-16731: -- This seems t

[jira] [Created] (SOLR-16731) "tls" key incorrect in SystemInfoHandler requests

2023-03-31 Thread Tomas Eduardo Fernandez Lobbe (Jira)
Tomas Eduardo Fernandez Lobbe created SOLR-16731: Summary: "tls" key incorrect in SystemInfoHandler requests Key: SOLR-16731 URL: https://issues.apache.org/jira/browse/SOLR-16731 Projec

[GitHub] [solr] tflobbe opened a new pull request, #1511: SOLR-16730: Exclude username, roles and permissions for inter-node requests to SystemInfoHandler

2023-03-31 Thread via GitHub
tflobbe opened a new pull request, #1511: URL: https://github.com/apache/solr/pull/1511 This PR addresses `SOLR-16730` by completely skipping including the username, roles and permissions when the request is an inter-node request to `SystemInfoHandler`. Having this part alone: ```

[GitHub] [solr-operator] HoustonPutman commented on issue #483: Servicemonitor for prometheus exporter is referring to cluster port instead of metrics pod port

2023-03-31 Thread via GitHub
HoustonPutman commented on issue #483: URL: https://github.com/apache/solr-operator/issues/483#issuecomment-1492374530 I have a patch that I _think_ should work: https://github.com/apache/solr-operator/pull/539. Would someone be willing to try out this fix in their cluster? Steps t

[GitHub] [solr] janhoy commented on a diff in pull request #1359: SOLR-16658 List of permissions returned to Admin UI is not complete

2023-03-31 Thread via GitHub
janhoy commented on code in PR #1359: URL: https://github.com/apache/solr/pull/1359#discussion_r1154744612 ## solr/core/src/java/org/apache/solr/handler/admin/SystemInfoHandler.java: ## @@ -339,7 +341,10 @@ public SimpleOrderedMap getSecurityInfo(SolrQueryRequest req) {

[GitHub] [solr-operator] HoustonPutman opened a new pull request, #539: Remove port annotation from PrometheusExporter service

2023-03-31 Thread via GitHub
HoustonPutman opened a new pull request, #539: URL: https://github.com/apache/solr-operator/pull/539 fixes #483 I think that the Prometheus server will use the port that the service has if none is provided, so this should fix any issues we are seeing. I'd love to see someone t

[jira] [Commented] (SOLR-16730) NPE in SystemInfoHandler for inter-node requests

2023-03-31 Thread Tomas Eduardo Fernandez Lobbe (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17707369#comment-17707369 ] Tomas Eduardo Fernandez Lobbe commented on SOLR-16730: -- I believe th

[GitHub] [solr-operator] HoustonPutman opened a new issue, #538: Make PodDisruptionBudget an optional feature

2023-03-31 Thread via GitHub
HoustonPutman opened a new issue, #538: URL: https://github.com/apache/solr-operator/issues/538 The PDB was added in: https://github.com/apache/solr-operator/issues/471 Not all users are going to want to use a `PodDisruptionBudget` when running Solr. The feature should be able to b

[jira] [Created] (SOLR-16730) NPE in SystemInfoHandler for inter-node requests

2023-03-31 Thread Tomas Eduardo Fernandez Lobbe (Jira)
Tomas Eduardo Fernandez Lobbe created SOLR-16730: Summary: NPE in SystemInfoHandler for inter-node requests Key: SOLR-16730 URL: https://issues.apache.org/jira/browse/SOLR-16730 Project

[jira] [Commented] (SOLR-16728) ClassCastException while creating new collection using JDK17

2023-03-31 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17707364#comment-17707364 ] Houston Putman commented on SOLR-16728: --- So I don't think this is related? The cl

[GitHub] [solr] stillalex commented on pull request #1504: ShardSplitTest flakiness investigation

2023-03-31 Thread via GitHub
stillalex commented on PR #1504: URL: https://github.com/apache/solr/pull/1504#issuecomment-1492285957 There is another weird error I saw while leaving this to run overnight. there are possibly more races, I will focus my proposal to the most common one, the doc addition (will be posting an

[jira] [Updated] (SOLR-16393) Cosmetic improvements and migration to JAX-RS (alias, alias-prop CRUD APIs)

2023-03-31 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated SOLR-16393: --- Description: As mentioned on SOLR-15781, the v2 API currently has an experimental designatio

[jira] [Updated] (SOLR-16393) Cosmetic improvements and migration to JAX-RS (alias, alias-prop CRUD APIs)

2023-03-31 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated SOLR-16393: --- Description: As mentioned on SOLR-15781, the v2 API currently has an experimental designatio

[jira] [Commented] (SOLR-16728) ClassCastException while creating new collection using JDK17

2023-03-31 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17707357#comment-17707357 ] Kevin Risden commented on SOLR-16728: - FYI [~houston] I don't know if this is speci

[jira] [Assigned] (SOLR-16729) NP because roles is null

2023-03-31 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl reassigned SOLR-16729: -- Assignee: Jan Høydahl > NP because roles is null > > >

[jira] [Commented] (SOLR-16729) NP because roles is null

2023-03-31 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17707334#comment-17707334 ] Jan Høydahl commented on SOLR-16729: Moving looong trace to a comment {noformat} 2023

[jira] [Updated] (SOLR-16729) NP because roles is null

2023-03-31 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-16729: --- Description: When using SolrCloud with following simple security.json   {code:java} { "authenticat

[jira] [Updated] (SOLR-16722) API to flag a solr node NOT READY for requests

2023-03-31 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-16722: --- Description: Spinoff from solr operator PR [https://github.com/apache/solr-operator/issues/529] See

[jira] [Commented] (SOLR-16722) API to flag a solr node NOT READY for requests

2023-03-31 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17707326#comment-17707326 ] Jan Høydahl commented on SOLR-16722: See [https://github.com/apache/solr-operator/iss

[jira] [Commented] (SOLR-16441) Upgrade Jetty to 11.x

2023-03-31 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17707296#comment-17707296 ] Kevin Risden commented on SOLR-16441: - [~bwahlen] {quote}current solrj-9.2 uses jet

[jira] [Comment Edited] (SOLR-16441) Upgrade Jetty to 11.x

2023-03-31 Thread Bernd Wahlen (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17707288#comment-17707288 ] Bernd Wahlen edited comment on SOLR-16441 at 3/31/23 3:06 PM: -

[jira] [Comment Edited] (SOLR-16441) Upgrade Jetty to 11.x

2023-03-31 Thread Bernd Wahlen (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17707288#comment-17707288 ] Bernd Wahlen edited comment on SOLR-16441 at 3/31/23 3:06 PM: -

[jira] [Comment Edited] (SOLR-16441) Upgrade Jetty to 11.x

2023-03-31 Thread Bernd Wahlen (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17707288#comment-17707288 ] Bernd Wahlen edited comment on SOLR-16441 at 3/31/23 3:05 PM: -

[jira] [Comment Edited] (SOLR-16441) Upgrade Jetty to 11.x

2023-03-31 Thread Bernd Wahlen (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17707288#comment-17707288 ] Bernd Wahlen edited comment on SOLR-16441 at 3/31/23 3:04 PM: -

[jira] [Commented] (SOLR-16441) Upgrade Jetty to 11.x

2023-03-31 Thread Bernd Wahlen (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17707288#comment-17707288 ] Bernd Wahlen commented on SOLR-16441: - - spring boot 2.7.y uses jetty 9.4 - spring bo

[GitHub] [solr-operator] HoustonPutman commented on issue #537: Slow restart of Solr Pod init_container cp-solr-xml chown

2023-03-31 Thread via GitHub
HoustonPutman commented on issue #537: URL: https://github.com/apache/solr-operator/issues/537#issuecomment-1491984499 Yeah, sounds like a good improvement! Looks like you are testing out some options, so make a PR when you are ready. -- This is an automated message from the Apache Git Se

[GitHub] [solr-operator] smoldenhauer-ish commented on issue #537: Slow restart of Solr Pod init_container cp-solr-xml chown

2023-03-31 Thread via GitHub
smoldenhauer-ish commented on issue #537: URL: https://github.com/apache/solr-operator/issues/537#issuecomment-1491648615 basic idea is to skip the chown if the backup directory is already writable for the solr user. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [solr] janhoy commented on pull request #1502: SOLR-16721 Java version detection fails when `_JAVA_OPTIONS` is set

2023-03-31 Thread via GitHub
janhoy commented on PR #1502: URL: https://github.com/apache/solr/pull/1502#issuecomment-1491630140 Yep, with your example you'd get this output: ``` 8 42 ``` Agree it won't hurt adding back the head -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [solr-operator] smoldenhauer-ish opened a new issue, #537: Slow restart of Solr Pod init_container cp-solr-xml chown

2023-03-31 Thread via GitHub
smoldenhauer-ish opened a new issue, #537: URL: https://github.com/apache/solr-operator/issues/537 Solr Operator 0.6.0 In our deployments a restart of Solr Pods will take minutes up to half an hour. The init container cp-solr-xml with the command cp /tmp/solr.xml /tmp-config/solr.xm

[jira] [Created] (SOLR-16729) NP because roles is null

2023-03-31 Thread Jira
Thomas Wöckinger created SOLR-16729: --- Summary: NP because roles is null Key: SOLR-16729 URL: https://issues.apache.org/jira/browse/SOLR-16729 Project: Solr Issue Type: Bug Security Le

[GitHub] [solr] alessandrobenedetti commented on a diff in pull request #1435: SOLR-16674: Introduce dense vector byte encoding

2023-03-31 Thread via GitHub
alessandrobenedetti commented on code in PR #1435: URL: https://github.com/apache/solr/pull/1435#discussion_r1154191299 ## solr/solr-ref-guide/modules/query-guide/pages/dense-vector-search.adoc: ## @@ -126,6 +126,18 @@ Accepted values: `hnsw`. Please note that the `knnAlgorit

[GitHub] [solr] alessandrobenedetti commented on a diff in pull request #1435: SOLR-16674: Introduce dense vector byte encoding

2023-03-31 Thread via GitHub
alessandrobenedetti commented on code in PR #1435: URL: https://github.com/apache/solr/pull/1435#discussion_r1154188607 ## solr/core/src/test/org/apache/solr/search/neural/KnnQParserTest.java: ## @@ -205,6 +214,31 @@ public void correctVectorField_shouldSearchOnThatField() {

[jira] [Created] (SOLR-16728) ClassCastException while creating new collection using JDK17

2023-03-31 Thread Jira
Thomas Wöckinger created SOLR-16728: --- Summary: ClassCastException while creating new collection using JDK17 Key: SOLR-16728 URL: https://issues.apache.org/jira/browse/SOLR-16728 Project: Solr

[GitHub] [solr] alessandrobenedetti commented on a diff in pull request #1435: SOLR-16674: Introduce dense vector byte encoding

2023-03-31 Thread via GitHub
alessandrobenedetti commented on code in PR #1435: URL: https://github.com/apache/solr/pull/1435#discussion_r1154186439 ## solr/core/src/test/org/apache/solr/schema/DenseVectorFieldTest.java: ## @@ -458,4 +574,127 @@ public void query_functionQueryUsage_shouldThrowException() t

[GitHub] [solr] alessandrobenedetti commented on a diff in pull request #1435: SOLR-16674: Introduce dense vector byte encoding

2023-03-31 Thread via GitHub
alessandrobenedetti commented on code in PR #1435: URL: https://github.com/apache/solr/pull/1435#discussion_r1154184243 ## solr/core/src/test/org/apache/solr/schema/DenseVectorFieldTest.java: ## @@ -357,6 +452,27 @@ public void query_storedField_shouldBeReturnedInResults() thro

[GitHub] [solr] alessandrobenedetti commented on a diff in pull request #1435: SOLR-16674: Introduce dense vector byte encoding

2023-03-31 Thread via GitHub
alessandrobenedetti commented on code in PR #1435: URL: https://github.com/apache/solr/pull/1435#discussion_r1154182662 ## solr/core/src/test/org/apache/solr/schema/DenseVectorFieldTest.java: ## @@ -253,10 +332,17 @@ public void parseVector_incorrectElement_shouldThrowException

[GitHub] [solr] alessandrobenedetti commented on a diff in pull request #1435: SOLR-16674: Introduce dense vector byte encoding

2023-03-31 Thread via GitHub
alessandrobenedetti commented on code in PR #1435: URL: https://github.com/apache/solr/pull/1435#discussion_r1154182254 ## solr/core/src/test/org/apache/solr/schema/DenseVectorFieldTest.java: ## @@ -253,10 +332,17 @@ public void parseVector_incorrectElement_shouldThrowException

[GitHub] [solr] alessandrobenedetti commented on a diff in pull request #1435: SOLR-16674: Introduce dense vector byte encoding

2023-03-31 Thread via GitHub
alessandrobenedetti commented on code in PR #1435: URL: https://github.com/apache/solr/pull/1435#discussion_r1154179416 ## solr/core/src/test/org/apache/solr/schema/DenseVectorFieldTest.java: ## @@ -171,57 +182,111 @@ public void parseVector_NotAList_shouldThrowException() {

[GitHub] [solr] alessandrobenedetti commented on a diff in pull request #1435: SOLR-16674: Introduce dense vector byte encoding

2023-03-31 Thread via GitHub
alessandrobenedetti commented on code in PR #1435: URL: https://github.com/apache/solr/pull/1435#discussion_r1154177094 ## solr/core/src/java/org/apache/solr/schema/DenseVectorField.java: ## @@ -205,53 +257,144 @@ public IndexableField createField(SchemaField field, Object pars

[GitHub] [solr] alessandrobenedetti commented on a diff in pull request #1435: SOLR-16674: Introduce dense vector byte encoding

2023-03-31 Thread via GitHub
alessandrobenedetti commented on code in PR #1435: URL: https://github.com/apache/solr/pull/1435#discussion_r1154173619 ## solr/core/src/java/org/apache/solr/schema/DenseVectorField.java: ## @@ -205,53 +257,144 @@ public IndexableField createField(SchemaField field, Object pars