stillalex commented on PR #1504:
URL: https://github.com/apache/solr/pull/1504#issuecomment-1518426686
I spent some more time on this class and have identified 2 problematic
things I wanted to share:
* this looks like a NPE waiting to happen
https://github.com/apache/solr/blob/db4cb6627
[
https://issues.apache.org/jira/browse/SOLR-16753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715165#comment-17715165
]
Noble Paul commented on SOLR-16753:
---
I have reverted the change from main and 9x . let'
[
https://issues.apache.org/jira/browse/SOLR-16753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714380#comment-17714380
]
Noble Paul edited comment on SOLR-16753 at 4/21/23 8:40 PM:
{
[
https://issues.apache.org/jira/browse/SOLR-16753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715164#comment-17715164
]
ASF subversion and git services commented on SOLR-16753:
Commit 0
[
https://issues.apache.org/jira/browse/SOLR-16753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715163#comment-17715163
]
ASF subversion and git services commented on SOLR-16753:
Commit 1
[
https://issues.apache.org/jira/browse/SOLR-16737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715142#comment-17715142
]
Alex Deparvu commented on SOLR-16737:
-
I am working on a PR for this, will be posted
[
https://issues.apache.org/jira/browse/SOLR-16741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Sweeney updated SOLR-16741:
--
Fix Version/s: 9.2.1
(was: 9.3)
> CLUSTERSTATUS API returns wrong value
[
https://issues.apache.org/jira/browse/SOLR-16741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715139#comment-17715139
]
Justin Sweeney commented on SOLR-16741:
---
I cherry-picked these changes onto branch_
[
https://issues.apache.org/jira/browse/SOLR-16741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715136#comment-17715136
]
ASF subversion and git services commented on SOLR-16741:
Commit 8
[
https://issues.apache.org/jira/browse/SOLR-16741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715135#comment-17715135
]
ASF subversion and git services commented on SOLR-16741:
Commit 3
[
https://issues.apache.org/jira/browse/SOLR-16741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715137#comment-17715137
]
ASF subversion and git services commented on SOLR-16741:
Commit a
stillalex commented on code in PR #1564:
URL: https://github.com/apache/solr/pull/1564#discussion_r1174077500
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##
@@ -1290,20 +1240,6 @@ public ResponseParser getParser() {
return parser;
}
-
stillalex commented on PR #1504:
URL: https://github.com/apache/solr/pull/1504#issuecomment-1518101663
> That is very similar to my other PR that does the same thing for a similar
case. I might just list both together, which we do sometimes.
The CHANGES.txt proposal sounds good to me,
[
https://issues.apache.org/jira/browse/SOLR-16759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anna updated SOLR-16759:
Summary: Introducing logAll parameter in the feature logger (was:
Introducing extractAll parameter in the feature
Anna created SOLR-16759:
---
Summary: Introducing extractAll parameter in the feature logger
Key: SOLR-16759
URL: https://issues.apache.org/jira/browse/SOLR-16759
Project: Solr
Issue Type: Improvement
15 matches
Mail list logo
