[GitHub] [solr] alessandrobenedetti commented on a diff in pull request #1680: SOLR-16836: introduce support for high dimensional vectors

2023-06-02 Thread via GitHub
alessandrobenedetti commented on code in PR #1680: URL: https://github.com/apache/solr/pull/1680#discussion_r1214612701 ## solr/core/src/test-files/solr/collection1/conf/schema-densevector-high-dimensionality.xml: ## @@ -0,0 +1,52 @@ + + + + + + + + + + + Review Comme

[GitHub] [solr] alessandrobenedetti commented on a diff in pull request #1680: SOLR-16836: introduce support for high dimensional vectors

2023-06-02 Thread via GitHub
alessandrobenedetti commented on code in PR #1680: URL: https://github.com/apache/solr/pull/1680#discussion_r1214612374 ## solr/core/src/java/org/apache/solr/schema/DenseVectorField.java: ## @@ -218,22 +238,46 @@ public List createFields(SchemaField field, Object value) {

[GitHub] [solr] alessandrobenedetti commented on a diff in pull request #1680: SOLR-16836: introduce support for high dimensional vectors

2023-06-02 Thread via GitHub
alessandrobenedetti commented on code in PR #1680: URL: https://github.com/apache/solr/pull/1680#discussion_r1214611949 ## solr/core/src/test/org/apache/solr/schema/DenseVectorFieldTest.java: ## @@ -456,6 +458,25 @@ public void indexing_correctDocument_shouldBeIndexed() throws

[GitHub] [solr] sonatype-lift[bot] commented on a diff in pull request #1682: SOLR-16395 JAX-RS conversion for zkversion and field related endpoints.

2023-06-02 Thread via GitHub
sonatype-lift[bot] commented on code in PR #1682: URL: https://github.com/apache/solr/pull/1682#discussion_r1214594404 ## solr/core/src/java/org/apache/solr/handler/admin/api/GetSchemaZkVersionAPI.java: ## @@ -0,0 +1,69 @@ +package org.apache.solr.handler.admin.api; + +import st

[GitHub] [solr] bszabo97 opened a new pull request, #1682: SOLR-16395 JAX-RS conversion for zkversion and field related endpoints.

2023-06-02 Thread via GitHub
bszabo97 opened a new pull request, #1682: URL: https://github.com/apache/solr/pull/1682 https://issues.apache.org/jira/browse/SOLR-16395 # Description This PR contains the JAX-RS conversion of endpoints: * /zkversion * /fields * /fields/{fieldname} * /copyfi

[GitHub] [solr] gerlowskija commented on pull request #1681: SOLR-16835: Generate Python client from OpenAPI spec

2023-06-02 Thread via GitHub
gerlowskija commented on PR #1681: URL: https://github.com/apache/solr/pull/1681#issuecomment-1573892626 I've left this as a "draft" to signal that I don't intend to merge it imminently, but this is largely ready to go if anyone wants to review or pull it down to try out. I'd really love s

[GitHub] [solr] gerlowskija opened a new pull request, #1681: SOLR-16835: Generate Python client from OpenAPI spec

2023-06-02 Thread via GitHub
gerlowskija opened a new pull request, #1681: URL: https://github.com/apache/solr/pull/1681 https://issues.apache.org/jira/browse/SOLR-16835 # Description Currently, Solr only offers one "first-party" client, SolrJ, which can only be used within JVM environments. This is obvio

[GitHub] [solr-operator] HoustonPutman commented on a diff in pull request #576: Document how a simple load balancer can be achieved through annotations on the headlessServiceOptions

2023-06-02 Thread via GitHub
HoustonPutman commented on code in PR #576: URL: https://github.com/apache/solr-operator/pull/576#discussion_r1214424449 ## docs/solr-cloud/solr-cloud-crd.md: ## @@ -151,6 +151,16 @@ If both of those criteria are met, then an individual ClusterIP Service will be If you are usi

[GitHub] [solr-operator] HoustonPutman commented on issue #577: Getting crashloopbackoff error in zookeeper cluster

2023-06-02 Thread via GitHub
HoustonPutman commented on issue #577: URL: https://github.com/apache/solr-operator/issues/577#issuecomment-1573792480 This sounds like an issue with the Zookeeper Operator (which actually runs the provided zookeeper cluster). I would recommend either: - Opening an issue in the

[GitHub] [solr-operator] HoustonPutman closed issue #577: Getting crashloopbackoff error in zookeeper cluster

2023-06-02 Thread via GitHub
HoustonPutman closed issue #577: Getting crashloopbackoff error in zookeeper cluster URL: https://github.com/apache/solr-operator/issues/577 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [solr] dsmiley commented on a diff in pull request #1680: SOLR-16836: introduce support for high dimensional vectors

2023-06-02 Thread via GitHub
dsmiley commented on code in PR #1680: URL: https://github.com/apache/solr/pull/1680#discussion_r1214296464 ## solr/core/src/test/org/apache/solr/schema/DenseVectorFieldTest.java: ## @@ -456,6 +458,25 @@ public void indexing_correctDocument_shouldBeIndexed() throws Exception {

[GitHub] [solr] alessandrobenedetti opened a new pull request, #1680: SOLR-16836: introduce support for high dimensional vectors

2023-06-02 Thread via GitHub
alessandrobenedetti opened a new pull request, #1680: URL: https://github.com/apache/solr/pull/1680 https://issues.apache.org/jira/browse/SOLR-16836 # Description Very simple draft implementation to support high dimensional vector in Apache Solr. It's a small change but quit

[jira] [Created] (SOLR-16836) DenseVectorField to support dimensions > 1024

2023-06-02 Thread Alessandro Benedetti (Jira)
Alessandro Benedetti created SOLR-16836: --- Summary: DenseVectorField to support dimensions > 1024 Key: SOLR-16836 URL: https://issues.apache.org/jira/browse/SOLR-16836 Project: Solr Issu

[GitHub] [solr] janhoy commented on pull request #193: SOLR-15474: Support Pluggable Circuit Breakers

2023-06-02 Thread via GitHub
janhoy commented on PR #193: URL: https://github.com/apache/solr/pull/193#issuecomment-1573383899 @atris It is unclear to me what remains to land this fine PR. Where is review still needed? Where is help still needed? -- This is an automated message from the Apache Git Service. To respond

[GitHub] [solr] janhoy commented on pull request #96: SOLR-15056: add circuit breaker for CPU, fix load circuit breaker

2023-06-02 Thread via GitHub
janhoy commented on PR #96: URL: https://github.com/apache/solr/pull/96#issuecomment-1573373516 @wrunderwood , @atris , it's a shame that this fine PR was abandoned due to bike shedding. Perhaps 24 months distance can help put it in a new light and get this ball rolling again? I'm also keen