[GitHub] [solr-operator] anilkhichar closed issue #593: Could not find a backup repository with name `solr-backup-s3-repo`

2023-07-24 Thread via GitHub
anilkhichar closed issue #593: Could not find a backup repository with name `solr-backup-s3-repo` URL: https://github.com/apache/solr-operator/issues/593 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [solr-operator] anilkhichar commented on issue #593: Could not find a backup repository with name `solr-backup-s3-repo`

2023-07-24 Thread via GitHub
anilkhichar commented on issue #593: URL: https://github.com/apache/solr-operator/issues/593#issuecomment-1648850445 Thank you @HoustonPutman for the guidance. Yes, we are using custom solr xml and that was the root cause. I wish, the solr backup document would have mentioned it. I will rai

[GitHub] [solr] janhoy commented on pull request #1791: add support of OAuth 2.0/OIDC 'code with PKCE' flow (front-end)

2023-07-24 Thread via GitHub
janhoy commented on PR #1791: URL: https://github.com/apache/solr/pull/1791#issuecomment-1648720273 I’m on vacation so please proceed without my review. I’m thrilled to see this be completed. Ok to support impl flow for 9.x but it should be removed for 10.0 -- This is an automated messag

[GitHub] [solr] gerlowskija commented on a diff in pull request #1774: SOLR-16397: Create v2(JAX-RS) endpoints for RELOAD core

2023-07-24 Thread via GitHub
gerlowskija commented on code in PR #1774: URL: https://github.com/apache/solr/pull/1774#discussion_r1272781413 ## solr/core/src/java/org/apache/solr/handler/admin/api/ReloadCoreAPI.java: ## @@ -17,52 +17,56 @@ package org.apache.solr.handler.admin.api; -import static org.a

[GitHub] [solr] gerlowskija commented on a diff in pull request #1740: SOLR-16490: Create a v2 equivalent for /admin/cores BACKUPCORE

2023-07-24 Thread via GitHub
gerlowskija commented on code in PR #1740: URL: https://github.com/apache/solr/pull/1740#discussion_r1272774432 ## solr/core/src/java/org/apache/solr/handler/admin/api/BackupCoreAPI.java: ## @@ -0,0 +1,171 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [solr] gerlowskija commented on a diff in pull request #1740: SOLR-16490: Create a v2 equivalent for /admin/cores BACKUPCORE

2023-07-24 Thread via GitHub
gerlowskija commented on code in PR #1740: URL: https://github.com/apache/solr/pull/1740#discussion_r1272773932 ## solr/core/src/java/org/apache/solr/handler/admin/api/BackupCoreAPI.java: ## @@ -0,0 +1,171 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[jira] [Resolved] (SOLR-16901) Fix gradle workflow for non-signed official images

2023-07-24 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman resolved SOLR-16901. --- Fix Version/s: 9.4 9.3.1 Resolution: Fixed > Fix gradle workflow fo

[GitHub] [solr] gerlowskija commented on a diff in pull request #1740: SOLR-16490: Create a v2 equivalent for /admin/cores BACKUPCORE

2023-07-24 Thread via GitHub
gerlowskija commented on code in PR #1740: URL: https://github.com/apache/solr/pull/1740#discussion_r1272662520 ## solr/core/src/java/org/apache/solr/handler/admin/api/BackupCoreAPI.java: ## @@ -0,0 +1,171 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [solr] gerlowskija commented on a diff in pull request #1740: SOLR-16490: Create a v2 equivalent for /admin/cores BACKUPCORE

2023-07-24 Thread via GitHub
gerlowskija commented on code in PR #1740: URL: https://github.com/apache/solr/pull/1740#discussion_r1272725984 ## solr/core/src/java/org/apache/solr/handler/admin/api/BackupCoreAPI.java: ## @@ -0,0 +1,171 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [solr] gerlowskija commented on a diff in pull request #1740: SOLR-16490: Create a v2 equivalent for /admin/cores BACKUPCORE

2023-07-24 Thread via GitHub
gerlowskija commented on code in PR #1740: URL: https://github.com/apache/solr/pull/1740#discussion_r1272725539 ## solr/core/src/java/org/apache/solr/handler/admin/api/BackupCoreAPI.java: ## @@ -0,0 +1,171 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [solr] dsmiley commented on a diff in pull request #1785: SOLR-16892: make CreateTool Cloud/Standalone Aware

2023-07-24 Thread via GitHub
dsmiley commented on code in PR #1785: URL: https://github.com/apache/solr/pull/1785#discussion_r1272681973 ## solr/core/src/java/org/apache/solr/cli/CreateTool.java: ## @@ -43,24 +68,295 @@ public String getName() { @Override public List getOptions() { -return Creat

[jira] [Commented] (SOLR-14496) Add basic auth support to postlogs

2023-07-24 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17746616#comment-17746616 ] Eric Pugh commented on SOLR-14496: -- I suspect this could be "Ensure Basic Auth Support o

[GitHub] [solr] gerlowskija commented on a diff in pull request #1740: SOLR-16490: Create a v2 equivalent for /admin/cores BACKUPCORE

2023-07-24 Thread via GitHub
gerlowskija commented on code in PR #1740: URL: https://github.com/apache/solr/pull/1740#discussion_r1272662520 ## solr/core/src/java/org/apache/solr/handler/admin/api/BackupCoreAPI.java: ## @@ -0,0 +1,171 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [solr] gerlowskija commented on a diff in pull request #1740: SOLR-16490: Create a v2 equivalent for /admin/cores BACKUPCORE

2023-07-24 Thread via GitHub
gerlowskija commented on code in PR #1740: URL: https://github.com/apache/solr/pull/1740#discussion_r1272661264 ## solr/core/src/java/org/apache/solr/handler/admin/api/BackupCoreAPI.java: ## @@ -0,0 +1,171 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[jira] [Commented] (SOLR-16800) Allow create and delete to use -url instead of -c and work with remote solr.

2023-07-24 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17746614#comment-17746614 ] Eric Pugh commented on SOLR-16800: -- I'll make sure that bin/solr healthcheck takes a -so

[GitHub] [solr] gerlowskija commented on a diff in pull request #1740: SOLR-16490: Create a v2 equivalent for /admin/cores BACKUPCORE

2023-07-24 Thread via GitHub
gerlowskija commented on code in PR #1740: URL: https://github.com/apache/solr/pull/1740#discussion_r1272653851 ## solr/core/src/java/org/apache/solr/handler/admin/api/BackupCoreAPI.java: ## @@ -0,0 +1,171 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[jira] [Commented] (SOLR-16800) Allow create and delete to use -url instead of -c and work with remote solr.

2023-07-24 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17746613#comment-17746613 ] Eric Pugh commented on SOLR-16800: -- Updated the title to reflect that in the very near f

[jira] [Updated] (SOLR-16800) Allow create and delete to use -url instead of -c and work with remote solr.

2023-07-24 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh updated SOLR-16800: - Summary: Allow create and delete to use -url instead of -c and work with remote solr. (was: Allow create

[jira] [Commented] (SOLR-16875) Resolve Fate of bin/post and the SimplePostTool code base.

2023-07-24 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17746578#comment-17746578 ] Eric Pugh commented on SOLR-16875: -- We are letting the bin/solr post addition in main "b

[jira] [Commented] (SOLR-16897) add support of OAuth 2.0/OIDC 'code with PKCE' flow (back-end)

2023-07-24 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17746566#comment-17746566 ] Eric Pugh commented on SOLR-16897: -- The only CLI that I've used regularly that does this

[GitHub] [solr] epugh commented on a diff in pull request #1805: SOLR-16803: Remove dependencies on SimplePostTool from Solr Core classes..

2023-07-24 Thread via GitHub
epugh commented on code in PR #1805: URL: https://github.com/apache/solr/pull/1805#discussion_r1272565454 ## solr/core/src/java/org/apache/solr/util/BinaryUtils.java: ## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor l

[GitHub] [solr] gerlowskija commented on a diff in pull request #1740: SOLR-16490: Create a v2 equivalent for /admin/cores BACKUPCORE

2023-07-24 Thread via GitHub
gerlowskija commented on code in PR #1740: URL: https://github.com/apache/solr/pull/1740#discussion_r1272544000 ## solr/core/src/java/org/apache/solr/handler/admin/api/BackupCoreAPI.java: ## @@ -0,0 +1,171 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [solr] rafalh commented on pull request #1801: Fix a typo in move-replica API documentation

2023-07-24 Thread via GitHub
rafalh commented on PR #1801: URL: https://github.com/apache/solr/pull/1801#issuecomment-1648129495 Thanks @gerlowskija for letting me know. Somehow I missed the `main` branch :sweat_smile: I think I've checked `master` branch and after realizing it has very old commits I through `branch_9x

[jira] [Commented] (SOLR-16897) add support of OAuth 2.0/OIDC 'code with PKCE' flow (back-end)

2023-07-24 Thread Lamine (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17746492#comment-17746492 ] Lamine commented on SOLR-16897: --- Hi [~epugh] , That's an interesting question. If you're

[GitHub] [solr] gerlowskija commented on pull request #1801: Fix a typo in move-replica API documentation

2023-07-24 Thread via GitHub
gerlowskija commented on PR #1801: URL: https://github.com/apache/solr/pull/1801#issuecomment-1647973043 One small note for next time - usually we ask contributors to develop against `main` rather than `branch_9x`. It just helps to keep things uniform I guess. Anyway, thanks again fo

[GitHub] [solr] gerlowskija commented on pull request #1801: Fix a typo in move-replica API documentation

2023-07-24 Thread via GitHub
gerlowskija commented on PR #1801: URL: https://github.com/apache/solr/pull/1801#issuecomment-1647957316 Looks great; thanks for the doc-fix @rafalh ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [solr] gerlowskija merged pull request #1801: Fix a typo in move-replica API documentation

2023-07-24 Thread via GitHub
gerlowskija merged PR #1801: URL: https://github.com/apache/solr/pull/1801 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apach

[GitHub] [solr] epugh commented on pull request #1805: SOLR-16803: Remove dependencies on SimplePostTool from Solr Core classes..

2023-07-24 Thread via GitHub
epugh commented on PR #1805: URL: https://github.com/apache/solr/pull/1805#issuecomment-1647882178 Great feedback @risdenk, especially on coming up with a better name ;-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [solr] risdenk commented on a diff in pull request #1805: SOLR-16803: Remove dependencies on SimplePostTool from Solr Core classes..

2023-07-24 Thread via GitHub
risdenk commented on code in PR #1805: URL: https://github.com/apache/solr/pull/1805#discussion_r1272208331 ## solr/core/src/java/org/apache/solr/util/BinaryUtils.java: ## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor

[GitHub] [solr] epugh commented on pull request #1786: SOLR-16883: Use postlogs tool from windows and unix via solr cli infrastructure.

2023-07-24 Thread via GitHub
epugh commented on PR #1786: URL: https://github.com/apache/solr/pull/1786#issuecomment-1647729418 @joel-bernstein I ran with it a bit and deprecated the SolrLogPostTool in favour of PostLogsTool and updated the ref guide as well in this PR. -- This is an automated message from the Apache

[jira] [Commented] (SOLR-16871) Race condition for coordinator node init

2023-07-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17746394#comment-17746394 ] ASF subversion and git services commented on SOLR-16871: Commit 8

[jira] [Commented] (SOLR-16871) Race condition for coordinator node init

2023-07-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17746392#comment-17746392 ] ASF subversion and git services commented on SOLR-16871: Commit c

[GitHub] [solr] noblepaul merged pull request #1800: SOLR-16871: Synchronize on a larger block to avoid race condition in CoordinatorHttpSolrCall init

2023-07-24 Thread via GitHub
noblepaul merged PR #1800: URL: https://github.com/apache/solr/pull/1800 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.