dsmiley commented on PR #1854:
URL: https://github.com/apache/solr/pull/1854#issuecomment-1685595403
I'm so glad you managed to implement this in core! Changes looks good.
FYI, one gap in propagation is that our Apache HttpClient isn't instrumented
with tracing, only the Jetty HttpCl
dsmiley commented on code in PR #1854:
URL: https://github.com/apache/solr/pull/1854#discussion_r1299567945
##
solr/core/src/test/org/apache/solr/util/tracing/TestSimplePropagatorDistributedTracing.java:
##
@@ -0,0 +1,130 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
stillalex commented on code in PR #1854:
URL: https://github.com/apache/solr/pull/1854#discussion_r1299447450
##
solr/modules/opentelemetry/src/test/org/apache/solr/opentelemetry/TestSimplePropagatorDistributedTracing.java:
##
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the Apache Sof
stillalex commented on code in PR #1854:
URL: https://github.com/apache/solr/pull/1854#discussion_r1299447062
##
solr/core/src/test/org/apache/solr/util/tracing/TestSimplePropagatorDistributedTracing.java:
##
@@ -0,0 +1,130 @@
+/*
+ * Licensed to the Apache Software Foundation (
stillalex commented on PR #1854:
URL: https://github.com/apache/solr/pull/1854#issuecomment-1685416582
@dsmiley thank you for the review so far. I managed to successfully move the
functionality to solr-core without extra dependencies (just api and context). I
think this allows for much more
