dsmiley commented on code in PR #1886:
URL: https://github.com/apache/solr/pull/1886#discussion_r1313721917
##
solr/core/src/test/org/apache/solr/search/TestThinCache.java:
##
@@ -26,13 +26,63 @@
import org.apache.solr.SolrTestCaseJ4;
import org.apache.solr.metrics.SolrMetricM
dsmiley opened a new pull request, #1886:
URL: https://github.com/apache/solr/pull/1886
* remove 2 test config files
* revert "solr.tests.loadSolrXml" option recently added
* use EmbeddedSolrServerTestRule for initialization
https://issues.apache.org/jira/browse/SOLR-16654
dsmiley commented on code in PR #1884:
URL: https://github.com/apache/solr/pull/1884#discussion_r1313674795
##
solr/modules/opentelemetry/src/test/org/apache/solr/opentelemetry/BasicAuthIntegrationTracingTest.java:
##
@@ -0,0 +1,103 @@
+/*
+ * Licensed to the Apache Software Fou
HoustonPutman commented on PR #611:
URL: https://github.com/apache/solr-operator/pull/611#issuecomment-1703280178
The integration tests will only work with 8.11, until #610 is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
gerlowskija opened a new pull request, #1885:
URL: https://github.com/apache/solr/pull/1885
https://issues.apache.org/jira/browse/SOLR-16825
# Description
Many of Solr's api definitions rely on `@Produces` annotation to explicitly
declare the response content types that the
[
https://issues.apache.org/jira/browse/SOLR-15734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17761388#comment-17761388
]
ASF subversion and git services commented on SOLR-15734:
Commit 4
[
https://issues.apache.org/jira/browse/SOLR-15734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17761386#comment-17761386
]
ASF subversion and git services commented on SOLR-15734:
Commit 8
gerlowskija merged PR #1876:
URL: https://github.com/apache/solr/pull/1876
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apach
gerlowskija commented on PR #1876:
URL: https://github.com/apache/solr/pull/1876#issuecomment-1703224136
> Would this page benefit from a short sample API calss with annotations at
the end? Or just link to a source file suitable for learning?
Good suggestion - I ended up linking to so
gerlowskija commented on code in PR #1876:
URL: https://github.com/apache/solr/pull/1876#discussion_r1313407091
##
dev-docs/apis.adoc:
##
@@ -0,0 +1,81 @@
+= APIs in Solr
+:toc: left
+
+Solr's codebase currently has a handful of ways of defining APIs.
+This complexity stems larg
dsmiley commented on PR #1824:
URL: https://github.com/apache/solr/pull/1824#issuecomment-1703185731
I'll merge this Monday if I hear no further feedback. We've been using this
in production and it's been peer reviewed.
--
This is an automated message from the Apache Git Service.
To resp
stillalex commented on code in PR #1868:
URL: https://github.com/apache/solr/pull/1868#discussion_r1313379893
##
solr/core/src/java/org/apache/solr/util/tracing/SimplePropagator.java:
##
@@ -0,0 +1,304 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
[
https://issues.apache.org/jira/browse/SOLR-16955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17761370#comment-17761370
]
David Smiley commented on SOLR-16955:
-
I agree; consuming the stream is risky. Your
[
https://issues.apache.org/jira/browse/SOLR-16955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17761368#comment-17761368
]
Alex Deparvu commented on SOLR-16955:
-
posted a PR for review https://github.com/apac
stillalex opened a new pull request, #1884:
URL: https://github.com/apache/solr/pull/1884
https://issues.apache.org/jira/browse/SOLR-16955
# Description
V2HttpCall reads the request stream to determine a better name for the
tracing span. this is problematic as other
[
https://issues.apache.org/jira/browse/SOLR-16955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Deparvu reassigned SOLR-16955:
---
Assignee: Alex Deparvu
> Tracing v2 apis breaks SecurityConfHandler
> --
dsmiley commented on code in PR #1868:
URL: https://github.com/apache/solr/pull/1868#discussion_r1313353614
##
solr/core/src/java/org/apache/solr/util/tracing/SimplePropagator.java:
##
@@ -0,0 +1,304 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
[
https://issues.apache.org/jira/browse/SOLR-16825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17761360#comment-17761360
]
ASF subversion and git services commented on SOLR-16825:
Commit 4
cpoerschke commented on code in PR #1880:
URL: https://github.com/apache/solr/pull/1880#discussion_r1313306240
##
solr/bin/solr:
##
@@ -1301,6 +1301,7 @@ if [ $# -gt 0 ]; then
exit 1
fi
SOLR_PORT="$2"
+PROVIDED_SOLR_PORT=SOLR_
[
https://issues.apache.org/jira/browse/SOLR-16825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17761358#comment-17761358
]
ASF subversion and git services commented on SOLR-16825:
Commit 9
gerlowskija merged PR #1866:
URL: https://github.com/apache/solr/pull/1866
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apach
gerlowskija commented on PR #1866:
URL: https://github.com/apache/solr/pull/1866#issuecomment-1703071652
Sounds good; I'll merge this in for now and we can revisit later if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
[
https://issues.apache.org/jira/browse/SOLR-16955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17761352#comment-17761352
]
Alex Deparvu commented on SOLR-16955:
-
Adding more details: the span name for v2 apis
stillalex commented on PR #1856:
URL: https://github.com/apache/solr/pull/1856#issuecomment-1702990381
I think this should be in good shape to go in, @dsmiley. there is a bit more
to be investigated in the SimplePropagator area, but I can create a followup
task.
--
This is an automated m
[
https://issues.apache.org/jira/browse/SOLR-15440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christine Poerschke updated SOLR-15440:
---
Fix Version/s: main (10.0)
9.4
> contrib/ltr FieldValueFeature: Do
[
https://issues.apache.org/jira/browse/SOLR-15440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17761337#comment-17761337
]
Christine Poerschke commented on SOLR-15440:
Opened https://github.com/apache
cpoerschke commented on PR #1883:
URL: https://github.com/apache/solr/pull/1883#issuecomment-1702965757
This builds on the #123 changes, so tagging both @tomglk and
@alessandrobenedetti as potential reviewers, thank you!
--
This is an automated message from the Apache Git Service.
To resp
[
https://issues.apache.org/jira/browse/SOLR-15440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christine Poerschke reassigned SOLR-15440:
--
Assignee: Christine Poerschke
> contrib/ltr FieldValueFeature: DocValues use f
[
https://issues.apache.org/jira/browse/SOLR-15440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christine Poerschke updated SOLR-15440:
---
Description:
SOLR-12697 in Solr 8.9 is intending to add {{FieldValueFeature}} support
cpoerschke opened a new pull request, #1883:
URL: https://github.com/apache/solr/pull/1883
https://issues.apache.org/jira/browse/SOLR-15440
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
gerlowskija opened a new issue, #616:
URL: https://github.com/apache/solr-operator/issues/616
According to our [compatibility
matrix](https://github.com/apache/solr-operator/blob/main/docs/upgrade-notes.md#solr-versions),
Solr Operator 0.7.0 supports a huge range of Solr versions - stretchi
cpoerschke commented on code in PR #1871:
URL: https://github.com/apache/solr/pull/1871#discussion_r1313172009
##
solr/core/src/java/org/apache/solr/util/circuitbreaker/CircuitBreaker.java:
##
@@ -52,4 +58,22 @@ public CircuitBreaker() {}
/** Get error message when the circ
cpoerschke commented on code in PR #1871:
URL: https://github.com/apache/solr/pull/1871#discussion_r1313122139
##
solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java:
##
@@ -355,18 +356,18 @@ public void handleRequestBody(SolrQueryRequest req,
SolrQueryRespo
cpoerschke merged PR #1881:
URL: https://github.com/apache/solr/pull/1881
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache
cpoerschke merged PR #1882:
URL: https://github.com/apache/solr/pull/1882
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache
[
https://issues.apache.org/jira/browse/SOLR-16958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colvin Cowie updated SOLR-16958:
Fix Version/s: 9.4
> Spurious warning logged when using latest luceneMatchVersion
> ---
[
https://issues.apache.org/jira/browse/SOLR-16958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colvin Cowie resolved SOLR-16958.
-
Resolution: Fixed
> Spurious warning logged when using latest luceneMatchVersion
> --
[
https://issues.apache.org/jira/browse/SOLR-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colvin Cowie closed SOLR-13396.
---
> SolrCloud will delete the core data for any core that is not referenced in
> the clusterstate
> --
[
https://issues.apache.org/jira/browse/SOLR-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17761310#comment-17761310
]
Colvin Cowie commented on SOLR-13396:
-
>From 9.3 onwards this functionality is no lon
[
https://issues.apache.org/jira/browse/SOLR-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colvin Cowie resolved SOLR-13396.
-
Fix Version/s: 9.3
Resolution: Fixed
> SolrCloud will delete the core data for any core th
[
https://issues.apache.org/jira/browse/SOLR-16958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17761309#comment-17761309
]
ASF subversion and git services commented on SOLR-16958:
Commit 0
[
https://issues.apache.org/jira/browse/SOLR-16958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17761308#comment-17761308
]
ASF subversion and git services commented on SOLR-16958:
Commit 8
colvinco merged PR #1879:
URL: https://github.com/apache/solr/pull/1879
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.o
[
https://issues.apache.org/jira/browse/SOLR-16897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl reassigned SOLR-16897:
--
Assignee: Jan Høydahl
> add support of OAuth 2.0/OIDC 'code with PKCE' flow (back-end)
> -
janhoy commented on PR #1792:
URL: https://github.com/apache/solr/pull/1792#issuecomment-1702639741
I'm going to force-push a squashed git-history in order for full test suite
to run. Will preserve you as commit author..
--
This is an automated message from the Apache Git Service.
To resp
[
https://issues.apache.org/jira/browse/SOLR-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh reassigned SOLR-16956:
Assignee: Eric Pugh
> bin/solr stop -p doesn't work
> -
>
>
[
https://issues.apache.org/jira/browse/SOLR-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17761274#comment-17761274
]
Eric Pugh commented on SOLR-16956:
--
This bug appears to only be on main..
> bin/solr st
epugh commented on PR #1880:
URL: https://github.com/apache/solr/pull/1880#issuecomment-1702561090
I tested on Branch_9x, and this issue is only on Main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
cpoerschke opened a new pull request, #1882:
URL: https://github.com/apache/solr/pull/1882
No change in existing behaviour, but the factored out method would be
supportive of customisation or future changes to (say) consider the
`rb.isDistrib` flag value.
--
This is an automated message
cpoerschke opened a new pull request, #1881:
URL: https://github.com/apache/solr/pull/1881
Could be considered follow-up to #123 for
https://issues.apache.org/jira/browse/SOLR-12697 and/or preparation for
https://issues.apache.org/jira/browse/SOLR-15440 or just well, independent with
"NO J
[
https://issues.apache.org/jira/browse/SOLR-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh updated SOLR-16956:
-
Priority: Blocker (was: Major)
> bin/solr stop -p doesn't work
> -
>
>
epugh opened a new pull request, #1880:
URL: https://github.com/apache/solr/pull/1880
https://issues.apache.org/jira/browse/SOLR-16956
# Description
In doing some other testing, I noticed that `bin/solr stop -p 7574` didn't
work, I get back the error message:
```
Found 2
epugh commented on PR #1880:
URL: https://github.com/apache/solr/pull/1880#issuecomment-1702552060
@HoustonPutman didn't you recently look at some port stuff? COuld you
review this bug fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
colvinco opened a new pull request, #1879:
URL: https://github.com/apache/solr/pull/1879
https://issues.apache.org/jira/browse/SOLR-16958
Switch back to the use of `==` to check whether the supplied version is
`LATEST` or the actual latest version (e.g. `9.7.0`).
--
This is an
colvinco commented on PR #1878:
URL: https://github.com/apache/solr/pull/1878#issuecomment-1702400914
Accidentally pushed to main. I've reverted the commits on main and I'll
create a new PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
[
https://issues.apache.org/jira/browse/SOLR-16958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17761239#comment-17761239
]
ASF subversion and git services commented on SOLR-16958:
Commit 9
[
https://issues.apache.org/jira/browse/SOLR-16958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17761237#comment-17761237
]
ASF subversion and git services commented on SOLR-16958:
Commit 7
[
https://issues.apache.org/jira/browse/SOLR-16958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17761236#comment-17761236
]
ASF subversion and git services commented on SOLR-16958:
Commit 0
colvinco merged PR #1878:
URL: https://github.com/apache/solr/pull/1878
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.o
colvinco opened a new pull request, #1878:
URL: https://github.com/apache/solr/pull/1878
https://issues.apache.org/jira/browse/SOLR-16958
Switch back to the use of `==` to check whether the supplied version is
`LATEST` or the actual latest version (e.g. `9.7.0`).
--
This is an auto
60 matches
Mail list logo
