[
https://issues.apache.org/jira/browse/SOLR-17044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski updated SOLR-17044:
---
Summary: Improve API path specifying in SolrJ (was: Improve context-root
specifying in
Jason Gerlowski created SOLR-17066:
--
Summary: Deprecate and remove core URLs in HttpSolrClient and
friends
Key: SOLR-17066
URL: https://issues.apache.org/jira/browse/SOLR-17066
Project: Solr
[
https://issues.apache.org/jira/browse/SOLR-16777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17782746#comment-17782746
]
Houston Putman commented on SOLR-16777:
---
+1 if everything passes
> Schema Designer blindly
[
https://issues.apache.org/jira/browse/SOLR-16777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17782739#comment-17782739
]
Ishan Chattopadhyaya commented on SOLR-16777:
-
Thanks for the quick review, Houston. Here's
[
https://issues.apache.org/jira/browse/SOLR-16777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17782719#comment-17782719
]
Houston Putman commented on SOLR-16777:
---
That looks good, except that
[
https://issues.apache.org/jira/browse/SOLR-16777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17782707#comment-17782707
]
Ishan Chattopadhyaya commented on SOLR-16777:
-
[~houston], can you please review my changes
[
https://issues.apache.org/jira/browse/SOLR-16943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated SOLR-16943:
Summary: Tracing: cover more flows by moving instrumentation down to our
HttpClient impls (was:
[
https://issues.apache.org/jira/browse/SOLR-16943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17782699#comment-17782699
]
David Smiley commented on SOLR-16943:
-
Sure Alex. And I edited this issue to clarify what was
[
https://issues.apache.org/jira/browse/SOLR-16943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley reassigned SOLR-16943:
---
Assignee: David Smiley
> Tracing: cover more flows by moving instrumentation down to our
[
https://issues.apache.org/jira/browse/SOLR-16943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated SOLR-16943:
Summary: Tracing: cover more flows by moving instrumentation down to our
HttpClient implies (was:
[
https://issues.apache.org/jira/browse/SOLR-16943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated SOLR-16943:
Description: Instead of injecting tracing at HttpShardHandler &
SolrCmdDistributor, go deeper at
janhoy commented on PR #1908:
URL: https://github.com/apache/solr/pull/1908#issuecomment-1792943180
> I wish it was ZK_FILESTORE and /filestore
As mentioned in the PR description I left the ZK node name as-is.
I fixed the `TMP_ZK_NODE` and two exception messages.
--
This is
janhoy commented on code in PR #2059:
URL: https://github.com/apache/solr/pull/2059#discussion_r1382062723
##
solr/core/src/java/org/apache/solr/util/circuitbreaker/CircuitBreaker.java:
##
@@ -62,6 +64,16 @@ public CircuitBreaker() {}
/** Get error message when the circuit
cpoerschke commented on code in PR #2059:
URL: https://github.com/apache/solr/pull/2059#discussion_r1382029848
##
solr/core/src/test/org/apache/solr/util/TestCircuitBreakers.java:
##
@@ -66,26 +76,40 @@ protected static void indexDocs() {
public void tearDown() throws
[
https://issues.apache.org/jira/browse/SOLR-16943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17782667#comment-17782667
]
Alex Deparvu commented on SOLR-16943:
-
this was merged to main and backported to 9.x. I would close
[
https://issues.apache.org/jira/browse/SOLR-16943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17782663#comment-17782663
]
ASF subversion and git services commented on SOLR-16943:
Commit
stillalex merged PR #2041:
URL: https://github.com/apache/solr/pull/2041
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
stillalex commented on code in PR #2041:
URL: https://github.com/apache/solr/pull/2041#discussion_r1381941298
##
solr/core/src/java/org/apache/solr/util/tracing/SolrJettyRequestCarrier.java:
##
@@ -22,13 +22,13 @@
import java.util.Map;
import
HoustonPutman opened a new pull request, #2062:
URL: https://github.com/apache/solr/pull/2062
https://issues.apache.org/jira/browse/SOLR-17065
- [ ] Absorb the CrossDC Consumer/Producer/Common
- [ ] Have the build work
- [ ] Fix the compilation warning and uncomment the lines
Houston Putman created SOLR-17065:
-
Summary: Migrate Sandbox CrossDC functionality into Solr
Key: SOLR-17065
URL: https://issues.apache.org/jira/browse/SOLR-17065
Project: Solr
Issue Type:
epugh commented on PR #1908:
URL: https://github.com/apache/solr/pull/1908#issuecomment-1792684853
I checked out the branch and did a search for "PackageStore" and found a
number of places it is still mentioned... DistribFileStore.java has a:
```
/** This is where al the files in
laminelam commented on code in PR #1994:
URL: https://github.com/apache/solr/pull/1994#discussion_r1366016833
##
solr/modules/aws-secret-provider/src/test/org/apache/solr/secret/zk/AWSSecretCredentialsProviderTest.java:
##
@@ -0,0 +1,440 @@
+/*
+ * Licensed to the Apache
laminelam commented on code in PR #1994:
URL: https://github.com/apache/solr/pull/1994#discussion_r1366016833
##
solr/modules/aws-secret-provider/src/test/org/apache/solr/secret/zk/AWSSecretCredentialsProviderTest.java:
##
@@ -0,0 +1,440 @@
+/*
+ * Licensed to the Apache
epugh commented on PR #1509:
URL: https://github.com/apache/solr/pull/1509#issuecomment-1792522903
Let's rip that bandaid off and get to 12! Jakarta EE!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
cpoerschke commented on code in PR #2059:
URL: https://github.com/apache/solr/pull/2059#discussion_r1381683950
##
solr/core/src/java/org/apache/solr/util/circuitbreaker/CircuitBreaker.java:
##
@@ -62,6 +64,16 @@ public CircuitBreaker() {}
/** Get error message when the
janhoy commented on code in PR #2059:
URL: https://github.com/apache/solr/pull/2059#discussion_r1381679936
##
solr/core/src/java/org/apache/solr/util/circuitbreaker/CircuitBreaker.java:
##
@@ -62,6 +64,16 @@ public CircuitBreaker() {}
/** Get error message when the circuit
janhoy commented on code in PR #2059:
URL: https://github.com/apache/solr/pull/2059#discussion_r1381677634
##
solr/core/src/java/org/apache/solr/util/circuitbreaker/CircuitBreaker.java:
##
@@ -62,6 +64,16 @@ public CircuitBreaker() {}
/** Get error message when the circuit
cpoerschke commented on code in PR #2059:
URL: https://github.com/apache/solr/pull/2059#discussion_r1381664586
##
solr/core/src/java/org/apache/solr/util/circuitbreaker/CircuitBreaker.java:
##
@@ -62,6 +64,16 @@ public CircuitBreaker() {}
/** Get error message when the
cpoerschke commented on code in PR #2059:
URL: https://github.com/apache/solr/pull/2059#discussion_r1381660418
##
solr/core/src/test/org/apache/solr/util/TestCircuitBreakers.java:
##
@@ -66,26 +76,39 @@ protected static void indexDocs() {
public void tearDown() throws
janhoy commented on code in PR #2059:
URL: https://github.com/apache/solr/pull/2059#discussion_r1381655377
##
solr/core/src/test/org/apache/solr/util/TestCircuitBreakers.java:
##
@@ -66,26 +76,39 @@ protected static void indexDocs() {
public void tearDown() throws Exception
janhoy commented on code in PR #2059:
URL: https://github.com/apache/solr/pull/2059#discussion_r1381648790
##
solr/core/src/java/org/apache/solr/util/circuitbreaker/CircuitBreaker.java:
##
@@ -62,6 +64,16 @@ public CircuitBreaker() {}
/** Get error message when the circuit
cpoerschke commented on code in PR #2059:
URL: https://github.com/apache/solr/pull/2059#discussion_r1381636810
##
solr/core/src/test/org/apache/solr/util/TestCircuitBreakers.java:
##
@@ -66,26 +76,39 @@ protected static void indexDocs() {
public void tearDown() throws
[
https://issues.apache.org/jira/browse/SOLR-16455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17782559#comment-17782559
]
Jan Høydahl commented on SOLR-16455:
I try to kick the tires of this Jira again. [~jebnix] are you
janhoy commented on PR #1904:
URL: https://github.com/apache/solr/pull/1904#issuecomment-1792348068
Closing this as duplicate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
janhoy closed pull request #1904: SOLR-16961: Remove deprecated
CircuitBreakerManager
URL: https://github.com/apache/solr/pull/1904
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
janhoy commented on PR #2059:
URL: https://github.com/apache/solr/pull/2059#issuecomment-1792346399
> > The only real diff is that #1904 had configurable error code ...
>
> Without the configurability seems simpler but given that `setErrorCode` is
not annotated as deprecated (or
jorgerod commented on PR #1911:
URL: https://github.com/apache/solr/pull/1911#issuecomment-1792329286
Hi
This upgrade would be great as spring boot 3.2 will use jetty 12 and right
now it is not solr compatible.
--
This is an automated message from the Apache Git Service.
To
uschindler commented on PR #1509:
URL: https://github.com/apache/solr/pull/1509#issuecomment-1792298278
I would recommend to use Jetty 12. It allows to use both servlet APIs so we
can stay with javax.servlet. You can run them in parallel, but actually a
single context must use one version.
jorgerod commented on PR #1509:
URL: https://github.com/apache/solr/pull/1509#issuecomment-1792273443
Hi @risdenk
Spring boot 3.0 and 3.1 use jetty 11x but Spring boot 3.2 will use jetty 12x.
Maybe it would be more interesting to upgrade directly to jetty 12x, what do
you
cpoerschke commented on PR #2059:
URL: https://github.com/apache/solr/pull/2059#issuecomment-1792149212
> The only real diff is that #1904 had configurable error code ...
Without the configurability seems simpler but given that `setErrorCode` is
not annotated as deprecated (or
janhoy commented on PR #2059:
URL: https://github.com/apache/solr/pull/2059#issuecomment-1792121405
For some reason, #1904 was not added to the JIRA issue by the bot, else I
would have seen it immediately when browsing my open JIRS for work to complete.
I think we should migrate from JIRA
janhoy commented on PR #2059:
URL: https://github.com/apache/solr/pull/2059#issuecomment-1792118109
The only real diff is that #1904 had configurable error code,
https://github.com/apache/solr/pull/1904/files#diff-e040eb54da15dcb4051d543df5be72f979fbc2f0f62fb217353f1ef90cb6f61dR71-R80
--
janhoy commented on PR #2059:
URL: https://github.com/apache/solr/pull/2059#issuecomment-1792107216
Yea, I might diff the patches from these two PRs and see if I miss anything
on this latest one...
--
This is an automated message from the Apache Git Service.
To respond to the message,
cpoerschke commented on PR #2059:
URL: https://github.com/apache/solr/pull/2059#issuecomment-1792104596
> Ok, I forgot that I already had #1904 already open with almost exactly
same changes. ...
Ah, I had a vague "wasn't there a prior draft or wasn't this further down in
the PR
janhoy commented on PR #2059:
URL: https://github.com/apache/solr/pull/2059#issuecomment-1792091597
Ok, I forgot that I already had #1904 already open with almost exactly same
changes. Well, double work there 藍 In that PR I chose to keep the Base
test-class in order to minimize merge
janhoy commented on PR #1908:
URL: https://github.com/apache/solr/pull/1908#issuecomment-1792079376
Added a few more reviewers and brought up to date with main. Again, this is
an internal java-level change and the API is experimental so no back compat
requirements.
As followup
46 matches
Mail list logo
