Re: [PR] Support readOnlyRootFilesystem [solr-operator]

2023-11-08 Thread via GitHub
radu-gheorghe commented on PR #648: URL: https://github.com/apache/solr-operator/pull/648#issuecomment-1803264540 Sounds good to me! Does this mean that this PR is good to merge, or should I change something? -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (SOLR-10466) setDefaultCollection should be deprecated in favor of SolrClientBuilder methods

2023-11-08 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784295#comment-17784295 ] David Smiley commented on SOLR-10466: - I don't think forbidding parallelStream discourages use of

Re: [PR] SOLR-16974: Global Circuit Breakers (backport 9x) [solr]

2023-11-08 Thread via GitHub
janhoy commented on PR #2070: URL: https://github.com/apache/solr/pull/2070#issuecomment-1802975311 Do we want to add CHANGES and refguide docs (separate PR) into this backport and squash it, or is it more transparent to do two commits for the backport too? -- This is an automated

Re: [PR] SOLR-16974: Documentation and changes entry for global CB [solr]

2023-11-08 Thread via GitHub
janhoy commented on PR #2069: URL: https://github.com/apache/solr/pull/2069#issuecomment-1802974051 @cpoerschke I was a bit quick merging the main PR. So here is a follow-up with changes entry and refguide docs. If you find other things missing as well, let's include it here. I'm awaiting

[PR] SOLR-16974: Global Circuit Breakers (backport 9x) [solr]

2023-11-08 Thread via GitHub
janhoy opened a new pull request, #2070: URL: https://github.com/apache/solr/pull/2070 Co-authored-by: Christine Poerschke (cherry picked from commit e740123546c7f20c6728df42d493e11f93dc8c79) -- This is an automated message from the Apache Git Service. To respond to the message,

[PR] SOLR-16974: Changes entry [solr]

2023-11-08 Thread via GitHub
janhoy opened a new pull request, #2069: URL: https://github.com/apache/solr/pull/2069 https://issues.apache.org/jira/browse/SOLR-16974 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (SOLR-16974) Global Circuit Breakers

2023-11-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784233#comment-17784233 ] ASF subversion and git services commented on SOLR-16974: Commit

Re: [PR] SOLR-16974: Global Circuit Breakers [solr]

2023-11-08 Thread via GitHub
janhoy merged PR #1919: URL: https://github.com/apache/solr/pull/1919 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Feature toggle local filesystem repo [solr]

2023-11-08 Thread via GitHub
janhoy opened a new pull request, #2068: URL: https://github.com/apache/solr/pull/2068 No JIRA - draft feature to disable `LocalFileSystemRepository` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (SOLR-17066) Deprecate and remove core URLs in HttpSolrClient and friends

2023-11-08 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784172#comment-17784172 ] David Smiley commented on SOLR-17066: - +1 for this; thanks Jason. > Deprecate and remove core URLs

[jira] [Commented] (SOLR-16252) Server admins cannot override default value for UPDATE_TIMEOUT_SECS

2023-11-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784166#comment-17784166 ] ASF subversion and git services commented on SOLR-16252: Commit

[jira] [Updated] (SOLR-16252) Server admins cannot override default value for UPDATE_TIMEOUT_SECS

2023-11-08 Thread Alex Deparvu (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Deparvu updated SOLR-16252: Priority: Minor (was: Major) > Server admins cannot override default value for

[jira] [Resolved] (SOLR-16252) Server admins cannot override default value for UPDATE_TIMEOUT_SECS

2023-11-08 Thread Alex Deparvu (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Deparvu resolved SOLR-16252. - Fix Version/s: main (10.0) 9.5 Resolution: Fixed > Server admins

[jira] [Commented] (SOLR-16252) Server admins cannot override default value for UPDATE_TIMEOUT_SECS

2023-11-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784165#comment-17784165 ] ASF subversion and git services commented on SOLR-16252: Commit

Re: [PR] SOLR-16252 Server admins cannot override default value for UPDATE_TIMEOUT_SECS [solr]

2023-11-08 Thread via GitHub
stillalex merged PR #2061: URL: https://github.com/apache/solr/pull/2061 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Resolved] (SOLR-17041) Make CommitTracker currentTlogSize lazy

2023-11-08 Thread Alex Deparvu (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Deparvu resolved SOLR-17041. - Fix Version/s: main (10.0) 9.5 Assignee: Alex Deparvu

[jira] [Commented] (SOLR-17041) Make CommitTracker currentTlogSize lazy

2023-11-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784164#comment-17784164 ] ASF subversion and git services commented on SOLR-17041: Commit

[jira] [Commented] (SOLR-17041) Make CommitTracker currentTlogSize lazy

2023-11-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784159#comment-17784159 ] ASF subversion and git services commented on SOLR-17041: Commit

Re: [PR] SOLR-17041 Make CommitTracker currentTlogSize lazy [solr]

2023-11-08 Thread via GitHub
stillalex merged PR #2027: URL: https://github.com/apache/solr/pull/2027 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] SOLR-17041 Make CommitTracker currentTlogSize lazy [solr]

2023-11-08 Thread via GitHub
stillalex commented on PR #2027: URL: https://github.com/apache/solr/pull/2027#issuecomment-1802332993 thank you for the review @cpoerschke! I will be merging this shortly -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Commented] (SOLR-15782) Configure custom node/container handlers in solr.xml

2023-11-08 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784144#comment-17784144 ] David Smiley commented on SOLR-15782: - I don't think we should proceed with , which is inconsistent,

[jira] [Resolved] (SOLR-17011) Add tracing spans to internal collection commands

2023-11-08 Thread Alex Deparvu (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Deparvu resolved SOLR-17011. - Fix Version/s: main (10.0) 9.5 Resolution: Fixed > Add tracing spans

[jira] [Commented] (SOLR-17011) Add tracing spans to internal collection commands

2023-11-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784142#comment-17784142 ] ASF subversion and git services commented on SOLR-17011: Commit

Re: [PR] [9.x] SOLR-17011 Add tracing spans to internal collection commands (#1979) [solr]

2023-11-08 Thread via GitHub
stillalex merged PR #2067: URL: https://github.com/apache/solr/pull/2067 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] Issue installing crd [solr-operator]

2023-11-08 Thread via GitHub
HoustonPutman closed issue #647: Issue installing crd URL: https://github.com/apache/solr-operator/issues/647 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Support readOnlyRootFilesystem [solr-operator]

2023-11-08 Thread via GitHub
HoustonPutman commented on PR #648: URL: https://github.com/apache/solr-operator/pull/648#issuecomment-1802283651 Let's keep it just the zk-init container for now (or all the init containers we do). That way we don't break use cases we don't know about. Not sure there's a giant benefit for

[jira] [Commented] (SOLR-17066) Deprecate and remove core URLs in HttpSolrClient and friends

2023-11-08 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784048#comment-17784048 ] Jason Gerlowski commented on SOLR-17066: Yes, definitely - I actually called out SOLR-10466 in

Re: [PR] SOLR-16974: Global Circuit Breakers [solr]

2023-11-08 Thread via GitHub
janhoy commented on code in PR #1919: URL: https://github.com/apache/solr/pull/1919#discussion_r1386590546 ## solr/core/src/java/org/apache/solr/util/circuitbreaker/CircuitBreakerRegistry.java: ## @@ -111,43 +199,82 @@ public static String toErrorMessage(List

Re: [PR] SOLR-16974: Global Circuit Breakers [solr]

2023-11-08 Thread via GitHub
cpoerschke commented on code in PR #1919: URL: https://github.com/apache/solr/pull/1919#discussion_r1386555317 ## solr/core/src/java/org/apache/solr/util/circuitbreaker/CircuitBreakerRegistry.java: ## @@ -111,43 +199,82 @@ public static String toErrorMessage(List

Re: [PR] Support readOnlyRootFilesystem [solr-operator]

2023-11-08 Thread via GitHub
thomaswoeckinger commented on PR #648: URL: https://github.com/apache/solr-operator/pull/648#issuecomment-1801811579 From my point of view, at least some common request for collection creation, modification, deletion and sharding is working, so i think this is good to go -- This is an

[jira] [Commented] (SOLR-14410) Switch from SysV init script to systemd service definition

2023-11-08 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783941#comment-17783941 ] Jan Høydahl commented on SOLR-14410: Ping. Any new energy on this? Would be nice to at least cut it

Re: [PR] SOLR-14410: switch from SysV to systemd service [solr]

2023-11-08 Thread via GitHub
janhoy commented on PR #428: URL: https://github.com/apache/solr/pull/428#issuecomment-1801348698 Ping. Any new energy on this? Would be nice to at least cut it over in main branch for 10.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Created] (SOLR-17071) Improve ZkFailoverTest

2023-11-08 Thread Jira
Jan Høydahl created SOLR-17071: -- Summary: Improve ZkFailoverTest Key: SOLR-17071 URL: https://issues.apache.org/jira/browse/SOLR-17071 Project: Solr Issue Type: Improvement Security