[PR] Patsonluk/solr 17076/optimize placement factory get all replica [solr]

2023-11-14 Thread via GitHub
patsonluk opened a new pull request, #2076: URL: https://github.com/apache/solr/pull/2076 https://issues.apache.org/jira/browse/SOLR-17076 # Description `OrderedNodePlacementPlugin#getAllReplicasOnNode` can be slow in a cluster with lot of replicas. The effect could compoun

[jira] [Updated] (SOLR-17076) Replica Placement could be slow for new collection creation with high amount of shards in a cluster with plenty replicas

2023-11-14 Thread Patson Luk (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patson Luk updated SOLR-17076: -- Summary: Replica Placement could be slow for new collection creation with high amount of shards in a cl

[jira] [Updated] (SOLR-17076) Replica Placement could be slow for new collection creation with high amount of shards in a cluster with plenty of replicas

2023-11-14 Thread Patson Luk (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patson Luk updated SOLR-17076: -- Summary: Replica Placement could be slow for new collection creation with high amount of shards in a cl

[jira] [Created] (SOLR-17076) Replica Placement could be slow for new collection with high amount of shard in a cluster with plenty replicas

2023-11-14 Thread Patson Luk (Jira)
Patson Luk created SOLR-17076: - Summary: Replica Placement could be slow for new collection with high amount of shard in a cluster with plenty replicas Key: SOLR-17076 URL: https://issues.apache.org/jira/browse/SOLR-1

Re: [PR] SOLR-16397: Modify v2 'renamecore' API to be more REST-ful [solr]

2023-11-14 Thread via GitHub
gerlowskija commented on code in PR #2072: URL: https://github.com/apache/solr/pull/2072#discussion_r1393262795 ## solr/solr-ref-guide/modules/configuration-guide/pages/coreadmin-api.adoc: ## @@ -349,9 +349,19 @@ This parameter is required in v1, and part of the url in the v2 A

Re: [PR] SOLR-16911: Purge last hostContext references [solr]

2023-11-14 Thread via GitHub
epugh commented on PR #2052: URL: https://github.com/apache/solr/pull/2052#issuecomment-1810651483 > > Is the "startJettySolrRunner" method actually used? [...] I wonder if that method is even needed??? > > It's not used currently. I thought about deleting it, but wasn't sure whether

Re: [PR] SOLR-15782: Declare PlacementPlugin in solr.xml [solr]

2023-11-14 Thread via GitHub
pvcnt commented on code in PR #2071: URL: https://github.com/apache/solr/pull/2071#discussion_r1392873965 ## solr/core/src/java/org/apache/solr/cluster/placement/plugins/AffinityPlacementFactory.java: ## @@ -150,7 +150,7 @@ public AffinityPlacementConfig getConfig() { * See

Re: [PR] SOLR-16835: Generate Python client from OpenAPI spec [solr]

2023-11-14 Thread via GitHub
gerlowskija commented on PR #1681: URL: https://github.com/apache/solr/pull/1681#issuecomment-1810571548 > In the package name? I won't put words in his mouth, but I interpreted Anshum's comment as being more about documentation and messaging around the client in general. As it stan

Re: [PR] SOLR-15782: Declare PlacementPlugin in solr.xml [solr]

2023-11-14 Thread via GitHub
pvcnt commented on PR #2071: URL: https://github.com/apache/solr/pull/2071#issuecomment-1810514488 Sure, I was looking for feedback about the approach first! Since this looks acceptable, I added some tests and documentation for the feature. -- This is an automated message from the Apache

Re: [PR] SOLR-16911: Purge last hostContext references [solr]

2023-11-14 Thread via GitHub
gerlowskija commented on PR #2052: URL: https://github.com/apache/solr/pull/2052#issuecomment-1810509662 > Is the "startJettySolrRunner" method actually used? [...] I wonder if that method is even needed??? It's not used currently. I thought about deleting it, but wasn't sure whethe

[jira] [Commented] (SOLR-17075) Ref Guide link checking not enabled in "gradle check" by default

2023-11-14 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785941#comment-17785941 ] Eric Pugh commented on SOLR-17075: -- Amazing how quickly the bit rot creeps in without th

[I] Add option to also log to a file [solr-operator]

2023-11-14 Thread via GitHub
HoustonPutman opened a new issue, #655: URL: https://github.com/apache/solr-operator/issues/655 There are setups with kuberenetes that require logs to be written to a file, so that they can then be uploaded to the log aggregators. Just logging to stdout does not allow for this. We do

[jira] [Created] (SOLR-17075) Ref Guide link checking not enabled in "gradle check" by default

2023-11-14 Thread Houston Putman (Jira)
Houston Putman created SOLR-17075: - Summary: Ref Guide link checking not enabled in "gradle check" by default Key: SOLR-17075 URL: https://issues.apache.org/jira/browse/SOLR-17075 Project: Solr

[PR] Fix ref-guide links and renable site checks by default [solr]

2023-11-14 Thread via GitHub
HoustonPutman opened a new pull request, #2075: URL: https://github.com/apache/solr/pull/2075 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

Re: [PR] SOLR-15782: Declare PlacementPlugin in solr.xml [solr]

2023-11-14 Thread via GitHub
dsmiley commented on PR #2071: URL: https://github.com/apache/solr/pull/2071#issuecomment-1810385153 Looks good! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

Re: [PR] Upgrade Kafka to 3.5.1 [solr-sandbox]

2023-11-14 Thread via GitHub
sigram commented on PR #85: URL: https://github.com/apache/solr-sandbox/pull/85#issuecomment-1809926848 [This documentation](https://kafka.apache.org/protocol.html#protocol_compatibility) claims it's bi-directionally compatible, ie. old clients can talk with new brokers and old brokers can

Re: [PR] SOLR-17072: CLI package to print problem JSON Path [solr]

2023-11-14 Thread via GitHub
mkhludnev commented on PR #2074: URL: https://github.com/apache/solr/pull/2074#issuecomment-1809866527 Thanks for approve @epugh. I'm thinking about test coverage. On top of my head only a simple unittest with mocks. WDYT? -- This is an automated message from the Apache Git Service. To re