[jira] [Updated] (SOLR-6853) solr.ManagedSynonymFilterFactory/ManagedStopwordFilterFactory: URLEncoding - Not able to delete Synonyms/Stopwords with special characters

2023-12-06 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-6853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-6853: -- Fix Version/s: 9.4.1 > solr.ManagedSynonymFilterFactory/ManagedStopwordFilterFactory: URLEncoding - > N

[jira] [Commented] (SOLR-15484) Frequent test failures for JWTAuthPluginIntegrationTest

2023-12-06 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794064#comment-17794064 ] Jan Høydahl commented on SOLR-15484: The mockOauth2Server project has enabled auto ge

Re: [PR] SOLR-16986: log cpuTime in addition to QTime [solr]

2023-12-06 Thread via GitHub
dsmiley commented on PR #2118: URL: https://github.com/apache/solr/pull/2118#issuecomment-1844506632 > What would you think about keeping the logs as currently done but changing the response to always and only use cpuTime ? Ah; that's a nice compromise! -- This is an automated mess

[PR] Switch to the correct branch for the PR [solr]

2023-12-06 Thread via GitHub
uvatbc opened a new pull request, #2124: URL: https://github.com/apache/solr/pull/2124 # Description PRs have remote refs. That remote ref will not be automatically fetched when we fetch origin. # Solution So how do we fetch it? 1. first fetch the actual remote

[jira] [Resolved] (SOLR-17077) When rejoining shard leader election, we try to leave the election twice

2023-12-06 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-17077. - Fix Version/s: main (10.0) Resolution: Fixed Thanks for contributing! > When rejoining sh

Re: [PR] SOLR-17057: JSON Query regression of defType [solr]

2023-12-06 Thread via GitHub
dsmiley commented on PR #2045: URL: https://github.com/apache/solr/pull/2045#issuecomment-1843999099 (a 9.4.1 will happen) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] SOLR-17060 CoreContainer#create may deadlock with concurrent requests for metrics [solr]

2023-12-06 Thread via GitHub
stillalex commented on PR #2101: URL: https://github.com/apache/solr/pull/2101#issuecomment-1843839631 > I don't understand how refCount <= 1 is a solution; there can be many simultaneous references (say 10) and we should expose values then. read the PR again, you may be parsing it in

Re: [PR] SOLR-17060 CoreContainer#create may deadlock with concurrent requests for metrics [solr]

2023-12-06 Thread via GitHub
stillalex commented on PR #2101: URL: https://github.com/apache/solr/pull/2101#issuecomment-1843835253 sure @dsmiley go for it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] SOLR-17053: Address ClassCastException issue [solr]

2023-12-06 Thread via GitHub
dsmiley commented on code in PR #2123: URL: https://github.com/apache/solr/pull/2123#discussion_r1418058054 ## solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java: ## @@ -598,7 +598,7 @@ public void handleRequestBody(SolrQueryRequest req, SolrQueryResponse r

Re: [PR] SOLR-17060 CoreContainer#create may deadlock with concurrent requests for metrics [solr]

2023-12-06 Thread via GitHub
dsmiley commented on PR #2101: URL: https://github.com/apache/solr/pull/2101#issuecomment-1843800021 BTW I'd be happy to throw up a proposal PR with my ideas, taking your test :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] SOLR-17060 CoreContainer#create may deadlock with concurrent requests for metrics [solr]

2023-12-06 Thread via GitHub
dsmiley commented on PR #2101: URL: https://github.com/apache/solr/pull/2101#issuecomment-1843798621 We can still move metrics initialization to later in addition to other ideas here. I think it belongs later conceptually. `initPlugins(CircuitBreaker)` would move later as well (there's a

[jira] [Commented] (SOLR-17100) Publish generated Python and JS clients

2023-12-06 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-17100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793945#comment-17793945 ] Jan Høydahl commented on SOLR-17100: I think there's no rush in publishing these, we

Re: [PR] SOLR-17053: Address ClassCastException issue [solr]

2023-12-06 Thread via GitHub
tflobbe commented on code in PR #2123: URL: https://github.com/apache/solr/pull/2123#discussion_r1418049650 ## solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java: ## @@ -598,7 +598,7 @@ public void handleRequestBody(SolrQueryRequest req, SolrQueryResponse r

Re: [PR] SOLR-17060 CoreContainer#create may deadlock with concurrent requests for metrics [solr]

2023-12-06 Thread via GitHub
dsmiley commented on PR #2101: URL: https://github.com/apache/solr/pull/2101#issuecomment-1843768954 Thanks for clarifying Andreas. I propose initializing metrics at the very end of the constructor, which is when we can say the SolrCore is reasonably constructed. > simply moving the

[PR] SOLR-17053: Address ClassCastException issue [solr]

2023-12-06 Thread via GitHub
aparnasuresh85 opened a new pull request, #2123: URL: https://github.com/apache/solr/pull/2123 https://issues.apache.org/jira/browse/SOLR-17053 # Description Please provide a short description of the changes you're making with this pull request. Address a ClassCa

Re: [PR] SOLR-17053: If all shards fail, fail the request despite shards.tolerant [solr]

2023-12-06 Thread via GitHub
aparnasuresh85 closed pull request #2122: SOLR-17053: If all shards fail, fail the request despite shards.tolerant URL: https://github.com/apache/solr/pull/2122 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[jira] [Commented] (SOLR-17012) Update Apache Hadoop to 3.3.6 and Apache Curator to 5.5.0

2023-12-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793940#comment-17793940 ] ASF subversion and git services commented on SOLR-17012: Commit b

[PR] SOLR-17053: If all shards fail, fail the request despite shards.tolerant [solr]

2023-12-06 Thread via GitHub
aparnasuresh85 opened a new pull request, #2122: URL: https://github.com/apache/solr/pull/2122 https://issues.apache.org/jira/browse/SOLR-17053 # Description Address a ClassCastException issue in the event exception in shard response is not of type org.apache.solr.c

Re: [PR] SOLR-15857: Add AWS Secret Manager support for ZK ACL credentials [solr]

2023-12-06 Thread via GitHub
HoustonPutman commented on code in PR #1994: URL: https://github.com/apache/solr/pull/1994#discussion_r1417821208 ## solr/modules/aws-secret-provider/src/java/org/apache/solr/secret/zk/AWSSecretManagerCredentialsInjector.java: ## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache

Re: [PR] [experimental] TextToVectorProcessor(Factory) using ONNX via OpenNLP [solr]

2023-12-06 Thread via GitHub
epugh commented on code in PR #2120: URL: https://github.com/apache/solr/pull/2120#discussion_r1417852787 ## gradle/testing/randomization/policies/solr-tests.policy: ## @@ -100,6 +100,9 @@ grant { permission java.lang.RuntimePermission "loadLibrary.jaas"; permission java.l

Re: [PR] solr/example/films/vectors/README.md tweaks [solr]

2023-12-06 Thread via GitHub
epugh commented on code in PR #2121: URL: https://github.com/apache/solr/pull/2121#discussion_r1417822279 ## solr/example/films/vectors/README.md: ## @@ -23,6 +23,12 @@ We present in this directory the Python scripts that were used to create the `fi To replicate the example

Re: [PR] solr/example/films/vectors/README.md tweaks [solr]

2023-12-06 Thread via GitHub
epugh commented on code in PR #2121: URL: https://github.com/apache/solr/pull/2121#discussion_r1417820528 ## solr/example/films/vectors/README.md: ## @@ -23,6 +23,12 @@ We present in this directory the Python scripts that were used to create the `fi To replicate the example

Re: [PR] solr/example/films/vectors/README.md tweaks [solr]

2023-12-06 Thread via GitHub
cpoerschke commented on code in PR #2121: URL: https://github.com/apache/solr/pull/2121#discussion_r1417803601 ## solr/example/films/vectors/README.md: ## @@ -23,6 +23,12 @@ We present in this directory the Python scripts that were used to create the `fi To replicate the exa

[PR] solr/example/films/vectors/README.md tweaks [solr]

2023-12-06 Thread via GitHub
cpoerschke opened a new pull request, #2121: URL: https://github.com/apache/solr/pull/2121 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

Re: [PR] SOLR-17077: Don't cancel twice when rejoining shard leader election [solr]

2023-12-06 Thread via GitHub
psalagnac commented on PR #2084: URL: https://github.com/apache/solr/pull/2084#issuecomment-1843427630 Yes, just main is fine. I want to follow-up on this work with other cleanups in leader election code. I don't think it is worth to backport them to 9x. -- This is an automated message

Re: [PR] SOLR-17060 CoreContainer#create may deadlock with concurrent requests for metrics [solr]

2023-12-06 Thread via GitHub
stillalex commented on PR #2101: URL: https://github.com/apache/solr/pull/2101#issuecomment-1843400180 > I was also thinking about whether that could be moved further down. I don't think that will help. there are some async things happening so simply moving the code would not provide

Re: [PR] [experimental] TextToVectorProcessor(Factory) using ONNX via OpenNLP [solr]

2023-12-06 Thread via GitHub
cpoerschke commented on code in PR #2120: URL: https://github.com/apache/solr/pull/2120#discussion_r1417761015 ## solr/modules/analysis-extras/src/java/org/apache/solr/update/processor/TextToVectorProcessor.java: ## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] [experimental] TextToVectorProcessor(Factory) using ONNX via OpenNLP [solr]

2023-12-06 Thread via GitHub
cpoerschke commented on code in PR #2120: URL: https://github.com/apache/solr/pull/2120#discussion_r1417757648 ## solr/modules/analysis-extras/src/test/org/apache/solr/update/processor/TestOpenNLPExtractNamedEntitiesUpdateProcessorFactory.java: ## @@ -34,6 +34,13 @@ public stati

[jira] [Commented] (SOLR-16880) Make OpenAPI spec a release artifact

2023-12-06 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793858#comment-17793858 ] Jason Gerlowski commented on SOLR-16880: bq. An alternative approach would be to

Re: [PR] [experimental] TextToVectorProcessor(Factory) using ONNX via OpenNLP [solr]

2023-12-06 Thread via GitHub
epugh commented on code in PR #2120: URL: https://github.com/apache/solr/pull/2120#discussion_r1417721067 ## solr/modules/analysis-extras/src/test/org/apache/solr/update/processor/TestOpenNLPExtractNamedEntitiesUpdateProcessorFactory.java: ## @@ -34,6 +34,13 @@ public static voi

Re: [PR] SOLR-16577: Always log core load issues [solr]

2023-12-06 Thread via GitHub
heythm commented on PR #1221: URL: https://github.com/apache/solr/pull/1221#issuecomment-1843222328 Sorry for the force-push, I did it to amend a commit message. It wasn't a good idea. @dsmiley knows about it. -- This is an automated message from the Apache Git Service. To respond to

[jira] [Commented] (SOLR-16825) Generate Java bindings from OpenAPI spec

2023-12-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793801#comment-17793801 ] ASF subversion and git services commented on SOLR-16825: Commit 8

Re: [PR] [experimental] TextToVectorProcessor(Factory) using ONNX via OpenNLP [solr]

2023-12-06 Thread via GitHub
cpoerschke commented on code in PR #2120: URL: https://github.com/apache/solr/pull/2120#discussion_r1417572475 ## solr/modules/analysis-extras/src/test/org/apache/solr/update/processor/TestOpenNLPExtractNamedEntitiesUpdateProcessorFactory.java: ## @@ -34,6 +34,13 @@ public stati

Re: [PR] SOLR-17060 CoreContainer#create may deadlock with concurrent requests for metrics [solr]

2023-12-06 Thread via GitHub
ahubold commented on PR #2101: URL: https://github.com/apache/solr/pull/2101#issuecomment-1843177371 > Who is calling SolrCore.initializeMetrics? It's hard to tell; it's an override of a base abstraction so is being called generically somewhere. I'm wondering if we can delay initializeMetri

[PR] [experimental] TextToVectorProcessor(Factory) using ONNX via OpenNLP [solr]

2023-12-06 Thread via GitHub
cpoerschke opened a new pull request, #2120: URL: https://github.com/apache/solr/pull/2120 Branched off the current #1999 branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[jira] [Commented] (SOLR-17012) Update Apache Hadoop to 3.3.6 and Apache Curator to 5.5.0

2023-12-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793787#comment-17793787 ] ASF subversion and git services commented on SOLR-17012: Commit 3

[jira] [Created] (SOLR-17100) Publish generated Python and JS clients

2023-12-06 Thread Jason Gerlowski (Jira)
Jason Gerlowski created SOLR-17100: -- Summary: Publish generated Python and JS clients Key: SOLR-17100 URL: https://issues.apache.org/jira/browse/SOLR-17100 Project: Solr Issue Type: Improvem

[jira] [Commented] (SOLR-17060) CoreContainer#create may deadlock with concurrent requests for metrics

2023-12-06 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793776#comment-17793776 ] David Smiley commented on SOLR-17060: - Fantastic investigation! > CoreContainer#crea

[jira] [Commented] (SOLR-16833) Apache Solr's blog

2023-12-06 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793764#comment-17793764 ] Eric Pugh commented on SOLR-16833: -- Agreed on the importance of linking out.. Most fol

[jira] [Commented] (SOLR-16825) Generate Java bindings from OpenAPI spec

2023-12-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793754#comment-17793754 ] ASF subversion and git services commented on SOLR-16825: Commit 5

Re: [PR] SOLR-16825: Migrate v2 definitions to 'api' module, pt 7 [solr]

2023-12-06 Thread via GitHub
gerlowskija merged PR #2116: URL: https://github.com/apache/solr/pull/2116 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apach

Re: [PR] SOLR-16986: log cpuTime in addition to QTime [solr]

2023-12-06 Thread via GitHub
gbellaton commented on PR #2118: URL: https://github.com/apache/solr/pull/2118#issuecomment-1842954763 I think that the distinction between cpuTime and localCpuTime is useful in the logs. It allows to generate statistics from the logs that make the difference between distributed queries

Re: [PR] SOLR-16986: log cpuTime in addition to QTime [solr]

2023-12-06 Thread via GitHub
gbellaton commented on code in PR #2118: URL: https://github.com/apache/solr/pull/2118#discussion_r1417368897 ## solr/core/src/java/org/apache/solr/util/ThreadStats.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contribut

[jira] [Commented] (SOLR-16833) Apache Solr's blog

2023-12-06 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793731#comment-17793731 ] David Smiley commented on SOLR-16833: - I completely agree with Alessandro's point of

Re: [PR] SOLR-6853: Allow '/' characters in the text managed by Managed Resources API (branch_9_4) [solr]

2023-12-06 Thread via GitHub
janhoy merged PR #2117: URL: https://github.com/apache/solr/pull/2117 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] SOLR-16577: Always log core load issues [solr]

2023-12-06 Thread via GitHub
heythm commented on code in PR #1221: URL: https://github.com/apache/solr/pull/1221#discussion_r1417168401 ## solr/core/src/java/org/apache/solr/core/CoreContainer.java: ## @@ -973,29 +969,31 @@ public void load() { solrCores.markCoreAsLoading(cd); }

Re: [PR] SOLR-16577: Always log core load issues [solr]

2023-12-06 Thread via GitHub
heythm commented on code in PR #1221: URL: https://github.com/apache/solr/pull/1221#discussion_r1417144757 ## solr/core/src/java/org/apache/solr/core/CoreContainer.java: ## @@ -1004,24 +1002,9 @@ public void load() { backgroundCloser.start(); } finally { - if

[jira] [Created] (SOLR-17099) Unsolicited snitch tag warnings from AttributeFetcherImpl

2023-12-06 Thread Colvin Cowie (Jira)
Colvin Cowie created SOLR-17099: --- Summary: Unsolicited snitch tag warnings from AttributeFetcherImpl Key: SOLR-17099 URL: https://issues.apache.org/jira/browse/SOLR-17099 Project: Solr Issue Ty

[jira] [Commented] (SOLR-16833) Apache Solr's blog

2023-12-06 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793655#comment-17793655 ] Jan Høydahl commented on SOLR-16833: A blog section on our site could host both. A fu