Re: [PR] SOLR-11535: Fix race condition in singleton-per-collection StateWatcher creation [solr]

2024-03-03 Thread via GitHub
noblepaul commented on code in PR #1964: URL: https://github.com/apache/solr/pull/1964#discussion_r1510479018 ## solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkStateReader.java: ## @@ -1763,26 +1784,29 @@ public void registerCollectionStateWatcher( * The Watche

Re: [PR] SOLR-11535: Fix race condition in singleton-per-collection StateWatcher creation [solr]

2024-03-03 Thread via GitHub
noblepaul commented on code in PR #1964: URL: https://github.com/apache/solr/pull/1964#discussion_r1510478108 ## solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkStateReader.java: ## @@ -1679,19 +1698,21 @@ public static String getCollectionPath(String coll) { *

Re: [PR] SOLR-11535: Fix race condition in singleton-per-collection StateWatcher creation [solr]

2024-03-03 Thread via GitHub
noblepaul commented on code in PR #1964: URL: https://github.com/apache/solr/pull/1964#discussion_r1510478108 ## solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkStateReader.java: ## @@ -1679,19 +1698,21 @@ public static String getCollectionPath(String coll) { *

Re: [PR] SOLR-16505: Switch UpdateShardHandler.getRecoveryOnlyHttpClient to Jetty HTTP2 [solr]

2024-03-03 Thread via GitHub
iamsanjay commented on PR #2276: URL: https://github.com/apache/solr/pull/2276#issuecomment-1975233648 @dsmiley I was working on IndexFetcher to change their client to Http2SolrClient. Suddenly all the request started failing due to authentication issue. Further inspection revealed that th

[jira] [Resolved] (SOLR-7074) Simple script to start external Zookeeper

2024-03-03 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-7074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh resolved SOLR-7074. - Resolution: Workaround > Simple script to start external Zookeeper > -

[jira] [Commented] (SOLR-7074) Simple script to start external Zookeeper

2024-03-03 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-7074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17822966#comment-17822966 ] Eric Pugh commented on SOLR-7074: - Need to start up zookeeper?  do this.   docker run --

[jira] [Commented] (SOLR-14115) Deprecate zkcli.sh

2024-03-03 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17822964#comment-17822964 ] Eric Pugh commented on SOLR-14115: -- I noticed in [https://solr.apache.org/guide/solr/la

[jira] (SOLR-7233) rename zkcli.sh script it clashes with zkCli.sh from ZooKeeper on Mac when both are in $PATH

2024-03-03 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-7233 ] Eric Pugh deleted comment on SOLR-7233: - was (Author: epugh): I noticed in [https://solr.apache.org/guide/solr/latest/deployment-guide/taking-solr-to-production.html#zookeeper-chroot] a reference

[jira] [Commented] (SOLR-7233) rename zkcli.sh script it clashes with zkCli.sh from ZooKeeper on Mac when both are in $PATH

2024-03-03 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-7233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17822957#comment-17822957 ] Eric Pugh commented on SOLR-7233: - I noticed in [https://solr.apache.org/guide/solr/lates

Re: [PR] SOLR-14115: Allow bin/solr zk commands to have parity with zkcli.sh commands. [solr]

2024-03-03 Thread via GitHub
epugh commented on PR #2298: URL: https://github.com/apache/solr/pull/2298#issuecomment-1975205848 @gus-asf would love your review of commit 2efdcdbc4174c4517cfc59e8fd8f42cf0bb0ec95 specifically! -- This is an automated message from the Apache Git Service. To respond to the message, plea