Re: [PR] SOLR-17153 Resolve IndexOutOfBoundsException [solr]

2024-04-07 Thread via GitHub
dsmiley commented on code in PR #2393: URL: https://github.com/apache/solr/pull/2393#discussion_r1555105525 ## solr/core/src/java/org/apache/solr/servlet/HttpSolrCall.java: ## @@ -1066,13 +1066,14 @@ private Map checkStateVersionsAreValid(String stateVer) { protected SolrC

Re: [PR] SOLR-17189 Fix DockMakerTest.testRealisticUnicode [solr]

2024-04-07 Thread via GitHub
dsmiley commented on PR #2327: URL: https://github.com/apache/solr/pull/2327#issuecomment-2041634519 After reading some QuickTheories docs, it seems using an `assume(Predicate)` would be an alternative; less code too. I'll switch it. -- This is an automated message from the Apache Git Se

[jira] [Commented] (SOLR-14410) Switch from SysV init script to systemd service definition

2024-04-07 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17834743#comment-17834743 ] Jan Høydahl commented on SOLR-14410: Thanks for chiming in Stefan. Not sold on runni

Re: [PR] Demonstrate a test framework bug [solr]

2024-04-07 Thread via GitHub
janhoy commented on PR #2242: URL: https://github.com/apache/solr/pull/2242#issuecomment-2041631503 Thanks for being proactive on this. I think too it is scary that SolrJ is hybrid client/server code that risks containing server specific code and dependencies. Your workaround of skipping pa

[jira] [Commented] (SOLR-17153) CloudSolrClient should not throw "Collection not found" with an out-dated ClusterState

2024-04-07 Thread Aparna Suresh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17834694#comment-17834694 ] Aparna Suresh commented on SOLR-17153: -- [~epugh] , thank you for bringing this to my

Re: [PR] SOLR-17153: Resolve IndexOutOfBoundsException in HttpSolrCall.resolveDocCollection() [solr]

2024-04-07 Thread via GitHub
aparnasuresh85 commented on PR #2392: URL: https://github.com/apache/solr/pull/2392#issuecomment-2041500688 > > +1 to the change. needs "tidy" clearly (you don't have a space to the left of the parenthesis) > > Also something was eating at it me a bit... the method you added, `resolveDoc

Re: [PR] SOLR-17153: Resolve IndexOutOfBoundsException in HttpSolrCall.resolveDocCollection() [solr]

2024-04-07 Thread via GitHub
aparnasuresh85 commented on PR #2392: URL: https://github.com/apache/solr/pull/2392#issuecomment-2041433421 > +1 to the change. needs "tidy" clearly (you don't have a space to the left of the parenthesis) > > Also something was eating at it me a bit... the method you added, `resolveD

[jira] (SOLR-17153) CloudSolrClient should not throw "Collection not found" with an out-dated ClusterState

2024-04-07 Thread Aparna Suresh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17153 ] Aparna Suresh deleted comment on SOLR-17153: -- was (Author: JIRAUSER302780): Hi [~epugh] , I have not reproduced the issue you reported. However, I've implemented a check to verify if the 'c

[PR] SOLR-17153 Resolve IndexOutOfBoundsException [solr]

2024-04-07 Thread via GitHub
aparnasuresh85 opened a new pull request, #2393: URL: https://github.com/apache/solr/pull/2393 https://issues.apache.org/jira/browse/SOLR-17153 # Description Resolve an IndexOutOfBoundsException in HttpSolrCall.resolveDocCollection(), at line: String collectionN

Re: [PR] SOLR-17153: Resolve IndexOutOfBoundsException in HttpSolrCall.resolveDocCollection() [solr]

2024-04-07 Thread via GitHub
aparnasuresh85 closed pull request #2392: SOLR-17153: Resolve IndexOutOfBoundsException in HttpSolrCall.resolveDocCollection() URL: https://github.com/apache/solr/pull/2392 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use