Re: [PR] SOLR-13350: Multithreaded search [solr]

2024-05-06 Thread via GitHub
chatman commented on PR #2248: URL: https://github.com/apache/solr/pull/2248#issuecomment-2097393260 > Merging to main was unexpected to me because of the healthy code review happening here didn't conclude. I didn't want this to languish for a long time, and there were large PRs in t

Re: [PR] EncryptionBackupRepository to back up encrypted files. [solr-sandbox]

2024-05-06 Thread via GitHub
dsmiley commented on code in PR #106: URL: https://github.com/apache/solr-sandbox/pull/106#discussion_r1591733443 ## encryption/src/main/java/org/apache/solr/encryption/EncryptionBackupRepository.java: ## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[jira] [Commented] (SOLR-16924) Restore: Have RESTORECORE set the UpdateLog state

2024-05-06 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844085#comment-17844085 ] David Smiley commented on SOLR-16924: - [~gerlowskija] I could use your insights on so

Re: [PR] SOLR-17049: Fix Replica Down on startup logic [solr]

2024-05-06 Thread via GitHub
murblanc commented on code in PR #2432: URL: https://github.com/apache/solr/pull/2432#discussion_r1591646646 ## solr/core/src/java/org/apache/solr/cloud/ZkController.java: ## @@ -2849,9 +2834,14 @@ public boolean checkIfCoreNodeNameAlreadyExists(CoreDescriptor dcore) { * Be

Re: [PR] SOLR-17192: Add "field-limiting" URP to catch ill-designed schemas [solr]

2024-05-06 Thread via GitHub
dsmiley commented on PR #2395: URL: https://github.com/apache/solr/pull/2395#issuecomment-2097012109 See https://github.com/gerlowskija/solr/pull/5 for a commit that makes a large simplification: * No NumFieldsMonitor * No named URP; anonymous class is fine (and less code) * URP nee

[PR] EncryptionBackupRepository to back up encrypted files. [solr-sandbox]

2024-05-06 Thread via GitHub
bruno-roustant opened a new pull request, #106: URL: https://github.com/apache/solr-sandbox/pull/106 A new EncryptionBackupRepository is required to backup correctly files encrypted with the EncryptionDirectory, otherwise index files are decrypted before the backup copy.
EncryptionBackupRep

[PR] EncryptionBackupRepository to back up encrypted files. [solr-sandbox]

2024-05-06 Thread via GitHub
bruno-roustant opened a new pull request, #105: URL: https://github.com/apache/solr-sandbox/pull/105 A new EncryptionBackupRepository is required to backup correctly files encrypted with the EncryptionDirectory, otherwise index files are decrypted before the backup copy. EncryptionBackup

Re: [PR] SOLR-17192: Add "field-limiting" URP to catch ill-designed schemas [solr]

2024-05-06 Thread via GitHub
dsmiley commented on code in PR #2395: URL: https://github.com/apache/solr/pull/2395#discussion_r1591513535 ## solr/core/src/java/org/apache/solr/update/processor/NumFieldLimitingUpdateRequestProcessorFactory.java: ## @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] SOLR-13350: Multithreaded search [solr]

2024-05-06 Thread via GitHub
dsmiley commented on PR #2248: URL: https://github.com/apache/solr/pull/2248#issuecomment-2096822608 > This pull request is closed, but the jira/solr-13350 branch has unmerged commits. Not sure what didn't make it -- This is an automated message from the Apache Git Service. To resp

Re: [PR] SOLR-13350: Multithreaded search [solr]

2024-05-06 Thread via GitHub
dsmiley commented on PR #2248: URL: https://github.com/apache/solr/pull/2248#issuecomment-2096821401 Merging to main was unexpected to me because of the healthy code review happening here didn't conclude. Next time please announce an intention to do so in a couple days. I would have given

[jira] [Commented] (SOLR-17278) Timezone with DST=true and DST=0 fails test

2024-05-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17843860#comment-17843860 ] ASF subversion and git services commented on SOLR-17278: Commit c

[jira] [Resolved] (SOLR-17278) Timezone with DST=true and DST=0 fails test

2024-05-06 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ishan Chattopadhyaya resolved SOLR-17278. - Fix Version/s: 9.7 Resolution: Fixed > Timezone with DST=true and DST=0 fa

[jira] [Commented] (SOLR-17278) Timezone with DST=true and DST=0 fails test

2024-05-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17843859#comment-17843859 ] ASF subversion and git services commented on SOLR-17278: Commit d

[jira] [Commented] (SOLR-17278) Timezone with DST=true and DST=0 fails test

2024-05-06 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17843858#comment-17843858 ] Ishan Chattopadhyaya commented on SOLR-17278: - FYI, the tzdb.dat that's on my

Re: [PR] SOLR-17263: HttpJdkSolrClient doesn't encode curly braces etc [solr]

2024-05-06 Thread via GitHub
jdyer1 commented on code in PR #2433: URL: https://github.com/apache/solr/pull/2433#discussion_r1591485125 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpJdkSolrClient.java: ## @@ -299,10 +299,23 @@ private PreparedRequest preparePutOrPost( InputStream is =

[jira] [Commented] (SOLR-17278) Timezone with DST=true and DST=0 fails test

2024-05-06 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17843854#comment-17843854 ] Ishan Chattopadhyaya commented on SOLR-17278: - {code} 1168 WARN (TEST-TimeZo

[jira] [Updated] (SOLR-17278) Timezone with DST=true and DST=0 fails test

2024-05-06 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ishan Chattopadhyaya updated SOLR-17278: Attachment: SOLR-17278-1.patch Status: Open (was: Open) > Timezone with DS

[jira] [Updated] (SOLR-17278) Timezone with DST=true and DST=0 fails test

2024-05-06 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ishan Chattopadhyaya updated SOLR-17278: Attachment: SOLR-17278.patch Status: Open (was: Open) Here's a patch to sk

[jira] [Created] (SOLR-17278) Timezone with DST=true and DST=0 fails test

2024-05-06 Thread Ishan Chattopadhyaya (Jira)
Ishan Chattopadhyaya created SOLR-17278: --- Summary: Timezone with DST=true and DST=0 fails test Key: SOLR-17278 URL: https://issues.apache.org/jira/browse/SOLR-17278 Project: Solr Issue

[jira] [Commented] (SOLR-13350) Explore collector managers for multi-threaded search

2024-05-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17843845#comment-17843845 ] ASF subversion and git services commented on SOLR-13350: Commit f

[jira] [Commented] (SOLR-13350) Explore collector managers for multi-threaded search

2024-05-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17843842#comment-17843842 ] ASF subversion and git services commented on SOLR-13350: Commit a

[jira] [Commented] (SOLR-13350) Explore collector managers for multi-threaded search

2024-05-06 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17843841#comment-17843841 ] Ishan Chattopadhyaya commented on SOLR-13350: - bq. Do we have a limited queue

Re: [PR] SOLR-13350: Multithreaded search [solr]

2024-05-06 Thread via GitHub
chatman commented on PR #2248: URL: https://github.com/apache/solr/pull/2248#issuecomment-2096693338 Thanks @cpoerschke and @dsmiley. I've merged to main, where this can bake for some days before merging to branch_9x. If there are any major outstanding issues, or any changes needed to docum

[jira] [Commented] (SOLR-13350) Explore collector managers for multi-threaded search

2024-05-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17843838#comment-17843838 ] ASF subversion and git services commented on SOLR-13350: Commit f

Re: [PR] SOLR-13350: Multithreaded search [solr]

2024-05-06 Thread via GitHub
asfgit closed pull request #2248: SOLR-13350: Multithreaded search URL: https://github.com/apache/solr/pull/2248 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] SOLR-13350: Multithreaded search [solr]

2024-05-06 Thread via GitHub
chatman commented on PR #2248: URL: https://github.com/apache/solr/pull/2248#issuecomment-2096670563 bq. I think that's an anti-pattern or broken and isn't what I meant in JIRA. We could use a SynchronousQueue (with fairness) if we want to block for a thread -- probably what we should do. F

Re: [I] Add support to set capabilities on Solr cloud container's security context [solr-operator]

2024-05-06 Thread via GitHub
bentastic27 commented on issue #489: URL: https://github.com/apache/solr-operator/issues/489#issuecomment-2096660400 I'm running into this issue on EKS. @janhoy / @HoustonPutman Are these extra capabilties/privs ever actually needed? If not, we can likely hardcode in the changes made

[PR] SOLR-17271 PerReplicaState: Shard leader elections still impact state.json [solr]

2024-05-06 Thread via GitHub
noblepaul opened a new pull request, #2443: URL: https://github.com/apache/solr/pull/2443 WIP. do not commit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[jira] [Commented] (SOLR-17271) PerReplicaState: Shard leader elections still impact state.json

2024-05-06 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17843821#comment-17843821 ] Noble Paul commented on SOLR-17271: --- [~jsweeney]  are you sure it is shard election th

[jira] [Resolved] (SOLR-17088) TestPrepRecovery.testLeaderNotResponding fails much more lately

2024-05-06 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman resolved SOLR-17088. --- Fix Version/s: main (10.0) Resolution: Fixed > TestPrepRecovery.testLeaderNotRespondin

[jira] [Created] (SOLR-17277) Circuit Breakers should support a "Warn-only" mode

2024-05-06 Thread Jason Gerlowski (Jira)
Jason Gerlowski created SOLR-17277: -- Summary: Circuit Breakers should support a "Warn-only" mode Key: SOLR-17277 URL: https://issues.apache.org/jira/browse/SOLR-17277 Project: Solr Issue Typ

Re: [PR] SOLR-17088: Fix custom solr.xml usage in tests with extra jettys [solr]

2024-05-06 Thread via GitHub
HoustonPutman merged PR #2437: URL: https://github.com/apache/solr/pull/2437 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apa

[PR] SOLR-17276 Scrape metrics at fixed rate in prometheus-exporter [solr]

2024-05-06 Thread via GitHub
rafalh opened a new pull request, #2442: URL: https://github.com/apache/solr/pull/2442 https://issues.apache.org/jira/browse/SOLR-17276 # Description Metrics are not scraped by prometheus-exporter at a fixed rate because it uses `scheduleWithFixedDelay` API to sched

[jira] [Created] (SOLR-17276) Use fixed rate instead of fixed delay in prometheus-exporter

2024-05-06 Thread Jira
Rafał Harabień created SOLR-17276: - Summary: Use fixed rate instead of fixed delay in prometheus-exporter Key: SOLR-17276 URL: https://issues.apache.org/jira/browse/SOLR-17276 Project: Solr

[jira] [Created] (SOLR-17275) Major performance regression of CloudSolrClient in Solr 9.6.0 when using aliases

2024-05-06 Thread Jira
Rafał Harabień created SOLR-17275: - Summary: Major performance regression of CloudSolrClient in Solr 9.6.0 when using aliases Key: SOLR-17275 URL: https://issues.apache.org/jira/browse/SOLR-17275 Proj

Re: [PR] SOLR-13360: Collation code fails with non-increasing token order [solr]

2024-05-06 Thread via GitHub
epugh commented on PR #210: URL: https://github.com/apache/solr/pull/210#issuecomment-2096253924 Looks like the PR needs a test to demonstrate the bug and therefore exercise the fix. These things are hard to evaluate without a unit test. Would you be willing to add one? -- This is an

Re: [PR] SOLR-17192: Add "field-limiting" URP to catch ill-designed schemas [solr]

2024-05-06 Thread via GitHub
gerlowskija commented on code in PR #2395: URL: https://github.com/apache/solr/pull/2395#discussion_r1591039849 ## solr/core/src/java/org/apache/solr/update/processor/NumFieldLimitingUpdateRequestProcessorFactory.java: ## @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache Software

Re: [PR] SOLR-17192: Add "field-limiting" URP to catch ill-designed schemas [solr]

2024-05-06 Thread via GitHub
gerlowskija commented on code in PR #2395: URL: https://github.com/apache/solr/pull/2395#discussion_r1591064705 ## solr/core/src/java/org/apache/solr/update/processor/NumFieldLimitingUpdateRequestProcessor.java: ## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] SOLR-13360: Collation code fails with non-increasing token order [solr]

2024-05-06 Thread via GitHub
geffchang commented on PR #210: URL: https://github.com/apache/solr/pull/210#issuecomment-2096067466 When is the plan to fix/merge this issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] SOLR-17192: Add "field-limiting" URP to catch ill-designed schemas [solr]

2024-05-06 Thread via GitHub
gerlowskija commented on code in PR #2395: URL: https://github.com/apache/solr/pull/2395#discussion_r1591039849 ## solr/core/src/java/org/apache/solr/update/processor/NumFieldLimitingUpdateRequestProcessorFactory.java: ## @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache Software

Re: [PR] Remove 9.4 from list of supported versions [solr-docker]

2024-05-06 Thread via GitHub
janhoy merged PR #21: URL: https://github.com/apache/solr-docker/pull/21 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.

Re: [PR] SOLR-17260 ReleaseWizard should remove old minor versions from Docker Hub [solr]

2024-05-06 Thread via GitHub
janhoy merged PR #2430: URL: https://github.com/apache/solr/pull/2430 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org