Re: [PR] SOLR-17274: allow JSON atomic updates to use multiple modifiers or a modifier like 'set' as a field name if child docs not enabled [solr]

2024-05-09 Thread via GitHub
dsmiley commented on code in PR #2451: URL: https://github.com/apache/solr/pull/2451#discussion_r1596254943 ## solr/core/src/test/org/apache/solr/update/processor/AtomicUpdatesJsonTest.java: ## @@ -0,0 +1,206 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] SOLR-17274: allow JSON atomic updates to use multiple modifiers or a modifier like 'set' as a field name if child docs not enabled [solr]

2024-05-09 Thread via GitHub
dsmiley commented on code in PR #2451: URL: https://github.com/apache/solr/pull/2451#discussion_r1596253399 ## solr/core/src/test/org/apache/solr/update/processor/AtomicUpdatesJsonTest.java: ## @@ -0,0 +1,206 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[jira] [Commented] (SOLR-16505) Switch UpdateShardHandler.getRecoveryOnlyHttpClient to Jetty HTTP2

2024-05-09 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845181#comment-17845181 ] Mark Robert Miller commented on SOLR-16505: --- Yeah, probably. The idea was to isolate connection

[I] zkHost and zkServer generated incorrectly - helm templates [solr-operator]

2024-05-09 Thread via GitHub
brickpattern opened a new issue, #704: URL: https://github.com/apache/solr-operator/issues/704 Observed the POD has a EnvVar with zkHost and zkServer set incorrectly ( generated from helm install )

Re: [PR] SOLR-17274: allow JSON atomic updates to use multiple modifiers or a modifier like 'set' as a field name if child docs not enabled [solr]

2024-05-09 Thread via GitHub
eukaryote commented on code in PR #2451: URL: https://github.com/apache/solr/pull/2451#discussion_r1596156041 ## solr/core/src/test/org/apache/solr/update/processor/AtomicUpdatesJsonTest.java: ## @@ -0,0 +1,206 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] SOLR-17274: allow JSON atomic updates to use multiple modifiers or a modifier like 'set' as a field name if child docs not enabled [solr]

2024-05-09 Thread via GitHub
eukaryote commented on code in PR #2451: URL: https://github.com/apache/solr/pull/2451#discussion_r1596155338 ## solr/core/src/test/org/apache/solr/update/processor/AtomicUpdatesJsonTest.java: ## @@ -0,0 +1,206 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] SOLR-17274: allow JSON atomic updates to use multiple modifiers or a modifier like 'set' as a field name if child docs not enabled [solr]

2024-05-09 Thread via GitHub
eukaryote commented on code in PR #2451: URL: https://github.com/apache/solr/pull/2451#discussion_r1596154616 ## solr/core/src/test/org/apache/solr/update/processor/AtomicUpdatesJsonTest.java: ## @@ -0,0 +1,206 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] SOLR-17274: allow JSON atomic updates to use multiple modifiers or a modifier like 'set' as a field name if child docs not enabled [solr]

2024-05-09 Thread via GitHub
eukaryote commented on code in PR #2451: URL: https://github.com/apache/solr/pull/2451#discussion_r1596153583 ## solr/core/src/test/org/apache/solr/update/processor/AtomicUpdatesJsonTest.java: ## @@ -0,0 +1,206 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] SOLR-17274: allow JSON atomic updates to use multiple modifiers or a modifier like 'set' as a field name if child docs not enabled [solr]

2024-05-09 Thread via GitHub
eukaryote commented on code in PR #2451: URL: https://github.com/apache/solr/pull/2451#discussion_r1596152691 ## solr/core/src/test/org/apache/solr/update/processor/AtomicUpdatesJsonTest.java: ## @@ -0,0 +1,206 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] SOLR-17274: allow JSON atomic updates to use multiple modifiers or a modifier like 'set' as a field name if child docs not enabled [solr]

2024-05-09 Thread via GitHub
eukaryote commented on code in PR #2451: URL: https://github.com/apache/solr/pull/2451#discussion_r1596153084 ## solr/core/src/test/org/apache/solr/update/processor/AtomicUpdatesJsonTest.java: ## @@ -0,0 +1,206 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] SOLR-17274: allow JSON atomic updates to use multiple modifiers or a modifier like 'set' as a field name if child docs not enabled [solr]

2024-05-09 Thread via GitHub
eukaryote commented on code in PR #2451: URL: https://github.com/apache/solr/pull/2451#discussion_r1596152187 ## solr/core/src/test/org/apache/solr/update/processor/AtomicUpdatesJsonTest.java: ## @@ -0,0 +1,206 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] SOLR-17274: allow JSON atomic updates to use multiple modifiers or a modifier like 'set' as a field name if child docs not enabled [solr]

2024-05-09 Thread via GitHub
eukaryote commented on code in PR #2451: URL: https://github.com/apache/solr/pull/2451#discussion_r1596138477 ## solr/core/src/test/org/apache/solr/update/processor/AtomicUpdatesJsonTest.java: ## @@ -0,0 +1,206 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[jira] [Resolved] (SOLR-17244) Create a dev-doc to orient prospective release managers

2024-05-09 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gus Heck resolved SOLR-17244. - Fix Version/s: main (10.0) Resolution: Done > Create a dev-doc to orient prospective release

Re: [PR] SOLR-17284: Remove deprecated BlobRepository [solr]

2024-05-09 Thread via GitHub
gus-asf commented on PR #2447: URL: https://github.com/apache/solr/pull/2447#issuecomment-2103628514 I'm not so keen on the loss of https://issues.apache.org/jira/browse/SOLR-8349 along with this. It was only tied to the blob repository because that seemed to be how folks wanted me to

Re: [PR] Jira/solr 16567 tentative [solr]

2024-05-09 Thread via GitHub
github-actions[bot] commented on PR #1246: URL: https://github.com/apache/solr/pull/1246#issuecomment-210365 This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify

[jira] [Commented] (SOLR-13350) Explore collector managers for multi-threaded search

2024-05-09 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845149#comment-17845149 ] Gus Heck commented on SOLR-13350: - I'm a little concerned that multithreaded is set to false [in the

Re: [PR] SOLR-17284: Remove deprecated BlobRepository [solr]

2024-05-09 Thread via GitHub
dsmiley commented on PR #2447: URL: https://github.com/apache/solr/pull/2447#issuecomment-2103571143 I see BlobHandler and supporting infrastructure still. It's not explicitly deprecated. Should the Schema Designer API use the "File Store" instead? Any way, I suppose this PR,

Re: [PR] Minor: Http2SolrClient cleanups [solr]

2024-05-09 Thread via GitHub
dsmiley commented on code in PR #2453: URL: https://github.com/apache/solr/pull/2453#discussion_r1596067352 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java: ## @@ -629,12 +624,6 @@ private static class MakeRequestReturnValue { } } -

[PR] Minor: Http2SolrClient cleanups [solr]

2024-05-09 Thread via GitHub
dsmiley opened a new pull request, #2453: URL: https://github.com/apache/solr/pull/2453 Just a few small matters; no material changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (SOLR-13350) Explore collector managers for multi-threaded search

2024-05-09 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845138#comment-17845138 ] Houston Putman commented on SOLR-13350: --- I've been looking around and can't quite tell why

[jira] [Comment Edited] (SOLR-16703) Clearing all documents of an index should delete traces of a previous Lucene version

2024-05-09 Thread Rahul Goswami (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845135#comment-17845135 ] Rahul Goswami edited comment on SOLR-16703 at 5/9/24 10:01 PM: --- I have done

[jira] [Commented] (SOLR-16703) Clearing all documents of an index should delete traces of a previous Lucene version

2024-05-09 Thread Rahul Goswami (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845135#comment-17845135 ] Rahul Goswami commented on SOLR-16703: -- I have done some work in this area and happy to take this

[jira] [Commented] (SOLR-16924) Restore: Have RESTORECORE set the UpdateLog state

2024-05-09 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845130#comment-17845130 ] David Smiley commented on SOLR-16924: - > (Funnily enough, this is actually an idea I got from you!

[jira] [Commented] (SOLR-17244) Create a dev-doc to orient prospective release managers

2024-05-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845127#comment-17845127 ] ASF subversion and git services commented on SOLR-17244: Commit

Re: [PR] SOLR-17244 - initial cut at an orientation for prospective release managers [solr]

2024-05-09 Thread via GitHub
gus-asf merged PR #2415: URL: https://github.com/apache/solr/pull/2415 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] SOLR-17244 - initial cut at an orientation for prospective release managers [solr]

2024-05-09 Thread via GitHub
gus-asf commented on PR #2415: URL: https://github.com/apache/solr/pull/2415#issuecomment-2103407100 > Be nice to get this merged ;-) I was just thinking the same thing :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (SOLR-16924) Restore: Have RESTORECORE set the UpdateLog state

2024-05-09 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845105#comment-17845105 ] Jason Gerlowski commented on SOLR-16924: bq. got very confused for a while until I realized we

Re: [PR] SOLR-17244 - initial cut at an orientation for prospective release managers [solr]

2024-05-09 Thread via GitHub
epugh commented on PR #2415: URL: https://github.com/apache/solr/pull/2415#issuecomment-2103223773 Be nice to get this merged ;-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Update dependency commons-codec:commons-codec to v1.17.0 [solr]

2024-05-09 Thread via GitHub
epugh merged PR #2426: URL: https://github.com/apache/solr/pull/2426 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[jira] [Resolved] (SOLR-17279) consolidate security.json constants in test code

2024-05-09 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh resolved SOLR-17279. -- Fix Version/s: main (10.0) Assignee: Eric Pugh Resolution: Fixed > consolidate

Re: [PR] SOLR-17279: consolidate security.json constants in tests [solr]

2024-05-09 Thread via GitHub
epugh merged PR #2445: URL: https://github.com/apache/solr/pull/2445 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[jira] [Commented] (SOLR-17279) consolidate security.json constants in test code

2024-05-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845096#comment-17845096 ] ASF subversion and git services commented on SOLR-17279: Commit

[PR] User Behavior Insights implementation for Apache Solr [solr]

2024-05-09 Thread via GitHub
epugh opened a new pull request, #2452: URL: https://github.com/apache/solr/pull/2452 # Description I am working with other folks, especially Stavros Macrakis (macra...@gmail.com), to come up with a solution for understanding what users are doing in response to search results. We

Re: [PR] SOLR-13681: make Lucene's index sorting directly configurable in Solr [solr]

2024-05-09 Thread via GitHub
atris commented on PR #313: URL: https://github.com/apache/solr/pull/313#issuecomment-2103067973 @cpoerschke I am about to pick this up and start a fresh PR since this one has gotten stale. Is it ok if I proceed? I will ensure that the PR is marked for your review and you are credited as

Re: [PR] SOLR-4587: integrate lucene-monitor into solr [solr]

2024-05-09 Thread via GitHub
cpoerschke commented on code in PR #2382: URL: https://github.com/apache/solr/pull/2382#discussion_r1595728913 ## solr/modules/monitor/src/java/org/apache/solr/monitor/search/ReverseSearchComponent.java: ## @@ -0,0 +1,254 @@ +/* + * + * * Licensed to the Apache Software

[jira] [Commented] (SOLR-17192) Maximum-fields-per-core soft limit

2024-05-09 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845060#comment-17845060 ] Jason Gerlowski commented on SOLR-17192: I can't say I'm always consistent on this, but I usually

Re: [PR] SOLR-17279: consolidate security.json constants in tests [solr]

2024-05-09 Thread via GitHub
epugh commented on PR #2445: URL: https://github.com/apache/solr/pull/2445#issuecomment-2103005840 i think I am coming around to the name... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (SOLR-16743) Auto reload keystore/truststore on change

2024-05-09 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845015#comment-17845015 ] David Smiley commented on SOLR-16743: - Where I work, we use rotating keys but we don't need changes

[jira] [Created] (SOLR-17286) HttpSolrCall.remoteQuery should use Jetty HttpClient

2024-05-09 Thread David Smiley (Jira)
David Smiley created SOLR-17286: --- Summary: HttpSolrCall.remoteQuery should use Jetty HttpClient Key: SOLR-17286 URL: https://issues.apache.org/jira/browse/SOLR-17286 Project: Solr Issue Type:

[jira] [Updated] (SOLR-17286) HttpSolrCall.remoteQuery should use Jetty HttpClient

2024-05-09 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-17286: Labels: newdev (was: ) > HttpSolrCall.remoteQuery should use Jetty HttpClient >

[jira] [Commented] (SOLR-16505) Switch UpdateShardHandler.getRecoveryOnlyHttpClient to Jetty HTTP2

2024-05-09 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844985#comment-17844985 ] David Smiley commented on SOLR-16505: - [~markrmiller] , based on the callers of

Re: [PR] SOLR-16503: Introduce new default Http2SolrClient in UpdateShardHandler [solr]

2024-05-09 Thread via GitHub
iamsanjay commented on code in PR #2351: URL: https://github.com/apache/solr/pull/2351#discussion_r1595232511 ## solr/core/src/java/org/apache/solr/update/UpdateShardHandler.java: ## @@ -236,11 +246,17 @@ public SolrMetricsContext getSolrMetricsContext() { return

Re: [PR] SOLR-16503: Introduce new default Http2SolrClient in UpdateShardHandler [solr]

2024-05-09 Thread via GitHub
iamsanjay commented on code in PR #2351: URL: https://github.com/apache/solr/pull/2351#discussion_r1595227078 ## solr/core/src/java/org/apache/solr/update/UpdateShardHandler.java: ## @@ -236,11 +246,17 @@ public SolrMetricsContext getSolrMetricsContext() { return