Re: [PR] SOLR-17290: Update SyncStrategy and PeerSyncWithLeader to use the recovery Http2SolrClient [solr]

2024-05-14 Thread via GitHub
dsmiley commented on PR #2460: URL: https://github.com/apache/solr/pull/2460#issuecomment-2111608909 +1; will merge tomorrow. > The solr client is being used for REQUESTRECOVERY and did not seem to need the auth for that. Maybe you know something I don't here; what technical

Re: [PR] SOLR-17294: The stall detection in the ConcurrentUpdateSolrClients easily detects false positives. [solr]

2024-05-14 Thread via GitHub
markrmiller commented on PR #2461: URL: https://github.com/apache/solr/pull/2461#issuecomment-2111409609 There is no real reason you need to check the size of the queue as well, but I just kept it anyway. -- This is an automated message from the Apache Git Service. To respond to the

[PR] SOLR-17294: The stall detection in the ConcurrentUpdateSolrClients easily detects false positives. [solr]

2024-05-14 Thread via GitHub
markrmiller opened a new pull request, #2461: URL: https://github.com/apache/solr/pull/2461 The current stall detection mechanism in the ConcurrentUpdateSolrClients is prone to generating false positives, especially under load. As pointed out by Jason, the existing approach simply

[jira] [Created] (SOLR-17294) The stall detection in the ConcurrentUpdateSolrClients easily detects false positives.

2024-05-14 Thread Mark Robert Miller (Jira)
Mark Robert Miller created SOLR-17294: - Summary: The stall detection in the ConcurrentUpdateSolrClients easily detects false positives. Key: SOLR-17294 URL: https://issues.apache.org/jira/browse/SOLR-17294

Re: [PR] SOLR-17106: LBSolrClient - Make zombie ping checks configurable [solr]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #2160: URL: https://github.com/apache/solr/pull/2160#issuecomment-2111347606 This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify

Re: [PR] SOLR-17109: Give security manager explicit read access to sharedLib [solr]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #2172: URL: https://github.com/apache/solr/pull/2172#issuecomment-2111347562 This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify

Re: [PR] SOLR-12813 followup -- preserve user Principal in alternate codepath in EmbeddedSolrServer [solr]

2024-05-14 Thread via GitHub
dsmiley commented on code in PR #2429: URL: https://github.com/apache/solr/pull/2429#discussion_r1600677935 ## solr/core/src/java/org/apache/solr/client/solrj/embedded/EmbeddedSolrServer.java: ## @@ -164,7 +164,8 @@ public NamedList request(SolrRequest request, String

Re: [PR] SOLR-16414: Race condition in PRS state updates [solr]

2024-05-14 Thread via GitHub
dsmiley commented on code in PR #1019: URL: https://github.com/apache/solr/pull/1019#discussion_r1600674211 ## solr/core/src/java/org/apache/solr/cloud/ZkController.java: ## Review Comment: @noblepaul , the change in ZkController.publishNodeAsDown was done on the

[jira] [Created] (SOLR-17293) Umbrella: Decentralized Cluster Processing as default

2024-05-14 Thread David Smiley (Jira)
David Smiley created SOLR-17293: --- Summary: Umbrella: Decentralized Cluster Processing as default Key: SOLR-17293 URL: https://issues.apache.org/jira/browse/SOLR-17293 Project: Solr Issue Type:

[jira] [Created] (SOLR-17292) PerReplicaStatesOps.persist should propagate failure

2024-05-14 Thread David Smiley (Jira)
David Smiley created SOLR-17292: --- Summary: PerReplicaStatesOps.persist should propagate failure Key: SOLR-17292 URL: https://issues.apache.org/jira/browse/SOLR-17292 Project: Solr Issue Type:

Re: [PR] SOLR-12813 followup -- preserve user Principal in alternate codepath in EmbeddedSolrServer [solr]

2024-05-14 Thread via GitHub
epugh commented on code in PR #2429: URL: https://github.com/apache/solr/pull/2429#discussion_r1600641695 ## solr/core/src/java/org/apache/solr/client/solrj/embedded/EmbeddedSolrServer.java: ## @@ -164,7 +164,8 @@ public NamedList request(SolrRequest request, String coreName)

Re: [PR] SOLR-12813 followup -- preserve user Principal in alternate codepath in EmbeddedSolrServer [solr]

2024-05-14 Thread via GitHub
epugh commented on code in PR #2429: URL: https://github.com/apache/solr/pull/2429#discussion_r1600640407 ## solr/core/src/java/org/apache/solr/client/solrj/embedded/EmbeddedSolrServer.java: ## @@ -164,7 +164,8 @@ public NamedList request(SolrRequest request, String coreName)

Re: [PR] SOLR-12813 followup -- preserve user Principal in alternate codepath in EmbeddedSolrServer [solr]

2024-05-14 Thread via GitHub
epugh commented on code in PR #2429: URL: https://github.com/apache/solr/pull/2429#discussion_r1600629287 ## solr/core/src/java/org/apache/solr/client/solrj/embedded/EmbeddedSolrServer.java: ## @@ -164,7 +164,8 @@ public NamedList request(SolrRequest request, String coreName)

Re: [PR] Admin UI: fixed node list display bug caused by different hostname with same front part [solr]

2024-05-14 Thread via GitHub
epugh commented on PR #2449: URL: https://github.com/apache/solr/pull/2449#issuecomment-2111092186 @hgdharold how would you like to be credited in the `solr/CHANGES.txt` file? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Updated] (SOLR-17275) Major performance regression of CloudSolrClient in Solr 9.6.0 when using aliases

2024-05-14 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-17275: Priority: Blocker (was: Major) > Major performance regression of CloudSolrClient in Solr 9.6.0

[jira] [Resolved] (SOLR-17049) Marking replicas down at startup and waiting does not wait

2024-05-14 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman resolved SOLR-17049. --- Fix Version/s: 9.7 9.6.1 Assignee: Houston Putman

Re: [PR] SOLR-17049: Fix Replica Down on startup logic [solr]

2024-05-14 Thread via GitHub
HoustonPutman merged PR #2432: URL: https://github.com/apache/solr/pull/2432 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (SOLR-13131) Category Routed Aliases

2024-05-14 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846390#comment-17846390 ] David Smiley commented on SOLR-13131: - [~gus] This issue introduced CoreContainer.runAsync using a

Re: [PR] SOLR-4587: integrate lucene-monitor into solr [solr]

2024-05-14 Thread via GitHub
kotman12 commented on code in PR #2382: URL: https://github.com/apache/solr/pull/2382#discussion_r1600473201 ## solr/modules/monitor/src/java/org/apache/solr/monitor/update/MonitorUpdateRequestProcessor.java: ## @@ -0,0 +1,257 @@ +/* + * + * * Licensed to the Apache Software

Re: [PR] SOLR-4587: integrate lucene-monitor into solr [solr]

2024-05-14 Thread via GitHub
kotman12 commented on code in PR #2382: URL: https://github.com/apache/solr/pull/2382#discussion_r1600473201 ## solr/modules/monitor/src/java/org/apache/solr/monitor/update/MonitorUpdateRequestProcessor.java: ## @@ -0,0 +1,257 @@ +/* + * + * * Licensed to the Apache Software

Re: [PR] SOLR-4587: integrate lucene-monitor into solr [solr]

2024-05-14 Thread via GitHub
cpoerschke commented on code in PR #2382: URL: https://github.com/apache/solr/pull/2382#discussion_r1600429537 ## solr/modules/monitor/src/java/org/apache/solr/monitor/update/MonitorUpdateRequestProcessor.java: ## @@ -0,0 +1,257 @@ +/* + * + * * Licensed to the Apache Software

Re: [PR] SOLR-4587: integrate lucene-monitor into solr [solr]

2024-05-14 Thread via GitHub
cpoerschke commented on code in PR #2382: URL: https://github.com/apache/solr/pull/2382#discussion_r1600429537 ## solr/modules/monitor/src/java/org/apache/solr/monitor/update/MonitorUpdateRequestProcessor.java: ## @@ -0,0 +1,257 @@ +/* + * + * * Licensed to the Apache Software

Re: [PR] SOLR-4587: integrate lucene-monitor into solr [solr]

2024-05-14 Thread via GitHub
cpoerschke commented on code in PR #2382: URL: https://github.com/apache/solr/pull/2382#discussion_r1600418059 ## solr/modules/monitor/src/java/org/apache/solr/monitor/update/MonitorUpdateRequestProcessor.java: ## @@ -0,0 +1,257 @@ +/* + * + * * Licensed to the Apache Software

[jira] [Commented] (SOLR-17274) atomic update error when using json w/ multiple modifiers

2024-05-14 Thread Calvin Smith (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846374#comment-17846374 ] Calvin Smith commented on SOLR-17274: - My pleasure. Thanks for your help in getting it in. > atomic

Re: [PR] Admin UI: fixed node list display bug caused by different hostname with same front part [solr]

2024-05-14 Thread via GitHub
cpoerschke commented on PR #2449: URL: https://github.com/apache/solr/pull/2449#issuecomment-2110667390 > ... @cpoerschke not sure if you have a strategy to test it? No, I don't, sorry. -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Updated] (SOLR-17291) Error opening new searcher Caused by indexDeletionPolicy must not be null

2024-05-14 Thread Jerry Chung (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jerry Chung updated SOLR-17291: --- Description: This happened when a new replica was created.   {{2024-05-14 15:08:17.474 ERROR

[jira] [Created] (SOLR-17291) Error opening new searcher Caused by indexDeletionPolicy must not be null

2024-05-14 Thread Jerry Chung (Jira)
Jerry Chung created SOLR-17291: -- Summary: Error opening new searcher Caused by indexDeletionPolicy must not be null Key: SOLR-17291 URL: https://issues.apache.org/jira/browse/SOLR-17291 Project: Solr

Re: [I] Our client needs zookeeper hosts [solr-operator]

2024-05-14 Thread via GitHub
HoustonPutman commented on issue #233: URL: https://github.com/apache/solr-operator/issues/233#issuecomment-2110589598 You cannot use an ingress for Zookeeper, since Ingresses only support HTTP (which Zookeeper does not use). -- This is an automated message from the Apache Git Service.

Re: [PR] SOLR-17290: Update SyncStrategy and PeerSyncWithLeader to use the recovery Http2SolrClient [solr]

2024-05-14 Thread via GitHub
iamsanjay commented on PR #2460: URL: https://github.com/apache/solr/pull/2460#issuecomment-2110584526 > I don't think this PR should be for [SOLR-16503](https://issues.apache.org/jira/browse/SOLR-16503). It should be [SOLR-16505](https://issues.apache.org/jira/browse/SOLR-16505) (it's

[jira] [Created] (SOLR-17290) Update SyncStrategy and PeerSyncWithLeader to use the recovery Http2SolrClient

2024-05-14 Thread Sanjay Dutt (Jira)
Sanjay Dutt created SOLR-17290: -- Summary: Update SyncStrategy and PeerSyncWithLeader to use the recovery Http2SolrClient Key: SOLR-17290 URL: https://issues.apache.org/jira/browse/SOLR-17290 Project:

Re: [PR] SOLR-16503: Update SyncStrategy and PeerSyncWithLeader to use the recovery Http2SolrClient [solr]

2024-05-14 Thread via GitHub
dsmiley commented on PR #2460: URL: https://github.com/apache/solr/pull/2460#issuecomment-2110414440 I don't think this PR should be for SOLR-16503. It should be SOLR-16505 (it's okay it's closed, can be reopened; is unreleased so there's time) as it's focused on "recovery". Or perhaps a

Re: [PR] SOLR-17289: OrderedNodePlacementPlugin: optimize don't loop collections [solr]

2024-05-14 Thread via GitHub
dsmiley commented on PR #2459: URL: https://github.com/apache/solr/pull/2459#issuecomment-2110379724 Separately, I wonder if we make it too easy to loop the state of every collection. I'm looking at `Cluster` added by @murblanc which contains not only an `Iterator iterator();` method, but

Re: [I] Our client needs zookeeper hosts [solr-operator]

2024-05-14 Thread via GitHub
nickZDG01 commented on issue #233: URL: https://github.com/apache/solr-operator/issues/233#issuecomment-2110191694 Hi, can i ask you how did you configure your Ingress service? Also does the internal connection between ZK and solr remain intact? -- This is an automated message from the

Re: [I] zkHost and zkServer generated incorrectly - helm templates [solr-operator]

2024-05-14 Thread via GitHub
brickpattern closed issue #704: zkHost and zkServer generated incorrectly - helm templates URL: https://github.com/apache/solr-operator/issues/704 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [I] zkHost and zkServer generated incorrectly - helm templates [solr-operator]

2024-05-14 Thread via GitHub
brickpattern commented on issue #704: URL: https://github.com/apache/solr-operator/issues/704#issuecomment-2110180705 closing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] zkHost and zkServer generated incorrectly - helm templates [solr-operator]

2024-05-14 Thread via GitHub
brickpattern commented on issue #704: URL: https://github.com/apache/solr-operator/issues/704#issuecomment-2110180338 after looking at what the Zookeeper charts are doing, its establishing the DOMAIN for the service as "solr-solrcloud-zookeeper-headless" Even though the name

Re: [PR] Admin UI: fixed node list display bug caused by different hostname with same front part [solr]

2024-05-14 Thread via GitHub
epugh commented on PR #2449: URL: https://github.com/apache/solr/pull/2449#issuecomment-2110176384 I'd like to merge this, however can you give me some concrete examples of different hostname with same front part? I'm just not totally sure how to test the fix ;-). @cpoerschke not sure

Re: [PR] SOLR-17284: Remove deprecated BlobRepository [solr]

2024-05-14 Thread via GitHub
epugh commented on PR #2447: URL: https://github.com/apache/solr/pull/2447#issuecomment-2110170918 I'd like to get this in for 9.7, so that isn't in a hurry. Why don't I leave this open till then, and then let's see what happens. If it get's fixed, great. if not, and someone really

[jira] [Commented] (SOLR-3443) Optimize hunspell dictionary loading with multiple cores

2024-05-14 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-3443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846298#comment-17846298 ] David Smiley commented on SOLR-3443: Where I work, we have both massive resources in our schema and

Re: [PR] Update ENCRYPTION.md to describe EncryptionBackupRepository. [solr-sandbox]

2024-05-14 Thread via GitHub
bruno-roustant merged PR #107: URL: https://github.com/apache/solr-sandbox/pull/107 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (SOLR-16505) Switch UpdateShardHandler.getRecoveryOnlyHttpClient to Jetty HTTP2

2024-05-14 Thread Sanjay Dutt (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846185#comment-17846185 ] Sanjay Dutt commented on SOLR-16505: Without your support, this PR wouldn't have seen the light of

Re: [PR] SOLR-17284: Remove deprecated BlobRepository [solr]

2024-05-14 Thread via GitHub
gus-asf commented on PR #2447: URL: https://github.com/apache/solr/pull/2447#issuecomment-2109362867 The ideal thing would be to use it to solve https://issues.apache.org/jira/browse/SOLR-3443 with it at the same time since that's essentially the same problem my client faced. Not sure

[PR] SOLR-16503: Update SyncStrategy and PeerSyncWithLeader to use the recovery Http2SolrClient [solr]

2024-05-14 Thread via GitHub
iamsanjay opened a new pull request, #2460: URL: https://github.com/apache/solr/pull/2460 https://issues.apache.org/jira/browse/SOLR-16503 As per the discussion on this thread [SOLR-16505](https://issues.apache.org/jira/browse/SOLR-16505), It has been identified that