Re: [PR] SOLR-17195: Add 'minPrefixLength' soft limit [solr]

2024-06-10 Thread via GitHub
markrmiller commented on PR #2499: URL: https://github.com/apache/solr/pull/2499#issuecomment-2159696597 One use case where opt-in still has a lot of value is when one team runs Solr as a service or for other teams. In that case, it's much more of an available feature than automatic user

Re: [PR] SOLR-17195: Add 'minPrefixLength' soft limit [solr]

2024-06-10 Thread via GitHub
markrmiller commented on PR #2499: URL: https://github.com/apache/solr/pull/2499#issuecomment-2159688977 “what do you think of Jason's approach here?” It is a kind thorny practice that evades a good definitive judgment. I suppose the idea is, at some, perhaps fairly arbitrary

Re: [PR] SOLR-17269: Do not publish synthetic solr core (of Coordinator node) to ZK [solr]

2024-06-10 Thread via GitHub
patsonluk commented on PR #2438: URL: https://github.com/apache/solr/pull/2438#issuecomment-2159442685 @dsmiley I have committed changes based on your feedback last week! And have replied to several of your comments. Would you mind to go over them again and let me know your thoughts?

Re: [PR] SOLR-17326: Fix wrong references in generated API classes [solr]

2024-06-10 Thread via GitHub
malliaridis commented on PR #2510: URL: https://github.com/apache/solr/pull/2510#issuecomment-2159414908 Thanks for the positive feedback, it means a lot. > Though I wonder about a few APIs that return "blobs" of data If this could be addressed then adding additional

Re: [PR] SOLR-17269: Do not publish synthetic solr core (of Coordinator node) to ZK [solr]

2024-06-10 Thread via GitHub
patsonluk commented on code in PR #2438: URL: https://github.com/apache/solr/pull/2438#discussion_r1633899859 ## solr/core/src/java/org/apache/solr/servlet/CoordinatorHttpSolrCall.java: ## @@ -88,198 +81,70 @@ public static SolrCore getCore( String syntheticCoreName =

Re: [PR] SOLR-17269: Do not publish synthetic solr core (of Coordinator node) to ZK [solr]

2024-06-10 Thread via GitHub
patsonluk commented on code in PR #2438: URL: https://github.com/apache/solr/pull/2438#discussion_r1633897358 ## solr/core/src/java/org/apache/solr/core/SyntheticSolrCore.java: ## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

Re: [PR] SOLR-17269: Do not publish synthetic solr core (of Coordinator node) to ZK [solr]

2024-06-10 Thread via GitHub
patsonluk commented on code in PR #2438: URL: https://github.com/apache/solr/pull/2438#discussion_r1633896429 ## solr/core/src/java/org/apache/solr/core/SyntheticSolrCore.java: ## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

Re: [PR] SOLR-17321: Remove Deprecated URL API in Preparation for Java 21 [solr]

2024-06-10 Thread via GitHub
dsmiley commented on code in PR #2501: URL: https://github.com/apache/solr/pull/2501#discussion_r1633855796 ## solr/CHANGES.txt: ## @@ -127,6 +127,8 @@ Improvements * SOLR-17300: Http2SolrClient.Builder.withHttpClient now copies HttpListenerFactory (e.g. for auth, metrics,

Re: [PR] SOLR-17310: Configurable LeafSorter to customize segment search order [solr]

2024-06-10 Thread via GitHub
dsmiley commented on PR #2477: URL: https://github.com/apache/solr/pull/2477#issuecomment-2159312054 Tagging @cpoerschke for review; I figure you're a better reviewer here. I haven't used this aspect of Lucene before. -- This is an automated message from the Apache Git Service. To

Re: [PR] SOLR-17269: Do not publish synthetic solr core (of Coordinator node) to ZK [solr]

2024-06-10 Thread via GitHub
patsonluk commented on PR #2438: URL: https://github.com/apache/solr/pull/2438#issuecomment-2159229315 > Can a SyntheticSolrCore be prevented from registering itself with CoreContainer? I would imagine so since this functionality is inserted at the HttpSolrCall level thus the SolrCore

Re: [PR] SOLR-17326: Fix wrong references in generated API classes [solr]

2024-06-10 Thread via GitHub
gerlowskija commented on PR #2510: URL: https://github.com/apache/solr/pull/2510#issuecomment-2159142519 Hey @malliaridis - thanks for the fix, and thanks even more for the detailed writeup. I wish everyone (myself included) was so thorough in listing out other potential approaches. This

Re: [PR] SOLR-10654: Introduce output of Prometheus metrics directly from Solr [solr]

2024-06-10 Thread via GitHub
mlbiscoc commented on PR #2405: URL: https://github.com/apache/solr/pull/2405#issuecomment-2159031117 > It doesn't feel right to merge this PR right now. Needs docs. Also the choice of what metrics are done so far is inverted from the value that would make most sense for this whole

[jira] [Commented] (SOLR-16796) Publish an SBOM for Solr maven artifacts

2024-06-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853745#comment-17853745 ] ASF subversion and git services commented on SOLR-16796: Commit

[jira] [Commented] (SOLR-16796) Publish an SBOM for Solr maven artifacts

2024-06-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853743#comment-17853743 ] ASF subversion and git services commented on SOLR-16796: Commit

Re: [PR] SOLR-16796: Add Maven SBOMs via cyclonedx [solr]

2024-06-10 Thread via GitHub
HoustonPutman merged PR #1203: URL: https://github.com/apache/solr/pull/1203 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Assigned] (SOLR-16796) Publish an SBOM for Solr maven artifacts

2024-06-10 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman reassigned SOLR-16796: - Assignee: Houston Putman > Publish an SBOM for Solr maven artifacts >

[jira] [Commented] (SOLR-16796) Publish an SBOM for Solr artifacts

2024-06-10 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853741#comment-17853741 ] Houston Putman commented on SOLR-16796: --- Splitting this ticket off into another ticket: SOLR-17328,

[jira] [Updated] (SOLR-16796) Publish an SBOM for Solr maven artifacts

2024-06-10 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman updated SOLR-16796: -- Summary: Publish an SBOM for Solr maven artifacts (was: Publish an SBOM for Solr artifacts)

[jira] [Created] (SOLR-17328) Publish SBOMs for Solr binary artifacts

2024-06-10 Thread Houston Putman (Jira)
Houston Putman created SOLR-17328: - Summary: Publish SBOMs for Solr binary artifacts Key: SOLR-17328 URL: https://issues.apache.org/jira/browse/SOLR-17328 Project: Solr Issue Type: Bug

Re: [PR] SOLR-17195: Add 'minPrefixLength' soft limit [solr]

2024-06-10 Thread via GitHub
gerlowskija commented on PR #2499: URL: https://github.com/apache/solr/pull/2499#issuecomment-2158867416 > Generally "q" is provided by a user, uses a more user-facing query parser (namely edismax), and would be a nice place for such a limit. But otherwise, queries show up in tons of other

Re: [PR] SOLR-16824: Adopt Linux Command line tool pattern of -- for long option commands [solr]

2024-06-10 Thread via GitHub
epugh commented on PR #1768: URL: https://github.com/apache/solr/pull/1768#issuecomment-2158813057 Hey all.. so, just got all green on the checks! I'm wondering, how many of the parameters do we want to have deprecation for... We have it for solr url and zk host, and they are pretty

Re: [PR] SOLR-17160: Time based tracking of core admin requests with Caffeine cache [solr]

2024-06-10 Thread via GitHub
psalagnac commented on code in PR #2304: URL: https://github.com/apache/solr/pull/2304#discussion_r1633502602 ## solr/core/src/java/org/apache/solr/handler/admin/CoreAdminHandler.java: ## @@ -497,42 +533,19 @@ public void submitAsyncTask(TaskObject taskObject) throws

Re: [PR] SOLR-17195: Add 'minPrefixLength' soft limit [solr]

2024-06-10 Thread via GitHub
gerlowskija commented on PR #2499: URL: https://github.com/apache/solr/pull/2499#issuecomment-2158766213 > Generally "q" is provided by a user, uses a more user-facing query parser (namely edismax), and would be a nice place for such a limit. But otherwise, queries show up in tons of other

[jira] [Comment Edited] (SOLR-17322) Make RankQuery.getTopDocsCollector use covariant generic types

2024-06-10 Thread Stephen Woods (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853249#comment-17853249 ] Stephen Woods edited comment on SOLR-17322 at 6/10/24 3:47 PM: --- I saw there

[jira] [Comment Edited] (SOLR-17322) Make RankQuery.getTopDocsCollector use covariant generic types

2024-06-10 Thread Stephen Woods (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853228#comment-17853228 ] Stephen Woods edited comment on SOLR-17322 at 6/10/24 3:46 PM: --- Good call

Re: [I] Solr 8.11 with SolrMetrics produces duplicate samples with prometheus v2.52 [solr-operator]

2024-06-10 Thread via GitHub
mlbiscoc commented on issue #705: URL: https://github.com/apache/solr-operator/issues/705#issuecomment-2158459566 Got it. What if you try updating the expression to omit `distrib` and `local`? Try using this expression instead to grab all metrics except `admin/ping` holding `distrib`

Re: [I] Solr 8.11 with SolrMetrics produces duplicate samples with prometheus v2.52 [solr-operator]

2024-06-10 Thread via GitHub
perosb commented on issue #705: URL: https://github.com/apache/solr-operator/issues/705#issuecomment-2157850924 > Did a bit of digging and I think the cause is because of the metrics api in Solr being different from 8->9. Solr 8: ` "ADMIN./admin/ping.totalTime":4869095628,